79754 2012-02-27 23:46:39 -0800 [Forms] Spin button sometimes ignores Indeterminate of m_upDownState 2012-02-28 22:17:30 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin tkent webkit.review.bot oldest_to_newest 566431 0 yosin 2012-02-27 23:46:39 -0800 SpinButton implementation contains code like below: input->stepUpFromRenderer(m_upDownState == Up ? 1 : -1); Member variable m_upDownState is type of enum UpDownState which has three values, Indeterminate, Down, and Up. Above code can pass -1 to input->setUpFromRenderer if m_upDownState is Down or Indeterminate. We should not call input->setUpFromRenderer if m_upDownState is Indeterminate. 566468 1 129209 yosin 2012-02-28 00:43:37 -0800 Created attachment 129209 Patch 1 566507 2 129209 tkent 2012-02-28 01:51:49 -0800 Comment on attachment 129209 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=129209&action=review > Source/WebCore/html/shadow/TextControlInnerElements.cpp:-297 > - ASSERT(m_upDownState != Indeterminate); If you think this assertion should be removed, please write a reason in ChangeLog. > Source/WebCore/html/shadow/TextControlInnerElements.cpp:299 > + if (m_upDownState != Indeterminate) { > + input->stepUpFromRenderer(m_upDownState == Up ? 1 : -1); > + if (renderer()) Wrong indentation. 566511 3 129217 yosin 2012-02-28 02:05:34 -0800 Created attachment 129217 Patch 2 566531 4 129217 tkent 2012-02-28 02:33:11 -0800 Comment on attachment 129217 Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=129217&action=review > Source/WebCore/ChangeLog:14 > + m_upDownState can be Indeterminate at mousedown event if mouse pointer is on > + spin button when it is displayed. > + > + Reviewed by NOBODY (OOPS!). > + > + No new tests. No behavior change. This patch changes a behavior, and it seems you know how to reproduce the behavior change. Please write a test. Also, usual position of "Reviewed by .." line is just after the bug URL, before the long description. 567300 5 129369 yosin 2012-02-28 18:13:07 -0800 Created attachment 129369 Patch 3 567306 6 129369 tkent 2012-02-28 18:21:27 -0800 Comment on attachment 129369 Patch 3 Looks good. Thanks! 567372 7 129369 webkit.review.bot 2012-02-28 22:17:25 -0800 Comment on attachment 129369 Patch 3 Clearing flags on attachment: 129369 Committed r109193: <http://trac.webkit.org/changeset/109193> 567373 8 webkit.review.bot 2012-02-28 22:17:30 -0800 All reviewed patches have been landed. Closing bug. 129209 2012-02-28 00:43:37 -0800 2012-02-28 02:05:29 -0800 Patch 1 bug-79754-20120228174336.patch text/plain 2357 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWZkNGQyZmVlNWY1NWY1 NDNmYWNlZmJlNTkxNDkxMmI1NGIwMjBiNy4uNjJmOGZmMGIzZDIyYjRkZGMwOTY5NDY2N2IzNDFk MjQyNTM5YzU3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTI4ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBTcGlu IGJ1dHRvbiBzb21ldGltZXMgaWdub3JlcyBJbmRldGVybWluYXRlIG9mIG1fdXBEb3duU3RhdGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NzU0CisK KyAgICAgICAgVGhpcyBwYXRjaCBjaGVja3MgZW51bSB2YWx1ZSBJbmRldGVybWluYXRlIGJlZm9y ZSB1c2luZyBtX3VwRG93blN0YXRlLiBUaGlzIG1ha2UKKyAgICAgICAgc3VyZSBJbmRldGVybWlu YXRlIHN0YXRlIGRvZXNuJ3QgYWN0IGxpa2UgRG93biBzdGF0ZS4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGJlaGF2aW9y IGNoYW5nZS4KKworICAgICAgICAqIGh0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVtZW50 cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTcGluQnV0dG9uRWxlbWVudDo6ZGVmYXVsdEV2ZW50 SGFuZGxlcik6CisgICAgICAgIChXZWJDb3JlOjpTcGluQnV0dG9uRWxlbWVudDo6cmVwZWF0aW5n VGltZXJGaXJlZCk6CisKIDIwMTItMDItMjcgIERhdmlkIEJhcnRvbiAgPGRiYXJ0b25AbWF0aHNj cmliZS5jb20+CiAKICAgICAgICAgRml4IDxtc3Vic3VwPiBmb3JtYXR0aW5nLCBlc3BlY2lhbGx5 IGZvciBhIHRhbGwgYmFzZSwgc3Vic2NyaXB0LCBvciBzdXBlcnNjcmlwdApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5jcHAK aW5kZXggMmZjMzVmMjBlMWIxYzQ2NGY2OWFiZmQ5Y2M1NDM1OGI1YzE4MGU2Ni4uZjFjNTQxYzcx ZTBlOTBiODViNmI4ODI5MDZmMGY3YjZlMzczZWM2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9zaGFkb3cvVGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxlbWVudHMuY3BwCkBAIC0yOTQs MTAgKzI5NCwxMSBAQCB2b2lkIFNwaW5CdXR0b25FbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVy KEV2ZW50KiBldmVudCkKICAgICAgICAgICAgIGlucHV0LT5mb2N1cygpOwogICAgICAgICAgICAg aW5wdXQtPnNlbGVjdCgpOwogICAgICAgICAgICAgaWYgKHJlbmRlcmVyKCkpIHsKLSAgICAgICAg ICAgICAgICBBU1NFUlQobV91cERvd25TdGF0ZSAhPSBJbmRldGVybWluYXRlKTsKLSAgICAgICAg ICAgICAgICBpbnB1dC0+c3RlcFVwRnJvbVJlbmRlcmVyKG1fdXBEb3duU3RhdGUgPT0gVXAgPyAx IDogLTEpOwotICAgICAgICAgICAgICAgIGlmIChyZW5kZXJlcigpKQotICAgICAgICAgICAgICAg ICAgICBzdGFydFJlcGVhdGluZ1RpbWVyKCk7CisgICAgICAgICAgICAgICAgaWYgKG1fdXBEb3du U3RhdGUgIT0gSW5kZXRlcm1pbmF0ZSkgeworICAgICAgICAgICAgICAgICAgaW5wdXQtPnN0ZXBV cEZyb21SZW5kZXJlcihtX3VwRG93blN0YXRlID09IFVwID8gMSA6IC0xKTsKKyAgICAgICAgICAg ICAgICAgIGlmIChyZW5kZXJlcigpKQorICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0UmVwZWF0 aW5nVGltZXIoKTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgICAg ICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKICAgICAgICAgfQpAQCAtMzY1LDcgKzM2Niw4 IEBAIHZvaWQgU3BpbkJ1dHRvbkVsZW1lbnQ6OnN0ZXAoaW50IGFtb3VudCkKICAgICAKIHZvaWQg U3BpbkJ1dHRvbkVsZW1lbnQ6OnJlcGVhdGluZ1RpbWVyRmlyZWQoVGltZXI8U3BpbkJ1dHRvbkVs ZW1lbnQ+KikKIHsKLSAgICBzdGVwKG1fdXBEb3duU3RhdGUgPT0gVXAgPyAxIDogLTEpOworICAg IGlmIChtX3VwRG93blN0YXRlICE9IEluZGV0ZXJtaW5hdGUpCisgICAgICAgIHN0ZXAobV91cERv d25TdGF0ZSA9PSBVcCA/IDEgOiAtMSk7CiB9CiAKIHZvaWQgU3BpbkJ1dHRvbkVsZW1lbnQ6OnNl dEhvdmVyZWQoYm9vbCBmbGFnKQo= 129217 2012-02-28 02:05:34 -0800 2012-02-28 18:13:02 -0800 Patch 2 bug-79754-20120228190532.patch text/plain 2494 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWZkNGQyZmVlNWY1NWY1 NDNmYWNlZmJlNTkxNDkxMmI1NGIwMjBiNy4uNjU0NGE3MTU0MDkwZGQ5MmM5NzVlZmE1MDcyMzgx ZjExMjdmZWRjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTI4ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBTcGlu IGJ1dHRvbiBzb21ldGltZXMgaWdub3JlcyBJbmRldGVybWluYXRlIG9mIG1fdXBEb3duU3RhdGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NzU0CisK KyAgICAgICAgVGhpcyBwYXRjaCBjaGVja3MgZW51bSB2YWx1ZSBJbmRldGVybWluYXRlIGJlZm9y ZSB1c2luZyBtX3VwRG93blN0YXRlLiBUaGlzIG1ha2UKKyAgICAgICAgc3VyZSBJbmRldGVybWlu YXRlIHN0YXRlIGRvZXNuJ3QgYWN0IGxpa2UgRG93biBzdGF0ZS4KKworICAgICAgICBtX3VwRG93 blN0YXRlIGNhbiBiZSBJbmRldGVybWluYXRlIGF0IG1vdXNlZG93biBldmVudCBpZiBtb3VzZSBw b2ludGVyIGlzIG9uCisgICAgICAgIHNwaW4gYnV0dG9uIHdoZW4gaXQgaXMgZGlzcGxheWVkLgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gTm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogaHRtbC9zaGFkb3cvVGV4dENv bnRyb2xJbm5lckVsZW1lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNwaW5CdXR0b25FbGVt ZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKToKKyAgICAgICAgKFdlYkNvcmU6OlNwaW5CdXR0b25F bGVtZW50OjpyZXBlYXRpbmdUaW1lckZpcmVkKToKKwogMjAxMi0wMi0yNyAgRGF2aWQgQmFydG9u ICA8ZGJhcnRvbkBtYXRoc2NyaWJlLmNvbT4KIAogICAgICAgICBGaXggPG1zdWJzdXA+IGZvcm1h dHRpbmcsIGVzcGVjaWFsbHkgZm9yIGEgdGFsbCBiYXNlLCBzdWJzY3JpcHQsIG9yIHN1cGVyc2Ny aXB0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElu bmVyRWxlbWVudHMuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dENvbnRyb2xJ bm5lckVsZW1lbnRzLmNwcAppbmRleCAyZmMzNWYyMGUxYjFjNDY0ZjY5YWJmZDljYzU0MzU4YjVj MTgwZTY2Li5jOWZiNzMyZTY5ZWUyNGI4MGYzNWUxN2M2NzczNGYyOWI1ZTA5OTI5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxlbWVudHMu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVt ZW50cy5jcHAKQEAgLTI5NCwxMCArMjk0LDExIEBAIHZvaWQgU3BpbkJ1dHRvbkVsZW1lbnQ6OmRl ZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2ZW50KQogICAgICAgICAgICAgaW5wdXQtPmZvY3Vz KCk7CiAgICAgICAgICAgICBpbnB1dC0+c2VsZWN0KCk7CiAgICAgICAgICAgICBpZiAocmVuZGVy ZXIoKSkgewotICAgICAgICAgICAgICAgIEFTU0VSVChtX3VwRG93blN0YXRlICE9IEluZGV0ZXJt aW5hdGUpOwotICAgICAgICAgICAgICAgIGlucHV0LT5zdGVwVXBGcm9tUmVuZGVyZXIobV91cERv d25TdGF0ZSA9PSBVcCA/IDEgOiAtMSk7Ci0gICAgICAgICAgICAgICAgaWYgKHJlbmRlcmVyKCkp Ci0gICAgICAgICAgICAgICAgICAgIHN0YXJ0UmVwZWF0aW5nVGltZXIoKTsKKyAgICAgICAgICAg ICAgICBpZiAobV91cERvd25TdGF0ZSAhPSBJbmRldGVybWluYXRlKSB7CisgICAgICAgICAgICAg ICAgICAgIGlucHV0LT5zdGVwVXBGcm9tUmVuZGVyZXIobV91cERvd25TdGF0ZSA9PSBVcCA/IDEg OiAtMSk7CisgICAgICAgICAgICAgICAgICAgIGlmIChyZW5kZXJlcigpKQorICAgICAgICAgICAg ICAgICAgICAgICAgc3RhcnRSZXBlYXRpbmdUaW1lcigpOworICAgICAgICAgICAgICAgIH0KICAg ICAgICAgICAgIH0KICAgICAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogICAg ICAgICB9CkBAIC0zNjUsNyArMzY2LDggQEAgdm9pZCBTcGluQnV0dG9uRWxlbWVudDo6c3RlcChp bnQgYW1vdW50KQogICAgIAogdm9pZCBTcGluQnV0dG9uRWxlbWVudDo6cmVwZWF0aW5nVGltZXJG aXJlZChUaW1lcjxTcGluQnV0dG9uRWxlbWVudD4qKQogewotICAgIHN0ZXAobV91cERvd25TdGF0 ZSA9PSBVcCA/IDEgOiAtMSk7CisgICAgaWYgKG1fdXBEb3duU3RhdGUgIT0gSW5kZXRlcm1pbmF0 ZSkKKyAgICAgICAgc3RlcChtX3VwRG93blN0YXRlID09IFVwID8gMSA6IC0xKTsKIH0KIAogdm9p ZCBTcGluQnV0dG9uRWxlbWVudDo6c2V0SG92ZXJlZChib29sIGZsYWcpCg== 129369 2012-02-28 18:13:07 -0800 2012-02-28 22:17:25 -0800 Patch 3 bug-79754-20120229111305.patch text/plain 5685 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWZkNGQyZmVlNWY1NWY1 NDNmYWNlZmJlNTkxNDkxMmI1NGIwMjBiNy4uYjQ1ZDlkOGUwMjRjMjNmMmJjMmJjM2E1NzA4NmVl N2NhMzNiNDJmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTI4ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBTcGlu IGJ1dHRvbiBzb21ldGltZXMgaWdub3JlcyBJbmRldGVybWluYXRlIG9mIG1fdXBEb3duU3RhdGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NzU0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRj aCBjaGVja3MgZW51bSB2YWx1ZSBJbmRldGVybWluYXRlIGJlZm9yZSB1c2luZyBtX3VwRG93blN0 YXRlLiBUaGlzIG1ha2UKKyAgICAgICAgc3VyZSBJbmRldGVybWluYXRlIHN0YXRlIGRvZXNuJ3Qg YWN0IGxpa2UgRG93biBzdGF0ZS4KKworICAgICAgICBtX3VwRG93blN0YXRlIGNhbiBiZSBJbmRl dGVybWluYXRlIGF0IG1vdXNlZG93biBldmVudCBpZiBtb3VzZSBwb2ludGVyIGlzIG9uCisgICAg ICAgIHNwaW4gYnV0dG9uIHdoZW4gaXQgaXMgZGlzcGxheWVkLgorCisgICAgICAgIFRlc3Q6IGZh c3QvZm9ybXMvbnVtYmVyL3NwaW4tYnV0dG9uLXN0YXRlLmh0bWwKKworICAgICAgICAqIGh0bWwv c2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT cGluQnV0dG9uRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6CisgICAgICAgIChXZWJDb3Jl OjpTcGluQnV0dG9uRWxlbWVudDo6cmVwZWF0aW5nVGltZXJGaXJlZCk6CisKIDIwMTItMDItMjcg IERhdmlkIEJhcnRvbiAgPGRiYXJ0b25AbWF0aHNjcmliZS5jb20+CiAKICAgICAgICAgRml4IDxt c3Vic3VwPiBmb3JtYXR0aW5nLCBlc3BlY2lhbGx5IGZvciBhIHRhbGwgYmFzZSwgc3Vic2NyaXB0 LCBvciBzdXBlcnNjcmlwdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cv VGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93 L1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5jcHAKaW5kZXggMmZjMzVmMjBlMWIxYzQ2NGY2OWFi ZmQ5Y2M1NDM1OGI1YzE4MGU2Ni4uYzlmYjczMmU2OWVlMjRiODBmMzVlMTdjNjc3MzRmMjliNWUw OTkyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dENvbnRyb2xJ bm5lckVsZW1lbnRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29u dHJvbElubmVyRWxlbWVudHMuY3BwCkBAIC0yOTQsMTAgKzI5NCwxMSBAQCB2b2lkIFNwaW5CdXR0 b25FbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldmVudCkKICAgICAgICAgICAg IGlucHV0LT5mb2N1cygpOwogICAgICAgICAgICAgaW5wdXQtPnNlbGVjdCgpOwogICAgICAgICAg ICAgaWYgKHJlbmRlcmVyKCkpIHsKLSAgICAgICAgICAgICAgICBBU1NFUlQobV91cERvd25TdGF0 ZSAhPSBJbmRldGVybWluYXRlKTsKLSAgICAgICAgICAgICAgICBpbnB1dC0+c3RlcFVwRnJvbVJl bmRlcmVyKG1fdXBEb3duU3RhdGUgPT0gVXAgPyAxIDogLTEpOwotICAgICAgICAgICAgICAgIGlm IChyZW5kZXJlcigpKQotICAgICAgICAgICAgICAgICAgICBzdGFydFJlcGVhdGluZ1RpbWVyKCk7 CisgICAgICAgICAgICAgICAgaWYgKG1fdXBEb3duU3RhdGUgIT0gSW5kZXRlcm1pbmF0ZSkgewor ICAgICAgICAgICAgICAgICAgICBpbnB1dC0+c3RlcFVwRnJvbVJlbmRlcmVyKG1fdXBEb3duU3Rh dGUgPT0gVXAgPyAxIDogLTEpOworICAgICAgICAgICAgICAgICAgICBpZiAocmVuZGVyZXIoKSkK KyAgICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0UmVwZWF0aW5nVGltZXIoKTsKKyAgICAgICAg ICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhh bmRsZWQoKTsKICAgICAgICAgfQpAQCAtMzY1LDcgKzM2Niw4IEBAIHZvaWQgU3BpbkJ1dHRvbkVs ZW1lbnQ6OnN0ZXAoaW50IGFtb3VudCkKICAgICAKIHZvaWQgU3BpbkJ1dHRvbkVsZW1lbnQ6OnJl cGVhdGluZ1RpbWVyRmlyZWQoVGltZXI8U3BpbkJ1dHRvbkVsZW1lbnQ+KikKIHsKLSAgICBzdGVw KG1fdXBEb3duU3RhdGUgPT0gVXAgPyAxIDogLTEpOworICAgIGlmIChtX3VwRG93blN0YXRlICE9 IEluZGV0ZXJtaW5hdGUpCisgICAgICAgIHN0ZXAobV91cERvd25TdGF0ZSA9PSBVcCA/IDEgOiAt MSk7CiB9CiAKIHZvaWQgU3BpbkJ1dHRvbkVsZW1lbnQ6OnNldEhvdmVyZWQoYm9vbCBmbGFnKQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IDM2M2VlYzA3ZGY5ZTJlZjkxOWE1YWQyNmU0YzI3MGMzNGFmODNiYjAuLmVmYWE0YWM0 MzQ0NjhmYjE3NTM3OGRiNmYyNzNhNzU2MzQwYTUwNmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxMi0wMi0yOCAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFtGb3Jtc10gU3BpbiBidXR0b24gc29tZXRpbWVzIGlnbm9yZXMgSW5kZXRlcm1pbmF0ZSBv ZiBtX3VwRG93blN0YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03OTc1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmFzdC9mb3Jtcy9udW1iZXIvc3Bpbi1idXR0b24tc3RhdGUuaHRtbDogQWRkZWQu CisgICAgICAgICogZmFzdC9mb3Jtcy9udW1iZXIvc3Bpbi1idXR0b24tc3RhdGUtZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKwogMjAxMi0wMi0yNyAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbnVtYmVyL2lucHV0LW51 bWJlci1ldmVudHMuaHRtbCBpcyBmYWlsaW5nIHNpbmNlIHIxMDgyMjgKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvbnVtYmVyL3NwaW4tYnV0dG9uLXN0YXRlLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbnVtYmVyL3NwaW4tYnV0dG9uLXN0YXRlLWV4cGVj dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi41YWM5MmVmOGVjYzMzMDUxYzI4MjhiYmIwNmNlYmJlNTVkMTc0 ZmZhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9udW1iZXIvc3Bp bi1idXR0b24tc3RhdGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTMgQEAKK0JVRyA3OTc1NFtG b3Jtc10gU3BpbiBidXR0b24gc29tZXRpbWVzIGlnbm9yZXMgSW5kZXRlcm1pbmF0ZSBvZiBtX3Vw RG93blN0YXRlCisKKworTWFudWFsdCB0ZXN0IHN0ZXBzCisKK0ludm9rZSBicm93c2VyIHdpdGgg c3BlY2lmeWluZyBzY3JlZW4gcG9zaXRpb24gd2hlcmUgbW91c3QgcG9pbnRlciBvbiB0aGUgc3Bp biBidXR0b24uCitDbGljayBsZWZ0IG1vdXNlIGJ1dHRvbiB3aXRob3V0IG1vdmluZyBtb3VzZSBw b2ludGVyLgorVmFsdWUgc2hvdWxkIG5vdCBiZSBjaGFuZ2VkLgorUmVzdWx0CisKK2V4cGVjdCAw LCBhY3R1YWw9MAorZXhwZWN0IDEsIGFjdHVhbD0xCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvbnVtYmVyL3NwaW4tYnV0dG9uLXN0YXRlLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL251bWJlci9zcGluLWJ1dHRvbi1zdGF0ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk5NzJi OWU1MDdhMGRiMDUxZjlmNTZlYTQ3Y2U1NDMxMzgzYTExN2MKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL251bWJlci9zcGluLWJ1dHRvbi1zdGF0ZS5odG1sCkBAIC0w LDAgKzEsNDYgQEAKKzxoMT5CVUcgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc5NzU0Ij43OTc1NDwvYT5bRm9ybXNdIFNwaW4gYnV0dG9uIHNvbWV0aW1l cyBpZ25vcmVzIEluZGV0ZXJtaW5hdGUgb2YgbV91cERvd25TdGF0ZTwvaDE+Cis8ZGl2IGlkPSJv dXRlciI+Cis8aW5wdXQgaWQ9Im51bTEiIHR5cGU9Im51bWJlciIgdmFsdWU9IjAiPgorPC9kaXY+ Cis8aDI+TWFudWFsdCB0ZXN0IHN0ZXBzPC9oMj4KKzxvbD4KKzxsaT5JbnZva2UgYnJvd3NlciB3 aXRoIHNwZWNpZnlpbmcgc2NyZWVuIHBvc2l0aW9uIHdoZXJlIG1vdXN0IHBvaW50ZXIgb24gdGhl IHNwaW4gYnV0dG9uLjwvbGk+Cis8bGk+Q2xpY2sgbGVmdCBtb3VzZSBidXR0b24gd2l0aG91dCBt b3ZpbmcgbW91c2UgcG9pbnRlci48L2xpPgorPGxpPlZhbHVlIHNob3VsZCBub3QgYmUgY2hhbmdl ZC48L2xpPgorPC9vbD4KKzxoMj5SZXN1bHQ8L2gyPgorPGRpdiBpZD0ibG9ncyI+PC9kaXY+Cis8 c2NyaXB0PgordmFyIGxvZ3MgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibG9ncyIpOworZnVu Y3Rpb24gbG9nKG1zZykgeyBsb2dzLmlubmVySFRNTCArPSBtc2cgKyAiPGJyPiI7IH0KKworZnVu Y3Rpb24gdGVzdEl0KCkgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsK KworICAgIHZhciBvdXRlciA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJvdXRlciIpOworCisg ICAgdmFyIG51bTEgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibnVtMSIpOworICAgIHZhciBt b3VzZVggPSBudW0xLm9mZnNldExlZnQgKyBudW0xLm9mZnNldFdpZHRoIC0gNTsKKyAgICB2YXIg bW91c2VZID0gbnVtMS5vZmZzZXRUb3AgKyA1OworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRv KG1vdXNlWCwgbW91c2VZKTsKKworICAgIC8vIFJlLWNvbnN0cnVjdCBpbnB1dCBlbGVtZW50Lgor ICAgIHZhciBjdHJsSHRtbCA9IG91dGVyLmlubmVySFRNTDsKKyAgICBvdXRlci5pbm5lckhUTUwg PSAiIjsKKyAgICBvdXRlci5pbm5lckhUTUwgPSBjdHJsSHRtbDsKKworICAgIHZhciBudW0yID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm51bTEiKTsKKyAgICBldmVudFNlbmRlci5tb3VzZURv d24oKTsKKyAgICBsb2coImV4cGVjdCAwLCBhY3R1YWw9IiArIG51bTIudmFsdWUpOworICAgIGV2 ZW50U2VuZGVyLm1vdXNlVXAoKTsKKworICAgIC8vIE1vdmUgbW91c2UgcG9pbnRlciBidXQgc3Rp bGwgaW4gc3BpbiBidXR0b24uCisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8obW91c2VYLCBt b3VzZVkgLSAxKTsKKyAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICBsb2coImV4cGVj dCAxLCBhY3R1YWw9IiArIG51bTIudmFsdWUpOworfQorCitpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKSB7CisgICAgdGVzdEl0KCk7Cit9Cis8L3NjcmlwdD4K