79747 2012-02-27 23:12:19 -0800 Determine parameters for rendering a TextTrackCue 2012-04-19 12:24:40 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 79347 79750 0 vcarbune vcarbune dglazkov eric.carlson webkit.review.bot oldest_to_newest 566417 0 vcarbune 2012-02-27 23:12:19 -0800 This bug represents inner substeps 10.1, 10.4 - 10.9 of section 3.5 of WebVTT rendering rules: http://dev.w3.org/html5/webvtt/#webvtt-cue-text-rendering-rules "10. For each text track cue cue in cues that has not yet had corresponding CSS boxes added to output, in text track cue order, run the following substeps: 10.1 Let nodes be the list of WebVTT Node Objects obtained by applying the WebVTT cue text parsing rules to the cue's text track cue text. [...]" 579250 1 132011 vcarbune 2012-03-15 03:35:31 -0700 Created attachment 132011 Preliminary patch Implemented the computational steps described in the spec. The patch could be submitted stand-alone - as it is - or in the same time with the first implemented rendering case that is blocked by it. 579263 2 132011 webkit.review.bot 2012-03-15 04:02:13 -0700 Comment on attachment 132011 Preliminary patch Attachment 132011 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11954572 579388 3 132011 eric.carlson 2012-03-15 07:59:50 -0700 Comment on attachment 132011 Preliminary patch View in context: https://bugs.webkit.org/attachment.cgi?id=132011&action=review This is close, but it needs some clean-up and tests. > Source/WebCore/html/track/TextTrackCue.cpp:128 > + m_displayWritingModeMap[Horizontal] = CSSValueHorizontalTb; > + m_displayWritingModeMap[VerticalGrowingLeft] = CSSValueVerticalLr; > + m_displayWritingModeMap[VerticalGrowingRight] = CSSValueVerticalRl; Nit: it would be good to have a comment here about why these are correct defaults. > Source/WebCore/html/track/TextTrackCue.cpp:438 > + int maximumSize; This will remain uninitialized if none of the conditions below evaluate to true. Even if this can't logically happen, the compiler will complain. > Source/WebCore/html/track/TextTrackCue.cpp:456 > + m_displaySize = m_cueSize < maximumSize ? m_cueSize : maximumSize; std::min() ? > Source/WebCore/html/track/TextTrackCue.cpp:460 > + // width be 'size vw' and height be 'auto'. Otherwise, let width be 'auto' > + // and height be 'size vh'. (These are CSS values used by the next section Nit: "size vw" and "size vh" ? > Source/WebCore/html/track/TextTrackCue.cpp:504 > + // 10.10 Let left be 'x-position vw' and top be 'y-position vh'. Nit: copy pasta here as well > Source/WebCore/html/track/TextTrackCue.h:161 > + int m_displayWritingModeMap[3]; WritingDirection is a private enum, so I think we should add a sentinel terminal value and use it here instead of hard coding the size of this array. 605789 4 vcarbune 2012-04-19 12:24:40 -0700 Submitted as part of https://bugs.webkit.org/show_bug.cgi?id=79750 Changeset 114640 (http://trac.webkit.org/changeset/114640) 132011 2012-03-15 03:35:31 -0700 2012-03-15 07:59:50 -0700 Preliminary patch bug-79747-20120315123530.patch text/plain 7912 vcarbune U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk2NjZmZTVmNjE4MDVk NWI1ODI0YmYzZTYxODg3MmMwNjQxNWQzNS4uM2VkMGZkNzVmNzA5NGJhZGRmMzVmZDJhMjdjNGM1 YmYxMDk2ODRmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTE1ICBWaWN0 b3IgQ2FyYnVuZSAgPHZjYXJidW5lQGFkb2JlLmNvbT4KKworICAgICAgICBDb21wdXRhdGlvbmFs IHN0ZXBzICgxMC4xLCAxMC40IC0gMTAuOSkgZnJvbSB0aGUgU2VjdGlvbiAzLjUgb2YgdGhlCisg ICAgICAgIFdlYlZUVCBzcGVjaWZpY2F0aW9uLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTc0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5IGludHJvZHVjZWQsIGFu ZCB0ZXN0cyB0byBjb3ZlciBhbGwgZGlzcGxheSBwYXJhbWV0ZXJzCisgICAgICAgIHNob3VsZCBi ZSBkb25lIHdoZW4gZWFjaCBvZiB0aGVzZSBwYXJhbWV0ZXJzIGlzIHVzZWQgaW4gdGhlIGFjdHVh bCByZW5kZXJpbmcuCisKKyAgICAgICAgKiBodG1sL3RyYWNrL1RleHRUcmFja0N1ZS5jcHA6IElt cGxlbWVudGVkIGNvbXB1dGF0aW9uYWwgc3RlcHMuCisgICAgICAgIChXZWJDb3JlKToKKyAgICAg ICAgKFdlYkNvcmU6OlRleHRUcmFja0N1ZTo6VGV4dFRyYWNrQ3VlKToKKyAgICAgICAgKFdlYkNv cmU6OlRleHRUcmFja0N1ZTo6ZGV0ZXJtaW5lRGlzcGxheVBhcmFtZXRlcnMpOiBVcGRhdGVkLgor ICAgICAgICAqIGh0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmg6IEFkZGVkIG1lbWJlciB2YXJpYWJs ZXMgdG8gc3RvcmUgdGhlIGNvbXB1dGF0aW9ucy4KKwogMjAxMi0wMy0xNCAgQ2hyaXMgRmxlaXph Y2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYRGVzY3JpcHRpb24gZm9yIEhU TUw1IGZvb3RlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJh Y2tDdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2tDdWUuY3BwCmlu ZGV4IDAwZWJiMjFhOWFiNDI1MTViYWZlOGQxOTNhZDk4N2NmZDdiZTE4M2UuLmQ1YTQ1NzZlNjg5 N2E3NmY5Mzk5ODhkMzk4ZGYzNTdiMDU0ODQ5YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3Ry YWNrL1RleHRUcmFja0N1ZS5jcHAKQEAgLTQ5LDYgKzQ5LDcgQEAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogc3RhdGljIGNvbnN0IGludCBpbnZhbGlkQ3VlSW5kZXggPSAtMTsKK3N0YXRpYyBjb25z dCBpbnQgdW5kZWZpbmVkUG9zaXRpb24gPSAtMTsKIAogc3RhdGljIGNvbnN0IFN0cmluZyYgc3Rh cnRLZXl3b3JkKCkKIHsKQEAgLTExNyw4ICsxMTgsMTUgQEAgVGV4dFRyYWNrQ3VlOjpUZXh0VHJh Y2tDdWUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgY29uc3QgU3RyaW5nJiBpZCwg ZG8KICAgICAsIG1fc25hcFRvTGluZXModHJ1ZSkKICAgICAsIG1fZGlzcGxheVRyZWVTaG91bGRD aGFuZ2UodHJ1ZSkKICAgICAsIG1fZGlzcGxheVRyZWUoSFRNTERpdkVsZW1lbnQ6OmNyZWF0ZShz dGF0aWNfY2FzdDxEb2N1bWVudCo+KGNvbnRleHQpKSkKKyAgICAsIG1fZGlzcGxheVhQb3NpdGlv bih1bmRlZmluZWRQb3NpdGlvbikKKyAgICAsIG1fZGlzcGxheVlQb3NpdGlvbih1bmRlZmluZWRQ b3NpdGlvbikKIHsKICAgICBBU1NFUlQobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT5pc0RvY3Vt ZW50KCkpOworCisgICAgbV9kaXNwbGF5V3JpdGluZ01vZGVNYXBbSG9yaXpvbnRhbF0gPSBDU1NW YWx1ZUhvcml6b250YWxUYjsKKyAgICBtX2Rpc3BsYXlXcml0aW5nTW9kZU1hcFtWZXJ0aWNhbEdy b3dpbmdMZWZ0XSA9IENTU1ZhbHVlVmVydGljYWxMcjsKKyAgICBtX2Rpc3BsYXlXcml0aW5nTW9k ZU1hcFtWZXJ0aWNhbEdyb3dpbmdSaWdodF0gPSBDU1NWYWx1ZVZlcnRpY2FsUmw7CisKICAgICBw YXJzZVNldHRpbmdzKHNldHRpbmdzKTsKIH0KIApAQCAtNDE1LDkgKzQyMyw4NyBAQCB2b2lkIFRl eHRUcmFja0N1ZTo6ZGV0ZXJtaW5lRGlzcGxheVBhcmFtZXRlcnMoKQogewogICAgIC8vIEZJWE1F KEJVRyA3OTc0OSk6IERldGVybWluZSB0aGUgdGV4dCBkaXJlY3Rpb24gdXNpbmcgdGhlIEJJREkg YWxnb3JpdGhtLgogICAgIC8vIFN0ZXBzIDEwLjIsIDEwLjMKKyAgICBtX2Rpc3BsYXlEaXJlY3Rp b24gPSBDU1NWYWx1ZUx0cjsKKworICAgIC8vIDEwLjQgSWYgdGhlIHRleHQgdHJhY2sgY3VlIHdy aXRpbmcgZGlyZWN0aW9uIGlzIGhvcml6b250YWwsIHRoZW4gbGV0CisgICAgLy8gYmxvY2stZmxv dyBiZSAndGInLiBPdGhlcndpc2UsIGlmIHRoZSB0ZXh0IHRyYWNrIGN1ZSB3cml0aW5nIGRpcmVj dGlvbiBpcworICAgIC8vIHZlcnRpY2FsIGdyb3dpbmcgbGVmdCwgdGhlbiBsZXQgYmxvY2stZmxv dyBiZSAnbHInLiBPdGhlcndpc2UsIHRoZSB0ZXh0CisgICAgLy8gdHJhY2sgY3VlIHdyaXRpbmcg ZGlyZWN0aW9uIGlzIHZlcnRpY2FsIGdyb3dpbmcgcmlnaHQ7IGxldCBibG9jay1mbG93IGJlCisg ICAgLy8gJ3JsJy4KKworICAgIG1fZGlzcGxheVdyaXRpbmdNb2RlID0gbV9kaXNwbGF5V3JpdGlu Z01vZGVNYXBbbV93cml0aW5nRGlyZWN0aW9uXTsKKworICAgIC8vIDEwLjUgRGV0ZXJtaW5lIHRo ZSB2YWx1ZSBvZiBtYXhpbXVtIHNpemUgZm9yIGN1ZSBhcyBwZXIgdGhlIGFwcHJvcHJpYXRlCisg ICAgLy8gcnVsZXMgZnJvbSB0aGUgZm9sbG93aW5nIGxpc3Q6CisgICAgaW50IG1heGltdW1TaXpl OworICAgIGlmICgobV93cml0aW5nRGlyZWN0aW9uID09IEhvcml6b250YWwgJiYgbV9jdWVBbGln bm1lbnQgPT0gU3RhcnQgJiYgbV9kaXNwbGF5RGlyZWN0aW9uID09IENTU1ZhbHVlTHRyKQorICAg ICAgICAgICAgfHwgKG1fd3JpdGluZ0RpcmVjdGlvbiA9PSBIb3Jpem9udGFsICYmIG1fY3VlQWxp Z25tZW50ID09IEVuZCAmJiBtX2Rpc3BsYXlEaXJlY3Rpb24gPT0gQ1NTVmFsdWVSdGwpCisgICAg ICAgICAgICB8fCAobV93cml0aW5nRGlyZWN0aW9uID09IFZlcnRpY2FsR3Jvd2luZ0xlZnQgJiYg bV9jdWVBbGlnbm1lbnQgPT0gU3RhcnQpCisgICAgICAgICAgICB8fCAobV93cml0aW5nRGlyZWN0 aW9uID09IFZlcnRpY2FsR3Jvd2luZ1JpZ2h0ICYmIG1fY3VlQWxpZ25tZW50ID09IEVuZCkpIHsK KyAgICAgICAgbWF4aW11bVNpemUgPSAxMDAgLSBtX3RleHRQb3NpdGlvbjsKKyAgICB9IGVsc2Ug aWYgKChtX3dyaXRpbmdEaXJlY3Rpb24gPT0gSG9yaXpvbnRhbCAmJiBtX2N1ZUFsaWdubWVudCA9 PSBFbmQgJiYgbV9kaXNwbGF5RGlyZWN0aW9uID09IENTU1ZhbHVlTHRyKQorICAgICAgICAgICAg fHwgKG1fd3JpdGluZ0RpcmVjdGlvbiA9PSBIb3Jpem9udGFsICYmIG1fY3VlQWxpZ25tZW50ID09 IFN0YXJ0ICYmIG1fZGlzcGxheURpcmVjdGlvbiA9PSBDU1NWYWx1ZVJ0bCkKKyAgICAgICAgICAg IHx8IChtX3dyaXRpbmdEaXJlY3Rpb24gPT0gVmVydGljYWxHcm93aW5nTGVmdCAmJiBtX2N1ZUFs aWdubWVudCA9PSBFbmQpCisgICAgICAgICAgICB8fCAobV93cml0aW5nRGlyZWN0aW9uID09IFZl cnRpY2FsR3Jvd2luZ1JpZ2h0ICYmIG1fY3VlQWxpZ25tZW50ID09IEVuZCkpIHsKKyAgICAgICAg bWF4aW11bVNpemUgPSBtX3RleHRQb3NpdGlvbjsKKyAgICB9IGVsc2UgaWYgKG1fY3VlQWxpZ25t ZW50ID09IE1pZGRsZSkgeworICAgICAgICBtYXhpbXVtU2l6ZSA9IG1fdGV4dFBvc2l0aW9uIDw9 IDUwID8gbV90ZXh0UG9zaXRpb24gOiAoMTAwIC0gbV90ZXh0UG9zaXRpb24pOworICAgICAgICBt YXhpbXVtU2l6ZSA9IG1heGltdW1TaXplICogMjsKKyAgICB9CisKKyAgICAvLyAxMC42IElmIHRo ZSB0ZXh0IHRyYWNrIGN1ZSBzaXplIGlzIGxlc3MgdGhhbiBtYXhpbXVtIHNpemUsIHRoZW4gbGV0 IHNpemUKKyAgICAvLyBiZSB0ZXh0IHRyYWNrIGN1ZSBzaXplLiBPdGhlcndpc2UsIGxldCBzaXpl IGJlIG1heGltdW0gc2l6ZS4KKyAgICBtX2Rpc3BsYXlTaXplID0gbV9jdWVTaXplIDwgbWF4aW11 bVNpemUgPyBtX2N1ZVNpemUgOiBtYXhpbXVtU2l6ZTsKKworICAgIC8vIDEwLjcgSWYgdGhlIHRl eHQgdHJhY2sgY3VlIHdyaXRpbmcgZGlyZWN0aW9uIGlzIGhvcml6b250YWwsIHRoZW4gbGV0Cisg ICAgLy8gd2lkdGggYmUgJ3NpemXigIl2dycgYW5kIGhlaWdodCBiZSAnYXV0bycuIE90aGVyd2lz ZSwgbGV0IHdpZHRoIGJlICdhdXRvJworICAgIC8vIGFuZCBoZWlnaHQgYmUgJ3NpemXigIl2aCcu IChUaGVzZSBhcmUgQ1NTIHZhbHVlcyB1c2VkIGJ5IHRoZSBuZXh0IHNlY3Rpb24KKyAgICAvLyB0 byBzZXQgQ1NTIHByb3BlcnRpZXMgZm9yIHRoZSByZW5kZXJpbmc7ICd2dycgYW5kICd2aCcgYXJl IENTUyB1bml0cy4pCisgICAgbV9kaXNwbGF5V2lkdGggPSBtX3dyaXRpbmdEaXJlY3Rpb24gPT0g SG9yaXpvbnRhbCA/IG1fZGlzcGxheVNpemUgOiAwOworICAgIG1fZGlzcGxheUhlaWdodCA9IG1f d3JpdGluZ0RpcmVjdGlvbiA9PSBIb3Jpem9udGFsID8gMCA6IG1fZGlzcGxheVNpemU7CisKKyAg ICAvLyAxMC44IERldGVybWluZSB0aGUgdmFsdWUgb2YgeC1wb3NpdGlvbiBvciB5LXBvc2l0aW9u IGZvciBjdWUgYXMgcGVyIHRoZQorICAgIC8vIGFwcHJvcHJpYXRlIHJ1bGVzIGZyb20gdGhlIGZv bGxvd2luZyBsaXN0OgorICAgIGlmICgobV93cml0aW5nRGlyZWN0aW9uID09IEhvcml6b250YWwg JiYgbV9jdWVBbGlnbm1lbnQgPT0gU3RhcnQgJiYgbV9kaXNwbGF5RGlyZWN0aW9uID09IENTU1Zh bHVlTHRyKQorICAgICAgICAgICAgfHwgKG1fd3JpdGluZ0RpcmVjdGlvbiA9PSBIb3Jpem9udGFs ICYmIG1fY3VlQWxpZ25tZW50ID09IEVuZCAmJiBtX2Rpc3BsYXlEaXJlY3Rpb24gPT0gQ1NTVmFs dWVSdGwpKSB7CisgICAgICAgIG1fZGlzcGxheVhQb3NpdGlvbiA9IG1fdGV4dFBvc2l0aW9uOwor ICAgIH0gZWxzZSBpZiAoKG1fd3JpdGluZ0RpcmVjdGlvbiA9PSBIb3Jpem9udGFsICYmIG1fY3Vl QWxpZ25tZW50ID09IEVuZCAmJiBtX2Rpc3BsYXlEaXJlY3Rpb24gPT0gQ1NTVmFsdWVMdHIpCisg ICAgICAgICAgICB8fCAobV93cml0aW5nRGlyZWN0aW9uID09IEhvcml6b250YWwgJiYgbV9jdWVB bGlnbm1lbnQgPT0gU3RhcnQgJiYgbV9kaXNwbGF5RGlyZWN0aW9uID09IENTU1ZhbHVlUnRsKSkg eworICAgICAgICBtX2Rpc3BsYXlYUG9zaXRpb24gPSAxMDAgLSBtX3RleHRQb3NpdGlvbjsKKyAg ICB9CisKKyAgICBpZiAoKG1fd3JpdGluZ0RpcmVjdGlvbiA9PSBWZXJ0aWNhbEdyb3dpbmdMZWZ0 ICYmIG1fY3VlQWxpZ25tZW50ID09IFN0YXJ0KQorICAgICAgICAgICAgfHwgKG1fd3JpdGluZ0Rp cmVjdGlvbiA9PSBWZXJ0aWNhbEdyb3dpbmdSaWdodCAmJiBtX2N1ZUFsaWdubWVudCA9PSBTdGFy dCkpIHsKKyAgICAgICAgbV9kaXNwbGF5WVBvc2l0aW9uID0gbV90ZXh0UG9zaXRpb247CisgICAg fSBlbHNlIGlmICgobV93cml0aW5nRGlyZWN0aW9uID09IFZlcnRpY2FsR3Jvd2luZ0xlZnQgJiYg bV9jdWVBbGlnbm1lbnQgPT0gRW5kKQorICAgICAgICAgICAgfHwgKG1fd3JpdGluZ0RpcmVjdGlv biA9PSBWZXJ0aWNhbEdyb3dpbmdSaWdodCAmJiBtX2N1ZUFsaWdubWVudCA9PSBFbmQpKSB7Cisg ICAgICAgIG1fZGlzcGxheVlQb3NpdGlvbiA9IDEwMCAtIG1fdGV4dFBvc2l0aW9uOworICAgIH0K KworICAgIGlmIChtX3dyaXRpbmdEaXJlY3Rpb24gPT0gSG9yaXpvbnRhbCAmJiBtX2N1ZUFsaWdu bWVudCA9PSBNaWRkbGUpIHsKKyAgICAgICAgbV9kaXNwbGF5WFBvc2l0aW9uID0gbV90ZXh0UG9z aXRpb24gLSBtX2Rpc3BsYXlTaXplIC8gMjsKKworICAgICAgICBpZiAobV9kaXNwbGF5RGlyZWN0 aW9uID09IENTU1ZhbHVlUnRsKQorICAgICAgICAgICBtX2Rpc3BsYXlYUG9zaXRpb24gPSAxMDAg LSBtX2Rpc3BsYXlYUG9zaXRpb247CisgICAgfQorCisgICAgaWYgKChtX3dyaXRpbmdEaXJlY3Rp b24gPT0gVmVydGljYWxHcm93aW5nTGVmdCAmJiBtX2N1ZUFsaWdubWVudCA9PSBNaWRkbGUpCisg ICAgICAgIHx8IChtX3dyaXRpbmdEaXJlY3Rpb24gPT0gVmVydGljYWxHcm93aW5nUmlnaHQgJiYg bV9jdWVBbGlnbm1lbnQgPT0gTWlkZGxlKSkKKyAgICAgICAgbV9kaXNwbGF5WVBvc2l0aW9uID0g bV90ZXh0UG9zaXRpb24gLSBtX2Rpc3BsYXlTaXplIC8gMjsKKworICAgIC8vIDEwLjkgRGV0ZXJt aW5lIHRoZSB2YWx1ZSBvZiB3aGljaGV2ZXIgb2YgeC1wb3NpdGlvbiBvciB5LXBvc2l0aW9uIGlz IG5vdAorICAgIC8vIHlldCBjYWxjdWxhdGVkIGZvciBjdWUgYXMgcGVyIHRoZSBhcHByb3ByaWF0 ZSBydWxlcyBmcm9tIHRoZSBmb2xsb3dpbmcKKyAgICAvLyBsaXN0OgorICAgIGlmIChtX2Rpc3Bs YXlZUG9zaXRpb24gPT0gdW5kZWZpbmVkUG9zaXRpb24gJiYgbV93cml0aW5nRGlyZWN0aW9uID09 IEhvcml6b250YWwpCisgICAgICAgIG1fZGlzcGxheVlQb3NpdGlvbiA9IG1fc25hcFRvTGluZXMg PyAwIDogbV9saW5lUG9zaXRpb247CisKKyAgICBpZiAobV9kaXNwbGF5WFBvc2l0aW9uID09IHVu ZGVmaW5lZFBvc2l0aW9uCisgICAgICAgICAgICAmJiAobV93cml0aW5nRGlyZWN0aW9uID09IFZl cnRpY2FsR3Jvd2luZ0xlZnQgfHwgbV93cml0aW5nRGlyZWN0aW9uID09IFZlcnRpY2FsR3Jvd2lu Z1JpZ2h0KSkKKyAgICAgICAgbV9kaXNwbGF5WFBvc2l0aW9uID0gbV9zbmFwVG9MaW5lcyA/IDAg OiBtX2xpbmVQb3NpdGlvbjsKKworICAgIC8vIDEwLjEwIExldCBsZWZ0IGJlICd4LXBvc2l0aW9u 4oCJdncnIGFuZCB0b3AgYmUgJ3ktcG9zaXRpb27igIl2aCcuCiAKLSAgICAvLyBGSVhNRShCVUcg Nzk3NDcpOiBEZXRlcm1pbmUgdGhlIGRpc3BsYXkgcGFyYW1ldGVycyBmcm9tIHRoZSBydWxlcy4K LSAgICAvLyBTdGVwcyAxMC4xLCAxMC40IC0gMTAuMTAKKyAgICAvLyBGSVhNRShCdWcgNzk5MTYp OiBDU1MgdG9wIGFuZCBsZWZ0IHByb3BlcnRpZXMgbmVlZCB0byBiZSBhcHBsaWVkLgogfQogCiBQ YXNzUmVmUHRyPEhUTUxEaXZFbGVtZW50PiBUZXh0VHJhY2tDdWU6OmdldERpc3BsYXlUcmVlKCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmggYi9T b3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFja0N1ZS5oCmluZGV4IDQwMTEzMmQ5NjQx YzhkNWM0MWVmNjNjZWM1N2VhNTBkYWY2N2Y4NDEuLmJjMWJmOGM5NjMyYjhlMTk1MmQ5MzMxNjVh NTdiMTRmODFkZjA2NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4 dFRyYWNrQ3VlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2tDdWUu aApAQCAtMTU1LDYgKzE1NSwxOCBAQCBwcml2YXRlOgogCiAgICAgYm9vbCBtX2Rpc3BsYXlUcmVl U2hvdWxkQ2hhbmdlOwogICAgIFJlZlB0cjxIVE1MRGl2RWxlbWVudD4gbV9kaXNwbGF5VHJlZTsK KworICAgIGludCBtX2Rpc3BsYXlEaXJlY3Rpb247CisKKyAgICBpbnQgbV9kaXNwbGF5V3JpdGlu Z01vZGVNYXBbM107CisgICAgaW50IG1fZGlzcGxheVdyaXRpbmdNb2RlOworCisgICAgaW50IG1f ZGlzcGxheVNpemU7CisgICAgaW50IG1fZGlzcGxheUhlaWdodDsKKyAgICBpbnQgbV9kaXNwbGF5 V2lkdGg7CisKKyAgICBkb3VibGUgbV9kaXNwbGF5WFBvc2l0aW9uOworICAgIGRvdWJsZSBtX2Rp c3BsYXlZUG9zaXRpb247CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==