79744 2012-02-27 21:59:39 -0800 kCTFontTableOptionExcludeSynthetic is unneeded 2012-02-28 14:03:41 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Enhancement --- 0 ned webkit-unassigned ap mitz webkit.review.bot oldest_to_newest 566372 0 ned 2012-02-27 21:59:39 -0800 fontHasVerticalGlyphs() in SimpleFontDataMac.mm passes kCTFontTableOptionExcludeSynthetic to CTFontCopyAvailableTables(), but there is no need to do so (the option only affects 10.5-linked apps). 566379 1 ned 2012-02-27 22:16:59 -0800 <rdar://problem/10940932> 566381 2 129188 ned 2012-02-27 22:19:24 -0800 Created attachment 129188 Proposed changes. 566399 3 129188 webkit.review.bot 2012-02-27 22:49:35 -0800 Comment on attachment 129188 Proposed changes. Clearing flags on attachment: 129188 Committed r109080: <http://trac.webkit.org/changeset/109080> 566400 4 webkit.review.bot 2012-02-27 22:49:40 -0800 All reviewed patches have been landed. Closing bug. 567004 5 ap 2012-02-28 13:01:24 -0800 This is surprising. Doesn't WebKit need to support 10.5-linked applications? 567071 6 ned 2012-02-28 14:03:41 -0800 I learn something new every day. Does WebKit support vertical text on 10.5? 129188 2012-02-27 22:19:24 -0800 2012-02-27 22:49:35 -0800 Proposed changes. NoOptions.txt text/plain 1801 ned SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwOTA3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTI3ICBOZWQgSG9s YnJvb2sgIDxuaG9sYnJvb2tAYXBwbGUuY29tPgorCisgICAgICAgIGtDVEZvbnRUYWJsZU9wdGlv bkV4Y2x1ZGVTeW50aGV0aWMgaXMgdW5uZWVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NzQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIGFmb3JlbWVudGlvbmVkIG9wdGlvbiBpcyBhIG5vLW9w LCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2lt cGxlRm9udERhdGFNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpmb250SGFzVmVydGljYWxHbHlw aHMpOiBTcGVjaWZ5IG5vIG9wdGlvbnMuCisKIDIwMTItMDItMjcgIFdlaSBKYW1lcyAgPGphbWVz LndlaUBpbnRlbC5jb20+CiAKICAgICAgICAgTXVsdGktQ2hhbm5lbCBzdXBwb3J0IGluIEF1ZGlv QnVmZmVyU291cmNlTm9kZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv bWFjL1NpbXBsZUZvbnREYXRhTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL21hYy9TaW1wbGVGb250RGF0YU1hYy5tbQkocmV2aXNpb24gMTA5MDc1 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1NpbXBsZUZvbnREYXRh TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw3ICs1Nyw3IEBAIGNvbnN0IGZsb2F0IHNtYWxs Q2Fwc0ZvbnRTaXplTXVsdGlwbGllciAKIHN0YXRpYyBib29sIGZvbnRIYXNWZXJ0aWNhbEdseXBo cyhDVEZvbnRSZWYgY3RGb250KQogewogICAgIC8vIFRoZSBjaGVjayBkb2Vzbid0IGxvb2sgbmVh dCBidXQgdGhpcyBpcyB3aGF0IEFwcEtpdCBkb2VzIGZvciB2ZXJ0aWNhbCB3cml0aW5nLi4uCi0g ICAgUmV0YWluUHRyPENGQXJyYXlSZWY+IHRhYmxlVGFncyhBZG9wdENGLCBDVEZvbnRDb3B5QXZh aWxhYmxlVGFibGVzKGN0Rm9udCwga0NURm9udFRhYmxlT3B0aW9uRXhjbHVkZVN5bnRoZXRpYykp OworICAgIFJldGFpblB0cjxDRkFycmF5UmVmPiB0YWJsZVRhZ3MoQWRvcHRDRiwgQ1RGb250Q29w eUF2YWlsYWJsZVRhYmxlcyhjdEZvbnQsIGtDVEZvbnRUYWJsZU9wdGlvbk5vT3B0aW9ucykpOwog ICAgIENGSW5kZXggbnVtVGFibGVzID0gQ0ZBcnJheUdldENvdW50KHRhYmxlVGFncy5nZXQoKSk7 CiAgICAgZm9yIChDRkluZGV4IGluZGV4ID0gMDsgaW5kZXggPCBudW1UYWJsZXM7ICsraW5kZXgp IHsKICAgICAgICAgQ1RGb250VGFibGVUYWcgdGFnID0gKENURm9udFRhYmxlVGFnKSh1aW50cHRy X3QpQ0ZBcnJheUdldFZhbHVlQXRJbmRleCh0YWJsZVRhZ3MuZ2V0KCksIGluZGV4KTsKQEAgLTcy LDcgKzcyLDYgQEAgc3RhdGljIGJvb2wgaW5pdEZvbnREYXRhKFNpbXBsZUZvbnREYXRhKgogICAg IGlmICghZm9udERhdGEtPnBsYXRmb3JtRGF0YSgpLmNnRm9udCgpKQogICAgICAgICByZXR1cm4g ZmFsc2U7CiAKLQogICAgIHJldHVybiB0cnVlOwogfQogCg==