79742 2012-02-27 21:35:03 -0800 Add missing parameter to didCreateScriptContext() so it overrides base class again. 2012-02-27 22:34:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koz koz bashi tkent webkit.review.bot oldest_to_newest 566358 0 koz 2012-02-27 21:35:03 -0800 Add missing parameter to didCreateScriptContext() so it overrides base class again. 566359 1 129184 koz 2012-02-27 21:35:42 -0800 Created attachment 129184 Patch 566360 2 bashi 2012-02-27 21:39:59 -0800 Kent-san, could you review the patch? This should fix WebFrameTest failures. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/12819/steps/webkit_unit_tests/logs/stdio 566366 3 129184 tkent 2012-02-27 21:45:02 -0800 Comment on attachment 129184 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129184&action=review ok > Source/WebKit/chromium/ChangeLog:7 > + We had better explain that http://trac.webkit.org/changeset/109064 added the parameter. 566393 4 129184 webkit.review.bot 2012-02-27 22:34:26 -0800 Comment on attachment 129184 Patch Clearing flags on attachment: 129184 Committed r109078: <http://trac.webkit.org/changeset/109078> 566394 5 webkit.review.bot 2012-02-27 22:34:30 -0800 All reviewed patches have been landed. Closing bug. 129184 2012-02-27 21:35:42 -0800 2012-02-27 22:34:26 -0800 Patch bug-79742-20120228163540.patch text/plain 1757 koz U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGE2ZTk0ZGY4OTQyZTM5ZGY3ODVhZDczNzk5OGNjMzQxZjVkMzk2N2UuLjRlNDUzODYyN2YyNjBk ZDUxNzViYTVlMGQxYTQwNGU5YzAxODMwMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDItMjcgIEphbWVzIEtvemlhbnNraSAgPGtvekBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgQWRkIG1pc3NpbmcgcGFyYW1ldGVyIHRvIGRpZENyZWF0ZVNjcmlw dENvbnRleHQoKSBzbyBpdCBvdmVycmlkZXMgYmFzZSBjbGFzcyBhZ2Fpbi4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NzQyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0cy9XZWJGcmFtZVRlc3Qu Y3BwOgorCiAyMDEyLTAyLTI2ICBIYWppbWUgTW9ycml0YSAgPG1vcnJpdGFAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIE1vdmUgQ2hyb21lQ2xpZW50OjpzaG93Q29udGV4dE1lbnUoKSB0byBDb250 ZXh0TWVudUNsaWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9X ZWJGcmFtZVRlc3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFtZVRl c3QuY3BwCmluZGV4IGRjMWRmZTUzNDJiYTBjZjRjMjM0N2E1OWJkNjZlNjZjMzc1MGU1ZTcuLjQ4 MWJkOTE2ZjNiZGIyOTZiNDU2Y2Y2MTQ1MDdlNWViOTMwODIzNDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAKQEAgLTMyMiwxMiArMzIyLDEyIEBA IHB1YmxpYzoKICAgICBzdGQ6OnZlY3RvcjxOb3RpZmljYXRpb24qPiByZWxlYXNlTm90aWZpY2F0 aW9uczsKIAogIHByaXZhdGU6Ci0gICAgdmlydHVhbCB2b2lkIGRpZENyZWF0ZVNjcmlwdENvbnRl eHQoV2ViRnJhbWUqIGZyYW1lLCB2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiBjb250ZXh0LCBpbnQg d29ybGRJZCkKKyAgICB2aXJ0dWFsIHZvaWQgZGlkQ3JlYXRlU2NyaXB0Q29udGV4dChXZWJGcmFt ZSogZnJhbWUsIHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNvbnRleHQsIGludCBleHRlbnNpb25H cm91cCwgaW50IHdvcmxkSWQpIE9WRVJSSURFCiAgICAgewogICAgICAgICBjcmVhdGVOb3RpZmlj YXRpb25zLnB1c2hfYmFjayhuZXcgTm90aWZpY2F0aW9uKGZyYW1lLCBjb250ZXh0LCB3b3JsZElk KSk7CiAgICAgfQogCi0gICAgdmlydHVhbCB2b2lkIHdpbGxSZWxlYXNlU2NyaXB0Q29udGV4dChX ZWJGcmFtZSogZnJhbWUsIHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNvbnRleHQsIGludCB3b3Js ZElkKQorICAgIHZpcnR1YWwgdm9pZCB3aWxsUmVsZWFzZVNjcmlwdENvbnRleHQoV2ViRnJhbWUq IGZyYW1lLCB2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiBjb250ZXh0LCBpbnQgd29ybGRJZCkgT1ZF UlJJREUKICAgICB7CiAgICAgICAgIHJlbGVhc2VOb3RpZmljYXRpb25zLnB1c2hfYmFjayhuZXcg Tm90aWZpY2F0aW9uKGZyYW1lLCBjb250ZXh0LCB3b3JsZElkKSk7CiAgICAgfQo=