79696 2012-02-27 13:47:44 -0800 Undefined variable 'current' when running chromium_android.py 2012-02-27 17:30:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wangxianzhu wangxianzhu abarth ojan webkit.review.bot oldest_to_newest 565938 0 wangxianzhu 2012-02-27 13:47:44 -0800 Sorry I uploaded a wrong version of patch to bug 79506 which contains a typo. Will fix it asap. 565950 1 129095 wangxianzhu 2012-02-27 13:59:31 -0800 Created attachment 129095 patch 565960 2 129095 abarth 2012-02-27 14:05:09 -0800 Comment on attachment 129095 patch This is the point when I nag you about adding unit testing for this code. This sort is bug is really easy to catch with a unit test. I think it's ok to land this patch without a test, but at some point we'll probably want to add tests. 566173 3 webkit.review.bot 2012-02-27 17:28:22 -0800 The commit-queue encountered the following flaky tests while processing attachment 129095: css3/filters/effect-invert-hw.html bug 79639 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 566178 4 129095 webkit.review.bot 2012-02-27 17:30:23 -0800 Comment on attachment 129095 patch Clearing flags on attachment: 129095 Committed r109049: <http://trac.webkit.org/changeset/109049> 566179 5 webkit.review.bot 2012-02-27 17:30:27 -0800 All reviewed patches have been landed. Closing bug. 129095 2012-02-27 13:59:31 -0800 2012-02-27 17:30:23 -0800 patch 79696 text/plain 1232 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwOTAyMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTAyLTI3ICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgVW5kZWZpbmVkIHZhcmlhYmxlICdjdXJyZW50JyB3aGVuIHJ1bm5p bmcgY2hyb21pdW1fYW5kcm9pZC5weQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Nzk2OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW1fYW5kcm9pZC5weToKKyAgICAgICAgKENocm9taXVtQW5kcm9pZERyaXZlci5fcmVhZF9wcm9t cHQpOgorCiAyMDEyLTAyLTI3ICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgQ2hyb21pdW0tQW5kcm9pZCBsYXlvdXQgdGVzdCBzY3JpcHQ6IHRoZSBh ZGIgc2hlbGwgcHJvbXB0IGlzIG5vdCBhbHdheXMgJyMgJwpJbmRleDogVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5k cm9pZC5weQkocmV2aXNpb24gMTA5MDIxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5CSh3b3JraW5nIGNvcHkpCkBAIC01Mjks NCArNTI5LDQgQEAgY2xhc3MgQ2hyb21pdW1BbmRyb2lkRHJpdmVyKGNocm9taXVtLkNocgogICAg ICAgICAgICAgICAgICAgICByZXR1cm4KICAgICAgICAgICAgICAgICBpZiBsYXN0X2NoYXIgPT0g JyQnOgogICAgICAgICAgICAgICAgICAgICByYWlzZSBBc3NlcnRpb25FcnJvcignQWRiZCBpcyBu b3QgcnVubmluZyBhcyByb290JykKLSAgICAgICAgICAgIGxhc3RfY2hhciA9IGN1cnJlbnQKKyAg ICAgICAgICAgIGxhc3RfY2hhciA9IGN1cnJlbnRfY2hhcgo=