79692 2012-02-27 12:04:39 -0800 [BlackBerry] Selection handling should be entirely directional 2012-02-27 13:22:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mifenton webkit-unassigned webkit.review.bot oldest_to_newest 565878 0 mifenton 2012-02-27 12:04:39 -0800 All generated selections used by SelectionHandler should be directional. 565886 1 129083 mifenton 2012-02-27 12:13:13 -0800 Created attachment 129083 Patch 565919 2 129083 webkit.review.bot 2012-02-27 13:22:34 -0800 Comment on attachment 129083 Patch Clearing flags on attachment: 129083 Committed r109019: <http://trac.webkit.org/changeset/109019> 565920 3 webkit.review.bot 2012-02-27 13:22:38 -0800 All reviewed patches have been landed. Closing bug. 129083 2012-02-27 12:13:13 -0800 2012-02-27 13:22:34 -0800 Patch 0001-2012-02-07-Mike-Fenton-mifenton-rim.com.patch text/plain 3956 mifenton RnJvbSAwNDAwOWI5NTliNDdkNmQ5MjhjODkxZmNiYmU5MDJmNmYxODhhZWU4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VHVlLCA3IEZlYiAyMDEyIDExOjA4OjQ4IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0wMi0w NyAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgoKICAgICAgICBNYWtlIGFsbCBWaXNp YmxlU2VsZWN0aW9ucyBkaXJlY3Rpb25hbC4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgogICAgICAgICogYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRs ZXIuY3BwOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OmV4 dGVuZFNlbGVjdGlvblRvRmllbGRCb3VuZGFyeSk6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktp dDo6U2VsZWN0aW9uSGFuZGxlcjo6dXBkYXRlT3JIYW5kbGVJbnB1dFNlbGVjdGlvbik6Ci0tLQog U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDEz ICsrKysrKysrKysrKysKIC4uLi9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFu ZGxlci5jcHAgIHwgICAgOCArKysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDBj MjUwZDMuLmRlNDZiMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEyLTAyLTI3ICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CisKKyAg ICAgICAgW0JsYWNrQmVycnldIFNlbGVjdGlvbiBoYW5kbGluZyBzaG91bGQgYmUgZW50aXJlbHkg ZGlyZWN0aW9uYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc5NjkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTWFrZSBhbGwgVmlzaWJsZVNlbGVjdGlvbnMgZGlyZWN0aW9uYWwuCisKKyAgICAgICAgKiBX ZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6 V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjp1cGRhdGVPckhhbmRsZUlucHV0U2VsZWN0aW9uKToK KyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6U2VsZWN0aW9uSGFuZGxlcjo6c2V0U2VsZWN0 aW9uKToKKwogMjAxMi0wMi0yNyAgTGVvIFlhbmcgIDxsZW8ueWFuZ0B0b3JjaG1vYmlsZS5jb20u Y24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFVwc3RyZWFtIGFjY2VsZXJhdGVkIGNvbXBvc2l0 aW5nIGhlbHBlciBjbGFzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcAppbmRleCBmZGE3MWI0Li4yYWEy NzBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9T ZWxlY3Rpb25IYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcApAQCAtMzg4LDEzICszODgsMTMgQEAgYm9vbCBT ZWxlY3Rpb25IYW5kbGVyOjp1cGRhdGVPckhhbmRsZUlucHV0U2VsZWN0aW9uKFZpc2libGVTZWxl Y3Rpb24mIG5ld1NlbGVjdGkKICAgICAgICAgY2hhcmFjdGVyID0gZXh0ZW5kU2VsZWN0aW9uVG9G aWVsZEJvdW5kYXJ5KHRydWUgLyogaXNTdGFydEhhbmRsZSAqLywgcmVsYXRpdmVTdGFydCwgbmV3 U2VsZWN0aW9uKTsKICAgICAgICAgaWYgKGNoYXJhY3RlcikgewogICAgICAgICAgICAgLy8gSW52 ZXJ0IHRoZSBzZWxlY3Rpb24gc28gdGhhdCB0aGUgY3Vyc29yIHBvaW50IGlzIGF0IHRoZSBiZWdp bm5pbmcuCi0gICAgICAgICAgICBjb250cm9sbGVyLT5zZXRTZWxlY3Rpb24oVmlzaWJsZVNlbGVj dGlvbihjb250cm9sbGVyLT5zZWxlY3Rpb24oKS5lbmQoKSwgY29udHJvbGxlci0+c2VsZWN0aW9u KCkuc3RhcnQoKSkpOworICAgICAgICAgICAgY29udHJvbGxlci0+c2V0U2VsZWN0aW9uKFZpc2li bGVTZWxlY3Rpb24oY29udHJvbGxlci0+c2VsZWN0aW9uKCkuZW5kKCksIGNvbnRyb2xsZXItPnNl bGVjdGlvbigpLnN0YXJ0KCksIHRydWUgLyogaXNEaXJlY3Rpb25hbCAqLykpOwogICAgICAgICB9 CiAgICAgfSBlbHNlIGlmIChlbmRJc091dHNpZGVPZkZpZWxkKSB7CiAgICAgICAgIGNoYXJhY3Rl ciA9IGV4dGVuZFNlbGVjdGlvblRvRmllbGRCb3VuZGFyeShmYWxzZSAvKiBpc1N0YXJ0SGFuZGxl ICovLCByZWxhdGl2ZUVuZCwgbmV3U2VsZWN0aW9uKTsKICAgICAgICAgaWYgKGNoYXJhY3Rlcikg ewogICAgICAgICAgICAgLy8gUmVzZXQgdGhlIHNlbGVjdGlvbiBzbyB0aGF0IHRoZSBlbmQgaXMg dGhlIGVkaXQgcG9pbnQuCi0gICAgICAgICAgICBjb250cm9sbGVyLT5zZXRTZWxlY3Rpb24oVmlz aWJsZVNlbGVjdGlvbihjb250cm9sbGVyLT5zZWxlY3Rpb24oKS5zdGFydCgpLCBjb250cm9sbGVy LT5zZWxlY3Rpb24oKS5lbmQoKSkpOworICAgICAgICAgICAgY29udHJvbGxlci0+c2V0U2VsZWN0 aW9uKFZpc2libGVTZWxlY3Rpb24oY29udHJvbGxlci0+c2VsZWN0aW9uKCkuc3RhcnQoKSwgY29u dHJvbGxlci0+c2VsZWN0aW9uKCkuZW5kKCksIHRydWUgLyogaXNEaXJlY3Rpb25hbCAqLykpOwog ICAgICAgICB9CiAgICAgfQogCkBAIC00NjIsNyArNDYyLDcgQEAgdm9pZCBTZWxlY3Rpb25IYW5k bGVyOjpzZXRTZWxlY3Rpb24oY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIHN0YXJ0LCBjb25zdCBX ZWJDb3IKIAogICAgIC8vIFdlIG5lZWQgdGhlIHNlbGVjdGlvbiB0byBiZSBvcmRlcmVkIGJhc2Ug dGhlbiBleHRlbnQuCiAgICAgaWYgKCFjb250cm9sbGVyLT5zZWxlY3Rpb24oKS5pc0Jhc2VGaXJz dCgpKQotICAgICAgICBjb250cm9sbGVyLT5zZXRTZWxlY3Rpb24oVmlzaWJsZVNlbGVjdGlvbihj b250cm9sbGVyLT5zZWxlY3Rpb24oKS5zdGFydCgpLCBjb250cm9sbGVyLT5zZWxlY3Rpb24oKS5l bmQoKSkpOworICAgICAgICBjb250cm9sbGVyLT5zZXRTZWxlY3Rpb24oVmlzaWJsZVNlbGVjdGlv bihjb250cm9sbGVyLT5zZWxlY3Rpb24oKS5zdGFydCgpLCBjb250cm9sbGVyLT5zZWxlY3Rpb24o KS5lbmQoKSwgdHJ1ZSAvKiBpc0RpcmVjdGlvbmFsICovKSk7CiAKICAgICBpZiAoc3RhcnRJc1Zh bGlkKSB7CiAgICAgICAgIHJlbGF0aXZlU3RhcnQgPSBET01TdXBwb3J0Ojpjb252ZXJ0UG9pbnRU b0ZyYW1lKG1fd2ViUGFnZS0+bWFpbkZyYW1lKCksIGZvY3VzZWRGcmFtZSwgc3RhcnQpOwpAQCAt NDg0LDYgKzQ4NCw4IEBAIHZvaWQgU2VsZWN0aW9uSGFuZGxlcjo6c2V0U2VsZWN0aW9uKGNvbnN0 IFdlYkNvcmU6OkludFBvaW50JiBzdGFydCwgY29uc3QgV2ViQ29yCiAgICAgICAgIG5ld1NlbGVj dGlvbi5zZXRXaXRob3V0VmFsaWRhdGlvbihjb250cm9sbGVyLT5zZWxlY3Rpb24oKS5zdGFydCgp LCBuZXdTZWxlY3Rpb24uZXh0ZW50KCkpOwogICAgIH0KIAorICAgIG5ld1NlbGVjdGlvbi5zZXRJ c0RpcmVjdGlvbmFsKHRydWUpOworCiAgICAgaWYgKG1fd2ViUGFnZS0+bV9pbnB1dEhhbmRsZXIt PmlzSW5wdXRNb2RlKCkpIHsKICAgICAgICAgaWYgKHVwZGF0ZU9ySGFuZGxlSW5wdXRTZWxlY3Rp b24obmV3U2VsZWN0aW9uLCByZWxhdGl2ZVN0YXJ0LCByZWxhdGl2ZUVuZCkpCiAgICAgICAgICAg ICByZXR1cm47Ci0tIAoxLjcuNS40Cgo=