79690 2012-02-27 11:56:08 -0800 Cleanup Gesture requirement when exiting video-play-require-user-gesture test 2012-02-27 14:11:15 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 qinmin webkit-unassigned pnormand webkit.review.bot oldest_to_newest 565867 0 qinmin 2012-02-27 11:56:08 -0800 Cleanup Gesture requirement when exiting video-play-require-user-gesture test 565868 1 129079 qinmin 2012-02-27 11:56:47 -0800 Created attachment 129079 Patch 565880 2 pnormand 2012-02-27 12:06:56 -0800 Is this the cause of the flakiness? I didn't check your whole patch introducing this test, it was just a hunch I had. 565883 3 qinmin 2012-02-27 12:10:22 -0800 Seems so, tested it with chromium. The chromium bot sometimes got 1-2 flaky test with my test html. But with this change, the flakiness is gone. 565892 4 129079 pnormand 2012-02-27 12:19:54 -0800 Comment on attachment 129079 Patch Looks good, thanks! 565914 5 129079 webkit.review.bot 2012-02-27 13:11:09 -0800 Comment on attachment 129079 Patch Clearing flags on attachment: 129079 Committed r109018: <http://trac.webkit.org/changeset/109018> 565915 6 webkit.review.bot 2012-02-27 13:11:14 -0800 All reviewed patches have been landed. Closing bug. 565943 7 pnormand 2012-02-27 13:54:57 -0800 Media flakiness indeed went away thanks to this patch. Thanks :) 565969 8 qinmin 2012-02-27 14:11:15 -0800 Thank you for finding out this problem, and for your hunch! 129079 2012-02-27 11:56:47 -0800 2012-02-27 13:11:09 -0800 Patch bug-79690-20120227115646.patch text/plain 2449 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4ODQ1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmQ5N2JhMzk4ZTFhNTFiYmQwYTU4 ZjYyYTc0MTcyMTNmY2ZjNThhMy4uNmY3NGNkOGYyYzI2OTkyYmQ4M2RiZmUyMGVjODA0YWNhZDdm MzQxZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAyLTI3ICBNaW4gUWluICA8cWlubWlu QGdvb2dsZS5jb20+CisKKyAgICAgICAgQ2xlYW51cCBHZXN0dXJlIHJlcXVpcmVtZW50IHdoZW4g ZXhpdGluZyB2aWRlby1wbGF5LXJlcXVpcmUtdXNlci1nZXN0dXJlIHRlc3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NjkwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtZWRpYS92aWRlby1wbGF5LXJl cXVpcmUtdXNlci1nZXN0dXJlLmh0bWw6CisKIDIwMTItMDItMjQgIEdhdmluIEJhcnJhY2xvdWdo ICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFNob3VsZCBub3QgYWxsb3cgbWFs Zm9ybWVkIFx4IGVzY2FwZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBs YXktcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBs YXktcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbAppbmRleCBhZGZmNjZiMGQxZjJmNDY0YTQzMTFi NmUyZjI5ZDY2ZTllYmUzYzRiLi43NGVkYWIxMmZhNjA0MmIzOTg1ZWI5ODM1M2IwN2RhMTgwNDQ4 OThmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wbGF5LXJlcXVpcmUtdXNl ci1nZXN0dXJlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcGxheS1yZXF1aXJl LXVzZXItZ2VzdHVyZS5odG1sCkBAIC05LDYgKzksMTEgQEAKICAgICAgICAgICAgIGlmICh3aW5k b3cuaW50ZXJuYWxzKSAKICAgICAgICAgICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNldE1lZGlh UGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlKGRvY3VtZW50LCB0cnVlKTsKIAorICAgICAgICAg ICAgZnVuY3Rpb24gY2xlYW5HZXN0dXJlUmVxdWlyZW1lbnQoKSB7CisgICAgICAgICAgICAgICAg aWYgKHdpbmRvdy5pbnRlcm5hbHMpIAorICAgICAgICAgICAgICAgICAgICB3aW5kb3cuaW50ZXJu YWxzLnNldE1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlKGRvY3VtZW50LCBmYWxzZSk7 CisgICAgICAgICAgICB9CisKICAgICAgICAgICAgIGZ1bmN0aW9uIGNsaWNrKCkKICAgICAgICAg ICAgIHsKICAgICAgICAgICAgICAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7CkBAIC0xNiw2 ICsyMSw3IEBACiAgICAgICAgICAgICAgICAgICAgIHRyeSB7CiAgICAgICAgICAgICAgICAgICAg ICAgICBwbGF5Q29vcmRzID0gbWVkaWFDb250cm9sc0J1dHRvbkNvb3JkaW5hdGVzKHZpZGVvLCAi cGxheS1idXR0b24iKTsKICAgICAgICAgICAgICAgICAgICAgfSBjYXRjaCAoZXhjZXB0aW9uKSB7 CisgICAgICAgICAgICAgICAgICAgICAgICBjbGVhbkdlc3R1cmVSZXF1aXJlbWVudCgpOwogICAg ICAgICAgICAgICAgICAgICAgICAgZmFpbFRlc3QoZXhjZXB0aW9uLmRlc2NyaXB0aW9uKTsKICAg ICAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgICAgICAgfQpAQCAt MzIsNiArMzgsNyBAQAogICAgICAgICAgICAgZnVuY3Rpb24gcGxheWluZygpCiAgICAgICAgICAg ICB7CiAgICAgICAgICAgICAgICAgaWYgKHVzZXJHZXN0dXJlSW5pdGlhdGVkID09IDApIHsKKyAg ICAgICAgICAgICAgICAgICAgY2xlYW5HZXN0dXJlUmVxdWlyZW1lbnQoKTsKICAgICAgICAgICAg ICAgICAgICAgZmFpbFRlc3QoIlNob3VsZCBub3QgcGxheSB3aXRob3V0IHVzZXIgZ2VzdHVyZS4i KTsKICAgICAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgICAgICBydW4oInZp ZGVvLnBhdXNlKCkiKTsKQEAgLTQ3LDggKzU0LDEwIEBACiAgICAgICAgICAgICAgICAgdHJ5IHsK ICAgICAgICAgICAgICAgICAgICAgcnVuKCJ2aWRlby53ZWJraXRFbnRlckZ1bGxTY3JlZW4oKSIp OwogICAgICAgICAgICAgICAgIH0gY2F0Y2goZXgpIHsKKyAgICAgICAgICAgICAgICAgICAgY2xl YW5HZXN0dXJlUmVxdWlyZW1lbnQoKTsKICAgICAgICAgICAgICAgICAgICAgZmFpbFRlc3QoInZp ZGVvLndlYmtpdEVudGVyRnVsbFNjcmVlbigpIHN0aWxsIHJlcXVpcmVzIHVzZXIgZ2VzdHVyZS4i KTsKICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgY2xlYW5HZXN0dXJlUmVxdWly ZW1lbnQoKTsgCiAgICAgICAgICAgICAgICAgZW5kVGVzdCgpOwogICAgICAgICAgICAgfQogCg==