79672 2012-02-27 07:28:58 -0800 Performance: stop recomputing SVG path data twice during layout 2012-02-27 09:58:13 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr webkit-unassigned rhodovan.u-szeged schenney webkit.review.bot zimmermann oldest_to_newest 565640 0 pdr 2012-02-27 07:28:58 -0800 We currently recompute SVG path data twice during layout, but we only need to do this once. This is especially bad in the case of circles and ellipses, where each call to createShape() ends up creating 4 expensive cubics. Patch forthcoming! 565641 1 129035 pdr 2012-02-27 07:31:07 -0800 Created attachment 129035 Stop recomputing SVG path data twice during layout 565687 2 129035 zimmermann 2012-02-27 08:54:05 -0800 Comment on attachment 129035 Stop recomputing SVG path data twice during layout Nice catch, r=me. 565757 3 webkit.review.bot 2012-02-27 09:56:09 -0800 The commit-queue encountered the following flaky tests while processing attachment 129035: css3/filters/effect-invert-hw.html bug 79639 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 565759 4 129035 webkit.review.bot 2012-02-27 09:58:09 -0800 Comment on attachment 129035 Stop recomputing SVG path data twice during layout Clearing flags on attachment: 129035 Committed r109003: <http://trac.webkit.org/changeset/109003> 565760 5 webkit.review.bot 2012-02-27 09:58:13 -0800 All reviewed patches have been landed. Closing bug. 129035 2012-02-27 07:31:07 -0800 2012-02-27 09:58:09 -0800 Stop recomputing SVG path data twice during layout 79672.1.patch text/plain 1692 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwODk5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTI3ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgU3RvcCByZWNvbXB1dGluZyBTVkcg cGF0aCBkYXRhIHR3aWNlIGR1cmluZyBsYXlvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NjcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1NoYXBlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR1NoYXBlOjpsYXlvdXQpOgorCiAyMDEyLTAyLTI3 ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBbU2hhZG93 XTogRXhwb3NlIG9uZSBTaGFkb3dSb290IGluIHRoZSBFbGVtZW50cyBwYW5lbCAodW5kZXIgZXhw ZXJpbWVudCBmbGFnKQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJT VkdTaGFwZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9S ZW5kZXJTVkdTaGFwZS5jcHAJKHJldmlzaW9uIDEwODk5MSkKKysrIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdmcvUmVuZGVyU1ZHU2hhcGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjgsNyAr MTY4LDcgQEAgdm9pZCBSZW5kZXJTVkdTaGFwZTo6bGF5b3V0KCkKICAgICBib29sIHVwZGF0ZUNh Y2hlZEJvdW5kYXJpZXNJblBhcmVudHMgPSBmYWxzZTsKIAogICAgIGJvb2wgbmVlZHNTaGFwZVVw ZGF0ZSA9IG1fbmVlZHNTaGFwZVVwZGF0ZTsKLSAgICBpZiAobmVlZHNTaGFwZVVwZGF0ZSkgewor ICAgIGlmIChuZWVkc1NoYXBlVXBkYXRlIHx8IG1fbmVlZHNCb3VuZGFyaWVzVXBkYXRlKSB7CiAg ICAgICAgIHNldElzUGFpbnRpbmdGYWxsYmFjayhmYWxzZSk7CiAgICAgICAgIG1fcGF0aC5jbGVh cigpOwogICAgICAgICBjcmVhdGVTaGFwZSgpOwpAQCAtMTgyLDEzICsxODIsNiBAQCB2b2lkIFJl bmRlclNWR1NoYXBlOjpsYXlvdXQoKQogICAgICAgICB1cGRhdGVDYWNoZWRCb3VuZGFyaWVzSW5Q YXJlbnRzID0gdHJ1ZTsKICAgICB9CiAKLSAgICBpZiAobV9uZWVkc0JvdW5kYXJpZXNVcGRhdGUp IHsKLSAgICAgICAgc2V0SXNQYWludGluZ0ZhbGxiYWNrKGZhbHNlKTsKLSAgICAgICAgbV9wYXRo LmNsZWFyKCk7Ci0gICAgICAgIGNyZWF0ZVNoYXBlKCk7Ci0gICAgICAgIHVwZGF0ZUNhY2hlZEJv dW5kYXJpZXNJblBhcmVudHMgPSB0cnVlOwotICAgIH0KLQogICAgIC8vIEludmFsaWRhdGUgYWxs IHJlc291cmNlcyBvZiB0aGlzIGNsaWVudCBpZiBvdXIgbGF5b3V0IGNoYW5nZWQuCiAgICAgaWYg KGV2ZXJIYWRMYXlvdXQoKSAmJiBzZWxmTmVlZHNMYXlvdXQoKSkgewogICAgICAgICBTVkdSZXNv dXJjZXNDYWNoZTo6Y2xpZW50TGF5b3V0Q2hhbmdlZCh0aGlzKTsK