79658 2012-02-27 03:47:06 -0800 [Qt] Fixed incorrect size pixmap creation for a new transparency layer. 2012-03-01 08:13:46 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79659 0 dongseong.hwang webkit-unassigned hausmann kenneth kling webkit.review.bot zherczeg oldest_to_newest 565552 0 dongseong.hwang 2012-02-27 03:47:06 -0800 If QPainter does not have clipping, beginPlatformTransparencyLayer can create wrong size pixmap, so it causes incorrect rendering. 565553 1 129005 dongseong.hwang 2012-02-27 03:48:24 -0800 Created attachment 129005 patch 565554 2 129006 dongseong.hwang 2012-02-27 03:52:25 -0800 Created attachment 129006 patch v.2 566134 3 dongseong.hwang 2012-02-27 17:02:19 -0800 Bug 79659 waits for this patch. 568663 4 hausmann 2012-03-01 07:58:31 -0800 (In reply to comment #3) > Bug 79659 waits for this patch. Then let's make it blocking :) 568666 5 129006 webkit.review.bot 2012-03-01 08:02:14 -0800 Comment on attachment 129006 patch v.2 Rejecting attachment 129006 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11770496 568672 6 hausmann 2012-03-01 08:13:46 -0800 Committed r109347: <http://trac.webkit.org/changeset/109347> 129005 2012-02-27 03:48:24 -0800 2012-02-27 03:52:25 -0800 patch 0001-Qt-Fixed-incorrect-size-pixmap-creation-for-a-new-tr.patch text/plain 1892 dongseong.hwang RnJvbSA1OGIyYWY2NzllZGE2OWY1NmI5MzdhZGIyYTNkMGU4ZTgwMzc0ZTFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IE1vbiwgMjcgRmViIDIwMTIgMjA6NDE6NDggKzA5MDAKU3ViamVjdDogW1BBVENI XSBbUXRdIEZpeGVkIGluY29ycmVjdCBzaXplIHBpeG1hcCBjcmVhdGlvbiBmb3IgYSBuZXcKIHRy YW5zcGFyZW5jeSBsYXllci4KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03OTY1OAoKSWYgUVBhaW50ZXIgZG9lcyBub3QgaGF2ZSBjbGlwcGluZywgYmVnaW5QbGF0Zm9y bVRyYW5zcGFyZW5jeUxheWVyIGNhbiBjcmVhdGUKd3Jvbmcgc2l6ZSBwaXhtYXAsIHNvIGl0IGNh dXNlcyBpbmNvcnJlY3QgcmVuZGVyaW5nLgotLS0KIC4uLi9wbGF0Zm9ybS9ncmFwaGljcy9xdC9H cmFwaGljc0NvbnRleHRRdC5jcHAgICAgIHwgICAxNCArKysrKysrKy0tLS0tLQogMSBmaWxlcyBj aGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3Bw CmluZGV4IDY1MDQwYjIuLjdkMDc1MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKQEAgLTEwNjgsMTIg KzEwNjgsMTQgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmJlZ2luUGxhdGZvcm1UcmFuc3BhcmVu Y3lMYXllcihmbG9hdCBvcGFjaXR5KQogICAgIHcgPSBkZXZpY2UtPndpZHRoKCk7CiAgICAgaCA9 IGRldmljZS0+aGVpZ2h0KCk7CiAKLSAgICBRUmVjdEYgY2xpcCA9IG1fZGF0YS0+Y2xpcEJvdW5k aW5nUmVjdCgpOwotICAgIFFSZWN0RiBkZXZpY2VDbGlwID0gcC0+dHJhbnNmb3JtKCkubWFwUmVj dChjbGlwKTsKLSAgICB4ID0gaW50KHFCb3VuZChxcmVhbCgwKSwgZGV2aWNlQ2xpcC54KCksIChx cmVhbCl3KSk7Ci0gICAgeSA9IGludChxQm91bmQocXJlYWwoMCksIGRldmljZUNsaXAueSgpLCAo cXJlYWwpaCkpOwotICAgIHcgPSBpbnQocUJvdW5kKHFyZWFsKDApLCBkZXZpY2VDbGlwLndpZHRo KCksIChxcmVhbCl3KSArIDIpOwotICAgIGggPSBpbnQocUJvdW5kKHFyZWFsKDApLCBkZXZpY2VD bGlwLmhlaWdodCgpLCAocXJlYWwpaCkgKyAyKTsKKyAgICBpZiAocC0+aGFzQ2xpcHBpbmcoKSkg eworICAgICAgICBRUmVjdEYgY2xpcCA9IG1fZGF0YS0+Y2xpcEJvdW5kaW5nUmVjdCgpOworICAg ICAgICBRUmVjdEYgZGV2aWNlQ2xpcCA9IHAtPnRyYW5zZm9ybSgpLm1hcFJlY3QoY2xpcCk7Cisg ICAgICAgIHggPSBpbnQocUJvdW5kKHFyZWFsKDApLCBkZXZpY2VDbGlwLngoKSwgKHFyZWFsKXcp KTsKKyAgICAgICAgeSA9IGludChxQm91bmQocXJlYWwoMCksIGRldmljZUNsaXAueSgpLCAocXJl YWwpaCkpOworICAgICAgICB3ID0gaW50KHFCb3VuZChxcmVhbCgwKSwgZGV2aWNlQ2xpcC53aWR0 aCgpLCAocXJlYWwpdykgKyAyKTsKKyAgICAgICAgaCA9IGludChxQm91bmQocXJlYWwoMCksIGRl dmljZUNsaXAuaGVpZ2h0KCksIChxcmVhbCloKSArIDIpOworICAgIH0KIAogICAgIFFQaXhtYXAg ZW1wdHlBbHBoYU1hc2s7CiAgICAgbV9kYXRhLT5sYXllcnMucHVzaChuZXcgVHJhbnNwYXJlbmN5 TGF5ZXIocCwgUVJlY3QoeCwgeSwgdywgaCksIG9wYWNpdHksIGVtcHR5QWxwaGFNYXNrKSk7Ci0t IAoxLjcuNS40Cgo= 129006 2012-02-27 03:52:25 -0800 2012-03-01 08:02:14 -0800 patch v.2 0001-Qt-Fixed-incorrect-size-pixmap-creation-for-a-new-tr.patch text/plain 2751 dongseong.hwang RnJvbSA1OWMwNGI3NzNiYTE3ZTAxN2EwZDdhODY5MmIyNWZmNmVmZmY4ODVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IE1vbiwgMjcgRmViIDIwMTIgMjA6NDE6NDggKzA5MDAKU3ViamVjdDogW1BBVENI XSBbUXRdIEZpeGVkIGluY29ycmVjdCBzaXplIHBpeG1hcCBjcmVhdGlvbiBmb3IgYSBuZXcKIHRy YW5zcGFyZW5jeSBsYXllci4KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03OTY1OAoKSWYgUVBhaW50ZXIgZG9lcyBub3QgaGF2ZSBjbGlwcGluZywgYmVnaW5QbGF0Zm9y bVRyYW5zcGFyZW5jeUxheWVyIGNhbiBjcmVhdGUKd3Jvbmcgc2l6ZSBwaXhtYXAsIHNvIGl0IGNh dXNlcyBpbmNvcnJlY3QgcmVuZGVyaW5nLgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vcGxhdGZv cm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwICAgICB8ICAgMTQgKysrKysrKyst LS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggOWY3NzFjZi4uNGE2MGMwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTAyLTI3ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0 PgorCisgICAgICAgIFtRdF0gRml4ZWQgaW5jb3JyZWN0IHNpemUgcGl4bWFwIGNyZWF0aW9uIGZv ciBhIG5ldyB0cmFuc3BhcmVuY3kgbGF5ZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03OTY1OAorCisgICAgICAgIElmIFFQYWludGVyIGRvZXMgbm90 IGhhdmUgY2xpcHBpbmcsIGJlZ2luUGxhdGZvcm1UcmFuc3BhcmVuY3lMYXllciBjYW4gY3JlYXRl CisgICAgICAgIHdyb25nIHNpemUgcGl4bWFwLCBzbyBpdCBjYXVzZXMgaW5jb3JyZWN0IHJlbmRl cmluZy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6YmVnaW5QbGF0Zm9ybVRyYW5zcGFyZW5jeUxheWVyKToK KwogMjAxMi0wMi0yNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwODU0Ny4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0 LmNwcAppbmRleCA2NTA0MGIyLi43ZDA3NTJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCkBAIC0xMDY4 LDEyICsxMDY4LDE0IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpiZWdpblBsYXRmb3JtVHJhbnNw YXJlbmN5TGF5ZXIoZmxvYXQgb3BhY2l0eSkKICAgICB3ID0gZGV2aWNlLT53aWR0aCgpOwogICAg IGggPSBkZXZpY2UtPmhlaWdodCgpOwogCi0gICAgUVJlY3RGIGNsaXAgPSBtX2RhdGEtPmNsaXBC b3VuZGluZ1JlY3QoKTsKLSAgICBRUmVjdEYgZGV2aWNlQ2xpcCA9IHAtPnRyYW5zZm9ybSgpLm1h cFJlY3QoY2xpcCk7Ci0gICAgeCA9IGludChxQm91bmQocXJlYWwoMCksIGRldmljZUNsaXAueCgp LCAocXJlYWwpdykpOwotICAgIHkgPSBpbnQocUJvdW5kKHFyZWFsKDApLCBkZXZpY2VDbGlwLnko KSwgKHFyZWFsKWgpKTsKLSAgICB3ID0gaW50KHFCb3VuZChxcmVhbCgwKSwgZGV2aWNlQ2xpcC53 aWR0aCgpLCAocXJlYWwpdykgKyAyKTsKLSAgICBoID0gaW50KHFCb3VuZChxcmVhbCgwKSwgZGV2 aWNlQ2xpcC5oZWlnaHQoKSwgKHFyZWFsKWgpICsgMik7CisgICAgaWYgKHAtPmhhc0NsaXBwaW5n KCkpIHsKKyAgICAgICAgUVJlY3RGIGNsaXAgPSBtX2RhdGEtPmNsaXBCb3VuZGluZ1JlY3QoKTsK KyAgICAgICAgUVJlY3RGIGRldmljZUNsaXAgPSBwLT50cmFuc2Zvcm0oKS5tYXBSZWN0KGNsaXAp OworICAgICAgICB4ID0gaW50KHFCb3VuZChxcmVhbCgwKSwgZGV2aWNlQ2xpcC54KCksIChxcmVh bCl3KSk7CisgICAgICAgIHkgPSBpbnQocUJvdW5kKHFyZWFsKDApLCBkZXZpY2VDbGlwLnkoKSwg KHFyZWFsKWgpKTsKKyAgICAgICAgdyA9IGludChxQm91bmQocXJlYWwoMCksIGRldmljZUNsaXAu d2lkdGgoKSwgKHFyZWFsKXcpICsgMik7CisgICAgICAgIGggPSBpbnQocUJvdW5kKHFyZWFsKDAp LCBkZXZpY2VDbGlwLmhlaWdodCgpLCAocXJlYWwpaCkgKyAyKTsKKyAgICB9CiAKICAgICBRUGl4 bWFwIGVtcHR5QWxwaGFNYXNrOwogICAgIG1fZGF0YS0+bGF5ZXJzLnB1c2gobmV3IFRyYW5zcGFy ZW5jeUxheWVyKHAsIFFSZWN0KHgsIHksIHcsIGgpLCBvcGFjaXR5LCBlbXB0eUFscGhhTWFzaykp OwotLSAKMS43LjUuNAoK