79651 2012-02-27 02:10:45 -0800 [GTK] Crop support in BitmapImage 2012-03-06 09:39:31 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 77087 1 pnormand webkit-unassigned alex mrobinson pnormand oldest_to_newest 565492 0 pnormand 2012-02-27 02:10:45 -0800 I'm not sure it's doable already. What I need to do when painting an Image surface from a source rectangle to a destination rectangle is to select only a region of the source rectangle. I'll attach a patch for ImageCairo. 565494 1 128991 pnormand 2012-02-27 02:13:44 -0800 Created attachment 128991 Crop support in BitmapImage 565688 2 128991 mrobinson 2012-02-27 08:54:07 -0800 Comment on attachment 128991 Crop support in BitmapImage Is this used anywhere? 565692 3 pnormand 2012-02-27 08:57:00 -0800 (In reply to comment #2) > (From update of attachment 128991 [details]) > Is this used anywhere? In the patch of bug 77087 :) I'm not sure this is the right approach though, I did this as an experiment and it seems to work but my knowledge of the Cairo stuff is a bit limited. 571674 4 pnormand 2012-03-06 02:11:48 -0800 Alex, what do you think about this? 571813 5 mrobinson 2012-03-06 06:56:00 -0800 (In reply to comment #4) > Alex, what do you think about this? Perhaps ::crop could me a method on ImageGstreamer. Then you could just adjust the srcRect you pass into Image::draw. 571814 6 128991 mrobinson 2012-03-06 06:57:13 -0800 Comment on attachment 128991 Crop support in BitmapImage I think perhaps platform-independent Image is the wrong place for this. :/ Also it seems like a change like this should just go in the patch that depends on it -- instead of introducing code that is totally dead. Perhaps we can chat about another design. 571841 7 pnormand 2012-03-06 07:31:07 -0800 (In reply to comment #5) > (In reply to comment #4) > > Alex, what do you think about this? > > Perhaps ::crop could me a method on ImageGstreamer. Then you could just adjust the srcRect you pass into Image::draw. the rect in MediaPlayerPrivateGStreamer::paint() is the destination rectangle, I think. Not the source rectangle. What I need to crop is the source. 571913 8 pnormand 2012-03-06 09:39:31 -0800 Will do as Martin suggests. Thanks! 128991 2012-02-27 02:13:44 -0800 2012-03-06 06:57:13 -0800 Crop support in BitmapImage Crop-support-in-BitmapImage.patch text/plain 2869 pnormand RnJvbSAxNDQ1ZTIxNzJhZjAwYmU4NTBkNjYyMGQ4NmQ4MTc4NDU3ZDJiNmYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDI0IEZlYiAyMDEyIDEyOjQwOjU3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g Q3JvcCBzdXBwb3J0IGluIEJpdG1hcEltYWdlCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNyArKysrKysrKysrKysrKysrKwogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuaCAgICAgfCAgICA0ICsr KysKIC4uLi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQ2Fpcm8uY3BwIHwg ICAgNiArKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggZDUyZTY3Ni4uYjEzMTYyYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIwIEBACisyMDEyLTAyLTI3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBDcm9wIHN1cHBvcnQgaW4gQml0bWFwSW1hZ2UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NjUxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmV3IDo6Y3JvcCgpIG1l dGhvZCBpbiBCaXRtYXBJbWFnZSBhbGxvd2luZyB0byBwYWludCBvbmx5IGEKKyAgICAgICAgc3Vi cmVnaW9uIG9mIHRoZSBpbWFnZS4gRm9yIG5vdyBvbmx5IHRoZSBDYWlybyBCaXRJbWFnZQorICAg ICAgICBpbXBsZW1lbnRhdGlvbiBzdXBwb3J0cyB0aGlzIHRob3VnaC4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmg6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJ bWFnZTo6Y3JvcCk6CisgICAgICAgIChCaXRtYXBJbWFnZSk6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vSW1hZ2VDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJ bWFnZTo6ZHJhdyk6CisKIDIwMTItMDEtMjYgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIGRpc2FibGUgR1N0cmVhbWVyR1dvcmxk IHdoZW4gYnVpbGRpbmcgYWdhaW5zdCAwLjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvQml0bWFwSW1hZ2UuaAppbmRleCAwMDgwMmY2Li4xMzEzNjIwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmgKQEAgLTExNiw2ICsx MTYsOCBAQCBwdWJsaWM6CiAgICAgSW50U2l6ZSBjdXJyZW50RnJhbWVTaXplKCkgY29uc3Q7CiAg ICAgdmlydHVhbCBib29sIGdldEhvdFNwb3QoSW50UG9pbnQmKSBjb25zdDsKIAorICAgIHZvaWQg Y3JvcChJbnRSZWN0IHIpIHsgbV9jcm9wUmVjdCA9IHI7IH0KKwogICAgIHZpcnR1YWwgYm9vbCBk YXRhQ2hhbmdlZChib29sIGFsbERhdGFSZWNlaXZlZCk7CiAgICAgdmlydHVhbCBTdHJpbmcgZmls ZW5hbWVFeHRlbnNpb24oKSBjb25zdDsgCiAKQEAgLTI4Niw2ICsyODgsOCBAQCBwcm90ZWN0ZWQ6 CiAgICAgYm9vbCBtX3NpemVBdmFpbGFibGUgOiAxOyAvLyBXaGV0aGVyIG9yIG5vdCB3ZSBjYW4g b2J0YWluIHRoZSBzaXplIG9mIHRoZSBmaXJzdCBpbWFnZSBmcmFtZSB5ZXQgZnJvbSBJbWFnZUlP LgogICAgIG11dGFibGUgYm9vbCBtX2hhc1VuaWZvcm1GcmFtZVNpemUgOiAxOwogICAgIG11dGFi bGUgYm9vbCBtX2hhdmVGcmFtZUNvdW50IDogMTsKKworICAgIEludFJlY3QgbV9jcm9wUmVjdDsK IH07CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL0ltYWdlQ2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fp cm8vSW1hZ2VDYWlyby5jcHAKaW5kZXggMDA4NGI0Mi4uMjllYzE0OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VDYWlyby5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VDYWlyby5jcHAKQEAg LTExOSw2ICsxMTksMTIgQEAgdm9pZCBCaXRtYXBJbWFnZTo6ZHJhdyhHcmFwaGljc0NvbnRleHQq IGNvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgZHN0LCBjb25zdCBGbG8KICAgICAgICAgY29udGV4 dC0+c2V0Q29tcG9zaXRlT3BlcmF0aW9uKENvbXBvc2l0ZUNvcHkpOwogICAgIGVsc2UKICAgICAg ICAgY29udGV4dC0+c2V0Q29tcG9zaXRlT3BlcmF0aW9uKG9wKTsKKworICAgIGlmICghbV9jcm9w UmVjdC5pc0VtcHR5KCkpIHsKKyAgICAgICAgc3JjUmVjdC5tb3ZlQnkobV9jcm9wUmVjdC5sb2Nh dGlvbigpKTsKKyAgICAgICAgc3JjUmVjdC5zZXRTaXplKG1fY3JvcFJlY3Quc2l6ZSgpKTsKKyAg ICB9CisKICAgICBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+ZHJhd1N1cmZhY2VUb0NvbnRl eHQoaW1hZ2UsIGRzdFJlY3QsIHNyY1JlY3QsIGNvbnRleHQpOwogCiAgICAgY29udGV4dC0+cmVz dG9yZSgpOwotLSAKMS43LjkuMQ==