79648 2012-02-27 01:55:57 -0800 Improve the visual of the tiling 2012-02-28 08:52:57 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kenneth kenneth hausmann jturcotte noam webkit.review.bot oldest_to_newest 565477 0 kenneth 2012-02-27 01:55:57 -0800 We currently tile the area outside the visible rect, in circles (or rather stars) from the inside-out. On pages which are blocking, this looks quite bad while scrolling, so the idea is to tile in rects instead. 565481 1 128987 kenneth 2012-02-27 01:58:37 -0800 Created attachment 128987 Patch 565572 2 128987 kenneth 2012-02-27 04:35:20 -0800 Comment on attachment 128987 Patch Wrong patch! 565573 3 129014 kenneth 2012-02-27 04:36:39 -0800 Created attachment 129014 Patch 565579 4 129014 jturcotte 2012-02-27 04:52:17 -0800 Comment on attachment 129014 Patch Makes sense if we use the trajectory vector to discard tiles outside the viewport when panning. LGTM. 565599 5 129022 kenneth 2012-02-27 05:56:26 -0800 Created attachment 129022 Patch 566740 6 129022 webkit.review.bot 2012-02-28 08:52:52 -0800 Comment on attachment 129022 Patch Clearing flags on attachment: 129022 Committed r109112: <http://trac.webkit.org/changeset/109112> 566741 7 webkit.review.bot 2012-02-28 08:52:57 -0800 All reviewed patches have been landed. Closing bug. 128987 2012-02-27 01:58:37 -0800 2012-02-27 04:36:33 -0800 Patch bug-79648-20120227105211.patch text/plain 2119 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZkYzQ4OGFiNmFiMzhk YmQzN2VjZDQxNTM1NTEzNTVhNjE0OWRlZi4uZGJhMWFlZTYxM2MyNjUxMzk2YWIyY2IxOWQ1MGU1 OTRmMTJmNWEyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTI3ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBJ bXByb3ZlIHRoZSB2aXN1YWwgb2YgdGhlIHRpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk2NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjdXJyZW50bHkgdGlsZSB0aGUgYXJlYSBvdXRzaWRl IHRoZSB2aXNpYmxlIHJlY3QsIGluIGNpcmNsZXMgKG9yCisgICAgICAgIHJhdGhlciBzdGFycykg ZnJvbSB0aGUgaW5zaWRlLW91dC4KKworICAgICAgICBBcyB0aGlzIGNhbiBsb29rIHF1aXRlIGJh ZCB3aGlsZSBzY3JvbGxpbmcsIHdlIG5vdyBpbnN0ZWFkIHRpbGUgaW4KKyAgICAgICAgcmVjdHMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpUaWxlZEJhY2tpbmdTdG9yZTo6dGlsZURpc3RhbmNlKToKKwogMjAx Mi0wMi0yMSAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBnZXQgcmlkIG9mIFJhd1NvdXJjZUNvZGUuc291cmNlTWFwcGlu ZyBnZXR0ZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9U aWxlZEJhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9U aWxlZEJhY2tpbmdTdG9yZS5jcHAKaW5kZXggYWNmNGM4OTU3MzRlYzBkM2RkNmUzZDkyNzg2YmQ1 MzBkN2JiNGRkNC4uODgxMTU5MWM0ZTUwMjA2OWExMDQwZDYxMzNjZWRkMjU4MTJiYzQwZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3Rv cmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2lu Z1N0b3JlLmNwcApAQCAtMTkzLDEzICsxOTMsMTQgQEAgZG91YmxlIFRpbGVkQmFja2luZ1N0b3Jl Ojp0aWxlRGlzdGFuY2UoY29uc3QgSW50UmVjdCYgdmlld3BvcnQsIGNvbnN0IFRpbGU6OkNvb3IK IHsKICAgICBpZiAodmlld3BvcnQuaW50ZXJzZWN0cyh0aWxlUmVjdEZvckNvb3JkaW5hdGUodGls ZUNvb3JkaW5hdGUpKSkKICAgICAgICAgcmV0dXJuIDA7Ci0gICAgCisKICAgICBJbnRQb2ludCB2 aWV3Q2VudGVyID0gdmlld3BvcnQubG9jYXRpb24oKSArIEludFNpemUodmlld3BvcnQud2lkdGgo KSAvIDIsIHZpZXdwb3J0LmhlaWdodCgpIC8gMik7CiAgICAgVGlsZTo6Q29vcmRpbmF0ZSBjZW50 ZXJDb29yZGluYXRlID0gdGlsZUNvb3JkaW5hdGVGb3JQb2ludCh2aWV3Q2VudGVyKTsKLSAgICAK KwogICAgIC8vIE1hbmhhdHRhbiBkaXN0YW5jZSwgYmlhc2VkIHNvIHRoYXQgdmVydGljYWwgZGlz dGFuY2VzIGFyZSBzaG9ydGVyLgogICAgIGNvbnN0IGRvdWJsZSBob3Jpem9udGFsQmlhcyA9IDEu MzsKICAgICByZXR1cm4gYWJzKGNlbnRlckNvb3JkaW5hdGUueSgpIC0gdGlsZUNvb3JkaW5hdGUu eSgpKSArIGhvcml6b250YWxCaWFzICogYWJzKGNlbnRlckNvb3JkaW5hdGUueCgpIC0gdGlsZUNv b3JkaW5hdGUueCgpKTsKKyAgICByZXR1cm4gc3RkOjptYXgoYWJzKGNlbnRlckNvb3JkaW5hdGUu eSgpIC0gdGlsZUNvb3JkaW5hdGUueSgpKSwgYWJzKGNlbnRlckNvb3JkaW5hdGUueCgpIC0gdGls ZUNvb3JkaW5hdGUueCgpKSk7CiB9CiAKIC8vIFJldHVybnMgYSByYXRpbyBiZXR3ZWVuIDAuMGYg YW5kIDEuMGYgb2YgdGhlIHN1cmZhY2Ugb2YgY29udGVudHNSZWN0IGNvdmVyZWQgYnkgcmVuZGVy ZWQgdGlsZXMuCg== 129014 2012-02-27 04:36:39 -0800 2012-02-27 05:56:20 -0800 Patch bug-79648-20120227133012.patch text/plain 2133 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQyNjc4M2ZkZjczNjBm MzM3MTA3Mjc2YzQzMGU3MTVhMGI3MDUyYi4uZGNhMzIyZDI0MTc2YjQ4NDhhZmMyZTlmZjUxOWUw YzJlMDUzM2Q2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTI3ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBJ bXByb3ZlIHRoZSB2aXN1YWwgb2YgdGhlIHRpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk2NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjdXJyZW50bHkgdGlsZSB0aGUgYXJlYSBvdXRzaWRl IHRoZSB2aXNpYmxlIHJlY3QsIGluIGNpcmNsZXMgKG9yCisgICAgICAgIHJhdGhlciBzdGFycykg ZnJvbSB0aGUgaW5zaWRlLW91dC4KKworICAgICAgICBBcyB0aGlzIGNhbiBsb29rIHF1aXRlIGJh ZCB3aGlsZSBzY3JvbGxpbmcsIHdlIG5vdyBpbnN0ZWFkIHRpbGUgaW4KKyAgICAgICAgcmVjdHMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpUaWxlZEJhY2tpbmdTdG9yZTo6dGlsZURpc3RhbmNlKToKKwogMjAx Mi0wMi0yNyAgVG9yIEFybmUgVmVzdGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CiAK ICAgICAgICAgW1F0XSBVc2UgVVNFKCkgbWFjcm8gaW5zdGVhZCBvZiBFTkFCTEUoKSBmb3IgdXNp bmcgdGhlIFF0IGltYWdlIGRlY29kZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcAppbmRleCBhY2Y0Yzg5NTczNGVjMGQz ZGQ2ZTNkOTI3ODZiZDUzMGQ3YmI0ZGQ0Li5mYWFjMGJiZjgxMjM5M2VjNGIyZTVlYzg3ZGMyZmUz MjIwZjc0MjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9U aWxlZEJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCkBAIC0xOTMsMTMgKzE5MywxMSBAQCBkb3VibGUgVGls ZWRCYWNraW5nU3RvcmU6OnRpbGVEaXN0YW5jZShjb25zdCBJbnRSZWN0JiB2aWV3cG9ydCwgY29u c3QgVGlsZTo6Q29vcgogewogICAgIGlmICh2aWV3cG9ydC5pbnRlcnNlY3RzKHRpbGVSZWN0Rm9y Q29vcmRpbmF0ZSh0aWxlQ29vcmRpbmF0ZSkpKQogICAgICAgICByZXR1cm4gMDsKLSAgICAKKwog ICAgIEludFBvaW50IHZpZXdDZW50ZXIgPSB2aWV3cG9ydC5sb2NhdGlvbigpICsgSW50U2l6ZSh2 aWV3cG9ydC53aWR0aCgpIC8gMiwgdmlld3BvcnQuaGVpZ2h0KCkgLyAyKTsKICAgICBUaWxlOjpD b29yZGluYXRlIGNlbnRlckNvb3JkaW5hdGUgPSB0aWxlQ29vcmRpbmF0ZUZvclBvaW50KHZpZXdD ZW50ZXIpOwotICAgIAotICAgIC8vIE1hbmhhdHRhbiBkaXN0YW5jZSwgYmlhc2VkIHNvIHRoYXQg dmVydGljYWwgZGlzdGFuY2VzIGFyZSBzaG9ydGVyLgotICAgIGNvbnN0IGRvdWJsZSBob3Jpem9u dGFsQmlhcyA9IDEuMzsKLSAgICByZXR1cm4gYWJzKGNlbnRlckNvb3JkaW5hdGUueSgpIC0gdGls ZUNvb3JkaW5hdGUueSgpKSArIGhvcml6b250YWxCaWFzICogYWJzKGNlbnRlckNvb3JkaW5hdGUu eCgpIC0gdGlsZUNvb3JkaW5hdGUueCgpKTsKKworICAgIHJldHVybiBzdGQ6Om1heChhYnMoY2Vu dGVyQ29vcmRpbmF0ZS55KCkgLSB0aWxlQ29vcmRpbmF0ZS55KCkpLCBhYnMoY2VudGVyQ29vcmRp bmF0ZS54KCkgLSB0aWxlQ29vcmRpbmF0ZS54KCkpKTsKIH0KIAogLy8gUmV0dXJucyBhIHJhdGlv IGJldHdlZW4gMC4wZiBhbmQgMS4wZiBvZiB0aGUgc3VyZmFjZSBvZiBjb250ZW50c1JlY3QgY292 ZXJlZCBieSByZW5kZXJlZCB0aWxlcy4K 129022 2012-02-27 05:56:26 -0800 2012-02-28 08:52:52 -0800 Patch bug-79648-20120227144959.patch text/plain 2845 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQyNjc4M2ZkZjczNjBm MzM3MTA3Mjc2YzQzMGU3MTVhMGI3MDUyYi4uNmZhMTg3NWU2NDIwNWRiYjMzZTQ3YmE1MjQ3Yjky ZGU2YjU3YWFiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTAyLTI3ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBJ bXByb3ZlIHRoZSB2aXN1YWwgb2YgdGhlIHRpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk2NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIGNvdmVyIHRoZSB2aWV3IHdpdGggdGlsZXNb MV0sIHdlIGRvIHNvIGZyb20gdGhlIGNlbnRlcgorICAgICAgICBhbmQgb3V0LCBpbiBiaWdnZXIg YW5kIGJpZ2dlciBjaWNsZXMgYnkgZmluZGluZyB0aGUgY3VycmVudCBtaW5pbXVtCisgICAgICAg IGNvdmVyZWQgZGlzdGFuY2UuCisKKyAgICAgICAgVGhpcyBsb29rcyBsaWtlIHBhaW50aW5nIGEg cmVjdCwgdGhlbiBhIGNyb3NzLCB0aGVuIGEgcmVjdCwgLi4uCisgICAgICAgIGFuZCBjYW4gYmUg bm90aWNlZCB3aGVuIGEgcGFnZSBibG9ja3MgZHVyaW5nIHRpbGluZy4KKworICAgICAgICBXZSBj YW4gZG8gdGhpcyBiZXR0ZXIgYnkgb25seSBjb3ZlcmluZyB3aXRoIHRpbGVzIGluIHJlY3RzIGF0 IGEgdGltZS4KKworICAgICAgICBUaGUgb3JpZ2luYWwgY29kZSB3YXMgZG9uZSBzbyB0aGF0IGl0 IGdhdmUgcHJlZmVyZW5jZSB0byB0aWxlcyBpbgorICAgICAgICB2ZXJ0aWNhbCBkaXJlY3Rpb24g ZHVlIHRvIHRoYXQgYmVpbmcgdGhlIG1vc3QgY29tbW9uIHNjcm9sbGluZworICAgICAgICBkaXJl Y3Rpb24uIFRoaXMgaXMgbm90IG5lZWRlZCBhbnltb3JlIGFzIHdlIGFyZSBub3cgdXNpbmcgdGhl CisgICAgICAgIHRyYWplY3RvcnkgdmVjdG9yIHdoZW4gcGFubmluZywgd2hpY2ggYWx3YXlzIGdp dmVzIHByZWZlcmVuY2UgZm9yCisgICAgICAgIGNyZWF0aW5nIHRpbGVzIGluIHRoZSBwYW5uZWQg ZGlyZWN0aW9uLgorCisgICAgICAgIFsxXSBJdCBzaG91bGQgYmUgbm90ZWQgdGhhdCB3ZSBhbHdh eXMgY292ZXIgdGhlIHZpc2libGVSZWN0IGluIG9uZSBnbywKKyAgICAgICAgICAgIGFuZCB0aGF0 IHdlIGhlcmUgYXJlIHRhbGtpbmcgYWJvdXQgY292ZXJpbmcgdGhlIGNvdmVyUmVjdCBiZXlvbmQK KyAgICAgICAgICAgIHRoZSB2aXNpYmxlUmVjdAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRCYWNraW5n U3RvcmU6OnRpbGVEaXN0YW5jZSk6CisKIDIwMTItMDItMjcgIFRvciBBcm5lIFZlc3Riw7ggIDx0 b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gVXNlIFVTRSgpIG1hY3Jv IGluc3RlYWQgb2YgRU5BQkxFKCkgZm9yIHVzaW5nIHRoZSBRdCBpbWFnZSBkZWNvZGVyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9y ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9y ZS5jcHAKaW5kZXggYWNmNGM4OTU3MzRlYzBkM2RkNmUzZDkyNzg2YmQ1MzBkN2JiNGRkNC4uZmFh YzBiYmY4MTIzOTNlYzRiMmU1ZWM4N2RjMmZlMzIyMGY3NDI4MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcApAQCAt MTkzLDEzICsxOTMsMTEgQEAgZG91YmxlIFRpbGVkQmFja2luZ1N0b3JlOjp0aWxlRGlzdGFuY2Uo Y29uc3QgSW50UmVjdCYgdmlld3BvcnQsIGNvbnN0IFRpbGU6OkNvb3IKIHsKICAgICBpZiAodmll d3BvcnQuaW50ZXJzZWN0cyh0aWxlUmVjdEZvckNvb3JkaW5hdGUodGlsZUNvb3JkaW5hdGUpKSkK ICAgICAgICAgcmV0dXJuIDA7Ci0gICAgCisKICAgICBJbnRQb2ludCB2aWV3Q2VudGVyID0gdmll d3BvcnQubG9jYXRpb24oKSArIEludFNpemUodmlld3BvcnQud2lkdGgoKSAvIDIsIHZpZXdwb3J0 LmhlaWdodCgpIC8gMik7CiAgICAgVGlsZTo6Q29vcmRpbmF0ZSBjZW50ZXJDb29yZGluYXRlID0g dGlsZUNvb3JkaW5hdGVGb3JQb2ludCh2aWV3Q2VudGVyKTsKLSAgICAKLSAgICAvLyBNYW5oYXR0 YW4gZGlzdGFuY2UsIGJpYXNlZCBzbyB0aGF0IHZlcnRpY2FsIGRpc3RhbmNlcyBhcmUgc2hvcnRl ci4KLSAgICBjb25zdCBkb3VibGUgaG9yaXpvbnRhbEJpYXMgPSAxLjM7Ci0gICAgcmV0dXJuIGFi cyhjZW50ZXJDb29yZGluYXRlLnkoKSAtIHRpbGVDb29yZGluYXRlLnkoKSkgKyBob3Jpem9udGFs QmlhcyAqIGFicyhjZW50ZXJDb29yZGluYXRlLngoKSAtIHRpbGVDb29yZGluYXRlLngoKSk7CisK KyAgICByZXR1cm4gc3RkOjptYXgoYWJzKGNlbnRlckNvb3JkaW5hdGUueSgpIC0gdGlsZUNvb3Jk aW5hdGUueSgpKSwgYWJzKGNlbnRlckNvb3JkaW5hdGUueCgpIC0gdGlsZUNvb3JkaW5hdGUueCgp KSk7CiB9CiAKIC8vIFJldHVybnMgYSByYXRpbyBiZXR3ZWVuIDAuMGYgYW5kIDEuMGYgb2YgdGhl IHN1cmZhY2Ugb2YgY29udGVudHNSZWN0IGNvdmVyZWQgYnkgcmVuZGVyZWQgdGlsZXMuCg==