79645 2012-02-27 01:30:21 -0800 [CSSRegions]Implement NamedFlow::name attribute 2012-05-28 02:13:44 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57312 87640 1 mihnea mihnea abarth abucur ojan webkit.review.bot oldest_to_newest 565460 0 mihnea 2012-02-27 01:30:21 -0800 http://dev.w3.org/csswg/css3-regions/#the-namedflow-interface 630437 1 143313 abucur 2012-05-22 09:19:57 -0700 Created attachment 143313 The implementation and the test 631478 2 143313 kling 2012-05-23 03:59:31 -0700 Comment on attachment 143313 The implementation and the test View in context: https://bugs.webkit.org/attachment.cgi?id=143313&action=review Patch itself looks fine, but let's make the test a little more consistent with the rest of our layout tests. Note that there's a helper script to create new tests in Tools/Scripts/make-new-script-test :) > LayoutTests/ChangeLog:2 > +2012-05-22 Andrei Bucur <abucur@adobe.com> > + [CSSRegions]Implement NamedFlow::name attribute Missing newline between these rows. > LayoutTests/fast/regions/webkit-named-flow-name-expected.txt:7 > +PASS > +PASS > +PASS We should try to write tests that tell you a bit more about what's going right/wrong. For example, this kind of construct in your test below: assert(namedFlow.name == "flow-name", "The name should be 'flow-name' when there are no regions to flow into"); Could be replaced by our existing JS test helpers: shouldBe("namedFlow.name", "'flow-name'"); As for the explanation of what's supposed to happen, that can just be a comment in the JS, or you can log them using the debug("foo bar baz"); helper. 631605 3 143558 abucur 2012-05-23 06:41:29 -0700 Created attachment 143558 Patch and test, second try Patch with updated test case using Andreas suggestions. It looks better, I have to agree :). 631608 4 143558 kling 2012-05-23 06:43:59 -0700 Comment on attachment 143558 Patch and test, second try Looks great. r=me 631648 5 143558 webkit.review.bot 2012-05-23 07:25:43 -0700 Comment on attachment 143558 Patch and test, second try Clearing flags on attachment: 143558 Committed r118178: <http://trac.webkit.org/changeset/118178> 631649 6 webkit.review.bot 2012-05-23 07:25:57 -0700 All reviewed patches have been landed. Closing bug. 143313 2012-05-22 09:19:57 -0700 2012-05-23 06:41:29 -0700 The implementation and the test namedflow_name.patch text/plain 5735 abucur ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmZjQ1ZjBhLi5iYjBhMTM3NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1 LTIyICBBbmRyZWkgQnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgorICAgICAgICBbQ1NTUmVnaW9u c11JbXBsZW1lbnQgTmFtZWRGbG93OjpuYW1lIGF0dHJpYnV0ZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk2NDUKKworICAgICAgICBUZXN0IGZvciB0 aGUgTmFtZWRGbG93OjpuYW1lIGF0dHJpYnV0ZSBwZXIgdGhlIENTUyBSZWdpb25zIFdEIDMtTWF5 LTIwMTIgcmVjb21tZW5kYXRpb246CisgICAgICAgIGh0dHA6Ly93d3cudzMub3JnL1RSLzIwMTIv V0QtY3NzMy1yZWdpb25zLTIwMTIwNTAzLworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZmFzdC9yZWdpb25zL3dlYmtpdC1uYW1lZC1mbG93LW5hbWUt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3JlZ2lvbnMvd2Via2l0LW5hbWVk LWZsb3ctbmFtZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wNS0yMiAgWmFuIERvYmVyc2VrICA8emFu ZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGdhcmRlbmluZy4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy93ZWJraXQtbmFtZWQtZmxvdy1u YW1lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy93ZWJraXQtbmFtZWQt Zmxvdy1uYW1lLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li41OTkxYTMzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3dl YmtpdC1uYW1lZC1mbG93LW5hbWUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsOSBAQAorVGVzdCBm b3IgW0NTU1JlZ2lvbnNdSW1wbGVtZW50IE5hbWVkRmxvdzo6bmFtZQorCitPbiBzdWNjZXNzLCB5 b3Ugc2hvdWxkIHNlZSBhIHNlcmllcyBvZiBQQVNTIGJlbG93LgorCitQQVNTCitQQVNTCitQQVNT CisKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3dlYmtpdC1uYW1lZC1m bG93LW5hbWUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy93ZWJraXQtbmFtZWQtZmxv dy1uYW1lLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uOGJjM2FkYgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy93ZWJraXQtbmFtZWQt Zmxvdy1uYW1lLmh0bWwKQEAgLTAsMCArMSw0NCBAQAorPCFkb2N0eXBlIGh0bWw+Cis8aHRtbD4K KyAgICA8aGVhZD4KKyAgICAgICAgPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSJyZXNvdXJj ZXMvcmVnaW9uLXN0eWxlLmNzcyI+CisgICAgICAgIDxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvaGVs cGVyLmpzIj48L3NjcmlwdD4KKyAgICAgICAgPHN0eWxlPgorICAgICAgICAgICAgYm9keSB7IGZv bnQtZmFtaWx5OiBtb25vc3BhY2U7IH0KKyAgICAgICAgICAgIC5mbG93IHsgLXdlYmtpdC1mbG93 LWludG86IGZsb3ctbmFtZTsgfQorICAgICAgICAgICAgLnJlZ2lvbiB7IC13ZWJraXQtZmxvdy1m cm9tOiBmbG93LW5hbWU7IH0KKyAgICAgICAgICAgICNyZWdpb24geyB3aWR0aDogMjUwcHg7IGhl aWdodDogNTBweDsgfQorICAgICAgICA8L3N0eWxlPgorICAgIDwvaGVhZD4KKyAgICA8Ym9keT4K KyAgICAgICAgPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc5NjQ1Ij4KKyAgICAgICAgW0NTU1JlZ2lvbnNdSW1wbGVtZW50IE5hbWVk Rmxvdzo6bmFtZTwvYT48L3A+CisgICAgICAgIDxwPk9uIHN1Y2Nlc3MsIHlvdSBzaG91bGQgc2Vl IGEgc2VyaWVzIG9mIFBBU1MgYmVsb3cuPC9wPgorICAgICAgICA8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KKyAgICAgICAgPGRpdiBpZD0iYXJ0aWNsZSIgY2xhc3M9ImZsb3ciPgorICAgICAgICAg ICAgPHA+Q29udGVudCBpbnNpZGUgYXJ0aWNsZTwvcD4KKyAgICAgICAgPC9kaXY+CisgICAgICAg IDxzY3JpcHQ+CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQor ICAgICAgICAgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 CisKKyAgICAgICAgICAgIC8vIEZsb3cgYXJ0aWNsZSBkb2VzIG5vdCBoYXZlIGFueSByZWdpb25z IHlldAorICAgICAgICAgICAgdmFyIG5hbWVkRmxvdyA9IGRvY3VtZW50LndlYmtpdEdldEZsb3dC eU5hbWUoImZsb3ctbmFtZSIpOworICAgICAgICAgICAgYXNzZXJ0KG5hbWVkRmxvdy5uYW1lID09 ICJmbG93LW5hbWUiLCAiVGhlIG5hbWUgc2hvdWxkIGJlICdmbG93LW5hbWUnIHdoZW4gdGhlcmUg YXJlIG5vIHJlZ2lvbnMgdG8gZmxvdyBpbnRvIik7CisKKyAgICAgICAgICAgIC8vIEFkZCBhIHJl Z2lvbiB0byB0YWtlIHRoZSBjb250ZW50LCB0aGUgbmFtZSBzaG91bGQgYmUgdGhlIHNhbWUKKyAg ICAgICAgICAgIHZhciByZWdpb24gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKKyAg ICAgICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQocmVnaW9uKTsKKyAgICAgICAgICAg IHJlZ2lvbi5pZCA9ICJyZWdpb24iOworICAgICAgICAgICAgcmVnaW9uLmNsYXNzTmFtZSA9ICJy ZWdpb24iOworICAgICAgICAgICAgYXNzZXJ0KG5hbWVkRmxvdy5uYW1lID09ICJmbG93LW5hbWUi LCAiVGhlIG5hbWUgc2hvdWxkIGJlICdmbG93LW5hbWUnIHdoZW4gdGhlcmUgYXJlIHJlZ2lvbnMg dG8gZmxvdyBpbnRvIik7CisKKyAgICAgICAgICAgIC8vIFJlbW92ZSB0aGUgZmxvdyBhbmQgdGhl IHJlZ2lvbiBlbGVtZW50LCBtb3ZlIHRoZSBOYW1lZEZsb3cgb2JqZWN0IGluIHRoZSBOVUxMIHN0 YXRlCisgICAgICAgICAgICByZWdpb24uY2xhc3NOYW1lID0gIiI7CisgICAgICAgICAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiYXJ0aWNsZSIpLmNsYXNOYW1lID0gIiI7CisgICAgICAgICAg ICBhc3NlcnQobmFtZWRGbG93Lm5hbWUgPT0gImZsb3ctbmFtZSIsICJUaGUgbmFtZSBzaG91bGQg YmUgJ2Zsb3ctbmFtZScgd2hlbiB0aGUgbmFtZWQgZmxvdyBpcyBpbiB0aGUgTlVMTCBzdGF0ZSIp OworCisgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYXJ0aWNsZSIpLnN0eWxl LnZpc2liaWxpdHkgPSAiaGlkZGVuIjsKKyAgICAgICAgPC9zY3JpcHQ+CisgICAgPC9ib2R5Pgor PC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IDdkY2NhYzUuLjBiZGJlYjMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxMi0wNS0yMiAgQW5kcmVpIEJ1Y3VyICA8YWJ1Y3VyQGFkb2JlLmNvbT4K KworICAgICAgICBbQ1NTUmVnaW9uc11JbXBsZW1lbnQgTmFtZWRGbG93OjpuYW1lIGF0dHJpYnV0 ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk2NDUK KworICAgICAgICBJbXBsZW1lbnRhdGlvbiBmb3IgdGhlIE5hbWVkRmxvdzo6bmFtZSBhdHRyaWJ1 dGUgcGVyIHRoZSBDU1MgUmVnaW9ucyBXRCAzLU1heS0yMDEyIHJlY29tbWVuZGF0aW9uOgorICAg ICAgICBodHRwOi8vd3d3LnczLm9yZy9UUi8yMDEyL1dELWNzczMtcmVnaW9ucy0yMDEyMDUwMy8K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBm YXN0L3JlZ2lvbnMvd2Via2l0LW5hbWVkLWZsb3ctbmFtZS5odG1sCisKKyAgICAgICAgKiBkb20v V2ViS2l0TmFtZWRGbG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYktpdE5hbWVkRmxvdzo6 bmFtZSk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBkb20vV2ViS2l0TmFtZWRGbG93 Lmg6CisgICAgICAgIChXZWJLaXROYW1lZEZsb3cpOgorICAgICAgICAqIGRvbS9XZWJLaXROYW1l ZEZsb3cuaWRsOgorCiAyMDEyLTA1LTIyICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBDaGFuZ2UgUmVuZGVyQmxvY2sgdG8gdXNlciBSZW5kZXJCb3gvUmVuZGVy SW5saW5lIHdyaXRpbmcgbW9kZSBsb2dpYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L1dlYktpdE5hbWVkRmxvdy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0TmFtZWRGbG93 LmNwcAppbmRleCA0Y2ZiYjRjLi45YTI3MTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vV2ViS2l0TmFtZWRGbG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0TmFt ZWRGbG93LmNwcApAQCAtNDUsNiArNDUsMTEgQEAgV2ViS2l0TmFtZWRGbG93Ojp+V2ViS2l0TmFt ZWRGbG93KCkKIHsKIH0KIAorU3RyaW5nIFdlYktpdE5hbWVkRmxvdzo6bmFtZSgpIGNvbnN0Cit7 CisgICAgcmV0dXJuIG1fcGFyZW50Rmxvd1RocmVhZC0+Zmxvd1RocmVhZE5hbWUoKTsKK30KKwog Ym9vbCBXZWJLaXROYW1lZEZsb3c6Om92ZXJmbG93KCkgY29uc3QKIHsKICAgICBtX3BhcmVudEZs b3dUaHJlYWQtPmRvY3VtZW50KCktPnVwZGF0ZUxheW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0 cygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1dlYktpdE5hbWVkRmxvdy5oIGIv U291cmNlL1dlYkNvcmUvZG9tL1dlYktpdE5hbWVkRmxvdy5oCmluZGV4IDBjNWQ1ZWEuLjVkMWU2 YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9XZWJLaXROYW1lZEZsb3cuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0TmFtZWRGbG93LmgKQEAgLTQ5LDYgKzQ5LDcgQEAg cHVibGljOgogCiAgICAgfldlYktpdE5hbWVkRmxvdygpOwogCisgICAgU3RyaW5nIG5hbWUoKSBj b25zdDsKICAgICBib29sIG92ZXJmbG93KCkgY29uc3Q7CiAgICAgUGFzc1JlZlB0cjxOb2RlTGlz dD4gZ2V0UmVnaW9uc0J5Q29udGVudE5vZGUoTm9kZSopOwogICAgIFBhc3NSZWZQdHI8Tm9kZUxp c3Q+IGNvbnRlbnROb2RlcygpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L1dlYktpdE5hbWVkRmxvdy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0TmFtZWRGbG93 LmlkbAppbmRleCAwZDMyNGE0Li42YjMwNjZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vV2ViS2l0TmFtZWRGbG93LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0TmFt ZWRGbG93LmlkbApAQCAtMzEsNiArMzEsNyBAQCBtb2R1bGUgY29yZSB7CiAgICAgaW50ZXJmYWNl IFsKICAgICAgICAgSlNHZW5lcmF0ZVRvSlNPYmplY3QKICAgICBdIFdlYktpdE5hbWVkRmxvdyB7 CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgbmFtZTsKICAgICAgICAgcmVh ZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gb3ZlcmZsb3c7CiAgICAgICAgIE5vZGVMaXN0IGdldFJl Z2lvbnNCeUNvbnRlbnROb2RlKGluIE5vZGUgY29udGVudE5vZGUpOwogICAgICAgICByZWFkb25s eSBhdHRyaWJ1dGUgTm9kZUxpc3QgY29udGVudE5vZGVzOwo= 143558 2012-05-23 06:41:29 -0700 2012-05-23 07:25:43 -0700 Patch and test, second try namedflow_name.patch text/plain 5751 abucur ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmZjQ1ZjBhLi5hMTE1MTYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUt MjIgIEFuZHJlaSBCdWN1ciAgPGFidWN1ckBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTU1JlZ2lv bnNdSW1wbGVtZW50IE5hbWVkRmxvdzo6bmFtZSBhdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NjQ1CisKKyAgICAgICAgVGVzdCBmb3Ig dGhlIE5hbWVkRmxvdzo6bmFtZSBhdHRyaWJ1dGUgcGVyIHRoZSBDU1MgUmVnaW9ucyBXRCAzLU1h eS0yMDEyIHJlY29tbWVuZGF0aW9uOgorICAgICAgICBodHRwOi8vd3d3LnczLm9yZy9UUi8yMDEy L1dELWNzczMtcmVnaW9ucy0yMDEyMDUwMy8KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvcmVnaW9ucy93ZWJraXQtbmFtZWQtZmxvdy1uYW1l LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9yZWdpb25zL3dlYmtpdC1uYW1l ZC1mbG93LW5hbWUuaHRtbDogQWRkZWQuCisKIDIwMTItMDUtMjIgIFphbiBEb2JlcnNlayAgPHph bmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIEdUSyBnYXJkZW5pbmcu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvd2Via2l0LW5hbWVkLWZsb3ct bmFtZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvd2Via2l0LW5hbWVk LWZsb3ctbmFtZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uNDhlZjY1NgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy93 ZWJraXQtbmFtZWQtZmxvdy1uYW1lLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEyIEBACitUaGlz IHRlc3RzIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgJ25hbWUnIGF0dHJpYnV0ZSBvbiB0aGUg TmFtZWRGbG93IG9iamVjdCBhdHRhY2hlZCB0byBhIGZsb3cgdGhyZWFkLiBGb3IgbW9yZSBkZXRh aWxzIHNlZSBodHRwOi8vd3d3LnczLm9yZy9UUi8yMDEyL1dELWNzczMtcmVnaW9ucy0yMDEyMDUw My8jZG9tLW5hbWVkLWZsb3cKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1Mg bmFtZWRGbG93Lm5hbWUgaXMgJ2Zsb3ctbmFtZScKK1BBU1MgbmFtZWRGbG93Lm5hbWUgaXMgJ2Zs b3ctbmFtZScKK1BBU1MgbmFtZWRGbG93Lm5hbWUgaXMgJ2Zsb3ctbmFtZScKK1BBU1Mgc3VjY2Vz c2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L3JlZ2lvbnMvd2Via2l0LW5hbWVkLWZsb3ctbmFtZS5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9yZWdpb25zL3dlYmtpdC1uYW1lZC1mbG93LW5hbWUuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42NzE5ZDdjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9yZWdpb25zL3dlYmtpdC1uYW1lZC1mbG93LW5hbWUuaHRtbApAQCAtMCww ICsxLDUwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bWV0YSBjaGFyc2V0 PSJ1dGYtOCI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzxzdHlsZT4KKyAgICAuZmxvdyB7IC13ZWJraXQtZmxvdy1pbnRvOiBmbG93LW5h bWU7IH0KKyAgICAucmVnaW9uIHsgLXdlYmtpdC1mbG93LWZyb206IGZsb3ctbmFtZTsgfQorICAg ICNyZWdpb24geyB3aWR0aDogMjUwcHg7IGhlaWdodDogNTBweDsgfQorPC9zdHlsZT4KKzwvaGVh ZD4KKzxib2R5PgorICAgIDxwIGlkPSJhcnRpY2xlIiBjbGFzcz0iZmxvdyI+VGhlIGNvbnRlbnQg ZmxvdzwvcD4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoZSBpbXBsZW1l bnRhdGlvbiBvZiB0aGUgJ25hbWUnIGF0dHJpYnV0ZSBvbiB0aGUgTmFtZWRGbG93IG9iamVjdCBh dHRhY2hlZCB0byBhIGZsb3cgdGhyZWFkLiBcCisgICAgICAgICAgICBGb3IgbW9yZSBkZXRhaWxz IHNlZSBodHRwOi8vd3d3LnczLm9yZy9UUi8yMDEyL1dELWNzczMtcmVnaW9ucy0yMDEyMDUwMy8j ZG9tLW5hbWVkLWZsb3ciKTsKKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKy8vIEZsb3cgYXJ0aWNsZSBk b2VzIG5vdCBoYXZlIGFueSByZWdpb25zIHlldAordmFyIG5hbWVkRmxvdyA9IGRvY3VtZW50Lndl YmtpdEdldEZsb3dCeU5hbWUoImZsb3ctbmFtZSIpOworCisvLyBUaGUgbmFtZSBzaG91bGQgYmUg J2Zsb3ctbmFtZScgd2hlbiB0aGVyZSBhcmUgbm8gcmVnaW9ucyB0byBmbG93IGludG8KK3Nob3Vs ZEJlKCJuYW1lZEZsb3cubmFtZSIsICInZmxvdy1uYW1lJyIpOworCisvLyBBZGQgYSByZWdpb24g dG8gdGFrZSB0aGUgY29udGVudCwgdGhlIG5hbWUgc2hvdWxkIGJlIHRoZSBzYW1lCit2YXIgcmVn aW9uID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7Citkb2N1bWVudC5ib2R5LmFwcGVu ZENoaWxkKHJlZ2lvbik7CityZWdpb24uaWQgPSAicmVnaW9uIjsKK3JlZ2lvbi5jbGFzc05hbWUg PSAicmVnaW9uIjsKKworLy8gVGhlIG5hbWUgc2hvdWxkIGJlICdmbG93LW5hbWUnIHdoZW4gdGhl cmUgYXJlIHJlZ2lvbnMgdG8gZmxvdyBpbnRvCitzaG91bGRCZSgibmFtZWRGbG93Lm5hbWUiLCAi J2Zsb3ctbmFtZSciKTsKKwordmFyIGFydGljbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi YXJ0aWNsZSIpOworCisvLyBSZW1vdmUgdGhlIGZsb3cgYW5kIHRoZSByZWdpb24gZWxlbWVudCwg bW92ZSB0aGUgTmFtZWRGbG93IG9iamVjdCBpbiB0aGUgTlVMTCBzdGF0ZQorcmVnaW9uLmNsYXNz TmFtZSA9ICIiOworYXJ0aWNsZS5jbGFzc05hbWUgPSAiIjsKK3JlZ2lvbi5zdHlsZS5kaXNwbGF5 ID0gIm5vbmUiOworYXJ0aWNsZS5zdHlsZS5kaXNwbGF5ID0gIm5vbmUiOworCisvLyBUaGUgbmFt ZSBzaG91bGQgYmUgJ2Zsb3ctbmFtZScgd2hlbiB0aGUgbmFtZWQgZmxvdyBpcyBpbiB0aGUgTlVM TCBzdGF0ZQorc2hvdWxkQmUoIm5hbWVkRmxvdy5uYW1lIiwgIidmbG93LW5hbWUnIik7Cis8L3Nj cmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3ZGNjYWM1Li4wYmRiZWIzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTItMDUtMjIgIEFuZHJlaSBCdWN1ciAgPGFi dWN1ckBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTU1JlZ2lvbnNdSW1wbGVtZW50IE5hbWVkRmxv dzo6bmFtZSBhdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc5NjQ1CisKKyAgICAgICAgSW1wbGVtZW50YXRpb24gZm9yIHRoZSBOYW1lZEZs b3c6Om5hbWUgYXR0cmlidXRlIHBlciB0aGUgQ1NTIFJlZ2lvbnMgV0QgMy1NYXktMjAxMiByZWNv bW1lbmRhdGlvbjoKKyAgICAgICAgaHR0cDovL3d3dy53My5vcmcvVFIvMjAxMi9XRC1jc3MzLXJl Z2lvbnMtMjAxMjA1MDMvCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGVzdDogZmFzdC9yZWdpb25zL3dlYmtpdC1uYW1lZC1mbG93LW5hbWUuaHRtbAor CisgICAgICAgICogZG9tL1dlYktpdE5hbWVkRmxvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpX ZWJLaXROYW1lZEZsb3c6Om5hbWUpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogZG9t L1dlYktpdE5hbWVkRmxvdy5oOgorICAgICAgICAoV2ViS2l0TmFtZWRGbG93KToKKyAgICAgICAg KiBkb20vV2ViS2l0TmFtZWRGbG93LmlkbDoKKwogMjAxMi0wNS0yMiAgRW1pbCBBIEVrbHVuZCAg PGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ2hhbmdlIFJlbmRlckJsb2NrIHRvIHVzZXIg UmVuZGVyQm94L1JlbmRlcklubGluZSB3cml0aW5nIG1vZGUgbG9naWMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9XZWJLaXROYW1lZEZsb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9t L1dlYktpdE5hbWVkRmxvdy5jcHAKaW5kZXggNGNmYmI0Yy4uOWEyNzE2NCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL1dlYktpdE5hbWVkRmxvdy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL1dlYktpdE5hbWVkRmxvdy5jcHAKQEAgLTQ1LDYgKzQ1LDExIEBAIFdlYktpdE5hbWVk Rmxvdzo6fldlYktpdE5hbWVkRmxvdygpCiB7CiB9CiAKK1N0cmluZyBXZWJLaXROYW1lZEZsb3c6 Om5hbWUoKSBjb25zdAoreworICAgIHJldHVybiBtX3BhcmVudEZsb3dUaHJlYWQtPmZsb3dUaHJl YWROYW1lKCk7Cit9CisKIGJvb2wgV2ViS2l0TmFtZWRGbG93OjpvdmVyZmxvdygpIGNvbnN0CiB7 CiAgICAgbV9wYXJlbnRGbG93VGhyZWFkLT5kb2N1bWVudCgpLT51cGRhdGVMYXlvdXRJZ25vcmVQ ZW5kaW5nU3R5bGVzaGVldHMoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9XZWJL aXROYW1lZEZsb3cuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9XZWJLaXROYW1lZEZsb3cuaAppbmRl eCAwYzVkNWVhLi41ZDFlNmE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0 TmFtZWRGbG93LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1dlYktpdE5hbWVkRmxvdy5oCkBA IC00OSw2ICs0OSw3IEBAIHB1YmxpYzoKIAogICAgIH5XZWJLaXROYW1lZEZsb3coKTsKIAorICAg IFN0cmluZyBuYW1lKCkgY29uc3Q7CiAgICAgYm9vbCBvdmVyZmxvdygpIGNvbnN0OwogICAgIFBh c3NSZWZQdHI8Tm9kZUxpc3Q+IGdldFJlZ2lvbnNCeUNvbnRlbnROb2RlKE5vZGUqKTsKICAgICBQ YXNzUmVmUHRyPE5vZGVMaXN0PiBjb250ZW50Tm9kZXMoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9XZWJLaXROYW1lZEZsb3cuaWRsIGIvU291cmNlL1dlYkNvcmUvZG9t L1dlYktpdE5hbWVkRmxvdy5pZGwKaW5kZXggMGQzMjRhNC4uNmIzMDY2YyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL1dlYktpdE5hbWVkRmxvdy5pZGwKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL1dlYktpdE5hbWVkRmxvdy5pZGwKQEAgLTMxLDYgKzMxLDcgQEAgbW9kdWxlIGNvcmUg ewogICAgIGludGVyZmFjZSBbCiAgICAgICAgIEpTR2VuZXJhdGVUb0pTT2JqZWN0CiAgICAgXSBX ZWJLaXROYW1lZEZsb3cgeworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIG5h bWU7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIG92ZXJmbG93OwogICAgICAg ICBOb2RlTGlzdCBnZXRSZWdpb25zQnlDb250ZW50Tm9kZShpbiBOb2RlIGNvbnRlbnROb2RlKTsK ICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIE5vZGVMaXN0IGNvbnRlbnROb2RlczsK