79643 2012-02-27 01:23:19 -0800 Remove [ConstructorParameters] from IDL files that have [Constructor] 2012-02-27 15:22:53 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet macpherson menard ojan webkit.review.bot oldest_to_newest 565453 0 haraken 2012-02-27 01:23:19 -0800 We can remove [ConstructorParameters] from IDL files that have [Constructor], since CodeGeneratorJS.pm can automatically detect the number of constructor arguments by the [Constructor(...)] signature. 565464 1 128983 haraken 2012-02-27 01:31:05 -0800 Created attachment 128983 Patch 566026 2 128983 webkit.review.bot 2012-02-27 15:22:48 -0800 Comment on attachment 128983 Patch Clearing flags on attachment: 128983 Committed r109029: <http://trac.webkit.org/changeset/109029> 566027 3 webkit.review.bot 2012-02-27 15:22:53 -0800 All reviewed patches have been landed. Closing bug. 128983 2012-02-27 01:31:05 -0800 2012-02-27 15:22:48 -0800 Patch bug-79643-20120227183103.patch text/plain 4948 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODU1ZWMyMWMyZGM4MGFh NWE1Y2M1MjllMDAyMWUyNTI3YzY0NTk4Yy4uODdmNTE2NDY1NzYxODYxYzUyMDgzNWNjNWIzOGQ5 NTJmMTQwNzJmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAyLTI3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgW0NvbnN0 cnVjdG9yUGFyYW1ldGVyc10gZnJvbSBJREwgZmlsZXMgdGhhdCBoYXZlIFtDb25zdHJ1Y3Rvcl0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NjQzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRj aCByZW1vdmVzIFtDb25zdHJ1Y3RvclBhcmFtZXRlcnNdIGZyb20gSURMIGZpbGVzIHRoYXQgaGF2 ZSBbQ29uc3RydWN0b3JdLAorICAgICAgICBzaW5jZSBDb2RlR2VuZXJhdG9ySlMucG0gY2FuIGF1 dG9tYXRpY2FsbHkgZGV0ZWN0IHRoZSBudW1iZXIgb2YgY29uc3RydWN0b3IKKyAgICAgICAgYXJn dW1lbnRzIGJ5IHRoZSBbQ29uc3RydWN0b3IoLi4uKV0gc2lnbmF0dXJlLgorCisgICAgICAgIFRl c3Q6IGZhc3QvanMvY29uc3RydWN0b3ItbGVuZ3RoLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMv bWVkaWFzdHJlYW0vUGVlckNvbm5lY3Rpb24uaWRsOgorICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVDb25zdHJ1Y3RvckRlZmlu aXRpb24pOgorICAgICAgICAqIGNzcy9XZWJLaXRDU1NNYXRyaXguaWRsOgorICAgICAgICAqIHBh Z2UvRXZlbnRTb3VyY2UuaWRsOgorICAgICAgICAqIHdvcmtlcnMvU2hhcmVkV29ya2VyLmlkbDoK KyAgICAgICAgKiB3b3JrZXJzL1dvcmtlci5pZGw6CisKIDIwMTItMDItMjcgIFl1cnkgU2VtaWto YXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogY291 bnRlciBncmFwaHMgc2hvdWxkIHJlc2l6ZSBhZnRlciBjb25zb2xlIHNob3dpbmcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUGVlckNvbm5lY3Rpb24uaWRs IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbi5pZGwK aW5kZXggNzc2MGQxMGNlZmExYjE1MTEyY2E2NTAzZmZkMzJmZTkwNTgxOTI2Ni4uNzU0M2EwZGJj ZTNjN2I1NWFiNDUwMDk0YmZjNjg3ZTgzMWQ3MDgxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbi5pZGwKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbi5pZGwKQEAgLTI3LDcgKzI3 LDYgQEAgbW9kdWxlIHAycCB7CiAgICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ29uZGl0aW9uYWw9 TUVESUFfU1RSRUFNLAogICAgICAgICBBY3RpdmVET01PYmplY3QsCi0gICAgICAgIENvbnN0cnVj dG9yUGFyYW1ldGVycz0yLAogICAgICAgICBDb25zdHJ1Y3RvcihpbiBET01TdHJpbmcgc2VydmVy Q29uZmlndXJhdGlvbiwgaW4gW0NhbGxiYWNrXSBTaWduYWxpbmdDYWxsYmFjayBzaWduYWxpbmdD YWxsYmFjayksCiAgICAgICAgIENhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAg ICAgIEpTQ3VzdG9tQ29uc3RydWN0b3IsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IDJhYTlmNTk3Nzk3NTBkNTZiYzM4YWNi OGFiZWI3OGUxMDZhMmI0MDMuLmY5YWE1YzhkMThhMTE0ODhjYjg4MzMwYzNkN2U3MzE4M2RkY2Yz NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckpTLnBtCkBAIC0zMzY4LDcgKzMzNjgsNyBAQCBzdWIgR2VuZXJhdGVDb25zdHJ1Y3RvckRl ZmluaXRpb24KICAgICBpZiAoIWRlZmluZWQgJG51bWJlck9mQ29uc3RydWN0b3JQYXJhbWV0ZXJz KSB7CiAgICAgICAgIGlmIChJc0NvbnN0cnVjdG9yVGVtcGxhdGUoJGRhdGFOb2RlLCAiRXZlbnQi KSkgewogICAgICAgICAgICAgJG51bWJlck9mQ29uc3RydWN0b3JQYXJhbWV0ZXJzID0gMjsKLSAg ICAgICAgfSBlbHNpZiAoJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ29uc3RydWN0 b3IifSBhbmQgISRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbUNvbnN0cnVj dG9yIn0gYW5kICEkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJKU0N1c3RvbUNvbnN0 cnVjdG9yIn0pIHsKKyAgICAgICAgfSBlbHNpZiAoJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0 ZXMtPnsiQ29uc3RydWN0b3IifSkgewogICAgICAgICAgICAgJG51bWJlck9mQ29uc3RydWN0b3JQ YXJhbWV0ZXJzID0gQHskZGF0YU5vZGUtPmNvbnN0cnVjdG9yLT5wYXJhbWV0ZXJzfTsKICAgICAg ICAgfQogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NNYXRy aXguaWRsIGIvU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENTU01hdHJpeC5pZGwKaW5kZXggMDhm ZDY2NDFkNWMxMWUyNWUxZTMwNDg1ZmY2MGEzYzkxMmViM2U5NS4uMDhjNDFhYTEyMzdmOWFjNmIw MDM3YzkzMDc3ZTczZDFlMTllMjFjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1dl YktpdENTU01hdHJpeC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENTU01hdHJp eC5pZGwKQEAgLTI3LDcgKzI3LDYgQEAgbW9kdWxlIGNzcyB7CiAKICAgICAvLyBJbnRyb2R1Y2Vk IGluIERPTSBMZXZlbCA/OgogICAgIGludGVyZmFjZSBbCi0gICAgICAgIENvbnN0cnVjdG9yUGFy YW1ldGVycz0xLAogICAgICAgICBDb25zdHJ1Y3RvcihpbiBbT3B0aW9uYWw9RGVmYXVsdElzTnVs bFN0cmluZ10gRE9NU3RyaW5nIGNzc1ZhbHVlKSwKICAgICAgICAgQ29uc3RydWN0b3JSYWlzZXNF eGNlcHRpb24sCiAgICAgXSBXZWJLaXRDU1NNYXRyaXggewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudFNvdXJjZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50U291 cmNlLmlkbAppbmRleCA5YjdmZTM4ZGMxNjgwNjM1MDcxMDc3MGM0OGNiMzNmZmZlN2YyODI3Li40 OGRmM2ViZThiODVjNGI0NWEyOWVhYmQ3MDFjZjhkZjI4NGNlYTdkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNlLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0V2ZW50U291cmNlLmlkbApAQCAtMzMsNyArMzMsNiBAQCBtb2R1bGUgd2luZG93IHsKIAogICAg IGludGVyZmFjZSBbCiAgICAgICAgIEFjdGl2ZURPTU9iamVjdCwKLSAgICAgICAgQ29uc3RydWN0 b3JQYXJhbWV0ZXJzPTEsCiAgICAgICAgIENvbnN0cnVjdG9yKGluIERPTVN0cmluZyBzY3JpcHRV cmwpLAogICAgICAgICBDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LAogICAgICAgICBD b25zdHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbiwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvU2hhcmVkV29ya2VyLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvU2hhcmVkV29y a2VyLmlkbAppbmRleCBkMjE1MjcyMGU0YmRjNGMyNzRlYTk2MWYwYTQwMGUxYWJmZDQyNWU2Li40 MGNjZGQ0MDM0MWUwYmJkZWU1NDE5NDM1N2RmNDhkYzMxMzhiNGE4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS93b3JrZXJzL1NoYXJlZFdvcmtlci5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUv d29ya2Vycy9TaGFyZWRXb3JrZXIuaWRsCkBAIC0zNSw3ICszNSw2IEBAIG1vZHVsZSB0aHJlYWRz IHsKICAgICAgICAgQ29uZGl0aW9uYWw9U0hBUkVEX1dPUktFUlMsCiAgICAgICAgIEFjdGl2ZURP TU9iamVjdCwKICAgICAgICAgSlNDdXN0b21Db25zdHJ1Y3RvciwKLSAgICAgICAgQ29uc3RydWN0 b3JQYXJhbWV0ZXJzPTIsCiAgICAgICAgIENvbnN0cnVjdG9yKGluIERPTVN0cmluZyBzY3JpcHRV UkwsIGluIFtPcHRpb25hbD1EZWZhdWx0SXNOdWxsU3RyaW5nXSBET01TdHJpbmcgbmFtZSksCiAg ICAgICAgIENhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAgICAgIENvbnN0cnVj dG9yUmFpc2VzRXhjZXB0aW9uLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9X b3JrZXIuaWRsIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuaWRsCmluZGV4IDg2N2Qz NjcxMGI2YzE2MjRmMzZkYjJlZmRhY2ZhZThiMTdlNjdmOTguLjA4MzM1M2MwNDYxMjgzNzhiM2E5 MGJhYTRhMjllZmE3MzNhMGQ2NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv V29ya2VyLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlci5pZGwKQEAgLTMx LDcgKzMxLDYgQEAgbW9kdWxlIHRocmVhZHMgewogICAgICAgICBDb25kaXRpb25hbD1XT1JLRVJT LAogICAgICAgICBBY3RpdmVET01PYmplY3QsCiAgICAgICAgIEpTQ3VzdG9tQ29uc3RydWN0b3Is Ci0gICAgICAgIENvbnN0cnVjdG9yUGFyYW1ldGVycz0xLAogICAgICAgICBDb25zdHJ1Y3Rvcihp biBET01TdHJpbmcgc2NyaXB0VXJsKSwKICAgICAgICAgQ2FsbFdpdGg9U2NyaXB0RXhlY3V0aW9u Q29udGV4dCwKICAgICAgICAgQ29uc3RydWN0b3JSYWlzZXNFeGNlcHRpb24sCg==