79625 2012-02-26 22:41:10 -0800 Move PointerLock APIs from Navigator.idl to NavigatorPointerLock.idl 2012-02-26 23:28:40 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 79327 1 haraken haraken abarth ap ojan webkit.review.bot oldest_to_newest 565342 0 haraken 2012-02-26 22:41:10 -0800 For WebKit modularization, we can move PointerLock APIs from Navigator.idl to NavigatorPointerLock.idl. 565344 1 128956 haraken 2012-02-26 22:45:56 -0800 Created attachment 128956 Patch 565354 2 128956 abarth 2012-02-26 22:59:35 -0800 Comment on attachment 128956 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128956&action=review > Source/WebCore/Modules/pointerlock/NavigatorPointerLock.idl:25 > + ] NavigatorPointerLock { There are a bunch of ENABLED(POINTER_LOCK) ifdefs in WebCore proper. It might be better to wait on creating a pointerlock module until we're certain we can remove them all (or at least the vast majority of them). > Source/WebCore/page/PointerLock.h:43 > -class PointerLock : public RefCounted<PointerLock>, public DOMWindowProperty { > +class PointerLock : public RefCounted<PointerLock>, public DOMWindowProperty, public NavigatorSupplement { PointerLock is RefCounted but NavigatorSupplement uses OwnPtr. This patch will create a use-after-free bug. We should make NavigatorPointerLock be the NavigatorSupplement, which can hold a RefPtr to the PointerLock object. 565356 3 abarth 2012-02-26 23:00:18 -0800 Note: This patch conflicts with <http://trac.webkit.org/changeset/108958>. You'll probably want to update past that revision when working on this patch. 565357 4 abarth 2012-02-26 23:01:11 -0800 Check out NavigatorGamepad for an example of how to create an OwnPtr'ed container class for a RefCounted object that hangs off of Navigator. 565377 5 haraken 2012-02-26 23:28:40 -0800 (In reply to comment #2) > (From update of attachment 128956 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=128956&action=review > > > Source/WebCore/Modules/pointerlock/NavigatorPointerLock.idl:25 > > + ] NavigatorPointerLock { > > There are a bunch of ENABLED(POINTER_LOCK) ifdefs in WebCore proper. It might be better to wait on creating a pointerlock module until we're certain we can remove them all (or at least the vast majority of them). Makes sense. As far as I see, it seems difficult to get rid of them. For now let me mark this bug as WONTFIX. 128956 2012-02-26 22:45:56 -0800 2012-02-26 22:59:35 -0800 Patch bug-79625-20120227154554.patch text/plain 12788 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRlMWQ1YzhjNDY5MjFk NDBkNDU4OWU4YjI4NzYzZWVhMThlMzExZC4uM2NlODA2NjRhMTYyMzkxMzU3ZDVjMTE1ZjVkZWU4 ZGJlMGY2YWZlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDQxIEBACiAyMDEyLTAyLTI2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBNb3ZlIFBvaW50ZXJM b2NrIEFQSXMgZnJvbSBOYXZpZ2F0b3IuaWRsIHRvIE5hdmlnYXRvclBvaW50ZXJMb2NrLmlkbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk2MjUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3IgV2ViS2l0 IG1vZHVsYXJpemF0aW9uLCB0aGlzIHBhdGNoIG1vdmVzIFBvaW50ZXJMb2NrIEFQSXMKKyAgICAg ICAgZnJvbSBOYXZpZ2F0b3IuaWRsIHRvIE5hdmlnYXRvclBvaW50ZXJMb2NrLmlkbC4KKworICAg ICAgICBUZXN0czogcG9pbnRlci1sb2NrLyogKE5vIGNoYW5nZSBpbiB0ZXN0IHJlc3VsdHMpCisK KyAgICAgICAgKiBNb2R1bGVzL3BvaW50ZXJsb2NrL05hdmlnYXRvclBvaW50ZXJMb2NrLmNwcDog QWRkZWQuCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6Ok5hdmlnYXRvclBv aW50ZXJMb2NrOjpOYXZpZ2F0b3JQb2ludGVyTG9jayk6CisgICAgICAgIChXZWJDb3JlOjpOYXZp Z2F0b3JQb2ludGVyTG9jazo6fk5hdmlnYXRvclBvaW50ZXJMb2NrKToKKyAgICAgICAgKFdlYkNv cmU6Ok5hdmlnYXRvclBvaW50ZXJMb2NrOjp3ZWJraXRQb2ludGVyKToKKyAgICAgICAgKiBNb2R1 bGVzL3BvaW50ZXJsb2NrL05hdmlnYXRvclBvaW50ZXJMb2NrLmg6IEFkZGVkLgorICAgICAgICAo V2ViQ29yZSk6CisgICAgICAgIChOYXZpZ2F0b3JQb2ludGVyTG9jayk6CisgICAgICAgICogTW9k dWxlcy9wb2ludGVybG9jay9OYXZpZ2F0b3JQb2ludGVyTG9jay5pZGw6IENvcGllZCBmcm9tIFNv dXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmlkbC4KKyAgICAgICAgKiBXZWJDb3JlLmd5cC9X ZWJDb3JlLmd5cDoKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6CisgICAgICAgICogcGFnZS9OYXZp Z2F0b3IuY3BwOgorICAgICAgICAqIHBhZ2UvTmF2aWdhdG9yLmg6CisgICAgICAgIChXZWJDb3Jl KToKKyAgICAgICAgKE5hdmlnYXRvcik6CisgICAgICAgICogcGFnZS9OYXZpZ2F0b3IuaWRsOgor ICAgICAgICAqIHBhZ2UvUG9pbnRlckxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9pbnRl ckxvY2s6OnN1cHBsZW1lbnROYW1lKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIHBh Z2UvUG9pbnRlckxvY2suaDoKKyAgICAgICAgKFdlYkNvcmU6OlBvaW50ZXJMb2NrOjpjcmVhdGUp OgorICAgICAgICAoUG9pbnRlckxvY2spOgorICAgICAgICAoV2ViQ29yZTo6UG9pbnRlckxvY2s6 OmZyb20pOgorCisyMDEyLTAyLTI2ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9y Zz4KKwogICAgICAgICBVbnJldmlld2VkLiBSZWJhc2VsaW5lZCBydW4tYmluZGluZ3MtdGVzdHMg cmVzdWx0cy4KIAogICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktp dERPTVRlc3RJbnRlcmZhY2UuY3BwOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9wb2ludGVybG9jay9OYXZpZ2F0b3JQb2ludGVyTG9jay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3BvaW50ZXJsb2NrL05hdmlnYXRvclBvaW50ZXJMb2NrLmNwcApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4w ZmZjNWZhZDAyZjdkZmU0YjY5ODMyZTYxNWE1NWZkNzdhOGYwMDIyCi0tLSAvZGV2L251bGwKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9wb2ludGVybG9jay9OYXZpZ2F0b3JQb2ludGVyTG9j ay5jcHAKQEAgLTAsMCArMSw1MyBAQAorLyoKKyAgICBDb3B5cmlnaHQgKEMpIDIwMDggTm9raWEg Q29ycG9yYXRpb24gYW5kL29yIGl0cyBzdWJzaWRpYXJ5KC1pZXMpCisKKyAgICBUaGlzIGxpYnJh cnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgICAg bW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJs aWMKKyAgICBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0 aW9uOyBlaXRoZXIKKyAgICB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9w dGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKyAgICBUaGlzIGxpYnJhcnkgaXMgZGlzdHJpYnV0 ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAgICBidXQgV0lUSE9VVCBB TlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICAgIE1F UkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0 aGUgR05VCisgICAgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFp bHMuCisKKyAgICBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGli cmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisgICAgYWxvbmcgd2l0aCB0aGlzIGxpYnJhcnk7 IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwgd3JpdGUgdG8KKyAgICB0aGUgRnJl ZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuLCA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZs b29yLAorICAgIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNBLgorKi8KKworI2luY2x1ZGUgImNv bmZpZy5oIgorI2luY2x1ZGUgIk5hdmlnYXRvclBvaW50ZXJMb2NrLmgiCisKKyNpZiBFTkFCTEUo UE9JTlRFUl9MT0NLKQorCisjaW5jbHVkZSAiRnJhbWUuaCIKKyNpbmNsdWRlICJOYXZpZ2F0b3Iu aCIKKyNpbmNsdWRlICJOYXZpZ2F0b3JTdXBwbGVtZW50LmgiCisjaW5jbHVkZSAiUGFnZS5oIgor I2luY2x1ZGUgIlBvaW50ZXJMb2NrLmgiCisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworTmF2aWdh dG9yUG9pbnRlckxvY2s6Ok5hdmlnYXRvclBvaW50ZXJMb2NrKCkKK3sKK30KKworTmF2aWdhdG9y UG9pbnRlckxvY2s6On5OYXZpZ2F0b3JQb2ludGVyTG9jaygpCit7Cit9CisKK1BvaW50ZXJMb2Nr KiBOYXZpZ2F0b3JQb2ludGVyTG9jazo6d2Via2l0UG9pbnRlcihOYXZpZ2F0b3IqIG5hdmlnYXRv cikKK3sKKyAgICBQb2ludGVyTG9jayogcG9pbnRlckxvY2sgPSBQb2ludGVyTG9jazo6ZnJvbShu YXZpZ2F0b3IpOworICAgIGlmICghcG9pbnRlckxvY2sgJiYgbmF2aWdhdG9yLT5mcmFtZSgpICYm IG5hdmlnYXRvci0+ZnJhbWUoKS0+cGFnZSgpKSB7CisgICAgICAgIE5hdmlnYXRvclN1cHBsZW1l bnQ6OnByb3ZpZGVUbyhuYXZpZ2F0b3IsIFBvaW50ZXJMb2NrOjpzdXBwbGVtZW50TmFtZSgpLCBQ b2ludGVyTG9jazo6Y3JlYXRlKG5hdmlnYXRvci0+ZnJhbWUoKSkpOworICAgICAgICBwb2ludGVy TG9jayA9IFBvaW50ZXJMb2NrOjpmcm9tKG5hdmlnYXRvcik7CisgICAgfQorICAgIHJldHVybiBw b2ludGVyTG9jazsKK30KKworfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQorCisjZW5kaWYgLy8gRU5B QkxFKFBPSU5URVJfTE9DSykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvcG9p bnRlcmxvY2svTmF2aWdhdG9yUG9pbnRlckxvY2suaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv cG9pbnRlcmxvY2svTmF2aWdhdG9yUG9pbnRlckxvY2suaApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40YTNkNGZkNjM3 YjVmYTIyNjE0MDBmYjM3M2IzMTQ1ZTVlY2UwODNmCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9wb2ludGVybG9jay9OYXZpZ2F0b3JQb2ludGVyTG9jay5oCkBAIC0w LDAgKzEsNDUgQEAKKy8qCisgICAgQ29weXJpZ2h0IChDKSAyMDA4IE5va2lhIENvcnBvcmF0aW9u IGFuZC9vciBpdHMgc3Vic2lkaWFyeSgtaWVzKQorCisgICAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUg c29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICAgIG1vZGlmeSBpdCB1 bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCisgICAgTGlj ZW5zZSBhcyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVy CisgICAgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBs YXRlciB2ZXJzaW9uLgorCisgICAgVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBo b3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgICAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZ OyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAgICBNRVJDSEFOVEFCSUxJ VFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICAg IExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCisgICAg WW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJh bCBQdWJsaWMgTGljZW5zZQorICAgIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhlIGZp bGUgQ09QWUlORy5MSUIuICBJZiBub3QsIHdyaXRlIHRvCisgICAgdGhlIEZyZWUgU29mdHdhcmUg Rm91bmRhdGlvbiwgSW5jLiwgNTEgRnJhbmtsaW4gU3RyZWV0LCBGaWZ0aCBGbG9vciwKKyAgICBC b3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KKyovCisKKyNpZm5kZWYgTmF2aWdhdG9yUG9pbnRl ckxvY2tfaAorI2RlZmluZSBOYXZpZ2F0b3JQb2ludGVyTG9ja19oCisKKyNpZiBFTkFCTEUoUE9J TlRFUl9MT0NLKQorCisjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgorCituYW1lc3BhY2UgV2ViQ29y ZSB7CisKK2NsYXNzIE5hdmlnYXRvcjsKK2NsYXNzIFBvaW50ZXJMb2NrOworCitjbGFzcyBOYXZp Z2F0b3JQb2ludGVyTG9jayB7CitwdWJsaWM6CisgICAgc3RhdGljIFBvaW50ZXJMb2NrKiB3ZWJr aXRQb2ludGVyKE5hdmlnYXRvciopOworCitwcml2YXRlOgorICAgIE5hdmlnYXRvclBvaW50ZXJM b2NrKCk7CisgICAgfk5hdmlnYXRvclBvaW50ZXJMb2NrKCk7Cit9OworCit9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCisKKyNlbmRpZiAvLyBFTkFCTEUoUE9JTlRFUl9MT0NLKQorCisjZW5kaWYgLy8g TmF2aWdhdG9yUG9pbnRlckxvY2tfaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9wb2ludGVybG9jay9OYXZpZ2F0b3JQb2ludGVyTG9jay5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3BvaW50ZXJsb2NrL05hdmlnYXRvclBvaW50ZXJMb2NrLmlkbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43 NmZiMWZhYWQ0OWNjYThhOThjYmM5MjBlZTc5MDI2MDMwOWI3YzE3Ci0tLSAvZGV2L251bGwKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9wb2ludGVybG9jay9OYXZpZ2F0b3JQb2ludGVyTG9j ay5pZGwKQEAgLTAsMCArMSwyOSBAQAorLyoKKyAgICBDb3B5cmlnaHQgKEMpIDIwMDggTm9raWEg Q29ycG9yYXRpb24gYW5kL29yIGl0cyBzdWJzaWRpYXJ5KC1pZXMpCisKKyAgICBUaGlzIGxpYnJh cnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgICAg bW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJs aWMKKyAgICBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0 aW9uOyBlaXRoZXIKKyAgICB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9w dGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKyAgICBUaGlzIGxpYnJhcnkgaXMgZGlzdHJpYnV0 ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAgICBidXQgV0lUSE9VVCBB TlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICAgIE1F UkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0 aGUgR05VCisgICAgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFp bHMuCisKKyAgICBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGli cmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisgICAgYWxvbmcgd2l0aCB0aGlzIGxpYnJhcnk7 IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwgd3JpdGUgdG8KKyAgICB0aGUgRnJl ZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuLCA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZs b29yLAorICAgIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNBLgorKi8KKworbW9kdWxlIHdpbmRv dyB7CisKKyAgICBpbnRlcmZhY2UgWworICAgICAgICBDb25kaXRpb25hbD1QT0lOVEVSX0xPQ0ss CisgICAgICAgIFN1cHBsZW1lbnRhbD1OYXZpZ2F0b3IKKyAgICBdIE5hdmlnYXRvclBvaW50ZXJM b2NrIHsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtWOEVuYWJsZWRBdFJ1bnRpbWVdIFBv aW50ZXJMb2NrIHdlYmtpdFBvaW50ZXI7CisgICAgfTsKKworfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3Jl Lmd5cC9XZWJDb3JlLmd5cAppbmRleCAyZmNiYWE0NDViMmFhOWU4MTA1MDQ2OTg3ODBmZTRiMjZl ZWNiMjA2Li44NTM3ODdmMDVmZGFmNmFjYzNmM2Q1MTdlNDQwMjdkMTUzN2ZkZGU4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAtNTUsNiArNTUsNyBAQAogICAgICAg Jy4uL01vZHVsZXMvZ2VvbG9jYXRpb24nLAogICAgICAgJy4uL01vZHVsZXMvaW50ZW50cycsCiAg ICAgICAnLi4vTW9kdWxlcy9pbmRleGVkZGInLAorICAgICAgJy4uL01vZHVsZXMvcG9pbnRlcmxv Y2snLAogICAgICAgJy4uL01vZHVsZXMvbWVkaWFzdHJlYW0nLAogICAgICAgJy4uL01vZHVsZXMv d2Vic29ja2V0cycsCiAgICAgICAnLi4vYWNjZXNzaWJpbGl0eScsCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkKaW5k ZXggOTYyMzhmNjY4NTFkNjU1ZmRmOTdlYzE3ZWU2Nzg4OTQ5MjI3NjczNS4uNDdlMDBlNzZmNjIw YjEwMTRlY2Q5YjI0MGYyY2E2MDBjYmY2YjA0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv V2ViQ29yZS5neXBpCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQpAQCAtNzQ1LDYg Kzc0NSw3IEBACiAgICAgICAgICAgICAnTW9kdWxlcy9tZWRpYXN0cmVhbS9OYXZpZ2F0b3JVc2Vy TWVkaWFTdWNjZXNzQ2FsbGJhY2suaWRsJywKICAgICAgICAgICAgICdNb2R1bGVzL21lZGlhc3Ry ZWFtL1BlZXJDb25uZWN0aW9uLmlkbCcsCiAgICAgICAgICAgICAnTW9kdWxlcy9tZWRpYXN0cmVh bS9TaWduYWxpbmdDYWxsYmFjay5pZGwnLAorICAgICAgICAgICAgJ01vZHVsZXMvcG9pbnRlcmxv Y2svTmF2aWdhdG9yUG9pbnRlckxvY2suaWRsJywKICAgICAgICAgICAgICdNb2R1bGVzL3dlYnNv Y2tldHMvQ2xvc2VFdmVudC5pZGwnLAogICAgICAgICAgICAgJ01vZHVsZXMvd2Vic29ja2V0cy9E T01XaW5kb3dXZWJTb2NrZXQuaWRsJywKICAgICAgICAgICAgICdNb2R1bGVzL3dlYnNvY2tldHMv V2ViU29ja2V0LmlkbCcsCkBAIC0xMzI3LDYgKzEzMjgsOCBAQAogICAgICAgICAgICAgJ01vZHVs ZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhQ29udHJvbGxlci5jcHAnLAogICAgICAgICAgICAgJ01v ZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAnLAogICAgICAgICAgICAgJ01v ZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5oJywKKyAgICAgICAgICAgICdNb2R1 bGVzL3BvaW50ZXJsb2NrL05hdmlnYXRvclBvaW50ZXJMb2NrLmNwcCcsCisgICAgICAgICAgICAn TW9kdWxlcy9wb2ludGVybG9jay9OYXZpZ2F0b3JQb2ludGVyTG9jay5oJywKICAgICAgICAgICAg ICdNb2R1bGVzL3dlYnNvY2tldHMvQ2xvc2VFdmVudC5oJywKICAgICAgICAgICAgICdNb2R1bGVz L3dlYnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuY3BwJywKICAgICAgICAgICAg ICdNb2R1bGVzL3dlYnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuaCcsCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL05hdmlnYXRvci5jcHAKaW5kZXggNzYzMjhhN2E1MzgyMWQxZjk2OTIyYzgxMzAwODcz OWZiMWU3YzE5Yy4uNDYwMTJlOTExNDFmODRmZTk5ZTIwZTM0OThhNDA2MTFiMGNlZjRkZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0b3IuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNwcApAQCAtMzIsNyArMzIsNiBAQAogI2luY2x1ZGUgIkZy YW1lTG9hZGVyQ2xpZW50LmgiCiAjaW5jbHVkZSAiR2VvbG9jYXRpb24uaCIKICNpbmNsdWRlICJQ YWdlLmgiCi0jaW5jbHVkZSAiUG9pbnRlckxvY2suaCIKICNpbmNsdWRlICJMYW5ndWFnZS5oIgog I2luY2x1ZGUgIlBsdWdpbkRhdGEuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgpAQCAtMTQwLDE1 ICsxMzksNiBAQCBib29sIE5hdmlnYXRvcjo6amF2YUVuYWJsZWQoKSBjb25zdAogICAgIHJldHVy biBtX2ZyYW1lLT5zZXR0aW5ncygpLT5pc0phdmFFbmFibGVkKCk7CiB9CiAKLSNpZiBFTkFCTEUo UE9JTlRFUl9MT0NLKQotUG9pbnRlckxvY2sqIE5hdmlnYXRvcjo6d2Via2l0UG9pbnRlcigpIGNv bnN0Ci17Ci0gICAgaWYgKCFtX3BvaW50ZXIgJiYgbV9mcmFtZSAmJiBtX2ZyYW1lLT5wYWdlKCkp Ci0gICAgICAgIG1fcG9pbnRlciA9IFBvaW50ZXJMb2NrOjpjcmVhdGUobV9mcmFtZSk7Ci0gICAg cmV0dXJuIG1fcG9pbnRlci5nZXQoKTsKLX0KLSNlbmRpZgotCiB2b2lkIE5hdmlnYXRvcjo6Z2V0 U3RvcmFnZVVwZGF0ZXMoKQogewogICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBtZXRob2Qgb3Ig cmVuYW1lIHRvIHlpZWxkRm9yU3RvcmFnZVVwZGF0ZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL05hdmlnYXRvci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0b3IuaApp bmRleCA3NTBlZWFhNTdiMDg4NzFiNTY3MGZmYjhkZjczOWI3NmE0OWJkNTkxLi45NTAwMjZmMzU4 ZTUwNjNjZmJkY2RjZmU5MzIwYWY4YWM1NmM0ZTA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL05hdmlnYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmgK QEAgLTM0LDcgKzM0LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgRE9NTWltZVR5cGVB cnJheTsKIGNsYXNzIERPTVBsdWdpbkFycmF5OwogY2xhc3MgRnJhbWU7Ci1jbGFzcyBQb2ludGVy TG9jazsKIGNsYXNzIFBsdWdpbkRhdGE7CiAKIHR5cGVkZWYgaW50IEV4Y2VwdGlvbkNvZGU7CkBA IC01MywxMCArNTIsNiBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIFN0cmluZyB1c2VyQWdlbnQo KSBjb25zdDsKIAotI2lmIEVOQUJMRShQT0lOVEVSX0xPQ0spCi0gICAgUG9pbnRlckxvY2sqIHdl YmtpdFBvaW50ZXIoKSBjb25zdDsKLSNlbmRpZgotCiAgICAgLy8gUmVsaW5xdWlzaGVzIHRoZSBz dG9yYWdlIGxvY2ssIGlmIG9uZSBleGlzdHMuCiAgICAgdm9pZCBnZXRTdG9yYWdlVXBkYXRlcygp OwogCkBAIC03MSw5ICs2Niw2IEBAIHByaXZhdGU6CiAKICAgICBtdXRhYmxlIFJlZlB0cjxET01Q bHVnaW5BcnJheT4gbV9wbHVnaW5zOwogICAgIG11dGFibGUgUmVmUHRyPERPTU1pbWVUeXBlQXJy YXk+IG1fbWltZVR5cGVzOwotI2lmIEVOQUJMRShQT0lOVEVSX0xPQ0spCi0gICAgbXV0YWJsZSBS ZWZQdHI8UG9pbnRlckxvY2s+IG1fcG9pbnRlcjsKLSNlbmRpZgogfTsKIAogfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0b3IuaWRsIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9OYXZpZ2F0b3IuaWRsCmluZGV4IDQwMGQ4ZTAxMGI0NjM1YzgzODBiZTVhNzcxMThkNjE2NDE3 MTJlNGUuLjNjMmFmMDFjOTI3MWM0M2M4YWRiYjY0YmE4NmQxN2QyYzRjMzAyMmIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL05hdmlnYXRvci5pZGwKQEAgLTQwLDEwICs0MCw2IEBAIG1vZHVsZSB3aW5kb3cgewog CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIG9uTGluZTsKIAotI2lmIGRlZmlu ZWQoRU5BQkxFX1BPSU5URVJfTE9DSykgJiYgRU5BQkxFX1BPSU5URVJfTE9DSwotICAgICAgICBy ZWFkb25seSBhdHRyaWJ1dGUgW1Y4RW5hYmxlZEF0UnVudGltZV0gUG9pbnRlckxvY2sgd2Via2l0 UG9pbnRlcjsKLSNlbmRpZgotCiAgICAgICAgIHZvaWQgZ2V0U3RvcmFnZVVwZGF0ZXMoKTsgLy8g RklYTUU6IFJlbW92ZSB0aGlzIG1ldGhvZCBvciByZW5hbWUgdG8geWllbGRGb3JTdG9yYWdlVXBk YXRlcy4KICAgICB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BvaW50ZXJM b2NrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUG9pbnRlckxvY2suY3BwCmluZGV4IDcyMzEx ZTBmMmM2Yjk0NGMxMDNjZDA1MTY2ZGNhMGFjZTQ0ZjZjMGMuLjIyOTVhY2EwODg4MzY4NmJhMmU4 ODcxZDY1YWEzNDU1YmM5ZmUzNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUG9p bnRlckxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUG9pbnRlckxvY2suY3BwCkBA IC02OSw2ICs2OSwxMiBAQCBib29sIFBvaW50ZXJMb2NrOjppc0xvY2tlZCgpCiAgICAgcmV0dXJu IG1fY29udHJvbGxlciAmJiBtX2NvbnRyb2xsZXItPmlzTG9ja2VkKCk7CiB9CiAKK2NvbnN0IEF0 b21pY1N0cmluZyYgUG9pbnRlckxvY2s6OnN1cHBsZW1lbnROYW1lKCkKK3sKKyAgICBERUZJTkVf U1RBVElDX0xPQ0FMKEF0b21pY1N0cmluZywgbmFtZSwgKCJQb2ludGVyTG9jayIpKTsKKyAgICBy ZXR1cm4gbmFtZTsKK30KKwogfQogCiAjZW5kaWYgLy8gRU5BQkxFKFBPSU5URVJfTE9DSykKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUG9pbnRlckxvY2suaCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvUG9pbnRlckxvY2suaAppbmRleCAyNDBkNzlhYzhkMWNiN2FkMTY5NTM5MWJiYTg5 MWY4ODJiMDM4ZGEzLi5hNzYzMmQ2Y2QzZGQ0ZTBjYTA3YmY0YjM0MjFkZDNlMjAyOGI1ZDdiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BvaW50ZXJMb2NrLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9Qb2ludGVyTG9jay5oCkBAIC0yOCw3ICsyOCw5IEBACiAjaWYgRU5BQkxF KFBPSU5URVJfTE9DSykKIAogI2luY2x1ZGUgIkRPTVdpbmRvd1Byb3BlcnR5LmgiCisjaW5jbHVk ZSAiTmF2aWdhdG9yU3VwcGxlbWVudC5oIgogI2luY2x1ZGUgIlZvaWRDYWxsYmFjay5oIgorI2lu Y2x1ZGUgPHd0Zi9QYXNzT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNp bmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogCkBAIC0zOCw5ICs0MCwxMSBAQCBjbGFzcyBFbGVt ZW50OwogY2xhc3MgRnJhbWU7CiBjbGFzcyBQb2ludGVyTG9ja0NvbnRyb2xsZXI7CiAKLWNsYXNz IFBvaW50ZXJMb2NrIDogcHVibGljIFJlZkNvdW50ZWQ8UG9pbnRlckxvY2s+LCBwdWJsaWMgRE9N V2luZG93UHJvcGVydHkgeworY2xhc3MgUG9pbnRlckxvY2sgOiBwdWJsaWMgUmVmQ291bnRlZDxQ b2ludGVyTG9jaz4sIHB1YmxpYyBET01XaW5kb3dQcm9wZXJ0eSwgcHVibGljIE5hdmlnYXRvclN1 cHBsZW1lbnQgewogcHVibGljOgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFBvaW50ZXJMb2NrPiBj cmVhdGUoRnJhbWUqIGZyYW1lKSB7IHJldHVybiBhZG9wdFJlZihuZXcgUG9pbnRlckxvY2soZnJh bWUpKTsgfQorICAgIHN0YXRpYyBQYXNzT3duUHRyPFBvaW50ZXJMb2NrPiBjcmVhdGUoRnJhbWUq IGZyYW1lKSB7IHJldHVybiBhZG9wdFB0cihuZXcgUG9pbnRlckxvY2soZnJhbWUpKTsgfQorICAg IHN0YXRpYyBjb25zdCBBdG9taWNTdHJpbmcmIHN1cHBsZW1lbnROYW1lKCk7CisgICAgc3RhdGlj IFBvaW50ZXJMb2NrKiBmcm9tKE5hdmlnYXRvciogbmF2aWdhdG9yKSB7IHJldHVybiBzdGF0aWNf Y2FzdDxQb2ludGVyTG9jayo+KE5hdmlnYXRvclN1cHBsZW1lbnQ6OmZyb20obmF2aWdhdG9yLCBz dXBwbGVtZW50TmFtZSgpKSk7IH0KIAogICAgIH5Qb2ludGVyTG9jaygpOwogCkBAIC02Miw0ICs2 NiwzIEBAIHByaXZhdGU6CiAjZW5kaWYgLy8gRU5BQkxFKFBPSU5URVJfTE9DSykKIAogI2VuZGlm IC8vIFBvaW50ZXJMb2NrX2gKLQo=