79605 2012-02-26 08:00:37 -0800 webkit-gtk does not respect LINGUAS 2012-03-02 15:10:55 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tetromino webkit-unassigned gnome mrobinson webkit.review.bot oldest_to_newest 565153 0 128916 tetromino 2012-02-26 08:00:37 -0800 Created attachment 128916 patch to respect LINGUAS It is generally expected that modern linux packages honor the LINGUAS environment variable to limit the set of translations that get built. For example, if LINGUAS="en ru de", then at most only the Englush, Russian, and German translations of messages etc. would be built; an empty or undefined LINGUAS is typically interpreted as "all available translations". Packages that use a copy of intltool's Makefile.in.in get this capability for free (see http://bazaar.launchpad.net/~intltool/intltool/trunk/view/head:/Makefile.in.in). Since webkit-gtk uses a rather non-standard build system, a patch is needed. Note that in the attached patch, PO_LINGUAS, USER_LINGUAS, and USE_LINGUAS are added to the root GNUmakefile.am to ensure that they are defined before MOFILES in the root GNUmakefile due to the way that automake interprets "+=". 566000 1 mrobinson 2012-02-27 15:04:41 -0800 There's already an effort to make the library intltool compliant: https://bugs.webkit.org/show_bug.cgi?id=45321 Would that fix the issue as well? I'm not opposed to this patch, but could you make it against the SVN checkout and include a changelog? See http://www.webkit.org/coding/contributing.html 566377 2 129187 tetromino 2012-02-27 22:05:59 -0800 Created attachment 129187 patch to respect LINGUAS (with changelogs) (In reply to comment #1) > There's already an effort to make the library intltool compliant: https://bugs.webkit.org/show_bug.cgi?id=45321 > > Would that fix the issue as well? Yes; if webkit-gtk used intltool's Makefile.in.in, then it would treat LINGUAS like all other intltool-using projects, and my patch would not be needed. > I'm not opposed to this patch, but could you make it against the SVN checkout and include a changelog? See http://www.webkit.org/coding/contributing.html Sure, patch with changelogs attached. 569975 3 129187 webkit.review.bot 2012-03-02 15:10:48 -0800 Comment on attachment 129187 patch to respect LINGUAS (with changelogs) Clearing flags on attachment: 129187 Committed r109620: <http://trac.webkit.org/changeset/109620> 569976 4 webkit.review.bot 2012-03-02 15:10:55 -0800 All reviewed patches have been landed. Closing bug. 128916 2012-02-26 08:00:37 -0800 2012-02-27 22:05:59 -0800 patch to respect LINGUAS webkit-gtk-1.7.5-linguas.patch text/plain 1447 tetromino UmVzcGVjdCBpbnRsdG9vbCdzIExJTkdVQVMgdmFyaWFibGUgZm9yIGJ1aWxkaW5nIHRyYW5zbGF0 aW9ucy4KCi0tLSBhL3dlYmtpdC0xLjcuNS9HTlVtYWtlZmlsZS5hbQorKysgYi93ZWJraXQtMS43 LjUvR05VbWFrZWZpbGUuYW0KQEAgLTU0LDYgKzU0LDkgQEAKIElETF9CSU5ESU5HUyA6PQogVEVT VF9QUk9HUyA6PQogUE9GSUxFUyA6PQorUE9fTElOR1VBUyA6PQorVVNFUl9MSU5HVUFTIDo9CitV U0VfTElOR1VBUyA6PQogTU9GSUxFUyA6PQogZG9tX2JpbmRpbmdfaWRscyA6PQogd3RmX2NwcGZs YWdzOj0KLS0tIGEvd2Via2l0LTEuNy41L1NvdXJjZS9XZWJLaXQvZ3RrL3BvL0dOVW1ha2VmaWxl LmFtCisrKyBiL3dlYmtpdC0xLjcuNS9Tb3VyY2UvV2ViS2l0L2d0ay9wby9HTlVtYWtlZmlsZS5h bQpAQCAtMjcsNyArMjcsMTUgQEAKIAogUE9GSUxFUyArPSAkKHNoZWxsIGxzICQoc3JjZGlyKS9T b3VyY2UvV2ViS2l0L2d0ay9wby8qLnBvKQogCi1NT0ZJTEVTICs9ICQoc2hlbGwgZWNobyAkKFBP RklMRVMpIHwgdHIgJyAnICdcbicgfCBzZWQgInMsXiQoc3JjZGlyKS8sLGciIHwgc2VkICdzL1wu cG8vLm1vL2cnKQorUE9fTElOR1VBUyArPSAkKHBhdHN1YnN0ICQoc3JjZGlyKS9Tb3VyY2UvV2Vi S2l0L2d0ay9wby8lLnBvLCUsJChQT0ZJTEVTKSkKKworVVNFUl9MSU5HVUFTICs9ICQoZmlsdGVy ICQoTElOR1VBUyksJChQT19MSU5HVUFTKSkKKworVVNFX0xJTkdVQVMgKz0gJChzaGVsbCBpZiB0 ZXN0IC1uICIkKFVTRVJfTElOR1VBUykiIC1vIC1uICIkKExJTkdVQVMpIjsgdGhlbiBMTElOR1VB Uz0iJChVU0VSX0xJTkdVQVMpIjsgZWxzZSBMTElOR1VBUz0iJChQT19MSU5HVUFTKSI7IGZpOyBm b3IgbGFuZyBpbiAkJExMSU5HVUFTOyBkbyBwcmludGYgIiQkbGFuZyAiOyBkb25lKQorCitNT0ZJ TEVTICs9ICQoVVNFX0xJTkdVQVM6JT1Tb3VyY2UvV2ViS2l0L2d0ay9wby8lLm1vKQorCitBTExf TU9GSUxFUyA6PSAkKHNoZWxsIGVjaG8gJChQT0ZJTEVTKSB8IHRyICcgJyAnXG4nIHwgc2VkICJz LF4kKHNyY2RpcikvLCxnIiB8IHNlZCAncy9cLnBvLy5tby9nJykKIAogLnBvLm1vOgogCXRlc3Qg LWQgU291cmNlL1dlYktpdC9ndGsvcG8vIHx8IG1rZGlyIC1wIFNvdXJjZS9XZWJLaXQvZ3RrL3Bv LwpAQCAtMTI0LDExICsxMzIsMTEgQEAKIAkkKHRvcF9idWlsZGRpcikvc3RhbXAtcG8KIAogTUFJ TlRBSU5FUkNMRUFORklMRVMgKz0gXAotCSQoTU9GSUxFUykgXAorCSQoQUxMX01PRklMRVMpIFwK IAkkKHRvcF9idWlsZGRpcikvU291cmNlL1dlYktpdC9ndGsvcG8vJChET01BSU4pLnBvdAogCiBE SVNUQ0xFQU5GSUxFUyArPSBcCi0JJChNT0ZJTEVTKSBcCisJJChBTExfTU9GSUxFUykgXAogCSQo dG9wX2J1aWxkZGlyKS9Tb3VyY2UvV2ViS2l0L2d0ay9wby8kKERPTUFJTikucG90CiAKIHBvLWlu c3RhbGwtZGF0YS1sb2NhbDogYWxsCg== 129187 2012-02-27 22:05:59 -0800 2012-03-02 15:10:48 -0800 patch to respect LINGUAS (with changelogs) webkit-gtk-svn-linguas.patch text/plain 2865 tetromino SW5kZXg6IEdOVW1ha2VmaWxlLmFtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEdOVW1ha2VmaWxlLmFtCShyZXZp c2lvbiAxMDkwNzIpCisrKyBHTlVtYWtlZmlsZS5hbQkod29ya2luZyBjb3B5KQpAQCAtNTQsNiAr NTQsOSBAQAogSURMX0JJTkRJTkdTIDo9CiBURVNUX1BST0dTIDo9CiBQT0ZJTEVTIDo9CitQT19M SU5HVUFTIDo9CitVU0VSX0xJTkdVQVMgOj0KK1VTRV9MSU5HVUFTIDo9CiBNT0ZJTEVTIDo9CiBk b21fYmluZGluZ19pZGxzIDo9CiB3dGZfY3BwZmxhZ3M6PQpJbmRleDogQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gMTA5MDc0KQorKysgQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDItMjcgIEFsZXhhbmRyZSBSb3N0b3Z0 c2V2ICA8dGV0cm9taW5vQGdlbnRvby5vcmc+CisKKyAgICAgICAgTWFrZSB3ZWJraXQtZ3RrIHRy YW5zbGF0aW9ucyByZXNwZWN0IExJTkdVQVMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc5NjA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUE9fTElOR1VBUywgVVNFUl9MSU5HVUFTLCBhbmQgVVNFX0xJTkdV QVMgYWRkZWQgdG8gcm9vdAorICAgICAgICBHTlVtYWtlZmlsZS5hbSB0byBlbnN1cmUgdGhhdCB0 aGV5IGNhbiBiZSB1c2VkIGluIHRoZSBkZWZpbml0aW9uIG9mCisgICAgICAgIE1PRklMRVMgdGhh dCB3aWxsIGJlIGdlbmVyYXRlZCBieSBhdXRvbWFrZS4KKworICAgICAgICAqIEdOVW1ha2VmaWxl LmFtOgorCiAyMDEyLTAyLTI3ICBEYXZlIFR1ICA8ZHR1QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBVcGRhdGUgZmxha2luZXNzIGRhc2hib2FyZCB1bml0IHRlc3QuCkluZGV4OiBTb3VyY2UvV2Vi S2l0L2d0ay9wby9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9ndGsvcG8v Q2hhbmdlTG9nCShyZXZpc2lvbiAxMDkwNzQpCisrKyBTb3VyY2UvV2ViS2l0L2d0ay9wby9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0wMi0yNyAgQWxleGFu ZHJlIFJvc3RvdnRzZXYgIDx0ZXRyb21pbm9AZ2VudG9vLm9yZz4KKworICAgICAgICBNYWtlIHdl YmtpdC1ndGsgdHJhbnNsYXRpb25zIHJlc3BlY3QgTElOR1VBUworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk2MDUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgorCiAyMDExLTEx LTA5ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBF c3BlcmFudG8tdHJhbnNsYXRpb24KSW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL3BvL0dOVW1ha2Vm aWxlLmFtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvZ3RrL3BvL0dOVW1ha2VmaWxlLmFt CShyZXZpc2lvbiAxMDkwNzMpCisrKyBTb3VyY2UvV2ViS2l0L2d0ay9wby9HTlVtYWtlZmlsZS5h bQkod29ya2luZyBjb3B5KQpAQCAtMjcsOCArMjcsMTYgQEAKIAogUE9GSUxFUyArPSAkKHNoZWxs IGxzICQoc3JjZGlyKS9Tb3VyY2UvV2ViS2l0L2d0ay9wby8qLnBvKQogCi1NT0ZJTEVTICs9ICQo c2hlbGwgZWNobyAkKFBPRklMRVMpIHwgdHIgJyAnICdcbicgfCBzZWQgInMsXiQoc3JjZGlyKS8s LGciIHwgc2VkICdzL1wucG8vLm1vL2cnKQorUE9fTElOR1VBUyArPSAkKHBhdHN1YnN0ICQoc3Jj ZGlyKS9Tb3VyY2UvV2ViS2l0L2d0ay9wby8lLnBvLCUsJChQT0ZJTEVTKSkKIAorVVNFUl9MSU5H VUFTICs9ICQoZmlsdGVyICQoTElOR1VBUyksJChQT19MSU5HVUFTKSkKKworVVNFX0xJTkdVQVMg Kz0gJChzaGVsbCBpZiB0ZXN0IC1uICIkKFVTRVJfTElOR1VBUykiIC1vIC1uICIkKExJTkdVQVMp IjsgdGhlbiBMTElOR1VBUz0iJChVU0VSX0xJTkdVQVMpIjsgZWxzZSBMTElOR1VBUz0iJChQT19M SU5HVUFTKSI7IGZpOyBmb3IgbGFuZyBpbiAkJExMSU5HVUFTOyBkbyBwcmludGYgIiQkbGFuZyAi OyBkb25lKQorCitNT0ZJTEVTICs9ICQoVVNFX0xJTkdVQVM6JT1Tb3VyY2UvV2ViS2l0L2d0ay9w by8lLm1vKQorCitBTExfTU9GSUxFUyA6PSAkKHNoZWxsIGVjaG8gJChQT0ZJTEVTKSB8IHRyICcg JyAnXG4nIHwgc2VkICJzLF4kKHNyY2RpcikvLCxnIiB8IHNlZCAncy9cLnBvLy5tby9nJykKKwog LnBvLm1vOgogCXRlc3QgLWQgU291cmNlL1dlYktpdC9ndGsvcG8vIHx8IG1rZGlyIC1wIFNvdXJj ZS9XZWJLaXQvZ3RrL3BvLwogCUBlY2hvICIkKE1TR0ZNVCkgLWMgLW8gJEAgJDwiOyBcCkBAIC0x MjQsMTEgKzEzMiwxMSBAQAogCSQodG9wX2J1aWxkZGlyKS9zdGFtcC1wbwogCiBNQUlOVEFJTkVS Q0xFQU5GSUxFUyArPSBcCi0JJChNT0ZJTEVTKSBcCisJJChBTExfTU9GSUxFUykgXAogCSQodG9w X2J1aWxkZGlyKS9Tb3VyY2UvV2ViS2l0L2d0ay9wby8kKERPTUFJTikucG90CiAKIERJU1RDTEVB TkZJTEVTICs9IFwKLQkkKE1PRklMRVMpIFwKKwkkKEFMTF9NT0ZJTEVTKSBcCiAJJCh0b3BfYnVp bGRkaXIpL1NvdXJjZS9XZWJLaXQvZ3RrL3BvLyQoRE9NQUlOKS5wb3QKIAogcG8taW5zdGFsbC1k YXRhLWxvY2FsOiBhbGwK