79593 2012-02-25 18:41:52 -0800 [Performance Tests] [Chromium] Bindings/dom-attributes.html is timing out 2012-02-26 17:48:22 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 1 rniwa haraken abarth arv dglazkov haraken morrita tony webkit.review.bot oldest_to_newest 565072 0 rniwa 2012-02-25 18:41:52 -0800 http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Perf%29/builds/530/steps/perf-test/logs/stdio Running Bindings/dom-attributes.html (1 of 44) timeout: PerformanceTests/Bindings/dom-attributes.html FAILED Letting any test timeout is incredibly harmful on perf bots because we let each test run 10 minutes. 565073 1 rniwa 2012-02-25 18:43:26 -0800 Given the test is generating passing on Lion, I bet this is a bug in Chromium code or Chromium DumpRenderTree: http://build.webkit.org/builders/Lion%20Intel%20Release%20%28Perf%29/builds/459/steps/perf-test/logs/stdio RESULT Bindings: dom-attributes= 8829.45 ms median= 8839.5 ms, stdev= 32.2327085427 ms, min= 8770.0 ms, max= 8871.0 ms 565223 2 128934 haraken 2012-02-26 16:38:38 -0800 Created attachment 128934 Patch 565224 3 128934 rniwa 2012-02-26 16:50:48 -0800 Comment on attachment 128934 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128934&action=review > PerformanceTests/ChangeLog:10 > + V8 DOM bindings are too much slower than JSC bindings. That's really bad. We should fix that. The results are also not reliable on Mac/Qt: http://webkit-perf.appspot.com/graph.html#tests=[[150153,2001,100137],[150153,2001,32196]]&sel=1330111816007.1082,1330303636915&displayrange=7&datatype=running Could you investigate why that's the case? Do we just need more samples or are we doing something inherently unstable? 565226 4 haraken 2012-02-26 16:59:19 -0800 (In reply to comment #3) > > PerformanceTests/ChangeLog:10 > > + V8 DOM bindings are too much slower than JSC bindings. > > That's really bad. We should fix that. Yes, yes, yes, really. I've been investigating why (using my 20% time though). > The results are also not reliable on Mac/Qt: > http://webkit-perf.appspot.com/graph.html#tests=[[150153,2001,100137],[150153,2001,32196]]&sel=1330111816007.1082,1330303636915&displayrange=7&datatype=running > > Could you investigate why that's the case? Do we just need more samples or are we doing something inherently unstable? OK. But let me commit the patch to observe the reliability on the perf bots. 565227 5 rniwa 2012-02-26 17:02:52 -0800 (In reply to comment #4) > (In reply to comment #3) > > > PerformanceTests/ChangeLog:10 > > > + V8 DOM bindings are too much slower than JSC bindings. > > > > That's really bad. We should fix that. > > Yes, yes, yes, really. I've been investigating why (using my 20% time though). > > > The results are also not reliable on Mac/Qt: > > http://webkit-perf.appspot.com/graph.html#tests=[[150153,2001,100137],[150153,2001,32196]]&sel=1330111816007.1082,1330303636915&displayrange=7&datatype=running > > > > Could you investigate why that's the case? Do we just need more samples or are we doing something inherently unstable? > > OK. But let me commit the patch to observe the reliability on the perf bots. Sounds good to me. 565231 6 128934 webkit.review.bot 2012-02-26 17:08:26 -0800 Comment on attachment 128934 Patch Attachment 128934 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11628770 New failing tests: inspector/protocol/console-agent.html 565242 7 128934 webkit.review.bot 2012-02-26 17:48:17 -0800 Comment on attachment 128934 Patch Clearing flags on attachment: 128934 Committed r108942: <http://trac.webkit.org/changeset/108942> 565243 8 webkit.review.bot 2012-02-26 17:48:22 -0800 All reviewed patches have been landed. Closing bug. 128934 2012-02-26 16:38:38 -0800 2012-02-26 17:48:17 -0800 Patch bug-79593-20120227093837.patch text/plain 1659 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTM2CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0JpbmRpbmdzL2RvbS1hdHRyaWJ1dGVzLmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL0JpbmRpbmdz L2RvbS1hdHRyaWJ1dGVzLmh0bWwKaW5kZXggYzRlNmMzYmU2MmRhZDFiNzg0NzkzNDIyOWE5OTI5 NTQ3YWQ2Yjk1NC4uYmM0ZTQ0NjI3YzI0ZmQ0NGU1NTViYzFmNGUxMDg2YTkzNDdiNGRlOSAxMDA2 NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9CaW5kaW5ncy9kb20tYXR0cmlidXRlcy5odG1sCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQmluZGluZ3MvZG9tLWF0dHJpYnV0ZXMuaHRtbApAQCAtMyw4 ICszLDggQEAKIDxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvcnVubmVyLmpzIj48L3NjcmlwdD4K IDxzY3JpcHQ+CiAKLXZhciBnZXR0ZXJSZXBlYXQgPSAzMDAwMDAwOwotdmFyIHNldHRlclJlcGVh dCA9IDUwMDAwMDsKK3ZhciBnZXR0ZXJSZXBlYXQgPSAxNTAwMDAwOwordmFyIHNldHRlclJlcGVh dCA9IDI1MDAwMDsKIAogdmFyIHRpbWVzID0ge307CiAKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNl VGVzdHMvQ2hhbmdlTG9nIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGM3MGNm YTUyZjJlOTljMzc0MjI2YzU1OTQyMGNhNzhhMTU4MTY0MS4uMjM4MTRjZTcyNjQ3OTVkMTFkY2M0 NTU2YWU2OGZjNTQ4Y2ZmYjEyYSAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VM b2cKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAx Mi0wMi0yNiAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg W1BlcmZvcm1hbmNlIFRlc3RzXSBbQ2hyb21pdW1dIEJpbmRpbmdzL2RvbS1hdHRyaWJ1dGVzLmh0 bWwgaXMgdGltaW5nIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Nzk1OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIGhhbHZlcyB0aGUgZXhlY3V0aW9uIHRpbWUgb2YgQmluZGluZ3Mv ZG9tLWF0dHJpYnV0ZXMuaHRtbAorICAgICAgICBpbiBvcmRlciB0byBhdm9pZCB0aW1lb3V0IGlu IENocm9taXVtLiBUaGUgcmVhc29uIGZvciB0aGUgdGltZW91dCBpcyB0aGF0CisgICAgICAgIFY4 IERPTSBiaW5kaW5ncyBhcmUgdG9vIG11Y2ggc2xvd2VyIHRoYW4gSlNDIGJpbmRpbmdzLgorICAg ICAgICBJIGFtIGEgYml0IGFmcmFpZCB0aGF0IHRoaXMgcGF0Y2ggd2lsbCByZWR1Y2UgdGhlIGFj Y3VyYWN5IG9mIHRoZQorICAgICAgICBwZXJmIHRlc3QgcmVzdWx0cywgYnV0IGl0IHdvdWxkIG1h a2Ugc2Vuc2UgdG8gcmVkdWNlIHRoZSBleGVjdXRpb24gdGltZQorICAgICAgICB1bnRpbCB3ZSBm aXggdGhlIHBlcmZvcm1hbmNlIGlzc3VlIGluIFY4IERPTSBiaW5kaW5ncy4KKworICAgICAgICAq IEJpbmRpbmdzL2RvbS1hdHRyaWJ1dGVzLmh0bWw6CisKIDIwMTItMDItMjQgIFJ5b3N1a2UgTml3 YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVuYW1lIGRvbSpfKmF0dHJpYnV0ZXMu aHRtbCB0byBkb20qLSphdHRyaWJ1dGVzLmh0bWwgdG8gZm9sbG93IHRoZSBXZWJLaXQgY29udmVu dGlvbi4K