79575 2012-02-25 10:42:46 -0800 Fix unused variable warnings in HarfBuzzShaperBase 2012-02-25 11:11:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne bashi enne oldest_to_newest 564983 0 enne 2012-02-25 10:42:46 -0800 Fix unused variable warnings in HarfBuzzShaperBase 564985 1 enne 2012-02-25 10:47:21 -0800 This was failing on ChromiumOS builds: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28tegra2%29/builds/4524/steps/cbuildbot/logs/stdio --SNIP-- third_party/WebKit/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: In function 'void WebCore::normalizeSpacesAndMirrorChars(const UChar*, UChar*, int, WebCore::HarfBuzzShaperBase::NormalizeMode)': chromeos-chrome-19.0.1053.0_alpha-r1: third_party/WebKit/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:58:10: error: variable 'error' set but not used [-Werror=unused-but-set-variable] chromeos-chrome-19.0.1053.0_alpha-r1: cc1plus: all warnings being treated as errors --SNIP-- 564986 2 128874 enne 2012-02-25 10:55:03 -0800 Created attachment 128874 Patch 564990 3 128875 enne 2012-02-25 11:07:44 -0800 Created attachment 128875 Use ASSERT_UNUSED 564992 4 enne 2012-02-25 11:11:41 -0800 Committed r108903: <http://trac.webkit.org/changeset/108903> 128874 2012-02-25 10:55:03 -0800 2012-02-25 11:07:30 -0800 Patch bug-79575-20120225105502.patch text/plain 1497 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVlNDk2YTI3YTcyYWE1 YTgxM2Y2ZDg5NTYxMTA1M2UyYmZlY2YyZS4uYzgwMmJjYzk2ZmUwZDFhYjI5NWE2MmE4OTdiNmZm M2FiODFlMjBkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTI1ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IHVudXNlZCB2YXJp YWJsZSB3YXJuaW5ncyBpbiBIYXJmQnV6elNoYXBlckJhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gYnVpbGRzIHdoZXJlIGFzc2VydHMgYXJlIG5v dCBlbmFibGVkLCB0aGUgZXJyb3IgdmFyaWFibGUgaXMgdW51c2VkLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXJCYXNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Om5vcm1hbGl6ZVNwYWNlc0FuZE1pcnJvckNoYXJzKToKKwogMjAxMi0wMi0yNSAg QW5kcmVhcyBLbGluZyAgPGF3ZXNvbWVrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3Zl IEhUTUxUYWJsZUVsZW1lbnQ6OmF0dGFjaCgpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXJCYXNlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0hhcmZCdXp6U2hhcGVyQmFzZS5j cHAKaW5kZXggYjhkYWZmOWUzYTA3YzUxMThiYTkyYjZkNmE4MDk2YjkzYTJiZWNjYy4uMzI0Yzdl NWNmY2Y4YmY0NmM0YTYzMGExNWEzMzFiYjcyMDllMGNjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXJCYXNlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9IYXJmQnV6elNo YXBlckJhc2UuY3BwCkBAIC01Niw2ICs1Niw4IEBAIHN0YXRpYyB2b2lkIG5vcm1hbGl6ZVNwYWNl c0FuZE1pcnJvckNoYXJzKGNvbnN0IFVDaGFyKiBzb3VyY2UsIFVDaGFyKiBkZXN0aW5hdGlvCiB7 CiAgICAgaW50IHBvc2l0aW9uID0gMDsKICAgICBib29sIGVycm9yID0gZmFsc2U7CisgICAgVU5V U0VEX1BBUkFNKGVycm9yKTsgLy8gUHJldmVudCB1bnVzZWQgdmFyaWFibGUgd2FybmluZ3MKKwog ICAgIC8vIEl0ZXJhdGUgY2hhcmFjdGVycyBpbiBzb3VyY2UgYW5kIG1pcnJvciBjaGFyYWN0ZXIg aWYgbmVlZGVkLgogICAgIHdoaWxlIChwb3NpdGlvbiA8IGxlbmd0aCkgewogICAgICAgICBVQ2hh cjMyIGNoYXJhY3RlcjsK 128875 2012-02-25 11:07:44 -0800 2012-02-25 11:10:00 -0800 Use ASSERT_UNUSED bug-79575-20120225110738.patch text/plain 1557 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVlNDk2YTI3YTcyYWE1 YTgxM2Y2ZDg5NTYxMTA1M2UyYmZlY2YyZS4uYzgwMmJjYzk2ZmUwZDFhYjI5NWE2MmE4OTdiNmZm M2FiODFlMjBkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTI1ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IHVudXNlZCB2YXJp YWJsZSB3YXJuaW5ncyBpbiBIYXJmQnV6elNoYXBlckJhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gYnVpbGRzIHdoZXJlIGFzc2VydHMgYXJlIG5v dCBlbmFibGVkLCB0aGUgZXJyb3IgdmFyaWFibGUgaXMgdW51c2VkLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXJCYXNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Om5vcm1hbGl6ZVNwYWNlc0FuZE1pcnJvckNoYXJzKToKKwogMjAxMi0wMi0yNSAg QW5kcmVhcyBLbGluZyAgPGF3ZXNvbWVrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3Zl IEhUTUxUYWJsZUVsZW1lbnQ6OmF0dGFjaCgpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXJCYXNlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0hhcmZCdXp6U2hhcGVyQmFzZS5j cHAKaW5kZXggYjhkYWZmOWUzYTA3YzUxMThiYTkyYjZkNmE4MDk2YjkzYTJiZWNjYy4uNTAwMmZk ZjZmNjM2N2VlOWE3OTdiOTAwNTFiNjEzY2U3YmM4Njg2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXJCYXNlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9IYXJmQnV6elNo YXBlckJhc2UuY3BwCkBAIC02OCw3ICs2OCw3IEBAIHN0YXRpYyB2b2lkIG5vcm1hbGl6ZVNwYWNl c0FuZE1pcnJvckNoYXJzKGNvbnN0IFVDaGFyKiBzb3VyY2UsIFVDaGFyKiBkZXN0aW5hdGlvCiAg ICAgICAgIGVsc2UgaWYgKG5vcm1hbGl6ZU1vZGUgPT0gSGFyZkJ1enpTaGFwZXJCYXNlOjpOb3Jt YWxpemVNaXJyb3JDaGFycykKICAgICAgICAgICAgIGNoYXJhY3RlciA9IHVfY2hhck1pcnJvcihj aGFyYWN0ZXIpOwogICAgICAgICBVMTZfQVBQRU5EKGRlc3RpbmF0aW9uLCBwb3NpdGlvbiwgbGVu Z3RoLCBjaGFyYWN0ZXIsIGVycm9yKTsKLSAgICAgICAgQVNTRVJUKCFlcnJvcik7CisgICAgICAg IEFTU0VSVF9VTlVTRUQoZXJyb3IsICFlcnJvcik7CiAgICAgICAgIHBvc2l0aW9uID0gbmV4dFBv c2l0aW9uOwogICAgIH0KIH0K