79570 2012-02-25 07:47:20 -0800 Web Inspector: [Extensions API] get rid of custom bind() in favor of built-in 2012-02-27 01:44:42 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq caseq apavlov bweinstein keishi loislo pfeldman pmuellr rik yurys oldest_to_newest 564952 0 caseq 2012-02-25 07:47:20 -0800 We used to have locally-defined bind() in ExtensionAPI.js for historical reasons. This switches ExtensionAPI.js over to built-in Function.prototype.bind(). 564954 1 128866 caseq 2012-02-25 07:48:26 -0800 Created attachment 128866 Patch 565472 2 caseq 2012-02-27 01:44:42 -0800 Committed r108972: <http://trac.webkit.org/changeset/108972> 128866 2012-02-25 07:48:26 -0800 2012-02-26 06:14:48 -0800 Patch bug-79570-20120225194824.patch text/plain 4492 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4ODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE0YWVmZDJlZjk4Njg1 NDBhNjJhZDM4NWRmMjBhN2FhMGJhMzViOS4uYzk3YzMyMzNhMThjZGQ3NDE5MjU5YTRmZTdlZDUy NGVlMWJiMjNlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTI1ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogW0V4dGVuc2lvbnMgQVBJXSBnaXQgcmlkIG9mIGN1c3RvbSBiaW5kKCkgaW4gZmF2b3Igb2Yg YnVpbHQtaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc5NTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qczoKKyAgICAgICAgKGluamVjdGVk RXh0ZW5zaW9uQVBJLkV2ZW50U2lua0ltcGwucHJvdG90eXBlLmFkZExpc3RlbmVyKToKKyAgICAg ICAgKGluamVjdGVkRXh0ZW5zaW9uQVBJKToKKyAgICAgICAgKGluamVjdGVkRXh0ZW5zaW9uQVBJ LlBhbmVscy5wcm90b3R5cGUuY3JlYXRlKToKKyAgICAgICAgKGluamVjdGVkRXh0ZW5zaW9uQVBJ LkF1ZGl0UmVzdWx0SW1wbCk6CisgICAgICAgIChpbmplY3RlZEV4dGVuc2lvbkFQSS5FeHRlbnNp b25TZXJ2ZXJDbGllbnQpOgorCiAyMDEyLTAyLTI1ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemlt bWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMDg1 NTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVu c2lvbkFQSS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9u QVBJLmpzCmluZGV4IDIyMGQ3OGJkZWM3YzlmZDZkNzVhMzg2NWI5OTJiYzdhY2U3ZmIxMWQuLmNl M2Y5NzZjZDhhNjhiYTBjNmEyMGY2MTQzYTA3MmJmNzYwYjJjYzggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uQVBJLmpzCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uQVBJLmpzCkBAIC0xMjUsNyAr MTI1LDcgQEAgRXZlbnRTaW5rSW1wbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICh0aGlzLl9s aXN0ZW5lcnMubGVuZ3RoID09PSAwKQogICAgICAgICAgICAgZXh0ZW5zaW9uU2VydmVyLnNlbmRS ZXF1ZXN0KHsgY29tbWFuZDogY29tbWFuZHMuU3Vic2NyaWJlLCB0eXBlOiB0aGlzLl90eXBlIH0p OwogICAgICAgICB0aGlzLl9saXN0ZW5lcnMucHVzaChjYWxsYmFjayk7Ci0gICAgICAgIGV4dGVu c2lvblNlcnZlci5yZWdpc3RlckhhbmRsZXIoIm5vdGlmeS0iICsgdGhpcy5fdHlwZSwgYmluZCh0 aGlzLl9kaXNwYXRjaCwgdGhpcykpOworICAgICAgICBleHRlbnNpb25TZXJ2ZXIucmVnaXN0ZXJI YW5kbGVyKCJub3RpZnktIiArIHRoaXMuX3R5cGUsIHRoaXMuX2Rpc3BhdGNoLmJpbmQodGhpcykp OwogICAgIH0sCiAKICAgICByZW1vdmVMaXN0ZW5lcjogZnVuY3Rpb24oY2FsbGJhY2spCkBAIC0y NzksNyArMjc5LDcgQEAgZnVuY3Rpb24gUGFuZWxzKCkKICAgICAgICAgcmV0dXJuIHBhbmVsc1tu YW1lXTsKICAgICB9CiAgICAgZm9yICh2YXIgcGFuZWwgaW4gcGFuZWxzKQotICAgICAgICB0aGlz Ll9fZGVmaW5lR2V0dGVyX18ocGFuZWwsIGJpbmQocGFuZWxHZXR0ZXIsIG51bGwsIHBhbmVsKSk7 CisgICAgICAgIHRoaXMuX19kZWZpbmVHZXR0ZXJfXyhwYW5lbCwgcGFuZWxHZXR0ZXIuYmluZChu dWxsLCBwYW5lbCkpOwogfQogCiBQYW5lbHMucHJvdG90eXBlID0gewpAQCAtMjkzLDcgKzI5Myw3 IEBAIFBhbmVscy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBpY29uOiBpY29uLAogICAgICAg ICAgICAgcGFnZTogcGFnZQogICAgICAgICB9OwotICAgICAgICBleHRlbnNpb25TZXJ2ZXIuc2Vu ZFJlcXVlc3QocmVxdWVzdCwgY2FsbGJhY2sgJiYgYmluZChjYWxsYmFjaywgdGhpcywgbmV3IEV4 dGVuc2lvblBhbmVsKGlkKSkpOworICAgICAgICBleHRlbnNpb25TZXJ2ZXIuc2VuZFJlcXVlc3Qo cmVxdWVzdCwgY2FsbGJhY2sgJiYgY2FsbGJhY2suYmluZCh0aGlzLCBuZXcgRXh0ZW5zaW9uUGFu ZWwoaWQpKSk7CiAgICAgfSwKIAogICAgIHNldE9wZW5SZXNvdXJjZUhhbmRsZXI6IGZ1bmN0aW9u KGNhbGxiYWNrKQpAQCAtNDk1LDkgKzQ5NSw5IEBAIGZ1bmN0aW9uIEF1ZGl0UmVzdWx0SW1wbChp ZCkKIHsKICAgICB0aGlzLl9pZCA9IGlkOwogCi0gICAgdGhpcy5jcmVhdGVVUkwgPSBiaW5kKHRo aXMuX25vZGVGYWN0b3J5LCBudWxsLCAidXJsIik7Ci0gICAgdGhpcy5jcmVhdGVTbmlwcGV0ID0g YmluZCh0aGlzLl9ub2RlRmFjdG9yeSwgbnVsbCwgInNuaXBwZXQiKTsKLSAgICB0aGlzLmNyZWF0 ZVRleHQgPSBiaW5kKHRoaXMuX25vZGVGYWN0b3J5LCBudWxsLCAidGV4dCIpOworICAgIHRoaXMu Y3JlYXRlVVJMID0gdGhpcy5fbm9kZUZhY3RvcnkuYmluZChudWxsLCAidXJsIik7CisgICAgdGhp cy5jcmVhdGVTbmlwcGV0ID0gdGhpcy5fbm9kZUZhY3RvcnkuYmluZChudWxsLCAic25pcHBldCIp OworICAgIHRoaXMuY3JlYXRlVGV4dCA9IHRoaXMuX25vZGVGYWN0b3J5LmJpbmQobnVsbCwgInRl eHQiKTsKIH0KIAogQXVkaXRSZXN1bHRJbXBsLnByb3RvdHlwZSA9IHsKQEAgLTY3NywxMSArNjc3 LDExIEBAIGZ1bmN0aW9uIEV4dGVuc2lvblNlcnZlckNsaWVudCgpCiAgICAgdGhpcy5fbGFzdFJl cXVlc3RJZCA9IDA7CiAgICAgdGhpcy5fbGFzdE9iamVjdElkID0gMDsKIAotICAgIHRoaXMucmVn aXN0ZXJIYW5kbGVyKCJjYWxsYmFjayIsIGJpbmQodGhpcy5fb25DYWxsYmFjaywgdGhpcykpOwor ICAgIHRoaXMucmVnaXN0ZXJIYW5kbGVyKCJjYWxsYmFjayIsIHRoaXMuX29uQ2FsbGJhY2suYmlu ZCh0aGlzKSk7CiAKICAgICB2YXIgY2hhbm5lbCA9IG5ldyBNZXNzYWdlQ2hhbm5lbCgpOwogICAg IHRoaXMuX3BvcnQgPSBjaGFubmVsLnBvcnQxOwotICAgIHRoaXMuX3BvcnQuYWRkRXZlbnRMaXN0 ZW5lcigibWVzc2FnZSIsIGJpbmQodGhpcy5fb25NZXNzYWdlLCB0aGlzKSwgZmFsc2UpOworICAg IHRoaXMuX3BvcnQuYWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIHRoaXMuX29uTWVzc2FnZS5i aW5kKHRoaXMpLCBmYWxzZSk7CiAgICAgdGhpcy5fcG9ydC5zdGFydCgpOwogCiAgICAgdG9wLnBv c3RNZXNzYWdlKCJyZWdpc3RlckV4dGVuc2lvbiIsIFsgY2hhbm5lbC5wb3J0MiBdLCAiKiIpOwpA QCAtNzQwLDE1ICs3NDAsNiBAQCBFeHRlbnNpb25TZXJ2ZXJDbGllbnQucHJvdG90eXBlID0gewog ICAgIH0KIH0KIAotLyoqCi0gKiBAcGFyYW0gey4uLip9IHZhcmFyZwotICovCi1mdW5jdGlvbiBi aW5kKGZ1bmMsIHRoaXNPYmplY3QsIHZhcmFyZykKLXsKLSAgICB2YXIgYXJncyA9IEFycmF5LnBy b3RvdHlwZS5zbGljZS5jYWxsKGFyZ3VtZW50cywgMik7Ci0gICAgcmV0dXJuIGZ1bmN0aW9uKCkg eyByZXR1cm4gZnVuYy5hcHBseSh0aGlzT2JqZWN0LCBhcmdzLmNvbmNhdChBcnJheS5wcm90b3R5 cGUuc2xpY2UuY2FsbChhcmd1bWVudHMsIDApKSk7IH07Ci19Ci0KIGZ1bmN0aW9uIHBvcHVsYXRl SW50ZXJmYWNlQ2xhc3MoaW50ZXJmYWNlLCBpbXBsZW1lbnRhdGlvbikKIHsKICAgICBmb3IgKHZh ciBtZW1iZXIgaW4gaW1wbGVtZW50YXRpb24pIHsKQEAgLTc2MSw5ICs3NTIsOSBAQCBmdW5jdGlv biBwb3B1bGF0ZUludGVyZmFjZUNsYXNzKGludGVyZmFjZSwgaW1wbGVtZW50YXRpb24pCiAgICAg ICAgIGlmICghZGVzY3JpcHRvcikKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBpZiAo dHlwZW9mIGRlc2NyaXB0b3IudmFsdWUgPT09ICJmdW5jdGlvbiIpCi0gICAgICAgICAgICBpbnRl cmZhY2VbbWVtYmVyXSA9IGJpbmQoZGVzY3JpcHRvci52YWx1ZSwgaW1wbGVtZW50YXRpb24pOwor ICAgICAgICAgICAgaW50ZXJmYWNlW21lbWJlcl0gPSBkZXNjcmlwdG9yLnZhbHVlLmJpbmQoaW1w bGVtZW50YXRpb24pOwogICAgICAgICBlbHNlIGlmICh0eXBlb2YgZGVzY3JpcHRvci5nZXQgPT09 ICJmdW5jdGlvbiIpCi0gICAgICAgICAgICBpbnRlcmZhY2UuX19kZWZpbmVHZXR0ZXJfXyhtZW1i ZXIsIGJpbmQoZGVzY3JpcHRvci5nZXQsIGltcGxlbWVudGF0aW9uKSk7CisgICAgICAgICAgICBp bnRlcmZhY2UuX19kZWZpbmVHZXR0ZXJfXyhtZW1iZXIsIGRlc2NyaXB0b3IuZ2V0LmJpbmQoaW1w bGVtZW50YXRpb24pKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgT2JqZWN0LmRlZmluZVBy b3BlcnR5KGludGVyZmFjZSwgbWVtYmVyLCBkZXNjcmlwdG9yKTsKICAgICB9Cg==