79556 2012-02-24 20:45:07 -0800 Fix the CopiedBlock offset alignment in a cross platform fashion 2012-02-27 10:48:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mhahnenberg mhahnenberg fpizlo harrison webkit.review.bot zherczeg oldest_to_newest 564849 0 mhahnenberg 2012-02-24 20:45:07 -0800 Differences in compilers can cause badness with the way we currently do the padding of CopiedBlock to ensure that the payload is 8-byte aligned. We can refactor CopiedBlock in such a way as to make this a non-issue. 564851 1 128846 mhahnenberg 2012-02-24 21:01:39 -0800 Created attachment 128846 Patch 564852 2 128846 fpizlo 2012-02-24 21:03:51 -0800 Comment on attachment 128846 Patch Looks right. 564890 3 webkit.review.bot 2012-02-25 00:06:15 -0800 The commit-queue encountered the following flaky tests while processing attachment 128846: inspector/protocol/console-agent.html bug 79563 (authors: caseq@chromium.org, loislo@chromium.org, and pfeldman@chromium.org) The commit-queue is continuing to process your patch. 564892 4 128846 webkit.review.bot 2012-02-25 00:07:59 -0800 Comment on attachment 128846 Patch Clearing flags on attachment: 128846 Committed r108888: <http://trac.webkit.org/changeset/108888> 564893 5 webkit.review.bot 2012-02-25 00:08:03 -0800 All reviewed patches have been landed. Closing bug. 564963 6 zherczeg 2012-02-25 09:19:08 -0800 Nice. m_dummy should be deleted as well. 565809 7 harrison 2012-02-27 10:48:36 -0800 Mark's comments in Radar that he believes this resolves rdar://10937628. 128846 2012-02-24 21:01:39 -0800 2012-02-25 00:07:59 -0800 Patch bug-79556-20120224210138.patch text/plain 6184 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4ODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ODBlOWUxMDY2ODdhOWM4YTU3ZDk2ZDAyOGZlNmU2Zjg3MDA0N2VlLi4yNGI2Y2YwMDgzYzEyMDBi NjNiMmNmZjhiYjhjYjFmMDI3ODI1N2M5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxMi0wMi0yNCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBw bGUuY29tPgorCisgICAgICAgIEZpeCB0aGUgQ29waWVkQmxvY2sgb2Zmc2V0IGFsaWdubWVudCBp biBhIGNyb3NzIHBsYXRmb3JtIGZhc2hpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc5NTU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVwbGFjZWQgbV9wYXlsb2FkIHdpdGggYSBwYXlsb2FkKCkgbWV0 aG9kIHRoYXQgY2FsY3VsYXRlcyB0aGUgb2Zmc2V0CisgICAgICAgIG9mIHRoZSBwYXlsb2FkIHdp dGggdGhlIHByb3BlciBhbGlnbm1lbnQuIFRoaXMgY2hhbmdlIGFsbG93cyB1cyB0byAKKyAgICAg ICAgYXZvaWQgYWxpZ25tZW50LXJlbGF0ZWQgaXNzdWVzIGluIGEgY3Jvc3MtcGxhdGZvcm0gbWFu bmVyLgorCisgICAgICAgICogaGVhcC9Db3BpZWRBbGxvY2F0b3IuaDoKKyAgICAgICAgKEpTQzo6 Q29waWVkQWxsb2NhdG9yOjpjdXJyZW50VXRpbGl6YXRpb24pOgorICAgICAgICAqIGhlYXAvQ29w aWVkQmxvY2suaDoKKyAgICAgICAgKEpTQzo6Q29waWVkQmxvY2s6OkNvcGllZEJsb2NrKToKKyAg ICAgICAgKEpTQzo6Q29waWVkQmxvY2s6OnBheWxvYWQpOgorICAgICAgICAoQ29waWVkQmxvY2sp OgorICAgICAgICAqIGhlYXAvQ29waWVkU3BhY2UuY3BwOgorICAgICAgICAoSlNDOjpDb3BpZWRT cGFjZTo6ZG9uZUZpbGxpbmdCbG9jayk6CisgICAgICAgICogaGVhcC9Db3BpZWRTcGFjZUlubGlu ZU1ldGhvZHMuaDoKKyAgICAgICAgKEpTQzo6Q29waWVkU3BhY2U6OmJvcnJvd0Jsb2NrKToKKyAg ICAgICAgKEpTQzo6Q29waWVkU3BhY2U6OmFsbG9jYXRlRnJvbUJsb2NrKToKKwogMjAxMi0wMi0y NCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCBXaW5kb3dzIGJ1aWxkIGZpeC4gIENoYW5nZWQgc2lnbmF0dXJlIGluIGV4cG9ydCB0byBt YXRjaApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkQWxsb2Nh dG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRBbGxvY2F0b3IuaAppbmRl eCBjNWJhNTBkNzhkNGMxMjcxMTU5YzcyYTQ4NDFlNjc0MGM3NmQ3YmVlLi41NTg1YjA4MTU3N2M3 MzJmMDY4NTRhOTVmNmY2ZWE5ZWRkZGNmNWIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9Db3BpZWRBbGxvY2F0b3IuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9Db3BpZWRBbGxvY2F0b3IuaApAQCAtOTMsNyArOTMsNyBAQCBpbmxpbmUgdm9pZCBDb3Bp ZWRBbGxvY2F0b3I6OnJlc2V0Q3VycmVudEJsb2NrKENvcGllZEJsb2NrKiBuZXdCbG9jaykKIAog aW5saW5lIHNpemVfdCBDb3BpZWRBbGxvY2F0b3I6OmN1cnJlbnRVdGlsaXphdGlvbigpCiB7Ci0g ICAgcmV0dXJuIHN0YXRpY19jYXN0PHNpemVfdD4obV9jdXJyZW50T2Zmc2V0IC0gbV9jdXJyZW50 QmxvY2stPm1fcGF5bG9hZCk7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PHNpemVfdD4obV9jdXJy ZW50T2Zmc2V0IC0gbV9jdXJyZW50QmxvY2stPnBheWxvYWQoKSk7CiB9CiAKIGlubGluZSB2b2lk IENvcGllZEFsbG9jYXRvcjo6cmVzZXRMYXN0QWxsb2NhdGlvbih2b2lkKiBwdHIpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRCbG9jay5oIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkQmxvY2suaAppbmRleCBhNTdjMTE1MGM0ODdlNGFlNWIx NzYyNzhmZjdlMDBkNjE0MzhlYTUwLi4xYjg2Y2MxMjZiYzg5OWVhODJlOWExY2Y1N2U1MWJiZTZh ZWVlNWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRCbG9j ay5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZEJsb2NrLmgKQEAgLTQw LDI2ICs0MCwzMSBAQCBjbGFzcyBDb3BpZWRCbG9jayA6IHB1YmxpYyBIZWFwQmxvY2sgewogcHVi bGljOgogICAgIENvcGllZEJsb2NrKFBhZ2VBbGxvY2F0aW9uQWxpZ25lZCYgYWxsb2NhdGlvbikK ICAgICAgICAgOiBIZWFwQmxvY2soYWxsb2NhdGlvbikKLSAgICAgICAgLCBtX29mZnNldChtX3Bh eWxvYWQpCisgICAgICAgICwgbV9vZmZzZXQocGF5bG9hZCgpKQogICAgICAgICAsIG1faXNQaW5u ZWQoZmFsc2UpCiAgICAgewotICAgICAgICBBU1NFUlQoaXM4Qnl0ZUFsaWduZWQoc3RhdGljX2Nh c3Q8dm9pZCo+KG1fcGF5bG9hZCkpKTsKKyAgICAgICAgQVNTRVJUKGlzOEJ5dGVBbGlnbmVkKHN0 YXRpY19jYXN0PHZvaWQqPihtX29mZnNldCkpKTsKICNpZiBVU0UoSlNWQUxVRTY0KQotICAgICAg ICBtZW1zZXQoc3RhdGljX2Nhc3Q8dm9pZCo+KG1fcGF5bG9hZCksIDAsIHN0YXRpY19jYXN0PHNp emVfdD4oKHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KHRoaXMpICsgYWxsb2NhdGlvbi5zaXplKCkp IC0gbV9wYXlsb2FkKSk7CisgICAgICAgIGNoYXIqIG9mZnNldCA9IHN0YXRpY19jYXN0PGNoYXIq PihtX29mZnNldCk7CisgICAgICAgIG1lbXNldChzdGF0aWNfY2FzdDx2b2lkKj4ob2Zmc2V0KSwg MCwgc3RhdGljX2Nhc3Q8c2l6ZV90PigocmVpbnRlcnByZXRfY2FzdDxjaGFyKj4odGhpcykgKyBh bGxvY2F0aW9uLnNpemUoKSkgLSBvZmZzZXQpKTsKICNlbHNlCiAgICAgICAgIEpTVmFsdWUgZW1w dHlWYWx1ZTsKICAgICAgICAgSlNWYWx1ZSogbGltaXQgPSByZWludGVycHJldF9jYXN0PEpTVmFs dWUqPihyZWludGVycHJldF9jYXN0PGNoYXIqPih0aGlzKSArIGFsbG9jYXRpb24uc2l6ZSgpKTsK LSAgICAgICAgZm9yIChKU1ZhbHVlKiBjdXJyZW50VmFsdWUgPSByZWludGVycHJldF9jYXN0PEpT VmFsdWUqPihtX3BheWxvYWQpOyBjdXJyZW50VmFsdWUgPCBsaW1pdDsgY3VycmVudFZhbHVlKysp CisgICAgICAgIGZvciAoSlNWYWx1ZSogY3VycmVudFZhbHVlID0gcmVpbnRlcnByZXRfY2FzdDxK U1ZhbHVlKj4obV9vZmZzZXQpOyBjdXJyZW50VmFsdWUgPCBsaW1pdDsgY3VycmVudFZhbHVlKysp CiAgICAgICAgICAgICAqY3VycmVudFZhbHVlID0gZW1wdHlWYWx1ZTsKICNlbmRpZgogICAgIH0K IAorICAgIGNoYXIqIHBheWxvYWQoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHJlaW50ZXJwcmV0 X2Nhc3Q8Y2hhcio+KHRoaXMpICsgKChzaXplb2YoQ29waWVkQmxvY2spICsgNykgJiB+Nyk7Cisg ICAgfQorCiBwcml2YXRlOgogICAgIHZvaWQqIG1fb2Zmc2V0OwogICAgIHVpbnRwdHJfdCBtX2lz UGlubmVkOwogICAgIHVpbnRwdHJfdCBtX3BhZGRpbmc7CiAgICAgdWludHB0cl90IG1fZHVtbXk7 Ci0gICAgY2hhciBtX3BheWxvYWRbMV07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBKU0MKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZFNwYWNlLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZFNwYWNlLmNwcAppbmRleCAzMzEwZDJjNTg0ZTNi N2Y4MTU1OWZjNTgwMThjOGEwMjRjNGJkYzA3Li5jODQ3MDEyMGY2NTIzYmI4NzRlNzAyNjNmNmJh YTY4MDk3ZWU3MmI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3Bp ZWRTcGFjZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2Uu Y3BwCkBAIC0xNTMsNyArMTUzLDcgQEAgdm9pZCBDb3BpZWRTcGFjZTo6ZG9uZUZpbGxpbmdCbG9j ayhDb3BpZWRCbG9jayogYmxvY2spCiAgICAgQVNTRVJUKGJsb2NrLT5tX29mZnNldCA8IHJlaW50 ZXJwcmV0X2Nhc3Q8Y2hhcio+KGJsb2NrKSArIEhlYXBCbG9jazo6c19ibG9ja1NpemUpOwogICAg IEFTU0VSVChtX2luQ29weWluZ1BoYXNlKTsKIAotICAgIGlmIChibG9jay0+bV9vZmZzZXQgPT0g YmxvY2stPm1fcGF5bG9hZCkgeworICAgIGlmIChibG9jay0+bV9vZmZzZXQgPT0gYmxvY2stPnBh eWxvYWQoKSkgewogICAgICAgICByZWN5Y2xlQmxvY2soYmxvY2spOwogICAgICAgICByZXR1cm47 CiAgICAgfQpAQCAtMTY3LDcgKzE2Nyw3IEBAIHZvaWQgQ29waWVkU3BhY2U6OmRvbmVGaWxsaW5n QmxvY2soQ29waWVkQmxvY2sqIGJsb2NrKQogCiAgICAgewogICAgICAgICBNdXRleExvY2tlciBs b2NrZXIobV9tZW1vcnlTdGF0c0xvY2spOwotICAgICAgICBtX3RvdGFsTWVtb3J5VXRpbGl6ZWQg Kz0gc3RhdGljX2Nhc3Q8c2l6ZV90PihzdGF0aWNfY2FzdDxjaGFyKj4oYmxvY2stPm1fb2Zmc2V0 KSAtIGJsb2NrLT5tX3BheWxvYWQpOworICAgICAgICBtX3RvdGFsTWVtb3J5VXRpbGl6ZWQgKz0g c3RhdGljX2Nhc3Q8c2l6ZV90PihzdGF0aWNfY2FzdDxjaGFyKj4oYmxvY2stPm1fb2Zmc2V0KSAt IGJsb2NrLT5wYXlsb2FkKCkpOwogICAgIH0KIAogICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZFNwYWNlSW5saW5lTWV0aG9kcy5oIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2VJbmxpbmVNZXRob2RzLmgKaW5kZXggOWExZjYz Y2VjNDM4YTNkMGNjNTg0OTA2MDkzMmY2ZGI3N2RkNzc3ZS4uMGIxYjM4ZDMyNjNiODU0MjA4MmE4 OWViNzg1MzNkN2QyMzg1YWVjMSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvQ29waWVkU3BhY2VJbmxpbmVNZXRob2RzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvQ29waWVkU3BhY2VJbmxpbmVNZXRob2RzLmgKQEAgLTkyLDcgKzkyLDcgQEAgaW5saW5l IENoZWNrZWRCb29sZWFuIENvcGllZFNwYWNlOjpib3Jyb3dCbG9jayhDb3BpZWRCbG9jayoqIG91 dEJsb2NrKQogICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX2xvYW5lZEJsb2Nrc0xvY2spOwogICAg IG1fbnVtYmVyT2ZMb2FuZWRCbG9ja3MrKzsKIAotICAgIEFTU0VSVChibG9jay0+bV9vZmZzZXQg PT0gYmxvY2stPm1fcGF5bG9hZCk7CisgICAgQVNTRVJUKGJsb2NrLT5tX29mZnNldCA9PSBibG9j ay0+cGF5bG9hZCgpKTsKICAgICAqb3V0QmxvY2sgPSBibG9jazsKICAgICByZXR1cm4gdHJ1ZTsK IH0KQEAgLTE1MSw5ICsxNTEsOSBAQCBpbmxpbmUgdm9pZCogQ29waWVkU3BhY2U6OmFsbG9jYXRl RnJvbUJsb2NrKENvcGllZEJsb2NrKiBibG9jaywgc2l6ZV90IGJ5dGVzKQogICAgIEFTU0VSVChp czhCeXRlQWxpZ25lZChibG9jay0+bV9vZmZzZXQpKTsKICAgICAKICAgICB2b2lkKiBwdHIgPSBi bG9jay0+bV9vZmZzZXQ7Ci0gICAgQVNTRVJUKGJsb2NrLT5tX29mZnNldCA+PSBibG9jay0+bV9w YXlsb2FkICYmIGJsb2NrLT5tX29mZnNldCA8IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGJsb2Nr KSArIEhlYXBCbG9jazo6c19ibG9ja1NpemUpOworICAgIEFTU0VSVChibG9jay0+bV9vZmZzZXQg Pj0gYmxvY2stPnBheWxvYWQoKSAmJiBibG9jay0+bV9vZmZzZXQgPCByZWludGVycHJldF9jYXN0 PGNoYXIqPihibG9jaykgKyBIZWFwQmxvY2s6OnNfYmxvY2tTaXplKTsKICAgICBibG9jay0+bV9v ZmZzZXQgPSBzdGF0aWNfY2FzdDx2b2lkKj4oKHN0YXRpY19jYXN0PGNoYXIqPihwdHIpICsgYnl0 ZXMpKTsKLSAgICBBU1NFUlQoYmxvY2stPm1fb2Zmc2V0ID49IGJsb2NrLT5tX3BheWxvYWQgJiYg YmxvY2stPm1fb2Zmc2V0IDwgcmVpbnRlcnByZXRfY2FzdDxjaGFyKj4oYmxvY2spICsgSGVhcEJs b2NrOjpzX2Jsb2NrU2l6ZSk7CisgICAgQVNTRVJUKGJsb2NrLT5tX29mZnNldCA+PSBibG9jay0+ cGF5bG9hZCgpICYmIGJsb2NrLT5tX29mZnNldCA8IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGJs b2NrKSArIEhlYXBCbG9jazo6c19ibG9ja1NpemUpOwogCiAgICAgQVNTRVJUKGlzOEJ5dGVBbGln bmVkKHB0cikpOwogICAgIHJldHVybiBwdHI7Cg==