79543 2012-02-24 16:14:54 -0800 [Qt] Use the existing inheritedOpacity/matrix properties of QSGNode 2012-03-03 11:27:00 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 79587 1 noam noam hausmann jturcotte menard ossy webkit.review.bot zoltan oldest_to_newest 564739 0 noam 2012-02-24 16:14:54 -0800 ... instead of figuring them out ourselves from the node tree. 564741 1 128826 noam 2012-02-24 16:19:25 -0800 Created attachment 128826 Patch 564940 2 128826 kenneth 2012-02-25 05:11:19 -0800 Comment on attachment 128826 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128826&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebpage_p_p.h:44 > + void paintToCurrentGLContext(const QTransform&, float); It is not obvious what the float represents here! 564953 3 128865 noam 2012-02-25 07:47:57 -0800 Created attachment 128865 Patch 564974 4 128865 webkit.review.bot 2012-02-25 09:59:44 -0800 Comment on attachment 128865 Patch Clearing flags on attachment: 128865 Committed r108900: <http://trac.webkit.org/changeset/108900> 564975 5 webkit.review.bot 2012-02-25 09:59:49 -0800 All reviewed patches have been landed. Closing bug. 565011 6 ossy 2012-02-25 13:26:00 -0800 Reopen, because it made API test crash. Could you fix it? 570161 7 130005 noam 2012-03-03 11:08:55 -0800 Created attachment 130005 Patch - fixed API test problem 570162 8 130005 webkit.review.bot 2012-03-03 11:26:56 -0800 Comment on attachment 130005 Patch - fixed API test problem Clearing flags on attachment: 130005 Committed r109664: <http://trac.webkit.org/changeset/109664> 570163 9 webkit.review.bot 2012-03-03 11:27:00 -0800 All reviewed patches have been landed. Closing bug. 128826 2012-02-24 16:19:25 -0800 2012-02-25 07:47:57 -0800 Patch bug-79543-20120224161922.patch text/plain 4117 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTJmOTJiNzQzOWQyMWM5 Yjk4OWE4Y2E1YzZiYzZkMWFkNjdmZjk5NC4uMTJmMzc1NWIyZjA2NjMzZGE1ZTVhZTU1OTBhNWQx Yjc1ZTEwNjA1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTI0ICBObydh bSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBV c2UgdGhlIGV4aXN0aW5nIGluaGVyaXRlZE9wYWNpdHkvbWF0cml4IHByb3BlcnRpZXMgb2YgUVNH Tm9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk1 NDMKKworICAgICAgICBVc2UgUVNHTm9kZTo6aW5oZXJpdGVkT3BhY2l0eSgpIGFuZCBRU0dOb2Rl OjptYXRyaXgoKS4KKyAgICAgICAgQWxzbywgcmVtb3ZlIGZsYWdzIGZyb20gY2hhbmdlZFN0YXRl cygpIHRoYXQgd2UgZG9uJ3QgYWN0dWFsbHkgdG91Y2guCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnBh Z2UuY3BwOgorICAgICAgICAoUVF1aWNrV2ViUGFnZVByaXZhdGU6OnBhaW50VG9DdXJyZW50R0xD b250ZXh0KToKKyAgICAgICAgKFBhZ2VQcm94eU5vZGU6OmNoYW5nZWRTdGF0ZXMpOgorICAgICAg ICAoUGFnZVByb3h5Tm9kZTo6cmVuZGVyKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Fx dWlja3dlYnBhZ2VfcF9wLmg6CisgICAgICAgIChRUXVpY2tXZWJQYWdlUHJpdmF0ZSk6CisKIDIw MTItMDItMjQgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBy ZXF1ZXN0UGVybWlzc2lvbiBjYWxsYmFjayBub3QgaW52b2tlZCBpZiB0aGUgV2ViUHJvY2VzcyBk b2Vzbid0IGhhdmUgdG8gYXNrIHRoZSBVSSBQcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJwYWdlLmNwcAppbmRleCBkMTY0YTZiODU4ZTMzN2U3 M2RhZWQ3NWFlOTE1NDk4MzkyNTJiZTQxLi5mOTkxMmFkMjlkNWM4Y2VhODVhMmJmNzhkZGIzNWI5 YjYxY2VhZjExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Fx dWlja3dlYnBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1 aWNrd2VicGFnZS5jcHAKQEAgLTYzLDE4ICs2Myw2IEBAIHZvaWQgUVF1aWNrV2ViUGFnZVByaXZh dGU6OmluaXRpYWxpemUoV2ViS2l0OjpXZWJQYWdlUHJveHkqIHdlYlBhZ2VQcm94eSkKICAgICBl dmVudEhhbmRsZXIucmVzZXQobmV3IFF0V2ViUGFnZUV2ZW50SGFuZGxlcih0b0FQSSh3ZWJQYWdl UHJveHkpLCBxLCB2aWV3cG9ydEl0ZW0pKTsKIH0KIAotc3RhdGljIGZsb2F0IGNvbXB1dGVFZmZl Y3RpdmVPcGFjaXR5KGNvbnN0IFFRdWlja0l0ZW0qIGl0ZW0pCi17Ci0gICAgaWYgKCFpdGVtKQot ICAgICAgICByZXR1cm4gMTsKLQotICAgIGZsb2F0IG9wYWNpdHkgPSBpdGVtLT5vcGFjaXR5KCk7 Ci0gICAgaWYgKG9wYWNpdHkgPCAwLjAxKQotICAgICAgICByZXR1cm4gMDsKLQotICAgIHJldHVy biBvcGFjaXR5ICogY29tcHV0ZUVmZmVjdGl2ZU9wYWNpdHkoaXRlbS0+cGFyZW50SXRlbSgpKTsK LX0KLQogdm9pZCBRUXVpY2tXZWJQYWdlUHJpdmF0ZTo6c2V0RHJhd2luZ0FyZWFTaXplKGNvbnN0 IFFTaXplJiBzaXplKQogewogICAgIERyYXdpbmdBcmVhUHJveHkqIGRyYXdpbmdBcmVhID0gd2Vi UGFnZVByb3h5LT5kcmF3aW5nQXJlYSgpOwpAQCAtODksMTUgKzc3LDExIEBAIHZvaWQgUVF1aWNr V2ViUGFnZVByaXZhdGU6OnBhaW50KFFQYWludGVyKiBwYWludGVyKQogICAgICAgICB3ZWJQYWdl UHJveHktPmRyYXdpbmdBcmVhKCktPnBhaW50TGF5ZXJUcmVlKHBhaW50ZXIpOwogfQogCi12b2lk IFFRdWlja1dlYlBhZ2VQcml2YXRlOjpwYWludFRvQ3VycmVudEdMQ29udGV4dCgpCit2b2lkIFFR dWlja1dlYlBhZ2VQcml2YXRlOjpwYWludFRvQ3VycmVudEdMQ29udGV4dChjb25zdCBRVHJhbnNm b3JtJiB0cmFuc2Zvcm0sIGZsb2F0IG9wYWNpdHkpCiB7CiAgICAgaWYgKCFxLT5pc1Zpc2libGUo KSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgUVRyYW5zZm9ybSB0cmFuc2Zvcm0gPSBxLT5pdGVt VHJhbnNmb3JtKDAsIDApOwotICAgIHRyYW5zZm9ybS5zY2FsZShjb250ZW50c1NjYWxlLCBjb250 ZW50c1NjYWxlKTsKLQotICAgIGZsb2F0IG9wYWNpdHkgPSBjb21wdXRlRWZmZWN0aXZlT3BhY2l0 eShxKTsKICAgICBRUmVjdEYgY2xpcFJlY3QgPSB2aWV3cG9ydEl0ZW0tPm1hcFJlY3RUb1NjZW5l KHZpZXdwb3J0SXRlbS0+Ym91bmRpbmdSZWN0KCkpOwogCiAgICAgaWYgKCFjbGlwUmVjdC5pc1Zh bGlkKCkpCkBAIC0xMDcsNyArOTEsNyBAQCB2b2lkIFFRdWlja1dlYlBhZ2VQcml2YXRlOjpwYWlu dFRvQ3VycmVudEdMQ29udGV4dCgpCiAgICAgaWYgKCFkcmF3aW5nQXJlYSkKICAgICAgICAgcmV0 dXJuOwogCi0gICAgZHJhd2luZ0FyZWEtPnBhaW50VG9DdXJyZW50R0xDb250ZXh0KHRyYW5zZm9y bSwgb3BhY2l0eSwgY2xpcFJlY3QpOworICAgIGRyYXdpbmdBcmVhLT5wYWludFRvQ3VycmVudEdM Q29udGV4dChRVHJhbnNmb3JtKHRyYW5zZm9ybSkuc2NhbGUoY29udGVudHNTY2FsZSwgY29udGVu dHNTY2FsZSksIG9wYWNpdHksIGNsaXBSZWN0KTsKIH0KIAogc3RydWN0IFBhZ2VQcm94eU5vZGUg OiBwdWJsaWMgUVNHUmVuZGVyTm9kZSB7CkBAIC0xMTgsMTQgKzEwMiwxMyBAQCBzdHJ1Y3QgUGFn ZVByb3h5Tm9kZSA6IHB1YmxpYyBRU0dSZW5kZXJOb2RlIHsKIAogICAgIHZpcnR1YWwgU3RhdGVG bGFncyBjaGFuZ2VkU3RhdGVzKCkKICAgICB7Ci0gICAgICAgIHJldHVybiBTdGF0ZUZsYWdzKERl cHRoU3RhdGUpIHwgU3RlbmNpbFN0YXRlIHwgU2Npc3NvclN0YXRlIHwgQ29sb3JTdGF0ZSB8IEJs ZW5kU3RhdGUKLSAgICAgICAgICAgICAgIHwgQ3VsbFN0YXRlIHwgVmlld3BvcnRTdGF0ZTsKKyAg ICAgICAgcmV0dXJuIFN0YXRlRmxhZ3MoU3RlbmNpbFN0YXRlKSB8IENvbG9yU3RhdGUgfCBCbGVu ZFN0YXRlOwogICAgIH0KIAotICAgIHZpcnR1YWwgdm9pZCByZW5kZXIoY29uc3QgUmVuZGVyU3Rh dGUgJikKKyAgICB2aXJ0dWFsIHZvaWQgcmVuZGVyKGNvbnN0IFJlbmRlclN0YXRlJikKICAgICB7 CiAgICAgICAgIGlmIChtX3BhZ2VQcml2YXRlKQotICAgICAgICAgICAgbV9wYWdlUHJpdmF0ZS0+ cGFpbnRUb0N1cnJlbnRHTENvbnRleHQoKTsKKyAgICAgICAgICAgIG1fcGFnZVByaXZhdGUtPnBh aW50VG9DdXJyZW50R0xDb250ZXh0KG1hdHJpeCgpLT50b1RyYW5zZm9ybSgpLCBpbmhlcml0ZWRP cGFjaXR5KCkpOwogICAgIH0KIAogICAgIH5QYWdlUHJveHlOb2RlKCkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2VicGFnZV9wX3AuaCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2VicGFnZV9wX3AuaAppbmRleCBkZmQy MjNkYmUzZWI4YzIyMTJkZmE3Njc3N2JhOTA1MTc5MzliMzkwLi5jMjExZjAyMTI2MDgzNzQzNjZh NzYyZjVmNTFjZjNjNzQxYjc1ODU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnBhZ2VfcF9wLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xcXVpY2t3ZWJwYWdlX3BfcC5oCkBAIC00MSw3ICs0MSw3IEBAIHB1YmxpYzoK IAogICAgIHZvaWQgdXBkYXRlU2l6ZSgpOwogCi0gICAgdm9pZCBwYWludFRvQ3VycmVudEdMQ29u dGV4dCgpOworICAgIHZvaWQgcGFpbnRUb0N1cnJlbnRHTENvbnRleHQoY29uc3QgUVRyYW5zZm9y bSYsIGZsb2F0KTsKICAgICB2b2lkIHBhaW50KFFQYWludGVyKik7CiAgICAgdm9pZCByZXNldFBh aW50Tm9kZSgpOwogCg== 128865 2012-02-25 07:47:57 -0800 2012-03-03 11:08:55 -0800 Patch patch.diff text/plain 4137 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTJmOTJiNzQzOWQyMWM5 Yjk4OWE4Y2E1YzZiYzZkMWFkNjdmZjk5NC4uMTJmMzc1NWIyZjA2NjMzZGE1ZTVhZTU1OTBhNWQx Yjc1ZTEwNjA1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTI0ICBObydh bSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBV c2UgdGhlIGV4aXN0aW5nIGluaGVyaXRlZE9wYWNpdHkvbWF0cml4IHByb3BlcnRpZXMgb2YgUVNH Tm9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzk1 NDMKKworICAgICAgICBVc2UgUVNHTm9kZTo6aW5oZXJpdGVkT3BhY2l0eSgpIGFuZCBRU0dOb2Rl OjptYXRyaXgoKS4KKyAgICAgICAgQWxzbywgcmVtb3ZlIGZsYWdzIGZyb20gY2hhbmdlZFN0YXRl cygpIHRoYXQgd2UgZG9uJ3QgYWN0dWFsbHkgdG91Y2guCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg S2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0 L3FxdWlja3dlYnBhZ2UuY3BwOgorICAgICAgICAoUVF1aWNrV2ViUGFnZVByaXZhdGU6OnBhaW50 VG9DdXJyZW50R0xDb250ZXh0KToKKyAgICAgICAgKFBhZ2VQcm94eU5vZGU6OmNoYW5nZWRTdGF0 ZXMpOgorICAgICAgICAoUGFnZVByb3h5Tm9kZTo6cmVuZGVyKToKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnBhZ2VfcF9wLmg6CisgICAgICAgIChRUXVpY2tXZWJQYWdlUHJp dmF0ZSk6CisKIDIwMTItMDItMjQgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4K IAogICAgICAgICByZXF1ZXN0UGVybWlzc2lvbiBjYWxsYmFjayBub3QgaW52b2tlZCBpZiB0aGUg V2ViUHJvY2VzcyBkb2Vzbid0IGhhdmUgdG8gYXNrIHRoZSBVSSBQcm9jZXNzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnBhZ2UuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJwYWdlLmNwcAppbmRleCBkMTY0 YTZiODU4ZTMzN2U3M2RhZWQ3NWFlOTE1NDk4MzkyNTJiZTQxLi5mOTkxMmFkMjlkNWM4Y2VhODVh MmJmNzhkZGIzNWI5YjYxY2VhZjExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2VicGFnZS5jcHAKQEAgLTYzLDE4ICs2Myw2IEBAIHZvaWQgUVF1aWNr V2ViUGFnZVByaXZhdGU6OmluaXRpYWxpemUoV2ViS2l0OjpXZWJQYWdlUHJveHkqIHdlYlBhZ2VQ cm94eSkKICAgICBldmVudEhhbmRsZXIucmVzZXQobmV3IFF0V2ViUGFnZUV2ZW50SGFuZGxlcih0 b0FQSSh3ZWJQYWdlUHJveHkpLCBxLCB2aWV3cG9ydEl0ZW0pKTsKIH0KIAotc3RhdGljIGZsb2F0 IGNvbXB1dGVFZmZlY3RpdmVPcGFjaXR5KGNvbnN0IFFRdWlja0l0ZW0qIGl0ZW0pCi17Ci0gICAg aWYgKCFpdGVtKQotICAgICAgICByZXR1cm4gMTsKLQotICAgIGZsb2F0IG9wYWNpdHkgPSBpdGVt LT5vcGFjaXR5KCk7Ci0gICAgaWYgKG9wYWNpdHkgPCAwLjAxKQotICAgICAgICByZXR1cm4gMDsK LQotICAgIHJldHVybiBvcGFjaXR5ICogY29tcHV0ZUVmZmVjdGl2ZU9wYWNpdHkoaXRlbS0+cGFy ZW50SXRlbSgpKTsKLX0KLQogdm9pZCBRUXVpY2tXZWJQYWdlUHJpdmF0ZTo6c2V0RHJhd2luZ0Fy ZWFTaXplKGNvbnN0IFFTaXplJiBzaXplKQogewogICAgIERyYXdpbmdBcmVhUHJveHkqIGRyYXdp bmdBcmVhID0gd2ViUGFnZVByb3h5LT5kcmF3aW5nQXJlYSgpOwpAQCAtODksMTUgKzc3LDExIEBA IHZvaWQgUVF1aWNrV2ViUGFnZVByaXZhdGU6OnBhaW50KFFQYWludGVyKiBwYWludGVyKQogICAg ICAgICB3ZWJQYWdlUHJveHktPmRyYXdpbmdBcmVhKCktPnBhaW50TGF5ZXJUcmVlKHBhaW50ZXIp OwogfQogCi12b2lkIFFRdWlja1dlYlBhZ2VQcml2YXRlOjpwYWludFRvQ3VycmVudEdMQ29udGV4 dCgpCit2b2lkIFFRdWlja1dlYlBhZ2VQcml2YXRlOjpwYWludFRvQ3VycmVudEdMQ29udGV4dChj b25zdCBRVHJhbnNmb3JtJiB0cmFuc2Zvcm0sIGZsb2F0IG9wYWNpdHkpCiB7CiAgICAgaWYgKCFx LT5pc1Zpc2libGUoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgUVRyYW5zZm9ybSB0cmFuc2Zv cm0gPSBxLT5pdGVtVHJhbnNmb3JtKDAsIDApOwotICAgIHRyYW5zZm9ybS5zY2FsZShjb250ZW50 c1NjYWxlLCBjb250ZW50c1NjYWxlKTsKLQotICAgIGZsb2F0IG9wYWNpdHkgPSBjb21wdXRlRWZm ZWN0aXZlT3BhY2l0eShxKTsKICAgICBRUmVjdEYgY2xpcFJlY3QgPSB2aWV3cG9ydEl0ZW0tPm1h cFJlY3RUb1NjZW5lKHZpZXdwb3J0SXRlbS0+Ym91bmRpbmdSZWN0KCkpOwogCiAgICAgaWYgKCFj bGlwUmVjdC5pc1ZhbGlkKCkpCkBAIC0xMDcsNyArOTEsNyBAQCB2b2lkIFFRdWlja1dlYlBhZ2VQ cml2YXRlOjpwYWludFRvQ3VycmVudEdMQ29udGV4dCgpCiAgICAgaWYgKCFkcmF3aW5nQXJlYSkK ICAgICAgICAgcmV0dXJuOwogCi0gICAgZHJhd2luZ0FyZWEtPnBhaW50VG9DdXJyZW50R0xDb250 ZXh0KHRyYW5zZm9ybSwgb3BhY2l0eSwgY2xpcFJlY3QpOworICAgIGRyYXdpbmdBcmVhLT5wYWlu dFRvQ3VycmVudEdMQ29udGV4dChRVHJhbnNmb3JtKHRyYW5zZm9ybSkuc2NhbGUoY29udGVudHNT Y2FsZSwgY29udGVudHNTY2FsZSksIG9wYWNpdHksIGNsaXBSZWN0KTsKIH0KIAogc3RydWN0IFBh Z2VQcm94eU5vZGUgOiBwdWJsaWMgUVNHUmVuZGVyTm9kZSB7CkBAIC0xMTgsMTQgKzEwMiwxMyBA QCBzdHJ1Y3QgUGFnZVByb3h5Tm9kZSA6IHB1YmxpYyBRU0dSZW5kZXJOb2RlIHsKIAogICAgIHZp cnR1YWwgU3RhdGVGbGFncyBjaGFuZ2VkU3RhdGVzKCkKICAgICB7Ci0gICAgICAgIHJldHVybiBT dGF0ZUZsYWdzKERlcHRoU3RhdGUpIHwgU3RlbmNpbFN0YXRlIHwgU2Npc3NvclN0YXRlIHwgQ29s b3JTdGF0ZSB8IEJsZW5kU3RhdGUKLSAgICAgICAgICAgICAgIHwgQ3VsbFN0YXRlIHwgVmlld3Bv cnRTdGF0ZTsKKyAgICAgICAgcmV0dXJuIFN0YXRlRmxhZ3MoU3RlbmNpbFN0YXRlKSB8IENvbG9y U3RhdGUgfCBCbGVuZFN0YXRlOwogICAgIH0KIAotICAgIHZpcnR1YWwgdm9pZCByZW5kZXIoY29u c3QgUmVuZGVyU3RhdGUgJikKKyAgICB2aXJ0dWFsIHZvaWQgcmVuZGVyKGNvbnN0IFJlbmRlclN0 YXRlJikKICAgICB7CiAgICAgICAgIGlmIChtX3BhZ2VQcml2YXRlKQotICAgICAgICAgICAgbV9w YWdlUHJpdmF0ZS0+cGFpbnRUb0N1cnJlbnRHTENvbnRleHQoKTsKKyAgICAgICAgICAgIG1fcGFn ZVByaXZhdGUtPnBhaW50VG9DdXJyZW50R0xDb250ZXh0KG1hdHJpeCgpLT50b1RyYW5zZm9ybSgp LCBpbmhlcml0ZWRPcGFjaXR5KCkpOwogICAgIH0KIAogICAgIH5QYWdlUHJveHlOb2RlKCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2VicGFnZV9w X3AuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2VicGFnZV9wX3Au aAppbmRleCBkZmQyMjNkYmUzZWI4YzIyMTJkZmE3Njc3N2JhOTA1MTc5MzliMzkwLi5jMjExZjAy MTI2MDgzNzQzNjZhNzYyZjVmNTFjZjNjNzQxYjc1ODU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnBhZ2VfcF9wLmgKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJwYWdlX3BfcC5oCkBAIC00MSw3ICs0MSw3 IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgdXBkYXRlU2l6ZSgpOwogCi0gICAgdm9pZCBwYWludFRv Q3VycmVudEdMQ29udGV4dCgpOworICAgIHZvaWQgcGFpbnRUb0N1cnJlbnRHTENvbnRleHQoY29u c3QgUVRyYW5zZm9ybSYsIGZsb2F0IG9wYWNpdHkpOwogICAgIHZvaWQgcGFpbnQoUVBhaW50ZXIq KTsKICAgICB2b2lkIHJlc2V0UGFpbnROb2RlKCk7CiAK 130005 2012-03-03 11:08:55 -0800 2012-03-03 11:26:55 -0800 Patch - fixed API test problem patch.diff text/plain 4031 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NWQxOTE3Li5iNjdlZDdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDMtMDMgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KKworICAgICAgICBbUXRdIFVzZSB0aGUgZXhpc3RpbmcgaW5oZXJpdGVkT3BhY2l0eS9tYXRy aXggcHJvcGVydGllcyBvZiBRU0dOb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03OTU0MworCisgICAgICAgIFVzZSBRU0dOb2RlOjppbmhlcml0ZWRP cGFjaXR5KCkgYW5kIFFTR05vZGU6Om1hdHJpeCgpLgorICAgICAgICBBbHNvLCByZW1vdmUgZmxh Z3MgZnJvbSBjaGFuZ2VkU3RhdGVzKCkgdGhhdCB3ZSBkb24ndCBhY3R1YWxseSB0b3VjaC4KKyAg ICAgICAgVGhpcyBpcyBjb3ZlcmVkIGJ5IGV4aXN0aW5nIEFQSSB0ZXN0cy4KKworICAgICAgICBS ZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvcXQvcXF1aWNrd2VicGFnZS5jcHA6CisgICAgICAgIChRUXVpY2tXZWJQYWdlUHJp dmF0ZTo6cGFpbnRUb0N1cnJlbnRHTENvbnRleHQpOgorICAgICAgICAoUGFnZVByb3h5Tm9kZTo6 Y2hhbmdlZFN0YXRlcyk6CisgICAgICAgIChQYWdlUHJveHlOb2RlOjpyZW5kZXIpOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2VicGFnZV9wX3AuaDoKKyAgICAgICAgKFFRdWlj a1dlYlBhZ2VQcml2YXRlKToKKwogMjAxMi0wMy0wMiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBs ZS5jb20+CiAKICAgICAgICAgTW92ZSBuc1N0cmluZ0Zyb21XZWJDb3JlU3RyaW5nIG91dCBvZiBQ YWdlQ2xpZW50SW1wbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1 aWNrd2VicGFnZS5jcHAKaW5kZXggZDE2NGE2Yi4uZDU4ZmVmZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJwYWdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnBhZ2UuY3BwCkBAIC02MywxOCArNjMs NiBAQCB2b2lkIFFRdWlja1dlYlBhZ2VQcml2YXRlOjppbml0aWFsaXplKFdlYktpdDo6V2ViUGFn ZVByb3h5KiB3ZWJQYWdlUHJveHkpCiAgICAgZXZlbnRIYW5kbGVyLnJlc2V0KG5ldyBRdFdlYlBh Z2VFdmVudEhhbmRsZXIodG9BUEkod2ViUGFnZVByb3h5KSwgcSwgdmlld3BvcnRJdGVtKSk7CiB9 CiAKLXN0YXRpYyBmbG9hdCBjb21wdXRlRWZmZWN0aXZlT3BhY2l0eShjb25zdCBRUXVpY2tJdGVt KiBpdGVtKQotewotICAgIGlmICghaXRlbSkKLSAgICAgICAgcmV0dXJuIDE7Ci0KLSAgICBmbG9h dCBvcGFjaXR5ID0gaXRlbS0+b3BhY2l0eSgpOwotICAgIGlmIChvcGFjaXR5IDwgMC4wMSkKLSAg ICAgICAgcmV0dXJuIDA7Ci0KLSAgICByZXR1cm4gb3BhY2l0eSAqIGNvbXB1dGVFZmZlY3RpdmVP cGFjaXR5KGl0ZW0tPnBhcmVudEl0ZW0oKSk7Ci19Ci0KIHZvaWQgUVF1aWNrV2ViUGFnZVByaXZh dGU6OnNldERyYXdpbmdBcmVhU2l6ZShjb25zdCBRU2l6ZSYgc2l6ZSkKIHsKICAgICBEcmF3aW5n QXJlYVByb3h5KiBkcmF3aW5nQXJlYSA9IHdlYlBhZ2VQcm94eS0+ZHJhd2luZ0FyZWEoKTsKQEAg LTg5LDE1ICs3NywxMSBAQCB2b2lkIFFRdWlja1dlYlBhZ2VQcml2YXRlOjpwYWludChRUGFpbnRl ciogcGFpbnRlcikKICAgICAgICAgd2ViUGFnZVByb3h5LT5kcmF3aW5nQXJlYSgpLT5wYWludExh eWVyVHJlZShwYWludGVyKTsKIH0KIAotdm9pZCBRUXVpY2tXZWJQYWdlUHJpdmF0ZTo6cGFpbnRU b0N1cnJlbnRHTENvbnRleHQoKQordm9pZCBRUXVpY2tXZWJQYWdlUHJpdmF0ZTo6cGFpbnRUb0N1 cnJlbnRHTENvbnRleHQoY29uc3QgUVRyYW5zZm9ybSYgdHJhbnNmb3JtLCBmbG9hdCBvcGFjaXR5 KQogewogICAgIGlmICghcS0+aXNWaXNpYmxlKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIFFU cmFuc2Zvcm0gdHJhbnNmb3JtID0gcS0+aXRlbVRyYW5zZm9ybSgwLCAwKTsKLSAgICB0cmFuc2Zv cm0uc2NhbGUoY29udGVudHNTY2FsZSwgY29udGVudHNTY2FsZSk7Ci0KLSAgICBmbG9hdCBvcGFj aXR5ID0gY29tcHV0ZUVmZmVjdGl2ZU9wYWNpdHkocSk7CiAgICAgUVJlY3RGIGNsaXBSZWN0ID0g dmlld3BvcnRJdGVtLT5tYXBSZWN0VG9TY2VuZSh2aWV3cG9ydEl0ZW0tPmJvdW5kaW5nUmVjdCgp KTsKIAogICAgIGlmICghY2xpcFJlY3QuaXNWYWxpZCgpKQpAQCAtMTA3LDcgKzkxLDcgQEAgdm9p ZCBRUXVpY2tXZWJQYWdlUHJpdmF0ZTo6cGFpbnRUb0N1cnJlbnRHTENvbnRleHQoKQogICAgIGlm ICghZHJhd2luZ0FyZWEpCiAgICAgICAgIHJldHVybjsKIAotICAgIGRyYXdpbmdBcmVhLT5wYWlu dFRvQ3VycmVudEdMQ29udGV4dCh0cmFuc2Zvcm0sIG9wYWNpdHksIGNsaXBSZWN0KTsKKyAgICBk cmF3aW5nQXJlYS0+cGFpbnRUb0N1cnJlbnRHTENvbnRleHQoUVRyYW5zZm9ybSh0cmFuc2Zvcm0p LnNjYWxlKGNvbnRlbnRzU2NhbGUsIGNvbnRlbnRzU2NhbGUpLCBvcGFjaXR5LCBjbGlwUmVjdCk7 CiB9CiAKIHN0cnVjdCBQYWdlUHJveHlOb2RlIDogcHVibGljIFFTR1JlbmRlck5vZGUgewpAQCAt MTE4LDE0ICsxMDIsMTUgQEAgc3RydWN0IFBhZ2VQcm94eU5vZGUgOiBwdWJsaWMgUVNHUmVuZGVy Tm9kZSB7CiAKICAgICB2aXJ0dWFsIFN0YXRlRmxhZ3MgY2hhbmdlZFN0YXRlcygpCiAgICAgewot ICAgICAgICByZXR1cm4gU3RhdGVGbGFncyhEZXB0aFN0YXRlKSB8IFN0ZW5jaWxTdGF0ZSB8IFNj aXNzb3JTdGF0ZSB8IENvbG9yU3RhdGUgfCBCbGVuZFN0YXRlCi0gICAgICAgICAgICAgICB8IEN1 bGxTdGF0ZSB8IFZpZXdwb3J0U3RhdGU7CisgICAgICAgIHJldHVybiBTdGF0ZUZsYWdzKFN0ZW5j aWxTdGF0ZSkgfCBDb2xvclN0YXRlIHwgQmxlbmRTdGF0ZTsKICAgICB9CiAKLSAgICB2aXJ0dWFs IHZvaWQgcmVuZGVyKGNvbnN0IFJlbmRlclN0YXRlICYpCisgICAgdmlydHVhbCB2b2lkIHJlbmRl cihjb25zdCBSZW5kZXJTdGF0ZSYpCiAgICAgewotICAgICAgICBpZiAobV9wYWdlUHJpdmF0ZSkK LSAgICAgICAgICAgIG1fcGFnZVByaXZhdGUtPnBhaW50VG9DdXJyZW50R0xDb250ZXh0KCk7Cisg ICAgICAgIGlmICghbV9wYWdlUHJpdmF0ZSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg UVRyYW5zZm9ybSB0cmFuc2Zvcm0gPSBtYXRyaXgoKSA/IG1hdHJpeCgpLT50b1RyYW5zZm9ybSgp IDogUVRyYW5zZm9ybSgpOworICAgICAgICBtX3BhZ2VQcml2YXRlLT5wYWludFRvQ3VycmVudEdM Q29udGV4dCh0cmFuc2Zvcm0sIGluaGVyaXRlZE9wYWNpdHkoKSk7CiAgICAgfQogCiAgICAgflBh Z2VQcm94eU5vZGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJwYWdlX3BfcC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x cXVpY2t3ZWJwYWdlX3BfcC5oCmluZGV4IGRmZDIyM2QuLmZhN2Q2OGMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2VicGFnZV9wX3AuaAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnBhZ2VfcF9wLmgKQEAgLTQx LDcgKzQxLDcgQEAgcHVibGljOgogCiAgICAgdm9pZCB1cGRhdGVTaXplKCk7CiAKLSAgICB2b2lk IHBhaW50VG9DdXJyZW50R0xDb250ZXh0KCk7CisgICAgdm9pZCBwYWludFRvQ3VycmVudEdMQ29u dGV4dChjb25zdCBRVHJhbnNmb3JtJiwgZmxvYXQgb3BhY2l0eSk7CiAgICAgdm9pZCBwYWludChR UGFpbnRlciopOwogICAgIHZvaWQgcmVzZXRQYWludE5vZGUoKTsKIAo=