79534 2012-02-24 14:52:03 -0800 [chromium] Provide DefaultDeviceScaleFactor though WebSettings 2012-02-28 15:05:44 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 tdresser webkit-unassigned ap darin ddkilzer fishd fsamuel joepeck rjkroege simon.fraser webkit.review.bot oldest_to_newest 564661 0 tdresser 2012-02-24 14:52:03 -0800 DefaultDeviceScaleFactor will be based solely on the screen DPI, as opposed to DeviceScaleFactor, which incorporates information from the viewport tag. 564682 1 128816 tdresser 2012-02-24 15:02:39 -0800 Created attachment 128816 Patch 564766 2 ap 2012-02-24 16:54:00 -0800 What does NOT FOR REVIEW in the bug title mean? Shouldn't it be on patch name instead? 565630 3 128816 rjkroege 2012-02-27 07:06:50 -0800 Comment on attachment 128816 Patch Looks reasonable to me. 565753 4 simon.fraser 2012-02-27 09:54:36 -0800 It's not clear to me that deviceScaleFactor should be affected by viewport tag settings. Would it change as the user zooms? 565811 5 rjkroege 2012-02-27 10:49:09 -0800 My apologies for the spam. I asked Tim to ask Darin, meaning fishd@ but he obediently added darin@ to the CC list. smfr@: in chromium, the viewport tag lets a web page author specify the devicePixelRatio of the page. However, we want the popup portion of <select> tags to obey the default device scale factor -- not a device scale factor modified by the viewport tag of the initiating page. Hence the additional integer parameter. fishd@: could you take a look at this CL? 567138 6 128816 webkit.review.bot 2012-02-28 15:05:39 -0800 Comment on attachment 128816 Patch Clearing flags on attachment: 128816 Committed r109155: <http://trac.webkit.org/changeset/109155> 567139 7 webkit.review.bot 2012-02-28 15:05:44 -0800 All reviewed patches have been landed. Closing bug. 128816 2012-02-24 15:02:39 -0800 2012-02-28 15:05:39 -0800 Patch bug-79534-20120224180238.patch text/plain 5918 tdresser U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4ODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJhOTc2ODBjNzY1Njc5 ZDk2YWJlYWEyNjU4NjkwMzE3Nzg3NDc4OC4uZTcxZDI5ZTYxMGQ2NjRhZDIxNzE4YTdiOTM3YmQ4 OTQxZTQ5OTk0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTI0ICBUaW0g RHJlc3NlciAgPHRkcmVzc2VyQGNocm9taXVtLm9yZz4KKworICAgICAgICBQcm92aWRlIERlZmF1 bHREZXZpY2VTY2FsZUZhY3RvciB0aG91Z2ggV2ViU2V0dGluZ3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NTM0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNldHRpbmdzOjpTZXR0aW5ncyk6CisgICAgICAgIChXZWJDb3JlOjpTZXR0 aW5nczo6c2V0RGVmYXVsdERldmljZVNjYWxlRmFjdG9yKToKKyAgICAgICAgKFdlYkNvcmUpOgor ICAgICAgICAqIHBhZ2UvU2V0dGluZ3MuaDoKKyAgICAgICAgKFNldHRpbmdzKToKKyAgICAgICAg KFdlYkNvcmU6OlNldHRpbmdzOjpkZWZhdWx0RGV2aWNlU2NhbGVGYWN0b3IpOgorCiAyMDEyLTAy LTI0ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IERvIG5vdCBzaG93IHNjcmlwdHMgcGFuZWwgbmF2aWdhdG9yIGF1dG9tYXRp Y2FsbHkgbW9yZSB0aGFuIG9uY2UgdG8gdGhlIHNhbWUgdXNlci4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKaW5kZXggMDE5ZGUzMTkwNTczNjUwOTk4MjdlYjljMTA3OWI3NzJhNDhkMGZjMy4uOTMz MmQ5MTU3YThmMmRmZmJmODRjZjRiMDU3NjgxNmNhZjllZjlmMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wMi0yNCAgVGltIERyZXNzZXIgIDx0ZHJl c3NlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUHJvdmlkZSBEZWZhdWx0RGV2aWNlU2NhbGVG YWN0b3IgdGhvdWdoIFdlYlNldHRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03OTUzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcHVibGljL1dlYlNldHRpbmdzLmg6CisgICAgICAgICogc3JjL1dl YlNldHRpbmdzSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlNldHRpbmdzSW1wbDo6c2V0 RGVmYXVsdERldmljZVNjYWxlRmFjdG9yKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICog c3JjL1dlYlNldHRpbmdzSW1wbC5oOgorICAgICAgICAoV2ViU2V0dGluZ3NJbXBsKToKKwogMjAx Mi0wMi0yNCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBOb3QgcmV2aWV3ZWQ6IGNocm9taXVtIGltYWdlIGZvciBpbnNwZWN0b3Igc3RhdHVzIGJhciBi dXR0b24gdXBkYXRlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3Mu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5jcHAKaW5kZXggZWM1MGY4OGM4ZTZh NDIyZmI5ZWY1MTBlYmI5NDM0ZGQ4YmY5ZjcxYi4uYzE5OTc2MmE3NzNiNjYxZTE5NTU3YzA2NTBk ZDU4ODRiNGJmZmQyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5jcHAKQEAgLTExNSw2ICsxMTUs NyBAQCBTZXR0aW5nczo6U2V0dGluZ3MoUGFnZSogcGFnZSkKICAgICAsIG1fbWluaW11bUxvZ2lj YWxGb250U2l6ZSgwKQogICAgICwgbV9kZWZhdWx0Rm9udFNpemUoMCkKICAgICAsIG1fZGVmYXVs dEZpeGVkRm9udFNpemUoMCkKKyAgICAsIG1fZGVmYXVsdERldmljZVNjYWxlRmFjdG9yKDEpCiAg ICAgLCBtX3ZhbGlkYXRpb25NZXNzYWdlVGltZXJNYWduaWZpY2F0aW9uKDUwKQogICAgICwgbV9t aW5pbXVtQWNjZWxlcmF0ZWQyZENhbnZhc1NpemUoMTI4ICogMTI4KQogICAgICwgbV9sYXlvdXRG YWxsYmFja1dpZHRoKDk4MCkKQEAgLTM2Myw2ICszNjQsMTEgQEAgdm9pZCBTZXR0aW5nczo6c2V0 RGVmYXVsdEZpeGVkRm9udFNpemUoaW50IGRlZmF1bHRGb250U2l6ZSkKICAgICBtX3BhZ2UtPnNl dE5lZWRzUmVjYWxjU3R5bGVJbkFsbEZyYW1lcygpOwogfQogCit2b2lkIFNldHRpbmdzOjpzZXRE ZWZhdWx0RGV2aWNlU2NhbGVGYWN0b3IoaW50IGRlZmF1bHREZXZpY2VTY2FsZUZhY3RvcikKK3sK KyAgICBtX2RlZmF1bHREZXZpY2VTY2FsZUZhY3RvciA9IGRlZmF1bHREZXZpY2VTY2FsZUZhY3Rv cjsKK30KKwogdm9pZCBTZXR0aW5nczo6c2V0TG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5KGJvb2wg bG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5KQogewogICAgIG1fbG9hZHNJbWFnZXNBdXRvbWF0aWNh bGx5ID0gbG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9TZXR0aW5ncy5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCmluZGV4 IGQzOTA2ZjFlNTU1MTc4ODJjZDk3Mzc4MTMyNjRmYTdiZDZlOWFhOTUuLjMyYWFiZDg0M2U5MTgy NzE5M2Y5NmJjM2Q4NDZjYmYxYTI4NDE0NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvU2V0dGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKQEAgLTEw Myw2ICsxMDMsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQgc2V0RGVmYXVs dEZpeGVkRm9udFNpemUoaW50KTsKICAgICAgICAgaW50IGRlZmF1bHRGaXhlZEZvbnRTaXplKCkg Y29uc3QgeyByZXR1cm4gbV9kZWZhdWx0Rml4ZWRGb250U2l6ZTsgfQogCisgICAgICAgIHZvaWQg c2V0RGVmYXVsdERldmljZVNjYWxlRmFjdG9yKGludCk7CisgICAgICAgIGludCBkZWZhdWx0RGV2 aWNlU2NhbGVGYWN0b3IoKSBjb25zdCB7IHJldHVybiBtX2RlZmF1bHREZXZpY2VTY2FsZUZhY3Rv cjsgfQorCiAgICAgICAgIC8vIFVubGlrZSBhcmVJbWFnZXNFbmFibGVkLCB0aGlzIG9ubHkgc3Vw cHJlc3NlcyB0aGUgbmV0d29yayBsb2FkIG9mCiAgICAgICAgIC8vIHRoZSBpbWFnZSBVUkwuICBB IGNhY2hlZCBpbWFnZSB3aWxsIHN0aWxsIGJlIHJlbmRlcmVkIGlmIHJlcXVlc3RlZC4KICAgICAg ICAgdm9pZCBzZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkoYm9vbCk7CkBAIC01NjIsNiArNTY1 LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBpbnQgbV9taW5pbXVtTG9naWNhbEZv bnRTaXplOwogICAgICAgICBpbnQgbV9kZWZhdWx0Rm9udFNpemU7CiAgICAgICAgIGludCBtX2Rl ZmF1bHRGaXhlZEZvbnRTaXplOworICAgICAgICBpbnQgbV9kZWZhdWx0RGV2aWNlU2NhbGVGYWN0 b3I7CiAgICAgICAgIGludCBtX3ZhbGlkYXRpb25NZXNzYWdlVGltZXJNYWduaWZpY2F0aW9uOwog ICAgICAgICBpbnQgbV9taW5pbXVtQWNjZWxlcmF0ZWQyZENhbnZhc1NpemU7CiAgICAgICAgIGlu dCBtX2xheW91dEZhbGxiYWNrV2lkdGg7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViU2V0dGluZ3MuaAppbmRleCA3ZjFiYmIwYzQ5Njk4ZGI5MjM2NGE1NjI4YWY1NGE1MTJmNTVl MTI1Li40N2FhZWVjZTBhZTIwOThlYzJhODg5MzUxZmFjODg0MTgxZDk3NDU2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgKQEAgLTYyLDYgKzYyLDcgQEAg cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXREZWZhdWx0Rml4ZWRGb250U2l6ZShpbnQpID0g MDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0TWluaW11bUZvbnRTaXplKGludCkgPSAwOwogICAgIHZp cnR1YWwgdm9pZCBzZXRNaW5pbXVtTG9naWNhbEZvbnRTaXplKGludCkgPSAwOworICAgIHZpcnR1 YWwgdm9pZCBzZXREZWZhdWx0RGV2aWNlU2NhbGVGYWN0b3IoaW50KSA9IDA7CiAgICAgdmlydHVh bCB2b2lkIHNldERlZmF1bHRUZXh0RW5jb2RpbmdOYW1lKGNvbnN0IFdlYlN0cmluZyYpID0gMDsK ICAgICB2aXJ0dWFsIHZvaWQgc2V0SmF2YVNjcmlwdEVuYWJsZWQoYm9vbCkgPSAwOwogICAgIHZp cnR1YWwgdm9pZCBzZXRXZWJTZWN1cml0eUVuYWJsZWQoYm9vbCkgPSAwOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAKaW5kZXggNDg1YTViMDUxYTAy NjIwOGJmNzZjODc2OTJjMzQxZmViNDI2ZjY1ZC4uM2IzYTg0Zjk4YjhiOTRmZjZhNmEwMGNhNTQz NzAwMmE3MzViZmRmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi U2V0dGluZ3NJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0 aW5nc0ltcGwuY3BwCkBAIC0xMDksNiArMTA5LDExIEBAIHZvaWQgV2ViU2V0dGluZ3NJbXBsOjpz ZXRNaW5pbXVtTG9naWNhbEZvbnRTaXplKGludCBzaXplKQogICAgIG1fc2V0dGluZ3MtPnNldE1p bmltdW1Mb2dpY2FsRm9udFNpemUoc2l6ZSk7CiB9CiAKK3ZvaWQgV2ViU2V0dGluZ3NJbXBsOjpz ZXREZWZhdWx0RGV2aWNlU2NhbGVGYWN0b3IoaW50IGRlZmF1bHREZXZpY2VTY2FsZUZhY3RvcikK K3sKKyAgICBtX3NldHRpbmdzLT5zZXREZWZhdWx0RGV2aWNlU2NhbGVGYWN0b3IoZGVmYXVsdERl dmljZVNjYWxlRmFjdG9yKTsKK30KKwogdm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldERlZmF1bHRU ZXh0RW5jb2RpbmdOYW1lKGNvbnN0IFdlYlN0cmluZyYgZW5jb2RpbmcpCiB7CiAgICAgbV9zZXR0 aW5ncy0+c2V0RGVmYXVsdFRleHRFbmNvZGluZ05hbWUoKFN0cmluZyllbmNvZGluZyk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oCmluZGV4IDUxZDkzMjNh NDA4ODI2ZTU0MWE5ZDMzZjAwNTE5ZGE5Y2EyZWE1NGUuLjcwMjRiNTE2NDM5YTdjOWM3YmZhNjA5 OGUxYTE4NWJjMDEwNDU4ZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlNldHRpbmdzSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNl dHRpbmdzSW1wbC5oCkBAIC01NCw2ICs1NCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQg c2V0RGVmYXVsdEZpeGVkRm9udFNpemUoaW50KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0TWluaW11 bUZvbnRTaXplKGludCk7CiAgICAgdmlydHVhbCB2b2lkIHNldE1pbmltdW1Mb2dpY2FsRm9udFNp emUoaW50KTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0RGVmYXVsdERldmljZVNjYWxlRmFjdG9yKGlu dCk7CiAgICAgdmlydHVhbCB2b2lkIHNldERlZmF1bHRUZXh0RW5jb2RpbmdOYW1lKGNvbnN0IFdl YlN0cmluZyYpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRKYXZhU2NyaXB0RW5hYmxlZChib29sKTsK ICAgICB2aXJ0dWFsIHZvaWQgc2V0V2ViU2VjdXJpdHlFbmFibGVkKGJvb2wpOwo=