79533 2012-02-24 14:49:10 -0800 More refactoring in RenderFlexibleBox 2012-02-24 17:46:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony ojan webkit.review.bot oldest_to_newest 564657 0 tony 2012-02-24 14:49:10 -0800 More refactoring in RenderFlexibleBox 564676 1 128815 tony 2012-02-24 15:00:03 -0800 Created attachment 128815 Patch 564787 2 128815 webkit.review.bot 2012-02-24 17:46:43 -0800 Comment on attachment 128815 Patch Clearing flags on attachment: 128815 Committed r108876: <http://trac.webkit.org/changeset/108876> 564788 3 webkit.review.bot 2012-02-24 17:46:47 -0800 All reviewed patches have been landed. Closing bug. 128815 2012-02-24 15:00:03 -0800 2012-02-24 17:46:43 -0800 Patch bug-79533-20120224150103.patch text/plain 5014 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4ODE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWE2MTNmNjI2MjJmZjdj NjNhZjNlNjU4MjhhOGE2YTdlNTkzNDgwYS4uZmE2NTMxZWExNDYxZDFlZWY4ZjdhZGQ3ODBkYzIy YTAyYjBjZmEyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTI0ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTW9yZSByZWZhY3RvcmluZyBp biBSZW5kZXJGbGV4aWJsZUJveAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Nzk1MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy RmxleGlibGVCb3g6OmxheW91dEZsZXhJdGVtcyk6IE1vdmUgdGhlIGZsaXBwaW5nIG9mIFJUTCtj b2x1bW4gcG9zaXRpb25zIHRvIGl0cyBvd24gbWV0aG9kLgorICAgICAgICBUaGlzIG1pZ2h0IGJl IGEgdGlueSBiaXQgc2xvd2VyLCBidXQgaXQncyBjbGVhcmVyIHNpbmNlIGl0J3Mgbm90IHJlbGF0 ZWQgdG8gYWxpZ25tZW50LgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxleGlibGVCb3g6Omxh eW91dEFuZFBsYWNlQ2hpbGRyZW4pOiBNb3ZlIHRoZSBsb2dpY2FsIGhlaWdodCBjYWxjdWxhdGlv biBvdXQgb2YgdGhlIGxvb3AuICBXZSBvbmx5IG5lZWQgdGhlIGZpbmFsIGhlaWdodC4KKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94OjphbGlnbkNoaWxkcmVuKToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94OjpmbGlwRm9yUmlnaHRUb0xlZnRDb2x1bW4pOgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5oOgorICAgICAgICAoUmVuZGVy RmxleGlibGVCb3gpOgorCiAyMDEyLTAyLTI0ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0 Lm9yZz4KIAogICAgICAgICBBdHRlbXB0IHRvIGZpeCB0aGUgV2luZG93cyBhbmQgV2luQ0UgYnVp bGQgYWZ0ZXIgY2hhbmdlc2V0IHIxMDg4MDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyRmxleGlibGVCb3guY3BwCmluZGV4IGYyZjk5M2Q3YjdmODNjNjQ4NGRmYzE2ZjRkZjQ0 ZTdhZjFkMGQ4MmYuLjZkMGI3NjExMzQ1MjRmYzg2YWM4N2EyNDRjYzkyMTJmMDE4YzdlOWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcApAQCAt NTIwLDYgKzUyMCw5IEBAIHZvaWQgUmVuZGVyRmxleGlibGVCb3g6OmxheW91dEZsZXhJdGVtcyhi b29sIHJlbGF5b3V0Q2hpbGRyZW4pCiAgICAgfQogCiAgICAgbGF5b3V0QW5kUGxhY2VDaGlsZHJl bihvcmRlcmVkQ2hpbGRyZW4sIGNoaWxkU2l6ZXMsIGF2YWlsYWJsZUZyZWVTcGFjZSk7CisKKyAg ICAvLyBkaXJlY3Rpb246cnRsICsgZmxleC1kaXJlY3Rpb246Y29sdW1uIG1lYW5zIHRoZSBjcm9z cy1heGlzIGRpcmVjdGlvbiBpcyBmbGlwcGVkLgorICAgIGZsaXBGb3JSaWdodFRvTGVmdENvbHVt bihmbGV4SXRlcmF0b3IpOwogfQogCiBmbG9hdCBSZW5kZXJGbGV4aWJsZUJveDo6cG9zaXRpdmVG bGV4Rm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCkgY29uc3QKQEAgLTc1OSwxMSArNzYyLDExIEBA IHZvaWQgUmVuZGVyRmxleGlibGVCb3g6OmxheW91dEFuZFBsYWNlQ2hpbGRyZW4oY29uc3QgT3Jk ZXJlZEZsZXhJdGVtTGlzdCYgY2hpbGRyCiAgICAgICAgIG1haW5BeGlzT2Zmc2V0ICs9IGNoaWxk TWFpbkV4dGVudCArIGZsb3dBd2FyZU1hcmdpbkVuZEZvckNoaWxkKGNoaWxkKTsKIAogICAgICAg ICBtYWluQXhpc09mZnNldCArPSBwYWNraW5nU3BhY2VCZXR3ZWVuQ2hpbGRyZW4oYXZhaWxhYmxl RnJlZVNwYWNlLCBzdHlsZSgpLT5mbGV4UGFjaygpLCBjaGlsZFNpemVzLnNpemUoKSk7Ci0KLSAg ICAgICAgaWYgKGlzQ29sdW1uRmxvdygpKQotICAgICAgICAgICAgc2V0TG9naWNhbEhlaWdodCht YWluQXhpc09mZnNldCArIGZsb3dBd2FyZUJvcmRlckVuZCgpICsgZmxvd0F3YXJlUGFkZGluZ0Vu ZCgpICsgc2Nyb2xsYmFyTG9naWNhbEhlaWdodCgpKTsKICAgICB9CiAKKyAgICBpZiAoaXNDb2x1 bW5GbG93KCkpCisgICAgICAgIHNldExvZ2ljYWxIZWlnaHQobWFpbkF4aXNPZmZzZXQgKyBmbG93 QXdhcmVCb3JkZXJFbmQoKSArIGZsb3dBd2FyZVBhZGRpbmdFbmQoKSArIHNjcm9sbGJhckxvZ2lj YWxIZWlnaHQoKSk7CisKICAgICBpZiAoc3R5bGUoKS0+ZmxleERpcmVjdGlvbigpID09IEZsb3dD b2x1bW5SZXZlcnNlKSB7CiAgICAgICAgIC8vIFdlIGhhdmUgdG8gZG8gYW4gZXh0cmEgcGFzcyBm b3IgY29sdW1uLXJldmVyc2UgdG8gcmVwb3NpdGlvbiB0aGUgZmxleCBpdGVtcyBzaW5jZSB0aGUg c3RhcnQgZGVwZW5kcwogICAgICAgICAvLyBvbiB0aGUgaGVpZ2h0IG9mIHRoZSBmbGV4Ym94LCB3 aGljaCB3ZSBvbmx5IGtub3cgYWZ0ZXIgd2UndmUgcG9zaXRpb25lZCBhbGwgdGhlIGZsZXggaXRl bXMuCkBAIC04MTgsOCArODIxLDYgQEAgdm9pZCBSZW5kZXJGbGV4aWJsZUJveDo6YWRqdXN0QWxp Z25tZW50Rm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCwgTGF5b3V0VW5pdCBkZWwKIAogdm9pZCBS ZW5kZXJGbGV4aWJsZUJveDo6YWxpZ25DaGlsZHJlbihjb25zdCBPcmRlcmVkRmxleEl0ZW1MaXN0 JiBjaGlsZHJlbiwgTGF5b3V0VW5pdCBtYXhBc2NlbnQpCiB7Ci0gICAgTGF5b3V0VW5pdCBjcm9z c0V4dGVudCA9IGNyb3NzQXhpc0V4dGVudCgpOwotCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkg PCBjaGlsZHJlbi5zaXplKCk7ICsraSkgewogICAgICAgICBSZW5kZXJCb3gqIGNoaWxkID0gY2hp bGRyZW5baV07CiAgICAgICAgIHN3aXRjaCAoZmxleEFsaWduRm9yQ2hpbGQoY2hpbGQpKSB7CkBA IC04NTYsMTQgKzg1NywxOSBAQCB2b2lkIFJlbmRlckZsZXhpYmxlQm94OjphbGlnbkNoaWxkcmVu KGNvbnN0IE9yZGVyZWRGbGV4SXRlbUxpc3QmIGNoaWxkcmVuLCBMYXlvdQogICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgfQorICAgIH0KK30KIAotICAgICAgICAvLyBkaXJl Y3Rpb246cnRsICsgZmxleC1kaXJlY3Rpb246Y29sdW1uIG1lYW5zIHRoZSBjcm9zcy1heGlzIGRp cmVjdGlvbiBpcyBmbGlwcGVkLgotICAgICAgICBpZiAoIXN0eWxlKCktPmlzTGVmdFRvUmlnaHRE aXJlY3Rpb24oKSAmJiBpc0NvbHVtbkZsb3coKSkgewotICAgICAgICAgICAgTGF5b3V0UG9pbnQg bG9jYXRpb24gPSBmbG93QXdhcmVMb2NhdGlvbkZvckNoaWxkKGNoaWxkKTsKLSAgICAgICAgICAg IGxvY2F0aW9uLnNldFkoY3Jvc3NFeHRlbnQgLSBjcm9zc0F4aXNFeHRlbnRGb3JDaGlsZChjaGls ZCkgLSBsb2NhdGlvbi55KCkpOwotICAgICAgICAgICAgc2V0Rmxvd0F3YXJlTG9jYXRpb25Gb3JD aGlsZChjaGlsZCwgbG9jYXRpb24pOwotICAgICAgICB9Cit2b2lkIFJlbmRlckZsZXhpYmxlQm94 OjpmbGlwRm9yUmlnaHRUb0xlZnRDb2x1bW4oRmxleE9yZGVySXRlcmF0b3ImIGl0ZXJhdG9yKQor eworICAgIGlmIChzdHlsZSgpLT5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCkgfHwgIWlzQ29sdW1u RmxvdygpKQorICAgICAgICByZXR1cm47CiAKKyAgICBMYXlvdXRVbml0IGNyb3NzRXh0ZW50ID0g Y3Jvc3NBeGlzRXh0ZW50KCk7CisgICAgZm9yIChSZW5kZXJCb3gqIGNoaWxkID0gaXRlcmF0b3Iu Zmlyc3QoKTsgY2hpbGQ7IGNoaWxkID0gaXRlcmF0b3IubmV4dCgpKSB7CisgICAgICAgIExheW91 dFBvaW50IGxvY2F0aW9uID0gZmxvd0F3YXJlTG9jYXRpb25Gb3JDaGlsZChjaGlsZCk7CisgICAg ICAgIGxvY2F0aW9uLnNldFkoY3Jvc3NFeHRlbnQgLSBjcm9zc0F4aXNFeHRlbnRGb3JDaGlsZChj aGlsZCkgLSBsb2NhdGlvbi55KCkpOworICAgICAgICBzZXRGbG93QXdhcmVMb2NhdGlvbkZvckNo aWxkKGNoaWxkLCBsb2NhdGlvbik7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJGbGV4aWJsZUJveC5oCmluZGV4IDBlZTcxNWY3ZWI4NDI3NWY2MWE2MDIxMmEw MzQ1NGYwNDdhMzYzODcuLmNhNWQ1OGE0YzQ1YzUxNjI4M2RhYzBkNGUxMGVhM2Y3OGY2ZWY2MDEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5oCkBAIC0x MDYsNiArMTA2LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGxheW91dEFuZFBsYWNlQ2hpbGRyZW4o Y29uc3QgT3JkZXJlZEZsZXhJdGVtTGlzdCYsIGNvbnN0IFdURjo6VmVjdG9yPExheW91dFVuaXQ+ JiBjaGlsZFNpemVzLCBMYXlvdXRVbml0IGF2YWlsYWJsZUZyZWVTcGFjZSk7CiAgICAgdm9pZCBs YXlvdXRDb2x1bW5SZXZlcnNlKGNvbnN0IE9yZGVyZWRGbGV4SXRlbUxpc3QmLCBjb25zdCBXVEY6 OlZlY3RvcjxMYXlvdXRVbml0PiYgY2hpbGRTaXplcywgTGF5b3V0VW5pdCBhdmFpbGFibGVGcmVl U3BhY2UpOwogICAgIHZvaWQgYWxpZ25DaGlsZHJlbihjb25zdCBPcmRlcmVkRmxleEl0ZW1MaXN0 JiwgTGF5b3V0VW5pdCBtYXhBc2NlbnQpOworICAgIHZvaWQgZmxpcEZvclJpZ2h0VG9MZWZ0Q29s dW1uKEZsZXhPcmRlckl0ZXJhdG9yJik7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==