79518 2012-02-24 12:05:50 -0800 Web Inspector: Close TabbedPanes on middle click of tab handle 2012-02-27 00:51:32 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 0 dbeam webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy vsevik webkit.review.bot yurys oldest_to_newest 564538 0 dbeam 2012-02-24 12:05:50 -0800 Corresponding webkit bug with patch to implement http://crbug.com/115551 If the feature ends up not being wanted, ignore this. 564540 1 128780 dbeam 2012-02-24 12:06:56 -0800 Created attachment 128780 Patch 564876 2 128780 apavlov 2012-02-24 22:43:27 -0800 Comment on attachment 128780 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128780&action=review > Source/WebCore/inspector/front-end/TabbedPane.js:619 > + if (event.button == 1 || event.target.classList.contains('tabbed-pane-header-tab-close-button')) Quotes are used instead of apostrophes for string literals across Web Inspector. Also, to determine if a CSS class is present on an element, you should use event.target.hasStyleClass("tabbed-pane-header-tab-close-button"); for better readability (Element.prototype.hasStyleClass is defined in utilities.js). 564882 3 128857 dbeam 2012-02-24 23:14:30 -0800 Created attachment 128857 Patch 564884 4 128857 apavlov 2012-02-24 23:21:59 -0800 Comment on attachment 128857 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128857&action=review You need a ChangeLog entry for WebKit patches as well. It can be put together by the Tools/Scripts/prepare-ChangeLog script. I believe having one, together with the comparison fix (see below), will qualify as a good patch. > Source/WebCore/inspector/front-end/TabbedPane.js:619 > + if (event.button == 1 || event.target.hasStyleClass("tabbed-pane-header-tab-close-button")) Sorry for overlooking this, we use the === comparison whenever possible. Also, don't forget to set the r? flag on the patches you upload for the review. 565015 5 128881 dbeam 2012-02-25 13:41:16 -0800 Created attachment 128881 Patch 565016 6 128882 dbeam 2012-02-25 13:46:59 -0800 Created attachment 128882 Patch 565017 7 webkit.review.bot 2012-02-25 13:52:52 -0800 Attachment 128882 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 565059 8 128895 dbeam 2012-02-25 17:01:06 -0800 Created attachment 128895 Patch 565163 9 128895 apavlov 2012-02-26 08:53:35 -0800 Comment on attachment 128895 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128895&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) ChangeLogs should never have the OOPS! string (there is a presubmit check that will prevent your patch from landing.) pfeldman and vsevik will know better if this functionality is/should be covered with a test. Otherwise the patch looks fine. 565165 10 128895 pfeldman 2012-02-26 09:31:02 -0800 Comment on attachment 128895 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128895&action=review Thanks for the fix, I'll fix the ChangeLog and land it. > Source/WebCore/ChangeLog:6 > + Reviewed by Alexander Pavlov. To avoid further confusion, let me clarify. ChangeLog must contain "Reviewed by NOBODY (OOPS!)." string. No other OOPS should be there. Reviewer is being filled in upon landing automatically. > Source/WebCore/inspector/front-end/TabbedPane.js:618 > + if (this._closeable && (event.button === 1 || event.target.hasStyleClass("tabbed-pane-header-tab-close-button"))) nit: I would make closeButtonSpan tab's field and compare it here. 565439 11 pfeldman 2012-02-27 00:51:32 -0800 Committed r108966: <http://trac.webkit.org/changeset/108966> 128780 2012-02-24 12:06:56 -0800 2012-02-24 23:14:30 -0800 Patch inspector_middle_click.patch text/plain 1512 dbeam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkUGFu ZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkUGFuZS5qcwpp bmRleCA0YjI0ZTg4Li4zZDlmNDIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9UYWJiZWRQYW5lLmpzCkBAIC01OTYsOSArNTk2LDcgQEAgV2ViSW5zcGVjdG9y LlRhYmJlZFBhbmVUYWIucHJvdG90eXBlID0gewogICAgICAgICAgICAgdGFiRWxlbWVudC5hZGRT dHlsZUNsYXNzKCJtZWFzdXJpbmciKTsKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICB0aGlz Ll90YWJFbGVtZW50ID0gdGFiRWxlbWVudDsKLSAgICAgICAgICAgIHRhYkVsZW1lbnQuYWRkRXZl bnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl90YWJTZWxlY3RlZC5iaW5kKHRoaXMpLCBmYWxzZSk7 Ci0gICAgICAgICAgICBpZiAodGhpcy5fY2xvc2VhYmxlKQotICAgICAgICAgICAgICAgIGNsb3Nl QnV0dG9uU3Bhbi5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX3RhYkNsb3NlZC5iaW5k KHRoaXMpLCBmYWxzZSk7CisgICAgICAgICAgICB0YWJFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIo ImNsaWNrIiwgdGhpcy5fdGFiQ2xpY2tlZC5iaW5kKHRoaXMpLCBmYWxzZSk7CiAgICAgICAgIH0K ICAgICAgICAgCiAgICAgICAgIHJldHVybiB0YWJFbGVtZW50OwpAQCAtNjEyLDEzICs2MTAsMTUg QEAgV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmVUYWIucHJvdG90eXBlID0gewogICAgICAgICB0aGlz Ll9tZWFzdXJlRWxlbWVudC5yZW1vdmVDaGlsZChtZWFzdXJpbmdUYWJFbGVtZW50KTsKICAgICB9 LAogCi0gICAgX3RhYlNlbGVjdGVkOiBmdW5jdGlvbigpCi0gICAgewotICAgICAgICB0aGlzLl90 YWJiZWRQYW5lLnNlbGVjdFRhYih0aGlzLmlkLCB0cnVlKTsgICAgICAgIAotICAgIH0sCi0KLSAg ICBfdGFiQ2xvc2VkOiBmdW5jdGlvbigpCisgICAgLyoqCisgICAgICogQHBhcmFtIHtFdmVudH0g ZXZlbnQKKyAgICAgKi8KKyAgICBfdGFiQ2xpY2tlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewot ICAgICAgICB0aGlzLl90YWJiZWRQYW5lLmNsb3NlVGFiKHRoaXMuaWQsIHRydWUpOyAgICAgICAg CisgICAgICAgIGlmICh0aGlzLl9jbG9zZWFibGUpIHsKKyAgICAgICAgICAgIGlmIChldmVudC5i dXR0b24gPT0gMSB8fCBldmVudC50YXJnZXQuY2xhc3NMaXN0LmNvbnRhaW5zKCd0YWJiZWQtcGFu ZS1oZWFkZXItdGFiLWNsb3NlLWJ1dHRvbicpKQorICAgICAgICAgICAgICAgIHRoaXMuX3RhYmJl ZFBhbmUuY2xvc2VUYWIodGhpcy5pZCwgdHJ1ZSk7CisgICAgICAgIH0gZWxzZQorICAgICAgICAg ICAgdGhpcy5fdGFiYmVkUGFuZS5zZWxlY3RUYWIodGhpcy5pZCwgdHJ1ZSk7CiAgICAgfQotfQpc IE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKK30K 128857 2012-02-24 23:14:30 -0800 2012-02-25 13:41:16 -0800 Patch inspector_middle_click.patch text/plain 1507 dbeam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkUGFu ZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkUGFuZS5qcwpp bmRleCA0YjI0ZTg4Li5lNDM0ZjlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9UYWJiZWRQYW5lLmpzCkBAIC01OTYsOSArNTk2LDcgQEAgV2ViSW5zcGVjdG9y LlRhYmJlZFBhbmVUYWIucHJvdG90eXBlID0gewogICAgICAgICAgICAgdGFiRWxlbWVudC5hZGRT dHlsZUNsYXNzKCJtZWFzdXJpbmciKTsKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICB0aGlz Ll90YWJFbGVtZW50ID0gdGFiRWxlbWVudDsKLSAgICAgICAgICAgIHRhYkVsZW1lbnQuYWRkRXZl bnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl90YWJTZWxlY3RlZC5iaW5kKHRoaXMpLCBmYWxzZSk7 Ci0gICAgICAgICAgICBpZiAodGhpcy5fY2xvc2VhYmxlKQotICAgICAgICAgICAgICAgIGNsb3Nl QnV0dG9uU3Bhbi5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX3RhYkNsb3NlZC5iaW5k KHRoaXMpLCBmYWxzZSk7CisgICAgICAgICAgICB0YWJFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIo ImNsaWNrIiwgdGhpcy5fdGFiQ2xpY2tlZC5iaW5kKHRoaXMpLCBmYWxzZSk7CiAgICAgICAgIH0K ICAgICAgICAgCiAgICAgICAgIHJldHVybiB0YWJFbGVtZW50OwpAQCAtNjEyLDEzICs2MTAsMTUg QEAgV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmVUYWIucHJvdG90eXBlID0gewogICAgICAgICB0aGlz Ll9tZWFzdXJlRWxlbWVudC5yZW1vdmVDaGlsZChtZWFzdXJpbmdUYWJFbGVtZW50KTsKICAgICB9 LAogCi0gICAgX3RhYlNlbGVjdGVkOiBmdW5jdGlvbigpCi0gICAgewotICAgICAgICB0aGlzLl90 YWJiZWRQYW5lLnNlbGVjdFRhYih0aGlzLmlkLCB0cnVlKTsgICAgICAgIAotICAgIH0sCi0KLSAg ICBfdGFiQ2xvc2VkOiBmdW5jdGlvbigpCisgICAgLyoqCisgICAgICogQHBhcmFtIHtFdmVudH0g ZXZlbnQKKyAgICAgKi8KKyAgICBfdGFiQ2xpY2tlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewot ICAgICAgICB0aGlzLl90YWJiZWRQYW5lLmNsb3NlVGFiKHRoaXMuaWQsIHRydWUpOyAgICAgICAg CisgICAgICAgIGlmICh0aGlzLl9jbG9zZWFibGUpIHsKKyAgICAgICAgICAgIGlmIChldmVudC5i dXR0b24gPT0gMSB8fCBldmVudC50YXJnZXQuaGFzU3R5bGVDbGFzcygidGFiYmVkLXBhbmUtaGVh ZGVyLXRhYi1jbG9zZS1idXR0b24iKSkKKyAgICAgICAgICAgICAgICB0aGlzLl90YWJiZWRQYW5l LmNsb3NlVGFiKHRoaXMuaWQsIHRydWUpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIHRo aXMuX3RhYmJlZFBhbmUuc2VsZWN0VGFiKHRoaXMuaWQsIHRydWUpOwogICAgIH0KLX0KXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlCit9Cg== 128881 2012-02-25 13:41:16 -0800 2012-02-25 13:46:59 -0800 Patch inspector_middle_click.patch text/plain 1487 dbeam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkUGFu ZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkUGFuZS5qcwpp bmRleCA0YjI0ZTg4Li42YTdiMTIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9UYWJiZWRQYW5lLmpzCkBAIC01OTYsOSArNTk2LDcgQEAgV2ViSW5zcGVjdG9y LlRhYmJlZFBhbmVUYWIucHJvdG90eXBlID0gewogICAgICAgICAgICAgdGFiRWxlbWVudC5hZGRT dHlsZUNsYXNzKCJtZWFzdXJpbmciKTsKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICB0aGlz Ll90YWJFbGVtZW50ID0gdGFiRWxlbWVudDsKLSAgICAgICAgICAgIHRhYkVsZW1lbnQuYWRkRXZl bnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl90YWJTZWxlY3RlZC5iaW5kKHRoaXMpLCBmYWxzZSk7 Ci0gICAgICAgICAgICBpZiAodGhpcy5fY2xvc2VhYmxlKQotICAgICAgICAgICAgICAgIGNsb3Nl QnV0dG9uU3Bhbi5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX3RhYkNsb3NlZC5iaW5k KHRoaXMpLCBmYWxzZSk7CisgICAgICAgICAgICB0YWJFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIo ImNsaWNrIiwgdGhpcy5fdGFiQ2xpY2tlZC5iaW5kKHRoaXMpLCBmYWxzZSk7CiAgICAgICAgIH0K ICAgICAgICAgCiAgICAgICAgIHJldHVybiB0YWJFbGVtZW50OwpAQCAtNjEyLDEzICs2MTAsMTQg QEAgV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmVUYWIucHJvdG90eXBlID0gewogICAgICAgICB0aGlz Ll9tZWFzdXJlRWxlbWVudC5yZW1vdmVDaGlsZChtZWFzdXJpbmdUYWJFbGVtZW50KTsKICAgICB9 LAogCi0gICAgX3RhYlNlbGVjdGVkOiBmdW5jdGlvbigpCi0gICAgewotICAgICAgICB0aGlzLl90 YWJiZWRQYW5lLnNlbGVjdFRhYih0aGlzLmlkLCB0cnVlKTsgICAgICAgIAotICAgIH0sCi0KLSAg ICBfdGFiQ2xvc2VkOiBmdW5jdGlvbigpCisgICAgLyoqCisgICAgICogQHBhcmFtIHtFdmVudH0g ZXZlbnQKKyAgICAgKi8KKyAgICBfdGFiQ2xpY2tlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewot ICAgICAgICB0aGlzLl90YWJiZWRQYW5lLmNsb3NlVGFiKHRoaXMuaWQsIHRydWUpOyAgICAgICAg CisgICAgICAgIGlmICh0aGlzLl9jbG9zZWFibGUgJiYgKGV2ZW50LmJ1dHRvbiA9PT0gMSB8fCBl dmVudC50YXJnZXQuaGFzU3R5bGVDbGFzcygidGFiYmVkLXBhbmUtaGVhZGVyLXRhYi1jbG9zZS1i dXR0b24iKSkpCisgICAgICAgICAgICB0aGlzLl90YWJiZWRQYW5lLmNsb3NlVGFiKHRoaXMuaWQs IHRydWUpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB0aGlzLl90YWJiZWRQYW5lLnNlbGVj dFRhYih0aGlzLmlkLCB0cnVlKTsKICAgICB9Ci19ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmls ZQorfQo= 128882 2012-02-25 13:46:59 -0800 2012-02-25 17:01:06 -0800 Patch inspector_middle_click.patch text/plain 2134 dbeam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MDAwZThiLi5mZGU0OTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDItMjUgIERhbiBCZWFtICA8ZGJlYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IENsb3NlIFRhYmJlZFBhbmVzIG9uIG1pZGRsZSBjbGljayBvZiB0YWIg aGFuZGxlCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGFuZGVyIFBhdmxvdi4KKworICAgICAg ICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv VGFiYmVkUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJiZWRQYW5lVGFiLnByb3Rv dHlwZS5fY3JlYXRlVGFiRWxlbWVudCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiYmVkUGFu ZVRhYi5wcm90b3R5cGUuX3RhYkNsaWNrZWQpOgorCiAyMDEyLTAyLTIzICBMZXZpIFdlaW50cmF1 YiAgPGxldml3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBTd2l0Y2ggZHJhd0xpbmVGb3JCb3hT aWRlIHRvIHVzZSBpbnRlZ2VycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9UYWJiZWRQYW5lLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9UYWJiZWRQYW5lLmpzCmluZGV4IDRiMjRlODguLjZhN2IxMjEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkUGFuZS5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUuanMKQEAgLTU5Niw5ICs1 OTYsNyBAQCBXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZVRhYi5wcm90b3R5cGUgPSB7CiAgICAgICAg ICAgICB0YWJFbGVtZW50LmFkZFN0eWxlQ2xhc3MoIm1lYXN1cmluZyIpOwogICAgICAgICBlbHNl IHsKICAgICAgICAgICAgIHRoaXMuX3RhYkVsZW1lbnQgPSB0YWJFbGVtZW50OwotICAgICAgICAg ICAgdGFiRWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX3RhYlNlbGVjdGVk LmJpbmQodGhpcyksIGZhbHNlKTsKLSAgICAgICAgICAgIGlmICh0aGlzLl9jbG9zZWFibGUpCi0g ICAgICAgICAgICAgICAgY2xvc2VCdXR0b25TcGFuLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwg dGhpcy5fdGFiQ2xvc2VkLmJpbmQodGhpcyksIGZhbHNlKTsKKyAgICAgICAgICAgIHRhYkVsZW1l bnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl90YWJDbGlja2VkLmJpbmQodGhpcyks IGZhbHNlKTsKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgcmV0dXJuIHRhYkVsZW1lbnQ7 CkBAIC02MTIsMTMgKzYxMCwxNCBAQCBXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZVRhYi5wcm90b3R5 cGUgPSB7CiAgICAgICAgIHRoaXMuX21lYXN1cmVFbGVtZW50LnJlbW92ZUNoaWxkKG1lYXN1cmlu Z1RhYkVsZW1lbnQpOwogICAgIH0sCiAKLSAgICBfdGFiU2VsZWN0ZWQ6IGZ1bmN0aW9uKCkKLSAg ICB7Ci0gICAgICAgIHRoaXMuX3RhYmJlZFBhbmUuc2VsZWN0VGFiKHRoaXMuaWQsIHRydWUpOyAg ICAgICAgCi0gICAgfSwKLQotICAgIF90YWJDbG9zZWQ6IGZ1bmN0aW9uKCkKKyAgICAvKioKKyAg ICAgKiBAcGFyYW0ge0V2ZW50fSBldmVudAorICAgICAqLworICAgIF90YWJDbGlja2VkOiBmdW5j dGlvbihldmVudCkKICAgICB7Ci0gICAgICAgIHRoaXMuX3RhYmJlZFBhbmUuY2xvc2VUYWIodGhp cy5pZCwgdHJ1ZSk7ICAgICAgICAKKyAgICAgICAgaWYgKHRoaXMuX2Nsb3NlYWJsZSAmJiAoZXZl bnQuYnV0dG9uID09PSAxIHx8IGV2ZW50LnRhcmdldC5oYXNTdHlsZUNsYXNzKCJ0YWJiZWQtcGFu ZS1oZWFkZXItdGFiLWNsb3NlLWJ1dHRvbiIpKSkKKyAgICAgICAgICAgIHRoaXMuX3RhYmJlZFBh bmUuY2xvc2VUYWIodGhpcy5pZCwgdHJ1ZSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHRo aXMuX3RhYmJlZFBhbmUuc2VsZWN0VGFiKHRoaXMuaWQsIHRydWUpOwogICAgIH0KLX0KXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlCit9Cg== 128895 2012-02-25 17:01:06 -0800 2012-02-26 09:31:02 -0800 Patch inspector_middle_click.patch text/plain 2189 dbeam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MDAwZThiLi5jNDg5NjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDItMjUgIERhbiBCZWFtICA8ZGJlYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IENsb3NlIFRhYmJlZFBhbmVzIG9uIG1pZGRsZSBjbGljayBvZiB0YWIg aGFuZGxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 OTUxOAorCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXhhbmRlciBQYXZsb3YuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Rh YmJlZFBhbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZVRhYi5wcm90b3R5 cGUuX2NyZWF0ZVRhYkVsZW1lbnQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmVU YWIucHJvdG90eXBlLl90YWJDbGlja2VkKToKKwogMjAxMi0wMi0yMyAgTGV2aSBXZWludHJhdWIg IDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU3dpdGNoIGRyYXdMaW5lRm9yQm94U2lk ZSB0byB1c2UgaW50ZWdlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvVGFiYmVkUGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGFiYmVkUGFuZS5qcwppbmRleCA0YjI0ZTg4Li42YTdiMTIxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UYWJiZWRQYW5lLmpzCkBAIC01OTYsOSArNTk2 LDcgQEAgV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmVUYWIucHJvdG90eXBlID0gewogICAgICAgICAg ICAgdGFiRWxlbWVudC5hZGRTdHlsZUNsYXNzKCJtZWFzdXJpbmciKTsKICAgICAgICAgZWxzZSB7 CiAgICAgICAgICAgICB0aGlzLl90YWJFbGVtZW50ID0gdGFiRWxlbWVudDsKLSAgICAgICAgICAg IHRhYkVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl90YWJTZWxlY3RlZC5i aW5kKHRoaXMpLCBmYWxzZSk7Ci0gICAgICAgICAgICBpZiAodGhpcy5fY2xvc2VhYmxlKQotICAg ICAgICAgICAgICAgIGNsb3NlQnV0dG9uU3Bhbi5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRo aXMuX3RhYkNsb3NlZC5iaW5kKHRoaXMpLCBmYWxzZSk7CisgICAgICAgICAgICB0YWJFbGVtZW50 LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fdGFiQ2xpY2tlZC5iaW5kKHRoaXMpLCBm YWxzZSk7CiAgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIHJldHVybiB0YWJFbGVtZW50OwpA QCAtNjEyLDEzICs2MTAsMTQgQEAgV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmVUYWIucHJvdG90eXBl ID0gewogICAgICAgICB0aGlzLl9tZWFzdXJlRWxlbWVudC5yZW1vdmVDaGlsZChtZWFzdXJpbmdU YWJFbGVtZW50KTsKICAgICB9LAogCi0gICAgX3RhYlNlbGVjdGVkOiBmdW5jdGlvbigpCi0gICAg ewotICAgICAgICB0aGlzLl90YWJiZWRQYW5lLnNlbGVjdFRhYih0aGlzLmlkLCB0cnVlKTsgICAg ICAgIAotICAgIH0sCi0KLSAgICBfdGFiQ2xvc2VkOiBmdW5jdGlvbigpCisgICAgLyoqCisgICAg ICogQHBhcmFtIHtFdmVudH0gZXZlbnQKKyAgICAgKi8KKyAgICBfdGFiQ2xpY2tlZDogZnVuY3Rp b24oZXZlbnQpCiAgICAgewotICAgICAgICB0aGlzLl90YWJiZWRQYW5lLmNsb3NlVGFiKHRoaXMu aWQsIHRydWUpOyAgICAgICAgCisgICAgICAgIGlmICh0aGlzLl9jbG9zZWFibGUgJiYgKGV2ZW50 LmJ1dHRvbiA9PT0gMSB8fCBldmVudC50YXJnZXQuaGFzU3R5bGVDbGFzcygidGFiYmVkLXBhbmUt aGVhZGVyLXRhYi1jbG9zZS1idXR0b24iKSkpCisgICAgICAgICAgICB0aGlzLl90YWJiZWRQYW5l LmNsb3NlVGFiKHRoaXMuaWQsIHRydWUpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB0aGlz Ll90YWJiZWRQYW5lLnNlbGVjdFRhYih0aGlzLmlkLCB0cnVlKTsKICAgICB9Ci19ClwgTm8gbmV3 bGluZSBhdCBlbmQgb2YgZmlsZQorfQo=