79495 2012-02-24 08:59:56 -0800 [GTK] FrameLoader signals: gtk-doc fixes 2012-03-07 00:30:20 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 pnormand pnormand cgarcia mrobinson oldest_to_newest 564351 0 pnormand 2012-02-24 08:59:56 -0800 +++ This bug was initially created as a clone of Bug #49543 +++ See https://bugs.webkit.org/show_bug.cgi?id=49543#c36 570590 1 cgarcia 2012-03-05 05:29:37 -0800 I've just added this to http://trac.webkit.org/wiki/WebKitGTK/1.8.x I think someone should fix this before 1.8, or roll the patch out. Note that the bug is not just about gtk-doc syntax errors. 570813 2 mrobinson 2012-03-05 10:10:15 -0800 (In reply to comment #1) > I've just added this to http://trac.webkit.org/wiki/WebKitGTK/1.8.x > > I think someone should fix this before 1.8, or roll the patch out. Note that the bug is not just about gtk-doc syntax errors. From your comment, you found both gtkdoc syntax errors and places where the documentation could be improved. Were there other problems as well? 571555 3 cgarcia 2012-03-05 23:45:59 -0800 The main problem for me with the patch is the lack of unit tests, but I would be happy just if the documentation is fixed. 571559 4 pnormand 2012-03-05 23:54:50 -0800 (In reply to comment #3) > The main problem for me with the patch is the lack of unit tests, but I would be happy just if the documentation is fixed. That patch unskipped a good number of layout tests though and that new API is used in DRT. I don't see the point of adding unit tests in that case. 571571 5 pnormand 2012-03-06 00:07:58 -0800 Ok let's do this.. 571576 6 cgarcia 2012-03-06 00:12:11 -0800 (In reply to comment #4) > (In reply to comment #3) > > The main problem for me with the patch is the lack of unit tests, but I would be happy just if the documentation is fixed. > > That patch unskipped a good number of layout tests though and that new API is used in DRT. I don't see the point of adding unit tests in that case. If the patch had included unit tests, you would have noticed that length-received is not the length of the resource, but the length of the data chunk received and that it can be emitted multiple times, for example. Unit test are useful to make sure that API works for multiple uses, I haven't looked at how DRT use the API, but I guess it doesn't use all the API (signals and methods) exposed. 571590 7 130319 pnormand 2012-03-06 00:42:09 -0800 Created attachment 130319 Patch 571603 8 130319 cgarcia 2012-03-06 00:50:43 -0800 Comment on attachment 130319 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130319&action=review Thanks for fixing this. > Source/WebKit/gtk/webkit/webkitwebframe.cpp:400 > + * Emitted when new resource data has been received. The > + * @length_received variable stores the amount of bytes received so > + * far. This is useful to provide progress information about the No, the value is not accumulated, it's the length of the chunk received, no the total amount of data received so far. 571806 9 mrobinson 2012-03-06 06:38:43 -0800 (In reply to comment #6) > If the patch had included unit tests, you would have noticed that length-received is not the length of the resource, but the length of the data chunk received and that it can be emitted multiple times, for example. Unit test are useful to make sure that API works for multiple uses, I haven't looked at how DRT use the API, but I guess it doesn't use all the API (signals and methods) exposed. If there is no layout test covering this, then it makes sense to add one. 571809 10 cgarcia 2012-03-06 06:46:32 -0800 (In reply to comment #9) > (In reply to comment #6) > > > If the patch had included unit tests, you would have noticed that length-received is not the length of the resource, but the length of the data chunk received and that it can be emitted multiple times, for example. Unit test are useful to make sure that API works for multiple uses, I haven't looked at how DRT use the API, but I guess it doesn't use all the API (signals and methods) exposed. > > If there is no layout test covering this, then it makes sense to add one. It's my opinion, I'm not saying phil did wrong not including unit tests in the patch, I just think that all patches adding new API should include unit tests even if the API is used by other tests. Typically the only tests that check every method, signal, etc. exposed by the API are unit tests. I think layout tests are complementary to unit tests. I can be wrong of course. 572385 11 130319 mrobinson 2012-03-06 18:05:19 -0800 Comment on attachment 130319 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130319&action=review >> Source/WebKit/gtk/webkit/webkitwebframe.cpp:400 >> + * far. This is useful to provide progress information about the > > No, the value is not accumulated, it's the length of the chunk received, no the total amount of data received so far. I'll fix this and land the patch. 572418 12 mrobinson 2012-03-06 18:35:07 -0800 (In reply to comment #11) > (From update of attachment 130319 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130319&action=review > > >> Source/WebKit/gtk/webkit/webkitwebframe.cpp:400 > >> + * far. This is useful to provide progress information about the > > > > No, the value is not accumulated, it's the length of the chunk received, no the total amount of data received so far. > > I'll fix this and land the patch. I think it makes sense to rename this signal. It seems that the name resource-content-length-received is a weird side effect of the Objective-C naming scheme. It's very odd! I think a better name would be resource-content-received. The name resource-content-length-received suggests that the Content-Length header of the HTTP header has been parsed, so I think it could be quite confusing. 572423 13 mrobinson 2012-03-06 18:38:02 -0800 (In reply to comment #12) > I think it makes sense to rename this signal. It seems that the name resource-content-length-received is a weird side effect of the Objective-C naming scheme. It's very odd! I think a better name would be resource-content-received. The name resource-content-length-received suggests that the Content-Length header of the HTTP header has been parsed, so I think it could be quite confusing. Well, it looks like we've already pushed this in 1.7.5, so we cannot change the signal name now. We should just verify that we fix the issue in WebKit2, I guess. 572426 14 mrobinson 2012-03-06 18:40:56 -0800 Committed r109997: <http://trac.webkit.org/changeset/109997> 572640 15 cgarcia 2012-03-07 00:29:34 -0800 (In reply to comment #12) > (In reply to comment #11) > > (From update of attachment 130319 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=130319&action=review > > > > >> Source/WebKit/gtk/webkit/webkitwebframe.cpp:400 > > >> + * far. This is useful to provide progress information about the > > > > > > No, the value is not accumulated, it's the length of the chunk received, no the total amount of data received so far. > > > > I'll fix this and land the patch. > > I think it makes sense to rename this signal. It seems that the name resource-content-length-received is a weird side effect of the Objective-C naming scheme. It's very odd! I think a better name would be resource-content-received. The name resource-content-length-received suggests that the Content-Length header of the HTTP header has been parsed, so I think it could be quite confusing. Yes, that's exactly why used a different name in wk2. Both Downloads API and Resources patch use received-data 572641 16 cgarcia 2012-03-07 00:30:20 -0800 (In reply to comment #13) > (In reply to comment #12) > > > I think it makes sense to rename this signal. It seems that the name resource-content-length-received is a weird side effect of the Objective-C naming scheme. It's very odd! I think a better name would be resource-content-received. The name resource-content-length-received suggests that the Content-Length header of the HTTP header has been parsed, so I think it could be quite confusing. > > Well, it looks like we've already pushed this in 1.7.5, so we cannot change the signal name now. We should just verify that we fix the issue in WebKit2, I guess. In wk2 it's called received-data for consistency with the downloads API. 130319 2012-03-06 00:42:09 -0800 2012-03-06 18:05:19 -0800 Patch bug-79495-20120306094207.patch text/plain 11945 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5ODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMzBiMjUwNGJh OWVmZGY5MTY4MGMyYTc3NDUwMjJlMzkwZTk5MmM5My4uMzIxOWIxZjYyMGUzOTA4MTA2MGMwZjA4 MjgyZjhiY2NkYjA3MzFmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTAzLTA2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBGcmFtZUxvYWRlciBzaWduYWxzOiBndGstZG9jIGZpeGVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTQ5NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYmZyYW1l LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfZnJhbWVfY2xhc3NfaW5pdCk6CisgICAgICAgICog d2Via2l0L3dlYmtpdHdlYnJlc291cmNlLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfcmVzb3Vy Y2VfY2xhc3NfaW5pdCk6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAg ICAgICAod2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorCiAyMDEyLTAzLTA1ICBaYW4gRG9i ZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgW0dUS10gcGx1Z2lucy9u ZXRzY2FwZS1wbHVnaW4tcGFnZS1jYWNoZS13b3Jrcy5odG1sIGZhaWxzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwIGIvU291cmNlL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcAppbmRleCA0ZGUxOTI3MDQzNjJmM2E5NGZj YjgyNTJmYjVlYzcwNmQ2NDVjMmY5Li40NDU3ODliMjNkNGEzMGJmYjc3NWMyYzVmOWY3MGI1MmYw Mzg1ODVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViZnJh bWUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAK QEAgLTM1MSwxMyArMzUxLDEzIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfZnJhbWVfY2xhc3Nf aW5pdChXZWJLaXRXZWJGcmFtZUNsYXNzKiBmcmFtZUNsYXNzKQogICAgICAgICAgICAgV0VCS0lU X1RZUEVfTkVUV09SS19SRVFVRVNULAogICAgICAgICAgICAgV0VCS0lUX1RZUEVfTkVUV09SS19S RVNQT05TRSk7CiAKLSAgICAvKgotICAgICAqIFdlYktpdFdlYkZyYW1lOjpyZXNvdXJjZS1yZXNw b25zZS1yZWNlaXZlZAotICAgICAqIEB3ZWJGcmFtZTogdGhlICNXZWJLaXRXZWJGcmFtZSB0aGUg cmVzcG9uc2Ugd2FzIHJlY2VpdmVkIGZvcgotICAgICAqIEB3ZWJSZXNvdXJjZTogdGhlICNXZWJL aXRXZWJSZXNvdXJjZSBiZWluZyBsb2FkZWQKKyAgICAvKioKKyAgICAgKiBXZWJLaXRXZWJGcmFt ZTo6cmVzb3VyY2UtcmVzcG9uc2UtcmVjZWl2ZWQ6CisgICAgICogQHdlYl9mcmFtZTogdGhlICNX ZWJLaXRXZWJGcmFtZSB0aGUgcmVzcG9uc2Ugd2FzIHJlY2VpdmVkIGZvcgorICAgICAqIEB3ZWJf cmVzb3VyY2U6IHRoZSAjV2ViS2l0V2ViUmVzb3VyY2UgYmVpbmcgbG9hZGVkCiAgICAgICogQHJl c3BvbnNlOiB0aGUgI1dlYktpdE5ldHdvcmtSZXNwb25zZSB0aGF0IHdhcyByZWNlaXZlZC4KICAg ICAgKgotICAgICAqIEVtaXR0ZWQgd2hlbiB0aGUgZmlyc3QgYnl0ZSBvZiBkYXRhIGFycml2ZXMK KyAgICAgKiBFbWl0dGVkIHdoZW4gdGhlIHJlc3BvbnNlIGlzIHJlY2VpdmVkIGZyb20gdGhlIHNl cnZlci4KICAgICAgKgogICAgICAqIFNpbmNlOiAxLjcuNQogICAgICAqLwpAQCAtMzcxLDEwICsz NzEsMTAgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9mcmFtZV9jbGFzc19pbml0KFdlYktpdFdl YkZyYW1lQ2xhc3MqIGZyYW1lQ2xhc3MpCiAgICAgICAgICAgICBXRUJLSVRfVFlQRV9XRUJfUkVT T1VSQ0UsCiAgICAgICAgICAgICBXRUJLSVRfVFlQRV9ORVRXT1JLX1JFU1BPTlNFKTsKIAotICAg IC8qCi0gICAgICogV2ViS2l0V2ViRnJhbWU6OnJlc291cmNlLWxvYWQtZmluaXNoZWQKLSAgICAg KiBAd2ViRnJhbWU6IHRoZSAjV2ViS2l0V2ViRnJhbWUgdGhlIHJlc3BvbnNlIHdhcyByZWNlaXZl ZCBmb3IKLSAgICAgKiBAd2ViUmVzb3VyY2U6IHRoZSAjV2ViS2l0V2ViUmVzb3VyY2UgYmVpbmcg bG9hZGVkCisgICAgLyoqCisgICAgICogV2ViS2l0V2ViRnJhbWU6OnJlc291cmNlLWxvYWQtZmlu aXNoZWQ6CisgICAgICogQHdlYl9mcmFtZTogdGhlICNXZWJLaXRXZWJGcmFtZSB0aGUgcmVzcG9u c2Ugd2FzIHJlY2VpdmVkIGZvcgorICAgICAqIEB3ZWJfcmVzb3VyY2U6IHRoZSAjV2ViS2l0V2Vi UmVzb3VyY2UgYmVpbmcgbG9hZGVkCiAgICAgICoKICAgICAgKiBFbWl0dGVkIHdoZW4gYWxsIHRo ZSBkYXRhIGZvciB0aGUgcmVzb3VyY2Ugd2FzIGxvYWRlZC4KICAgICAgKgpAQCAtMzg5LDEzICsz ODksMTYgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9mcmFtZV9jbGFzc19pbml0KFdlYktpdFdl YkZyYW1lQ2xhc3MqIGZyYW1lQ2xhc3MpCiAgICAgICAgICAgICBHX1RZUEVfTk9ORSwgMSwKICAg ICAgICAgICAgIFdFQktJVF9UWVBFX1dFQl9SRVNPVVJDRSk7CiAKLSAgICAvKgotICAgICAqIFdl YktpdFdlYkZyYW1lOjpyZXNvdXJjZS1jb250ZW50LWxlbmd0aC1yZWNlaXZlZAotICAgICAqIEB3 ZWJGcmFtZTogdGhlICNXZWJLaXRXZWJGcmFtZSB0aGUgcmVzcG9uc2Ugd2FzIHJlY2VpdmVkIGZv cgotICAgICAqIEB3ZWJSZXNvdXJjZTogdGhlICNXZWJLaXRXZWJSZXNvdXJjZSB0aGF0IHdhcyBs b2FkZWQKLSAgICAgKiBAbGVuZ3RoUmVjZWl2ZWQ6IHRoZSByZXNvdXJjZSBkYXRhIGxlbmd0aCBp biBieXRlcworICAgIC8qKgorICAgICAqIFdlYktpdFdlYkZyYW1lOjpyZXNvdXJjZS1jb250ZW50 LWxlbmd0aC1yZWNlaXZlZDoKKyAgICAgKiBAd2ViX2ZyYW1lOiB0aGUgI1dlYktpdFdlYkZyYW1l IHRoZSByZXNwb25zZSB3YXMgcmVjZWl2ZWQgZm9yCisgICAgICogQHdlYl9yZXNvdXJjZTogdGhl ICNXZWJLaXRXZWJSZXNvdXJjZSB0aGF0IHdhcyBsb2FkZWQKKyAgICAgKiBAbGVuZ3RoX3JlY2Vp dmVkOiB0aGUgbGVuZ3RoIGluIGJ5dGVzIG9mIHJlc291cmNlIHJlY2VpdmVkIHNvIGZhcgogICAg ICAqCi0gICAgICogRW1pdHRlZCB3aGVuIGFsbCB0aGUgZGF0YSBmb3IgdGhlIHJlc291cmNlIHdh cyBsb2FkZWQuCisgICAgICogRW1pdHRlZCB3aGVuIG5ldyByZXNvdXJjZSBkYXRhIGhhcyBiZWVu IHJlY2VpdmVkLiBUaGUKKyAgICAgKiBAbGVuZ3RoX3JlY2VpdmVkIHZhcmlhYmxlIHN0b3JlcyB0 aGUgYW1vdW50IG9mIGJ5dGVzIHJlY2VpdmVkIHNvCisgICAgICogZmFyLiBUaGlzIGlzIHVzZWZ1 bCB0byBwcm92aWRlIHByb2dyZXNzIGluZm9ybWF0aW9uIGFib3V0IHRoZQorICAgICAqIHJlc291 cmNlIGxvYWQgb3BlcmF0aW9uLgogICAgICAqCiAgICAgICogU2luY2U6IDEuNy41CiAgICAgICov CkBAIC00MDksMTEgKzQxMiwxMSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX2ZyYW1lX2NsYXNz X2luaXQoV2ViS2l0V2ViRnJhbWVDbGFzcyogZnJhbWVDbGFzcykKICAgICAgICAgICAgIFdFQktJ VF9UWVBFX1dFQl9SRVNPVVJDRSwKICAgICAgICAgICAgIEdfVFlQRV9JTlQpOwogCi0gICAgLyoK LSAgICAgKiBXZWJLaXRXZWJGcmFtZTo6cmVzb3VyY2UtbG9hZC1mYWlsZWQKLSAgICAgKiBAd2Vi RnJhbWU6IHRoZSAjV2ViS2l0V2ViRnJhbWUgdGhlIHJlc3BvbnNlIHdhcyByZWNlaXZlZCBmb3IK LSAgICAgKiBAd2ViUmVzb3VyY2U6IHRoZSAjV2ViS2l0V2ViUmVzb3VyY2UgdGhhdCB3YXMgbG9h ZGVkCi0gICAgICogQHdlYkVycm9yOiB0aGUgI0dFcnJvciB0aGF0IHdhcyB0cmlnZ2VyZWQKKyAg ICAvKioKKyAgICAgKiBXZWJLaXRXZWJGcmFtZTo6cmVzb3VyY2UtbG9hZC1mYWlsZWQ6CisgICAg ICogQHdlYl9mcmFtZTogdGhlICNXZWJLaXRXZWJGcmFtZSB0aGUgcmVzcG9uc2Ugd2FzIHJlY2Vp dmVkIGZvcgorICAgICAqIEB3ZWJfcmVzb3VyY2U6IHRoZSAjV2ViS2l0V2ViUmVzb3VyY2UgdGhh dCB3YXMgbG9hZGVkCisgICAgICogQGVycm9yOiB0aGUgI0dFcnJvciB0aGF0IHdhcyB0cmlnZ2Vy ZWQKICAgICAgKgogICAgICAqIEludm9rZWQgd2hlbiBhIHJlc291cmNlIGZhaWxlZCB0byBsb2Fk LgogICAgICAqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi cmVzb3VyY2UuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnJlc291cmNl LmNwcAppbmRleCBmMzIzOTYyNmJmZjQ5YWEwNDJhMDJjOWY2ODMyZDMwYjVkM2QwZTgzLi5kNzFh MTE1ODEzN2UyNjFlNWNkYTBiZTgxNDlmMDY1NjRmNmRjMGI5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicmVzb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJyZXNvdXJjZS5jcHAKQEAgLTEyMiwxMiArMTIyLDEyIEBA IHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfcmVzb3VyY2VfY2xhc3NfaW5pdChXZWJLaXRXZWJSZXNv dXJjZUNsYXNzKiB3ZWJSZXNvdXJjZUNsCiAgICAgZ29iamVjdF9jbGFzcy0+Z2V0X3Byb3BlcnR5 ID0gd2Via2l0X3dlYl9yZXNvdXJjZV9nZXRfcHJvcGVydHk7CiAgICAgZ29iamVjdF9jbGFzcy0+ c2V0X3Byb3BlcnR5ID0gd2Via2l0X3dlYl9yZXNvdXJjZV9zZXRfcHJvcGVydHk7CiAKLSAgICAv KgotICAgICAqIFdlYktpdFdlYlJlc291cmNlOjpyZXNwb25zZS1yZWNlaXZlZAotICAgICAqIEB3 ZWJSZXNvdXJjZTogdGhlICNXZWJLaXRXZWJSZXNvdXJjZSBiZWluZyBsb2FkZWQKKyAgICAvKioK KyAgICAgKiBXZWJLaXRXZWJSZXNvdXJjZTo6cmVzcG9uc2UtcmVjZWl2ZWQ6CisgICAgICogQHdl Yl9yZXNvdXJjZTogdGhlICNXZWJLaXRXZWJSZXNvdXJjZSBiZWluZyBsb2FkZWQKICAgICAgKiBA cmVzcG9uc2U6IHRoZSAjV2ViS2l0TmV0d29ya1Jlc3BvbnNlIHRoYXQgd2FzIHJlY2VpdmVkCiAg ICAgICoKLSAgICAgKiBFbWl0dGVkIHdoZW4gdGhlIGZpcnN0IGJ5dGUgb2YgZGF0YSBhcnJpdmVz CisgICAgICogRW1pdHRlZCB3aGVuIHRoZSByZXNwb25zZSBpcyByZWNlaXZlZCBmcm9tIHRoZSBz ZXJ2ZXIuCiAgICAgICoKICAgICAgKiBTaW5jZTogMS43LjUKICAgICAgKi8KQEAgLTE0MCwxMiAr MTQwLDEyIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfcmVzb3VyY2VfY2xhc3NfaW5pdChXZWJL aXRXZWJSZXNvdXJjZUNsYXNzKiB3ZWJSZXNvdXJjZUNsCiAgICAgICAgICAgICBHX1RZUEVfTk9O RSwgMSwKICAgICAgICAgICAgIFdFQktJVF9UWVBFX05FVFdPUktfUkVTUE9OU0UpOwogCi0gICAg LyoKLSAgICAgKiBXZWJLaXRXZWJSZXNvdXJjZTo6bG9hZC1mYWlsZWQKLSAgICAgKiBAd2ViUmVz b3VyY2U6IHRoZSAjV2ViS2l0V2ViUmVzb3VyY2UgdGhhdCB3YXMgbG9hZGVkCi0gICAgICogQHdl YkVycm9yOiB0aGUgI0dFcnJvciB0aGF0IHdhcyB0cmlnZ2VyZWQKKyAgICAvKioKKyAgICAgKiBX ZWJLaXRXZWJSZXNvdXJjZTo6bG9hZC1mYWlsZWQ6CisgICAgICogQHdlYl9yZXNvdXJjZTogdGhl ICNXZWJLaXRXZWJSZXNvdXJjZSB0aGF0IHdhcyBsb2FkZWQKKyAgICAgKiBAZXJyb3I6IHRoZSAj R0Vycm9yIHRoYXQgd2FzIHRyaWdnZXJlZAogICAgICAqCi0gICAgICogSW52b2tlZCB3aGVuIGEg cmVzb3VyY2UgZmFpbGVkIHRvIGxvYWQKKyAgICAgKiBJbnZva2VkIHdoZW4gdGhlIEB3ZWJfcmVz b3VyY2UgZmFpbGVkIHRvIGxvYWQKICAgICAgKgogICAgICAqIFNpbmNlOiAxLjcuNQogICAgICAq LwpAQCAtMTU4LDkgKzE1OCw5IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfcmVzb3VyY2VfY2xh c3NfaW5pdChXZWJLaXRXZWJSZXNvdXJjZUNsYXNzKiB3ZWJSZXNvdXJjZUNsCiAgICAgICAgICAg ICBHX1RZUEVfTk9ORSwgMSwKICAgICAgICAgICAgIEdfVFlQRV9QT0lOVEVSKTsKIAotICAgIC8q Ci0gICAgICogV2ViS2l0V2ViUmVzb3VyY2U6OmxvYWQtZmluaXNoZWQKLSAgICAgKiBAd2ViUmVz b3VyY2U6IHRoZSAjV2ViS2l0V2ViUmVzb3VyY2UgYmVpbmcgbG9hZGVkCisgICAgLyoqCisgICAg ICogV2ViS2l0V2ViUmVzb3VyY2U6OmxvYWQtZmluaXNoZWQ6CisgICAgICogQHdlYl9yZXNvdXJj ZTogdGhlICNXZWJLaXRXZWJSZXNvdXJjZSBiZWluZyBsb2FkZWQKICAgICAgKgogICAgICAqIEVt aXR0ZWQgd2hlbiBhbGwgdGhlIGRhdGEgZm9yIHRoZSByZXNvdXJjZSB3YXMgbG9hZGVkCiAgICAg ICoKQEAgLTE3NCwxMiArMTc0LDE1IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfcmVzb3VyY2Vf Y2xhc3NfaW5pdChXZWJLaXRXZWJSZXNvdXJjZUNsYXNzKiB3ZWJSZXNvdXJjZUNsCiAgICAgICAg ICAgICBnX2NjbG9zdXJlX21hcnNoYWxfVk9JRF9fVk9JRCwKICAgICAgICAgICAgIEdfVFlQRV9O T05FLCAwKTsKIAotICAgIC8qCi0gICAgICogV2ViS2l0V2ViUmVzb3VyY2U6OmNvbnRlbnQtbGVu Z3RoLXJlY2VpdmVkCi0gICAgICogQHdlYlJlc291cmNlOiB0aGUgI1dlYktpdFdlYlJlc291cmNl IHRoYXQgd2FzIGxvYWRlZAotICAgICAqIEBsZW5ndGhSZWNlaXZlZDogdGhlIHJlc291cmNlIGRh dGEgbGVuZ3RoIGluIGJ5dGVzCisgICAgLyoqCisgICAgICogV2ViS2l0V2ViUmVzb3VyY2U6OmNv bnRlbnQtbGVuZ3RoLXJlY2VpdmVkOgorICAgICAqIEB3ZWJfcmVzb3VyY2U6IHRoZSAjV2ViS2l0 V2ViUmVzb3VyY2UgdGhhdCB3YXMgbG9hZGVkCisgICAgICogQGxlbmd0aF9yZWNlaXZlZDogdGhl IHJlc291cmNlIGRhdGEgbGVuZ3RoIGluIGJ5dGVzCiAgICAgICoKLSAgICAgKiBFbWl0dGVkIHdo ZW4gYWxsIHRoZSBkYXRhIGZvciB0aGUgcmVzb3VyY2Ugd2FzIGxvYWRlZAorICAgICAqIEVtaXR0 ZWQgd2hlbiBuZXcgcmVzb3VyY2UgZGF0YSBoYXMgYmVlbiByZWNlaXZlZC4gVGhlCisgICAgICog QGxlbmd0aF9yZWNlaXZlZCB2YXJpYWJsZSBzdG9yZXMgdGhlIGFtb3VudCBvZiBieXRlcyByZWNl aXZlZCBzbworICAgICAqIGZhci4gVGhpcyBpcyB1c2VmdWwgdG8gcHJvdmlkZSBwcm9ncmVzcyBp bmZvcm1hdGlvbiBhYm91dCB0aGUKKyAgICAgKiByZXNvdXJjZSBsb2FkIG9wZXJhdGlvbi4KICAg ICAgKgogICAgICAqIFNpbmNlOiAxLjcuNQogICAgICAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvd2Vi a2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IGZmNTUwNGUwZmM4MDk4MGI0ZGYxZWIzMWQyODJm ZTg4NjM1NmIyMzQuLjMxMjgwYmZlZTQ3MTU1YzQ2NDNiZTRjYzMzMTIzMjUwZGFkOWE2MGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTI1MzEsOCAr MjUzMSw4IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdl YlZpZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAgICAqIHB1cnBvc2UsIHRvIG1ha2UgdGhlbSBu b3QgYmUgY2F0Y2hlZCBieSBndGstZG9jLgogICAgICAqLwogCi0gICAgLyoKLSAgICAgKiBXZWJL aXRXZWJWaWV3Ojpkb2N1bWVudC1sb2FkLWZpbmlzaGVkCisgICAgLyoqCisgICAgICogV2ViS2l0 V2ViVmlldzo6ZG9jdW1lbnQtbG9hZC1maW5pc2hlZDoKICAgICAgKiBAd2ViX3ZpZXc6IHRoZSBv YmplY3Qgd2hpY2ggcmVjZWl2ZWQgdGhlIHNpZ25hbAogICAgICAqIEB3ZWJfZnJhbWU6IHRoZSAj V2ViS2l0V2ViRnJhbWUgd2hvc2UgbG9hZCBkaXNwYXRjaGVkIHRoaXMgcmVxdWVzdAogICAgICAq CkBAIC0yNTQ4LDggKzI1NDgsOCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3Nf aW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICAgICAgICAgIEdfVFlQ RV9OT05FLCAxLAogICAgICAgICAgICAgV0VCS0lUX1RZUEVfV0VCX0ZSQU1FKTsKIAotICAgIC8q Ci0gICAgICogV2ViS2l0V2ViVmlldzo6ZnJhbWUtY3JlYXRlZAorICAgIC8qKgorICAgICAqIFdl YktpdFdlYlZpZXc6OmZyYW1lLWNyZWF0ZWQ6CiAgICAgICogQHdlYl92aWV3OiB0aGUgb2JqZWN0 IHdoaWNoIHJlY2VpdmVkIHRoZSBzaWduYWwKICAgICAgKiBAd2ViX2ZyYW1lOiB0aGUgI1dlYktp dFdlYkZyYW1lIHdoaWNoIHdhcyBqdXN0IGNyZWF0ZWQuCiAgICAgICoKQEAgLTI3MzEsMTEgKzI3 MzEsMTEgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQoV2ViS2l0V2Vi Vmlld0NsYXNzKiB3ZWJWaWV3Q2xhc3MpCiAgICAgICAgICAgICAgICAgICAgICAgICAgd2Via2l0 X21hcnNoYWxfQk9PTEVBTl9fT0JKRUNULAogICAgICAgICAgICAgICAgICAgICAgICAgIEdfVFlQ RV9CT09MRUFOLCAxLCBXRUJLSVRfVFlQRV9ET01fSFRNTF9FTEVNRU5UKTsKIAotICAgIC8qCi0g ICAgICogV2ViS2l0V2ViVmlldzo6cmVzb3VyY2UtcmVzcG9uc2UtcmVjZWl2ZWQKLSAgICAgKiBA d2ViVmlldzogdGhlIG9iamVjdCB3aGljaCByZWNlaXZlZCB0aGUgc2lnbmFsCi0gICAgICogQHdl YkZyYW1lOiB0aGUgI1dlYktpdFdlYkZyYW1lIHRoZSByZXNwb25zZSB3YXMgcmVjZWl2ZWQgZm9y Ci0gICAgICogQHdlYlJlc291cmNlOiB0aGUgI1dlYktpdFdlYlJlc291cmNlIGJlaW5nIGxvYWRl ZAorICAgIC8qKgorICAgICAqIFdlYktpdFdlYlZpZXc6OnJlc291cmNlLXJlc3BvbnNlLXJlY2Vp dmVkOgorICAgICAqIEB3ZWJfdmlldzogdGhlIG9iamVjdCB3aGljaCByZWNlaXZlZCB0aGUgc2ln bmFsCisgICAgICogQHdlYl9mcmFtZTogdGhlICNXZWJLaXRXZWJGcmFtZSB0aGUgcmVzcG9uc2Ug d2FzIHJlY2VpdmVkIGZvcgorICAgICAqIEB3ZWJfcmVzb3VyY2U6IHRoZSAjV2ViS2l0V2ViUmVz b3VyY2UgYmVpbmcgbG9hZGVkCiAgICAgICogQHJlc3BvbnNlOiB0aGUgI1dlYktpdE5ldHdvcmtS ZXNwb25zZSB0aGF0IHdhcyByZWNlaXZlZAogICAgICAqCiAgICAgICogRW1pdHRlZCB3aGVuIHRo ZSBmaXJzdCBieXRlIG9mIGRhdGEgYXJyaXZlcwpAQCAtMjc1MywxMSArMjc1MywxMSBAQCBzdGF0 aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdl YlZpZXdDbGFzcykKICAgICAgICAgICAgIFdFQktJVF9UWVBFX1dFQl9SRVNPVVJDRSwKICAgICAg ICAgICAgIFdFQktJVF9UWVBFX05FVFdPUktfUkVTUE9OU0UpOwogCi0gICAgLyoKLSAgICAgKiBX ZWJLaXRXZWJWaWV3OjpyZXNvdXJjZS1sb2FkLWZpbmlzaGVkCi0gICAgICogQHdlYlZpZXc6IHRo ZSBvYmplY3Qgd2hpY2ggcmVjZWl2ZWQgdGhlIHNpZ25hbAotICAgICAqIEB3ZWJGcmFtZTogdGhl ICNXZWJLaXRXZWJGcmFtZSB0aGUgcmVzcG9uc2Ugd2FzIHJlY2VpdmVkIGZvcgotICAgICAqIEB3 ZWJSZXNvdXJjZTogdGhlICNXZWJLaXRXZWJSZXNvdXJjZSB0aGF0IHdhcyBsb2FkZWQKKyAgICAv KioKKyAgICAgKiBXZWJLaXRXZWJWaWV3OjpyZXNvdXJjZS1sb2FkLWZpbmlzaGVkOgorICAgICAq IEB3ZWJfdmlldzogdGhlIG9iamVjdCB3aGljaCByZWNlaXZlZCB0aGUgc2lnbmFsCisgICAgICog QHdlYl9mcmFtZTogdGhlICNXZWJLaXRXZWJGcmFtZSB0aGUgcmVzcG9uc2Ugd2FzIHJlY2VpdmVk IGZvcgorICAgICAqIEB3ZWJfcmVzb3VyY2U6IHRoZSAjV2ViS2l0V2ViUmVzb3VyY2UgdGhhdCB3 YXMgbG9hZGVkCiAgICAgICoKICAgICAgKiBFbWl0dGVkIHdoZW4gYWxsIHRoZSBkYXRhIGZvciB0 aGUgcmVzb3VyY2Ugd2FzIGxvYWRlZAogICAgICAqCkBAIC0yNzczLDE1ICsyNzczLDE3IEBAIHN0 YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFzcyog d2ViVmlld0NsYXNzKQogICAgICAgICAgICAgV0VCS0lUX1RZUEVfV0VCX0ZSQU1FLAogICAgICAg ICAgICAgV0VCS0lUX1RZUEVfV0VCX1JFU09VUkNFKTsKIAotICAgIC8qCi0gICAgICogV2ViS2l0 V2ViVmlldzo6cmVzb3VyY2UtY29udGVudC1sZW5ndGgtcmVjZWl2ZWQKLSAgICAgKiBAd2ViVmll dzogdGhlIG9iamVjdCB3aGljaCByZWNlaXZlZCB0aGUgc2lnbmFsCi0gICAgICogQHdlYkZyYW1l OiB0aGUgI1dlYktpdFdlYkZyYW1lIHRoZSByZXNwb25zZSB3YXMgcmVjZWl2ZWQgZm9yCi0gICAg ICogQHdlYlJlc291cmNlOiB0aGUgI1dlYktpdFdlYlJlc291cmNlIHRoYXQgd2FzIGxvYWRlZAot ICAgICAqIEBsZW5ndGhSZWNlaXZlZDogdGhlIHJlc291cmNlIGRhdGEgbGVuZ3RoIGluIGJ5dGVz CisgICAgLyoqCisgICAgICogV2ViS2l0V2ViVmlldzo6cmVzb3VyY2UtY29udGVudC1sZW5ndGgt cmVjZWl2ZWQ6CisgICAgICogQHdlYl92aWV3OiB0aGUgb2JqZWN0IHdoaWNoIHJlY2VpdmVkIHRo ZSBzaWduYWwKKyAgICAgKiBAd2ViX2ZyYW1lOiB0aGUgI1dlYktpdFdlYkZyYW1lIHRoZSByZXNw b25zZSB3YXMgcmVjZWl2ZWQgZm9yCisgICAgICogQHdlYl9yZXNvdXJjZTogdGhlICNXZWJLaXRX ZWJSZXNvdXJjZSB0aGF0IHdhcyBsb2FkZWQKKyAgICAgKiBAbGVuZ3RoX3JlY2VpdmVkOiB0aGUg cmVzb3VyY2UgZGF0YSBsZW5ndGggaW4gYnl0ZXMKICAgICAgKgotICAgICAqIEVtaXR0ZWQgd2hl biB0aGUgSFRUUCBDb250ZW50LUxlbmd0aCByZXNwb25zZSBoZWFkZXIgaGFzIGJlZW4KLSAgICAg KiByZWNlaXZlZCBhbmQgcGFyc2VkIHN1Y2Nlc3NmdWxseS4KKyAgICAgKiBFbWl0dGVkIHdoZW4g bmV3IHJlc291cmNlIGRhdGEgaGFzIGJlZW4gcmVjZWl2ZWQuIFRoZQorICAgICAqIEBsZW5ndGhf cmVjZWl2ZWQgdmFyaWFibGUgc3RvcmVzIHRoZSBhbW91bnQgb2YgYnl0ZXMgcmVjZWl2ZWQgc28K KyAgICAgKiBmYXIuIFRoaXMgaXMgdXNlZnVsIHRvIHByb3ZpZGUgcHJvZ3Jlc3MgaW5mb3JtYXRp b24gYWJvdXQgdGhlCisgICAgICogcmVzb3VyY2UgbG9hZCBvcGVyYXRpb24uCiAgICAgICoKICAg ICAgKiBTaW5jZTogMS43LjUKICAgICAgKi8KQEAgLTI3OTYsMTIgKzI3OTgsMTIgQEAgc3RhdGlj IHZvaWQgd2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQoV2ViS2l0V2ViVmlld0NsYXNzKiB3ZWJW aWV3Q2xhc3MpCiAgICAgICAgICAgICBXRUJLSVRfVFlQRV9XRUJfUkVTT1VSQ0UsCiAgICAgICAg ICAgICBHX1RZUEVfSU5UKTsKIAotICAgIC8qCi0gICAgICogV2ViS2l0V2ViVmlldzo6cmVzb3Vy Y2UtbG9hZC1mYWlsZWQKLSAgICAgKiBAd2ViVmlldzogdGhlIG9iamVjdCB3aGljaCByZWNlaXZl ZCB0aGUgc2lnbmFsCi0gICAgICogQHdlYkZyYW1lOiB0aGUgI1dlYktpdFdlYkZyYW1lIHRoZSBy ZXNwb25zZSB3YXMgcmVjZWl2ZWQgZm9yCi0gICAgICogQHdlYlJlc291cmNlOiB0aGUgI1dlYktp dFdlYlJlc291cmNlIHRoYXQgd2FzIGxvYWRlZAotICAgICAqIEB3ZWJFcnJvcjogdGhlICNHRXJy b3IgdGhhdCB3YXMgdHJpZ2dlcmVkCisgICAgLyoqCisgICAgICogV2ViS2l0V2ViVmlldzo6cmVz b3VyY2UtbG9hZC1mYWlsZWQ6CisgICAgICogQHdlYl92aWV3OiB0aGUgb2JqZWN0IHdoaWNoIHJl Y2VpdmVkIHRoZSBzaWduYWwKKyAgICAgKiBAd2ViX2ZyYW1lOiB0aGUgI1dlYktpdFdlYkZyYW1l IHRoZSByZXNwb25zZSB3YXMgcmVjZWl2ZWQgZm9yCisgICAgICogQHdlYl9yZXNvdXJjZTogdGhl ICNXZWJLaXRXZWJSZXNvdXJjZSB0aGF0IHdhcyBsb2FkZWQKKyAgICAgKiBAZXJyb3I6IHRoZSAj R0Vycm9yIHRoYXQgd2FzIHRyaWdnZXJlZAogICAgICAqCiAgICAgICogSW52b2tlZCB3aGVuIGEg cmVzb3VyY2UgZmFpbGVkIHRvIGxvYWQKICAgICAgKgo=