79465 2012-02-24 01:53:12 -0800 Tests for showModalDialog need to ask for permission to open windows 2012-02-24 14:02:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen ap webkit.review.bot oldest_to_newest 564097 0 jochen 2012-02-24 01:53:12 -0800 Fix fast/events/scroll-event-during-modal-dialog.html so it actually displays a modal dialog 564111 1 jochen 2012-02-24 02:03:43 -0800 affects fast/animation/request-animation-frame-during-modal.html as well 564112 2 128692 jochen 2012-02-24 02:04:22 -0800 Created attachment 128692 Patch 564264 3 128692 webkit.review.bot 2012-02-24 06:08:55 -0800 Comment on attachment 128692 Patch Clearing flags on attachment: 128692 Committed r108783: <http://trac.webkit.org/changeset/108783> 564266 4 webkit.review.bot 2012-02-24 06:09:01 -0800 All reviewed patches have been landed. Closing bug. 564616 5 ap 2012-02-24 13:59:59 -0800 Why? Does popup blocker affect modal dialogs? 564619 6 jochen 2012-02-24 14:02:44 -0800 (In reply to comment #5) > Why? Does popup blocker affect modal dialogs? yes (at least on chromium) 128692 2012-02-24 02:04:22 -0800 2012-02-24 06:08:55 -0800 Patch bug-79465-20120224110421.patch text/plain 2092 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4MjIxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWRmN2MwNWNjZTgyMWZkOGY3NTJi N2ViYWVkNzExNTgzMTY3ZTFjOC4uYjYyMDQxMjg2MTUzMTU0OGRhNzNhMWIwNWYxYWNjYTAxZWZi Mjg2OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTI0ICBKb2NoZW4gRWlzaW5nZXIg IDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFRlc3RzIGZvciBzaG93TW9kYWxEaWFs b2cgbmVlZCB0byBhc2sgZm9yIHBlcm1pc3Npb24gdG8gb3BlbiB3aW5kb3dzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTQ2NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9hbmltYXRpb24vcmVx dWVzdC1hbmltYXRpb24tZnJhbWUtZHVyaW5nLW1vZGFsLmh0bWw6CisgICAgICAgICogZmFzdC9l dmVudHMvc2Nyb2xsLWV2ZW50LWR1cmluZy1tb2RhbC1kaWFsb2cuaHRtbDoKKwogMjAxMi0wMi0y MCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgR1RLIGJhc2VsaW5lcyBmb3IgYSBuZXcgZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRl bnQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvYW5pbWF0aW9uL3JlcXVlc3QtYW5pbWF0 aW9uLWZyYW1lLWR1cmluZy1tb2RhbC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9hbmltYXRpb24v cmVxdWVzdC1hbmltYXRpb24tZnJhbWUtZHVyaW5nLW1vZGFsLmh0bWwKaW5kZXggYWE4YzJmN2Rm OTE5ZDM2NGJiNWY1NzY4MjhiZmRmMTZlNDA3YTI3OC4uNzZkZThmMmM4OWEyNzc5YWI4MzVkNjI4 MTYyMjE0MDZmOTRhMDc1MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9hbmltYXRpb24v cmVxdWVzdC1hbmltYXRpb24tZnJhbWUtZHVyaW5nLW1vZGFsLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9hbmltYXRpb24vcmVxdWVzdC1hbmltYXRpb24tZnJhbWUtZHVyaW5nLW1vZGFsLmh0 bWwKQEAgLTQsNiArNCw5IEBACiA8Ym9keT4KIAogPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3Jp cHQiPgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5zZXRDYW5PcGVuV2luZG93cygpOworCiBkZXNjcmlwdGlvbignVGVzdHMgdGhhdCBy ZXF1ZXN0QW5pbWF0aW9uRnJhbWUgY2FsbGJhY2tzIGFyZSBub3QgaW52b2tlZCB3aGlsZSBtb2Rh bCBkaWFsb2dzIGFyZSBkaXNwbGF5ZWQuJyk7CiAKIG9ubG9hZCA9IGZ1bmN0aW9uKCkKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1ldmVudC1kdXJpbmctbW9kYWwt ZGlhbG9nLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zY3JvbGwtZXZlbnQtZHVyaW5n LW1vZGFsLWRpYWxvZy5odG1sCmluZGV4IDExYzAxMThjNWM1OTFhYTJmZDY5MmE0NjM2OTVjNmUw NzRiMzQ3ZGMuLmVkM2RjN2E3YjFlYjAwMzJkNjQ3ZjNmNThlMGRiNTg2YjdlMWI4MDQgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1ldmVudC1kdXJpbmctbW9kYWwt ZGlhbG9nLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2Nyb2xsLWV2ZW50LWR1 cmluZy1tb2RhbC1kaWFsb2cuaHRtbApAQCAtMyw2ICszLDkgQEAKIDxib2R5IHN0eWxlPSJtaW4t aGVpZ2h0OiAyMDAwcHgiPiAKIAogPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgoraWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5z ZXRDYW5PcGVuV2luZG93cygpOworCiBkZXNjcmlwdGlvbignVGVzdHMgdGhhdCBzY3JvbGwgZXZl bnRzIGFyZSBub3QgZmlyZWQgd2hpbGUgbW9kYWwgZGlhbG9ncyBhcmUgZGlzcGxheWVkLicpOwog CiB2YXIgdHJpZ2dlcmVkQ2FwdHVyZUxpc3RlbmVyID0gZmFsc2U7Cg==