79420 2012-02-23 16:32:13 -0800 Small refactor in RenderFlexibleBox::layoutAndPlaceChildren 2012-02-24 01:52:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony ojan webkit.review.bot oldest_to_newest 563666 0 tony 2012-02-23 16:32:13 -0800 Small refactor in RenderFlexibleBox::layoutAndPlaceChildren 563674 1 128598 tony 2012-02-23 16:34:58 -0800 Created attachment 128598 Patch 564095 2 128598 webkit.review.bot 2012-02-24 01:52:55 -0800 Comment on attachment 128598 Patch Clearing flags on attachment: 128598 Committed r108755: <http://trac.webkit.org/changeset/108755> 564096 3 webkit.review.bot 2012-02-24 01:52:58 -0800 All reviewed patches have been landed. Closing bug. 128598 2012-02-23 16:34:58 -0800 2012-02-24 01:52:54 -0800 Patch bug-79420-20120223163557.patch text/plain 2726 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFmZDJhODEyOTVkNzg5 NTE1YTJjZDM2MzVmMmZiNDRhZjkxNDI3YS4uMzg5MDY1MzdjNTgwZWQzNmM5MzYyZjJlNDMzMjcz OTVlNTY5ZWQ2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTIzICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU21hbGwgcmVmYWN0b3IgaW4g UmVuZGVyRmxleGlibGVCb3g6OmxheW91dEFuZFBsYWNlQ2hpbGRyZW4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5NDIwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBqdXN0IGEgcmVm YWN0b3IuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyRmxleGlibGVCb3g6OmxheW91dEFuZFBsYWNlQ2hpbGRyZW4p OiBTaGFyZSBzb21lIG9mIHRoZSBsb2dpYworICAgICAgICBpbiBjb21wdXRpbmcgdGhlIGNyb3Nz IGF4aXMgbGVuZ3RoLgorCiAyMDEyLTAyLTIzICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFtDTWFrZV0gQWRkIFdFQktJVF9JTkNMVURFX0NPTkZJR19G SUxFU19JRl9FWElTVFMgbWFjcm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJGbGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy RmxleGlibGVCb3guY3BwCmluZGV4IGU0NWViNzQyMThjYjk2MjllMDk3OGQwMTI2Mzc0MmE5MWE2 YmRkYTYuLmYyZjk5M2Q3YjdmODNjNjQ4NGRmYzE2ZjRkZjQ0ZTdhZjFkMGQ4MmYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcApAQCAtNzM0LDYg KzczNCw3IEBAIHZvaWQgUmVuZGVyRmxleGlibGVCb3g6OmxheW91dEFuZFBsYWNlQ2hpbGRyZW4o Y29uc3QgT3JkZXJlZEZsZXhJdGVtTGlzdCYgY2hpbGRyCiAgICAgICAgIGNoaWxkLT5zZXRDaGls ZE5lZWRzTGF5b3V0KHRydWUpOwogICAgICAgICBjaGlsZC0+bGF5b3V0SWZOZWVkZWQoKTsKIAor ICAgICAgICBMYXlvdXRVbml0IGNoaWxkQ3Jvc3NBeGlzRXh0ZW50OwogICAgICAgICBpZiAoZmxl eEFsaWduRm9yQ2hpbGQoY2hpbGQpID09IEFsaWduQmFzZWxpbmUpIHsKICAgICAgICAgICAgIExh eW91dFVuaXQgYXNjZW50ID0gbWFyZ2luQm94QXNjZW50KGNoaWxkKTsKICAgICAgICAgICAgIExh eW91dFVuaXQgZGVzY2VudCA9IChjcm9zc0F4aXNNYXJnaW5FeHRlbnRGb3JDaGlsZChjaGlsZCkg KyBjcm9zc0F4aXNFeHRlbnRGb3JDaGlsZChjaGlsZCkpIC0gYXNjZW50OwpAQCAtNzQxLDEwICs3 NDIsMTEgQEAgdm9pZCBSZW5kZXJGbGV4aWJsZUJveDo6bGF5b3V0QW5kUGxhY2VDaGlsZHJlbihj b25zdCBPcmRlcmVkRmxleEl0ZW1MaXN0JiBjaGlsZHIKICAgICAgICAgICAgIG1heEFzY2VudCA9 IHN0ZDo6bWF4KG1heEFzY2VudCwgYXNjZW50KTsKICAgICAgICAgICAgIG1heERlc2NlbnQgPSBz dGQ6Om1heChtYXhEZXNjZW50LCBkZXNjZW50KTsKIAotICAgICAgICAgICAgaWYgKGNyb3NzQXhp c0xlbmd0aCgpLmlzQXV0bygpKQotICAgICAgICAgICAgICAgIHNldENyb3NzQXhpc0V4dGVudChz dGQ6Om1heChjcm9zc0F4aXNFeHRlbnQoKSwgY3Jvc3NBeGlzQm9yZGVyQW5kUGFkZGluZ0V4dGVu dCgpICsgY3Jvc3NBeGlzTWFyZ2luRXh0ZW50Rm9yQ2hpbGQoY2hpbGQpICsgbWF4QXNjZW50ICsg bWF4RGVzY2VudCArIGNyb3NzQXhpc1Njcm9sbGJhckV4dGVudCgpKSk7Ci0gICAgICAgIH0gZWxz ZSBpZiAoY3Jvc3NBeGlzTGVuZ3RoKCkuaXNBdXRvKCkpCi0gICAgICAgICAgICBzZXRDcm9zc0F4 aXNFeHRlbnQoc3RkOjptYXgoY3Jvc3NBeGlzRXh0ZW50KCksIGNyb3NzQXhpc0JvcmRlckFuZFBh ZGRpbmdFeHRlbnQoKSArIGNyb3NzQXhpc01hcmdpbkV4dGVudEZvckNoaWxkKGNoaWxkKSArIGNy b3NzQXhpc0V4dGVudEZvckNoaWxkKGNoaWxkKSArIGNyb3NzQXhpc1Njcm9sbGJhckV4dGVudCgp KSk7CisgICAgICAgICAgICBjaGlsZENyb3NzQXhpc0V4dGVudCA9IG1heEFzY2VudCArIG1heERl c2NlbnQ7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgY2hpbGRDcm9zc0F4aXNFeHRlbnQg PSAgY3Jvc3NBeGlzRXh0ZW50Rm9yQ2hpbGQoY2hpbGQpOworICAgICAgICBpZiAoY3Jvc3NBeGlz TGVuZ3RoKCkuaXNBdXRvKCkpCisgICAgICAgICAgICBzZXRDcm9zc0F4aXNFeHRlbnQoc3RkOjpt YXgoY3Jvc3NBeGlzRXh0ZW50KCksIGNyb3NzQXhpc0JvcmRlckFuZFBhZGRpbmdFeHRlbnQoKSAr IGNyb3NzQXhpc01hcmdpbkV4dGVudEZvckNoaWxkKGNoaWxkKSArIGNoaWxkQ3Jvc3NBeGlzRXh0 ZW50ICsgY3Jvc3NBeGlzU2Nyb2xsYmFyRXh0ZW50KCkpKTsKIAogICAgICAgICBtYWluQXhpc09m ZnNldCArPSBmbG93QXdhcmVNYXJnaW5TdGFydEZvckNoaWxkKGNoaWxkKTsKIAo=