79392 2012-02-23 13:10:33 -0800 [BlackBerry] Selection handler has compile failure with logs enabled. 2012-02-23 20:40:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mifenton webkit-unassigned leo.yang tonikitoo webkit.review.bot oldest_to_newest 563394 0 mifenton 2012-02-23 13:10:33 -0800 When toString was removed a compile error was introduced if Selection logs were enabled. 563402 1 128539 mifenton 2012-02-23 13:15:14 -0800 Created attachment 128539 Patch 563408 2 128541 mifenton 2012-02-23 13:23:30 -0800 Created attachment 128541 Proper patch 563885 3 128541 webkit.review.bot 2012-02-23 20:40:29 -0800 Comment on attachment 128541 Proper patch Clearing flags on attachment: 128541 Committed r108723: <http://trac.webkit.org/changeset/108723> 563886 4 webkit.review.bot 2012-02-23 20:40:35 -0800 All reviewed patches have been landed. Closing bug. 128539 2012-02-23 13:15:14 -0800 2012-02-23 13:15:46 -0800 Patch 0001-2012-02-23-Mike-Fenton-mifenton-rim.com.patch text/plain 3220 mifenton RnJvbSA0OTNmMTNkYTZmOGZhMDUxMjRkMTBhMTk5OGIxNjBmN2M2NWE1OTMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VGh1LCAyMyBGZWIgMjAxMiAxNjowNzoxOCAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDIt MjMgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgQnVpbGQgRml4LiAg VXBkYXRlIGxvZyB0byBhdm9pZCB1c2FnZSBvZiB0b1N0cmluZyB3aGljaCB3YXMgcmVtb3ZlZC4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICogV2ViS2l0U3Vw cG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcDoKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpT ZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3Rpb25Qb3NpdGlvbkNoYW5nZWQpOgogICAgICAgIChCbGFj a0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OmNhcmV0UG9zaXRpb25DaGFuZ2VkKToK LS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8 ICAgMTMgKysrKysrKysrKysrKwogLi4uL2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rp b25IYW5kbGVyLmNwcCAgfCAgICA5ICsrKysrLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmlu ZGV4IGRiOGI0MTAuLmU4YmZlNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDEyLTAyLTIzICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+ CisKKyAgICAgICAgW0JsYWNrQmVycnldIFNlbGVjdGlvbiBoYW5kbGVyIGhhcyBjb21waWxlIGZh aWx1cmUgd2l0aCBsb2dzIGVuYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03OTM5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEJ1aWxkIEZpeC4gIFVwZGF0ZSBsb2cgdG8gYXZvaWQgdXNhZ2Ugb2Yg dG9TdHJpbmcgd2hpY2ggd2FzIHJlbW92ZWQuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L1Nl bGVjdGlvbkhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rp b25IYW5kbGVyOjpzZWxlY3Rpb25Qb3NpdGlvbkNoYW5nZWQpOgorICAgICAgICAoQmxhY2tCZXJy eTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpjYXJldFBvc2l0aW9uQ2hhbmdlZCk6CisKIDIw MTItMDItMjEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVt b3ZlIHRoZSByZW1haW5pbmcgdXNlcyBvZiBDU1NTdHlsZURlY2xhcmF0aW9uIGluIEVkaXRvcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0 aW9uSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9T ZWxlY3Rpb25IYW5kbGVyLmNwcAppbmRleCBhYjJkZGY4Li5iNjM2MmY1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25I YW5kbGVyLmNwcApAQCAtODgyLDggKzg4Miw5IEBAIHZvaWQgU2VsZWN0aW9uSGFuZGxlcjo6c2Vs ZWN0aW9uUG9zaXRpb25DaGFuZ2VkKGJvb2wgdmlzdWFsQ2hhbmdlT25seSkKICAgICAgICAgfQog ICAgIH0KIAotICAgIERFQlVHX1NFTEVDVElPTihCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6TG9nTGV2 ZWxJbmZvLCAiU2VsZWN0aW9uSGFuZGxlcjo6c2VsZWN0aW9uUG9zaXRpb25DaGFuZ2VkIFN0YXJ0 IFJlY3Q9JXMgRW5kIFJlY3Q9JXMiLAotICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnRDYXJl dC50b1N0cmluZygpLnV0ZjgoKS5kYXRhKCksIGVuZENhcmV0LnRvU3RyaW5nKCkudXRmOCgpLmRh dGEoKSk7CisgICAgREVCVUdfU0VMRUNUSU9OKEJsYWNrQmVycnk6OlBsYXRmb3JtOjpMb2dMZXZl bEluZm8sICJTZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3Rpb25Qb3NpdGlvbkNoYW5nZWQgU3RhcnQg UmVjdD0oJWQsICVkKSAoJWQgeCAlZCkgRW5kIFJlY3Q9KCVkLCAlZCkgKCVkIHggJWQpIiwKKyAg ICAgICAgICAgICAgICAgICAgc3RhcnRDYXJldC54KCksIHN0YXJ0Q2FyZXQueSgpLCBzdGFydENh cmV0LndpZHRoKCksIHN0YXJ0Q2FyZXQuaGVpZ2h0KCksIGVuZENhcmV0LngoKSwgZW5kQ2FyZXQu eSgpLCBlbmRDYXJldC53aWR0aCgpLCBlbmRDYXJldC5oZWlnaHQoKSk7CisKIAogICAgIG1fd2Vi UGFnZS0+bV9jbGllbnQtPm5vdGlmeVNlbGVjdGlvbkRldGFpbHNDaGFuZ2VkKHN0YXJ0Q2FyZXQs IGVuZENhcmV0LCByZWdpb24pOwogfQpAQCAtODkxLDkgKzg5Miw5IEBAIHZvaWQgU2VsZWN0aW9u SGFuZGxlcjo6c2VsZWN0aW9uUG9zaXRpb25DaGFuZ2VkKGJvb2wgdmlzdWFsQ2hhbmdlT25seSkK IC8vIE5PVEU6IFRoaXMgZnVuY3Rpb24gaXMgbm90IGluIFdlYktpdCBjb29yZGluYXRlcy4KIHZv aWQgU2VsZWN0aW9uSGFuZGxlcjo6Y2FyZXRQb3NpdGlvbkNoYW5nZWQoKQogewotICAgIERFQlVH X1NFTEVDVElPTihCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6TG9nTGV2ZWxJbmZvLCAiU2VsZWN0aW9u SGFuZGxlcjo6Y2FyZXRQb3NpdGlvbkNoYW5nZWQiKTsKKyAgICBERUJVR19TRUxFQ1RJT04oTG9n TGV2ZWxJbmZvLCAiU2VsZWN0aW9uSGFuZGxlcjo6Y2FyZXRQb3NpdGlvbkNoYW5nZWQiKTsKIAot ICAgIEludFJlY3QgY2FyZXRMb2NhdGlvbjsKKyAgICBXZWJDb3JlOjpJbnRSZWN0IGNhcmV0TG9j YXRpb247CiAgICAgLy8gSWYgdGhlIGlucHV0IGZpZWxkIGlzIG5vdCBhY3RpdmUsIHdlIG11c3Qg YmUgdHVybmluZyBvZmYgdGhlIGNhcmV0LgogICAgIGlmICghbV93ZWJQYWdlLT5tX2lucHV0SGFu ZGxlci0+aXNJbnB1dE1vZGUoKSAmJiBtX2NhcmV0QWN0aXZlKSB7CiAgICAgICAgIG1fY2FyZXRB Y3RpdmUgPSBmYWxzZTsKLS0gCjEuNy41LjQKCg== 128541 2012-02-23 13:23:30 -0800 2012-02-23 20:40:29 -0800 Proper patch 0001-2012-02-23-Mike-Fenton-mifenton-rim.com.patch text/plain 2455 mifenton RnJvbSBjM2ZmYzQ0MjAyZWQ1OGY3MTY2NWUyNjFlZjRiNjJiYWYyMmY5OWVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VGh1LCAyMyBGZWIgMjAxMiAxNjoxODozMyAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDIt MjMgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgQnVpbGQgRml4LiAg VXBkYXRlIGxvZyB0byBhdm9pZCB1c2FnZSBvZiB0b1N0cmluZyB3aGljaCB3YXMgcmVtb3ZlZC4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICogV2ViS2l0U3Vw cG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcDoKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpT ZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3Rpb25Qb3NpdGlvbkNoYW5nZWQpOgotLS0KIFNvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysr KysrKysKIC4uLi9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAg IHwgICAgNSArKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGRiOGI0MTAuLjMwM2M0 YTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTAyLTIzICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNr QmVycnldIFNlbGVjdGlvbiBoYW5kbGVyIGhhcyBjb21waWxlIGZhaWx1cmUgd2l0aCBsb2dzIGVu YWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 OTM5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1 aWxkIEZpeC4gIFVwZGF0ZSBsb2cgdG8gYXZvaWQgdXNhZ2Ugb2YgdG9TdHJpbmcgd2hpY2ggd2Fz IHJlbW92ZWQuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3Bw OgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3Rp b25Qb3NpdGlvbkNoYW5nZWQpOgorCiAyMDEyLTAyLTIxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB0aGUgcmVtYWluaW5nIHVzZXMgb2YgQ1NTU3R5 bGVEZWNsYXJhdGlvbiBpbiBFZGl0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKaW5kZXggYWIyZGRm OC4uMTQ5MDZmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKQEAgLTg4Miw4ICs4ODIsOSBAQCB2 b2lkIFNlbGVjdGlvbkhhbmRsZXI6OnNlbGVjdGlvblBvc2l0aW9uQ2hhbmdlZChib29sIHZpc3Vh bENoYW5nZU9ubHkpCiAgICAgICAgIH0KICAgICB9CiAKLSAgICBERUJVR19TRUxFQ1RJT04oQmxh Y2tCZXJyeTo6UGxhdGZvcm06OkxvZ0xldmVsSW5mbywgIlNlbGVjdGlvbkhhbmRsZXI6OnNlbGVj dGlvblBvc2l0aW9uQ2hhbmdlZCBTdGFydCBSZWN0PSVzIEVuZCBSZWN0PSVzIiwKLSAgICAgICAg ICAgICAgICAgICAgICAgIHN0YXJ0Q2FyZXQudG9TdHJpbmcoKS51dGY4KCkuZGF0YSgpLCBlbmRD YXJldC50b1N0cmluZygpLnV0ZjgoKS5kYXRhKCkpOworICAgIERFQlVHX1NFTEVDVElPTihCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6TG9nTGV2ZWxJbmZvLCAiU2VsZWN0aW9uSGFuZGxlcjo6c2VsZWN0 aW9uUG9zaXRpb25DaGFuZ2VkIFN0YXJ0IFJlY3Q9KCVkLCAlZCkgKCVkIHggJWQpIEVuZCBSZWN0 PSglZCwgJWQpICglZCB4ICVkKSIsCisgICAgICAgICAgICAgICAgICAgIHN0YXJ0Q2FyZXQueCgp LCBzdGFydENhcmV0LnkoKSwgc3RhcnRDYXJldC53aWR0aCgpLCBzdGFydENhcmV0LmhlaWdodCgp LCBlbmRDYXJldC54KCksIGVuZENhcmV0LnkoKSwgZW5kQ2FyZXQud2lkdGgoKSwgZW5kQ2FyZXQu aGVpZ2h0KCkpOworCiAKICAgICBtX3dlYlBhZ2UtPm1fY2xpZW50LT5ub3RpZnlTZWxlY3Rpb25E ZXRhaWxzQ2hhbmdlZChzdGFydENhcmV0LCBlbmRDYXJldCwgcmVnaW9uKTsKIH0KLS0gCjEuNy41 LjQKCg==