79389 2012-02-23 12:20:27 -0800 Hitch (due to style recalc?) when starting CSS3 animation 2022-07-12 16:56:16 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED CONFIGURATION CHANGED FacebookBug, InRadar P2 Normal --- 1 robarnold webkit-unassigned ap bfulgham browser-bugs crizweather21 dbates dino esprehn igor.oliveira jamesr jmkaldor loic.yhuel nduca rniwa shanestephens simon.fraser tony webkit-bug-importer webkit.review.bot oldest_to_newest 563357 0 128532 robarnold 2012-02-23 12:20:27 -0800 Created attachment 128532 Testcase See the attached testcase for an example. In it, we begin animating a div smoothly using JS to modify the transform property but when we switch to using the CSS3 animation, there is a noticeable visual hitch. We've observed this on the latest versions of Safari, Mobile Safari and Chrome (which most clearly shows the problem). The inspector seems to attribute this hitch to a style recalc. On mobile safari, NUMBER_OF_LAYERS can be set lower (say, 256). You may need to tune this number depending on your machine to observe the problem. 564781 1 simon.fraser 2012-02-24 17:23:55 -0800 Pretty sure that touching animRule will cause full style recalc. 565845 2 129074 jmkaldor 2012-02-27 11:24:48 -0800 Created attachment 129074 Revised testcase which does not modify the animation rule and removes the change in background color, still exhibits hitch 565846 3 jmkaldor 2012-02-27 11:26:00 -0800 Regarding modifying animRule, the hitch occurs whether or not lines 70-73 and 97-101 are commented out; the hitch seems to occur because of line 102, e.g. the setting of the animation property on container. I just uploaded a newer version of the testcase which does not modify the animation rule and which also removes the change in background color. 580052 4 132179 jmkaldor 2012-03-15 19:46:09 -0700 Created attachment 132179 Test case without overlap In profiling, we noticed that there was a significant penalty to all the overlap testing. We still see the hitch without the overlap, though, so this revised test case separates the child layers so the cost of style recalc is more apparent 581084 5 132412 robarnold 2012-03-16 16:35:57 -0700 Created attachment 132412 Patch 581087 6 132412 robarnold 2012-03-16 16:39:22 -0700 Comment on attachment 132412 Patch This seems too simple to be true but I did not see any of the existing tests on the Mac port fail. I am undoing a change that was introduced when CSS3 animations were added to WebKit; it's not clear to me why the children also need to have a forced style recalc though I suspect it may be related to moving elements in and out of RenderLayers (animations are a trigger for compositing). Mostly I'm looking for a smoke check here. 581105 7 simon.fraser 2012-03-16 16:52:18 -0700 Interesting. Do you have a trac link for when that was added? 581106 8 igor.oliveira 2012-03-16 16:56:53 -0700 In the code: // SyntheticStyleChange means that we need to go through the entire style change logic even though // no style property has actually changed. It is used to restructure the tree when, for instance, // RenderLayers are created or destroyed due to animation changes. So would be interesting test sites using complex animations. 581119 9 robarnold 2012-03-16 17:14:49 -0700 (In reply to comment #7) > Interesting. Do you have a trac link for when that was added? I misread the patch - it was https://bugs.webkit.org/show_bug.cgi?id=19938 which added the webkitAnimation* event and AnimationStyleChange (later renamed for WebGL). (In reply to comment #8) > In the code: > > // SyntheticStyleChange means that we need to go through the entire style change logic even though > // no style property has actually changed. It is used to restructure the tree when, for instance, > // RenderLayers are created or destroyed due to animation changes. > > So would be interesting test sites using complex animations. I was hoping that this would be covered by existing tests but I can start looking for some. Our internal prototypes appear to be working at least though I don't think they are cover enough of the edge cases. 586859 10 robarnold 2012-03-23 16:48:03 -0700 I tried a couple of sites that use animations (some css3 filters, morphing power cubes) and wrote some test cases that (I hope) targeted the now non-recursive style recalculation (rediscovering bug 46041 in the process) but I was unable to find a test case where the behavior different from Chrome 17. Simon, do you have any ideas for test cases that might spot a bug? I noticed that you had some comments about this line of code in bug 19938 comment 5. 588188 11 132412 igor.oliveira 2012-03-26 15:24:21 -0700 Comment on attachment 132412 Patch Lets put in the commit queue and hope for the best. 588196 12 132412 webkit.review.bot 2012-03-26 15:33:04 -0700 Comment on attachment 132412 Patch Clearing flags on attachment: 132412 Committed r112155: <http://trac.webkit.org/changeset/112155> 588197 13 webkit.review.bot 2012-03-26 15:33:08 -0700 All reviewed patches have been landed. Closing bug. 604281 14 137588 loic.yhuel 2012-04-17 13:18:42 -0700 Created attachment 137588 regression : blinking text animation This animation no longer works after this commit. In this case, when the text color should be changed to white : - styleChangeType() is SyntheticStyleChange, the animated style (color: white) is set on the Element in setRenderStyle(newStyle) - currentStyle and newStyle are the same (color: black), so ch is NoChange - After r112155, change is no more set to Force, so Text::recalcTextStyle is called with NoChange as argument, the style of the text is not changed, so the text color is still black. 604320 15 ap 2012-04-17 13:57:34 -0700 Could you please file a new bug about the regression? It's helpful to mention the problem in a bug that introduced it, but actual discussion should happen in a new one. 604354 16 loic.yhuel 2012-04-17 14:36:24 -0700 (In reply to comment #15) > Could you please file a new bug about the regression? It's helpful to mention the problem in a bug that introduced it, but actual discussion should happen in a new one. https://bugs.webkit.org/show_bug.cgi?id=84194 630543 17 ap 2012-05-22 10:55:07 -0700 This also caused bug 87146. 634188 18 dino 2012-05-25 12:35:19 -0700 We've received multiple reports internally and externally that this is breaking things. Sorry, I'm going to revert. 634214 19 dino 2012-05-25 13:04:04 -0700 Reverted in http://trac.webkit.org/changeset/118553 810092 20 esprehn 2013-01-17 18:53:31 -0800 (In reply to comment #18) > We've received multiple reports internally and externally that this is breaking things. Sorry, I'm going to revert. Can you explain what was broken? It's not clear in the bug. 810801 21 robarnold 2013-01-18 10:33:34 -0800 (In reply to comment #20) > (In reply to comment #18) > > We've received multiple reports internally and externally that this is breaking things. Sorry, I'm going to revert. > > Can you explain what was broken? It's not clear in the bug. In the blinking text example (bug 84194), the text would not blink. My guess was that any inherited values would not be animated as a side effect of my change. The use case I'm interested in is animating transforms which cannot (I think) be inherited. 1882751 22 bfulgham 2022-07-12 16:55:21 -0700 This seems to work properly (at least I don't see any meaningful animation hitches). Please REOPEN if you believe there is still an issue here. 1882752 23 webkit-bug-importer 2022-07-12 16:56:16 -0700 <rdar://problem/96918334> 128532 2012-02-23 12:20:27 -0800 2012-02-23 12:20:27 -0800 Testcase style.html text/html 3423 robarnold PGh0bWw+CjxoZWFkPgo8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9MzAwLCBp bml0aWFsLXNjYWxlPTEuMCwgdXNlci1zY2FsYWJsZT0wLCBtaW5pbXVtLXNjYWxlPTEuMCwgbWF4 aW11bS1zY2FsZT0xLjAiPgo8bWV0YSBuYW1lPSJhcHBsZS1tb2JpbGUtd2ViLWFwcC1jYXBhYmxl IiBjb250ZW50PSJ5ZXMiPgo8bWV0YSBuYW1lPSJhcHBsZS1tb2JpbGUtd2ViLWFwcC1zdGF0dXMt YmFyLXN0eWxlIiBjb250ZW50PSJibGFjayI+Cgo8dGl0bGU+cmVjYWxjIHRlc3Q8L3RpdGxlPgo8 c3R5bGU+CiN2aWV3cG9ydCB7CiAgcG9zaXRpb246IGFic29sdXRlOwogIGJvcmRlcjogNHB4IHNv bGlkICMwMDAwMDA7CiAgdG9wOiAwcHg7CiAgbGVmdDogMHB4OwogIGJvdHRvbTogMCU7CiAgcmln aHQ6IDAlOwogIG92ZXJmbG93OiBoaWRkZW47CiAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0 ZTNkKDBweCwgMHB4LCAwcHgpOwp9CiNjb250YWluZXIgewogIHBvc2l0aW9uOiBhYnNvbHV0ZTsK ICB0b3A6IDBweDsKICBsZWZ0OiAwcHg7CiAgd2lkdGg6IDEwMCU7CiAgaGVpZ2h0OiA0MDAwcHg7 CiAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDBweCwgMHB4LCAwcHgpOwp9Ci5ib3hH ZW5lcmFsIHsKICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgdG9wOiAwcHg7CiAgbGVmdDogMHB4Owog IHdpZHRoOiA1MHB4OwogIGhlaWdodDogNTBweDsKfQpib2R5IHsKICBiYWNrZ3JvdW5kLWNvbG9y OiAjZmZmZmZmOwp9CgpALXdlYmtpdC1rZXlmcmFtZXMgY29udGFpbmVyQW5pbSB7CiAgZnJvbSB7 LXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDBweCwgLTIwMHB4LCAwcHgpO30KICB0byB7 LXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDBweCwgLTQwMHB4LCAwcHgpO30KfQo8L3N0 eWxlPgo8c2NyaXB0IGxhbmd1YWdlPSJqYXZhc2NyaXB0Ij4KCnZhciBib3hDb3VudCA9IDA7CnZh ciBzdGFydFRpbWUgPSAwOwp2YXIgYW5pbVJ1bGUgPSBudWxsOwp2YXIgTlVNQkVSX09GX0xBWUVS UyA9IDEwMjQ7CgpmdW5jdGlvbiBjcmVhdGVCb3goYm91bmRzWCwgYm91bmRzWSkgewogIHZhciBj c3MgPSBkb2N1bWVudC5zdHlsZVNoZWV0c1swXTsKICB2YXIgciA9IE1hdGgucm91bmQoMjU1Kihi b3hDb3VudCAlIDI1NikgLyA1MTIpOwogIHZhciBnID0gTWF0aC5yb3VuZCgyNTUqKGJveENvdW50 ICUgMTYpIC8gMTYpOwogIHZhciBiID0gTWF0aC5yb3VuZCgyNTUqKGJveENvdW50ICUgMikpOwog IGNzcy5pbnNlcnRSdWxlKCcuYm94Q29sb3InICsgYm94Q291bnQgKyAnIHsgYmFja2dyb3VuZC1j b2xvcjogcmdiKCcgKyByICsgJywgJyArIGcgKyAnLCAnICsgYiArICcpOyB9Jyk7CiAgdmFyIHgg PSBNYXRoLnJvdW5kKE1hdGgucmFuZG9tKCkgKiBib3VuZHNYKTsKICB2YXIgeSA9IE1hdGgucm91 bmQoTWF0aC5yYW5kb20oKSAqIGJvdW5kc1kpOwogIHZhciByb3QgPSBNYXRoLnJvdW5kKE1hdGgu cmFuZG9tKCkgKiAzNjApOwogIGNzcy5pbnNlcnRSdWxlKCcuYm94R2VuZXJhbDpudGgtY2hpbGQo JyArIChib3hDb3VudCsxKSArICcpIHsgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKCcg KyB4ICsgJ3B4LCAnICsgeSArICdweCwgMHB4KSByb3RhdGVaKCcgKyByb3QgKyAnZGVnKTt9Jyk7 CiAgdmFyIGVsdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOwogIGVsdC5jbGFzc0xp c3QuYWRkKCdib3hHZW5lcmFsJyk7CiAgZWx0LmNsYXNzTGlzdC5hZGQoJ2JveENvbG9yJyArIGJv eENvdW50KTsKICBib3hDb3VudCsrOwogIHJldHVybiBlbHQ7Cn0KCmZ1bmN0aW9uIGluaXQoKSB7 CiAgdmFyIGNvbnRhaW5lciA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb250YWluZXInKTsK ICB2YXIgY3NzID0gZG9jdW1lbnQuc3R5bGVTaGVldHNbMF07CiAgZm9yICh2YXIgaSA9IDA7IGkg PCBjc3MucnVsZXMubGVuZ3RoOyArK2kpIHsKICAgIGlmIChjc3MucnVsZXNbaV0udHlwZSA9PSA4 KSAvLyBXRUJLSVRfS0VZRlJBTUVfUlVMRQogICAgICBhbmltUnVsZSA9IGNzcy5ydWxlc1tpXTsK ICB9CiAgZm9yICh2YXIgaSA9IDA7IGkgPCBOVU1CRVJfT0ZfTEFZRVJTOyArK2kpIHsKICAgIHZh ciBlbHQgPSBjcmVhdGVCb3goNTAwLCAyMDAwKTsKICAgIGNvbnRhaW5lci5hcHBlbmRDaGlsZChl bHQpOwogIH0KfQoKZnVuY3Rpb24gZG9BbmltYXRpb25UZXN0KCkgewogIHN0YXJ0VGltZSA9IERh dGUubm93KCk7CiAgY29uc29sZS5sb2coJ0JlZ2lubmluZyB0ZXN0Jyk7CiAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ2NvbnRhaW5lcicpLnN0eWxlLmJhY2tncm91bmRDb2xvciA9ICcjZmZmZmZm JzsKICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29udGFpbmVyJykuc3R5bGUud2Via2l0QW5p bWF0aW9uID0gJyc7CiAgc2V0VGltZW91dChzbGlkZSwgMTYpOwp9CgpmdW5jdGlvbiBzbGlkZSgp IHsKICB2YXIgY3VyclRpbWUgPSBEYXRlLm5vdygpOwogIHZhciBkZWx0YSA9IGN1cnJUaW1lIC0g c3RhcnRUaW1lOwogIHZhciBjb250YWluZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29u dGFpbmVyJyk7CiAgaWYgKGRlbHRhIDwgMjAwMCkgewogICAgY29udGFpbmVyLnN0eWxlLndlYmtp dFRyYW5zZm9ybSA9ICd0cmFuc2xhdGUzZCgwcHgsIC0nICsgTWF0aC5yb3VuZChkZWx0YS8xMCkg KyAncHgsIDBweCknOwogICAgc2V0VGltZW91dChzbGlkZSwgMTYpOwogIH0gZWxzZSB7CiAgICBj b250YWluZXIuc3R5bGUuYmFja2dyb3VuZENvbG9yID0gJyM5OTk5OTknOwogICAgZm9yICh2YXIg aSA9IGFuaW1SdWxlLmNzc1J1bGVzLmxlbmd0aC0xOyBpID49IDA7IC0taSkgewogICAgICBhbmlt UnVsZS5kZWxldGVSdWxlKGFuaW1SdWxlLmNzc1J1bGVzW2ldLmtleVRleHQpOwogICAgfQogICAg YW5pbVJ1bGUuaW5zZXJ0UnVsZSgnZnJvbSB7LXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNk KDBweCwgLScgKyBNYXRoLnJvdW5kKGRlbHRhLzEwKSArICdweCwgMHB4KTsgfScpOwogICAgYW5p bVJ1bGUuaW5zZXJ0UnVsZSgndG8gey13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGUzZCgwcHgs IC0nICsgTWF0aC5yb3VuZCgoZGVsdGErMjAwMCkvMTApICsgJ3B4LCAwcHgpOyB9Jyk7CiAgICBj b250YWluZXIuc3R5bGUud2Via2l0QW5pbWF0aW9uID0gJ2NvbnRhaW5lckFuaW0gMnMgbGluZWFy IDBzIDEgbm9ybWFsJzsKICAgIGNvbnRhaW5lci5zdHlsZS53ZWJraXRUcmFuc2Zvcm0gPSAndHJh bnNsYXRlM2QoMHB4LCAtNDAwcHgsIDBweCknOwogIH0KfQoKPC9zY3JpcHQ+CjwvaGVhZD4KPGJv ZHkgb25sb2FkPSJpbml0KCkiPgo8ZGl2IGlkPSJ2aWV3cG9ydCIgb25jbGljaz0iZG9BbmltYXRp b25UZXN0KCkiPgogIDxkaXYgaWQ9ImNvbnRhaW5lciI+CgogIDwvZGl2Pgo8L2Rpdj4KCjwvYm9k eT4K 129074 2012-02-27 11:24:48 -0800 2012-02-27 11:24:48 -0800 Revised testcase which does not modify the animation rule and removes the change in background color, still exhibits hitch recalc_test.html text/html 2865 jmkaldor PGh0bWw+CjxoZWFkPgo8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9MzAwLCBp bml0aWFsLXNjYWxlPTEuMCwgdXNlci1zY2FsYWJsZT0wLCBtaW5pbXVtLXNjYWxlPTEuMCwgbWF4 aW11bS1zY2FsZT0xLjAiPgo8bWV0YSBuYW1lPSJhcHBsZS1tb2JpbGUtd2ViLWFwcC1jYXBhYmxl IiBjb250ZW50PSJ5ZXMiPgo8bWV0YSBuYW1lPSJhcHBsZS1tb2JpbGUtd2ViLWFwcC1zdGF0dXMt YmFyLXN0eWxlIiBjb250ZW50PSJibGFjayI+Cgo8dGl0bGU+cmVjYWxjIHRlc3Q8L3RpdGxlPgo8 c3R5bGU+CiN2aWV3cG9ydCB7CiAgcG9zaXRpb246IGFic29sdXRlOwogIGJvcmRlcjogNHB4IHNv bGlkICMwMDAwMDA7CiAgdG9wOiAwcHg7CiAgbGVmdDogMHB4OwogIGJvdHRvbTogMCU7CiAgcmln aHQ6IDAlOwogIG92ZXJmbG93OiBoaWRkZW47CiAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0 ZTNkKDBweCwgMHB4LCAwcHgpOwp9CiNjb250YWluZXIgewogIHBvc2l0aW9uOiBhYnNvbHV0ZTsK ICB0b3A6IDBweDsKICBsZWZ0OiAwcHg7CiAgd2lkdGg6IDEwMCU7CiAgaGVpZ2h0OiA0MDAwcHg7 CiAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDBweCwgMHB4LCAwcHgpOwp9Ci5ib3hH ZW5lcmFsIHsKICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgdG9wOiAwcHg7CiAgbGVmdDogMHB4Owog IHdpZHRoOiA1MHB4OwogIGhlaWdodDogNTBweDsKfQpib2R5IHsKICBiYWNrZ3JvdW5kLWNvbG9y OiAjZmZmZmZmOwp9CgpALXdlYmtpdC1rZXlmcmFtZXMgY29udGFpbmVyQW5pbSB7CiAgZnJvbSB7 LXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDBweCwgLTIwMHB4LCAwcHgpO30KICB0byB7 LXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDBweCwgLTQwMHB4LCAwcHgpO30KfQo8L3N0 eWxlPgo8c2NyaXB0IGxhbmd1YWdlPSJqYXZhc2NyaXB0Ij4KCnZhciBib3hDb3VudCA9IDA7CnZh ciBzdGFydFRpbWUgPSAwOwp2YXIgTlVNQkVSX09GX0xBWUVSUyA9IDEwMjQ7CgpmdW5jdGlvbiBj cmVhdGVCb3goYm91bmRzWCwgYm91bmRzWSkgewogIHZhciBjc3MgPSBkb2N1bWVudC5zdHlsZVNo ZWV0c1swXTsKICB2YXIgciA9IE1hdGgucm91bmQoMjU1Kihib3hDb3VudCAlIDI1NikgLyA1MTIp OwogIHZhciBnID0gTWF0aC5yb3VuZCgyNTUqKGJveENvdW50ICUgMTYpIC8gMTYpOwogIHZhciBi ID0gTWF0aC5yb3VuZCgyNTUqKGJveENvdW50ICUgMikpOwogIGNzcy5pbnNlcnRSdWxlKCcuYm94 Q29sb3InICsgYm94Q291bnQgKyAnIHsgYmFja2dyb3VuZC1jb2xvcjogcmdiKCcgKyByICsgJywg JyArIGcgKyAnLCAnICsgYiArICcpOyB9Jyk7CiAgdmFyIHggPSBNYXRoLnJvdW5kKE1hdGgucmFu ZG9tKCkgKiBib3VuZHNYKTsKICB2YXIgeSA9IE1hdGgucm91bmQoTWF0aC5yYW5kb20oKSAqIGJv dW5kc1kpOwogIHZhciByb3QgPSBNYXRoLnJvdW5kKE1hdGgucmFuZG9tKCkgKiAzNjApOwogIGNz cy5pbnNlcnRSdWxlKCcuYm94R2VuZXJhbDpudGgtY2hpbGQoJyArIChib3hDb3VudCsxKSArICcp IHsgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKCcgKyB4ICsgJ3B4LCAnICsgeSArICdw eCwgMHB4KSByb3RhdGVaKCcgKyByb3QgKyAnZGVnKTt9Jyk7CiAgdmFyIGVsdCA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOwogIGVsdC5jbGFzc0xpc3QuYWRkKCdib3hHZW5lcmFsJyk7 CiAgZWx0LmNsYXNzTGlzdC5hZGQoJ2JveENvbG9yJyArIGJveENvdW50KTsKICBib3hDb3VudCsr OwogIHJldHVybiBlbHQ7Cn0KCmZ1bmN0aW9uIGluaXQoKSB7CiAgdmFyIGNvbnRhaW5lciA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb250YWluZXInKTsKICB2YXIgY3NzID0gZG9jdW1lbnQu c3R5bGVTaGVldHNbMF07CiAgZm9yICh2YXIgaSA9IDA7IGkgPCBOVU1CRVJfT0ZfTEFZRVJTOyAr K2kpIHsKICAgIHZhciBlbHQgPSBjcmVhdGVCb3goNTAwLCAyMDAwKTsKICAgIGNvbnRhaW5lci5h cHBlbmRDaGlsZChlbHQpOwogIH0KfQoKZnVuY3Rpb24gZG9BbmltYXRpb25UZXN0KCkgewogIHN0 YXJ0VGltZSA9IERhdGUubm93KCk7CiAgY29uc29sZS5sb2coJ0JlZ2lubmluZyB0ZXN0Jyk7CiAg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnRhaW5lcicpLnN0eWxlLmJhY2tncm91bmRDb2xv ciA9ICcjZmZmZmZmJzsKICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29udGFpbmVyJykuc3R5 bGUud2Via2l0QW5pbWF0aW9uID0gJyc7CiAgc2V0VGltZW91dChzbGlkZSwgMTYpOwp9CgpmdW5j dGlvbiBzbGlkZSgpIHsKICB2YXIgY3VyclRpbWUgPSBEYXRlLm5vdygpOwogIHZhciBkZWx0YSA9 IGN1cnJUaW1lIC0gc3RhcnRUaW1lOwogIHZhciBjb250YWluZXIgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnY29udGFpbmVyJyk7CiAgaWYgKGRlbHRhIDwgMjAwMCkgewogICAgY29udGFpbmVy LnN0eWxlLndlYmtpdFRyYW5zZm9ybSA9ICd0cmFuc2xhdGUzZCgwcHgsIC0nICsgTWF0aC5yb3Vu ZChkZWx0YS8xMCkgKyAncHgsIDBweCknOwogICAgc2V0VGltZW91dChzbGlkZSwgMTYpOwogIH0g ZWxzZSB7CiAgICBjb250YWluZXIuc3R5bGUud2Via2l0QW5pbWF0aW9uID0gJ2NvbnRhaW5lckFu aW0gMnMgbGluZWFyIDBzIDEgbm9ybWFsJzsKICAgIGNvbnRhaW5lci5zdHlsZS53ZWJraXRUcmFu c2Zvcm0gPSAndHJhbnNsYXRlM2QoMHB4LCAtNDAwcHgsIDBweCknOwogIH0KfQoKPC9zY3JpcHQ+ CjwvaGVhZD4KPGJvZHkgb25sb2FkPSJpbml0KCkiPgo8ZGl2IGlkPSJ2aWV3cG9ydCIgb25jbGlj az0iZG9BbmltYXRpb25UZXN0KCkiPgogIDxkaXYgaWQ9ImNvbnRhaW5lciI+CgogIDwvZGl2Pgo8 L2Rpdj4KCjwvYm9keT4K 132179 2012-03-15 19:46:09 -0700 2012-03-15 19:46:09 -0700 Test case without overlap recalc_test.html text/html 3107 jmkaldor PGh0bWw+CjxoZWFkPgo8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9MzAwLCBp bml0aWFsLXNjYWxlPTEuMCwgdXNlci1zY2FsYWJsZT0wLCBtaW5pbXVtLXNjYWxlPTEuMCwgbWF4 aW11bS1zY2FsZT0xLjAiPgo8bWV0YSBuYW1lPSJhcHBsZS1tb2JpbGUtd2ViLWFwcC1jYXBhYmxl IiBjb250ZW50PSJ5ZXMiPgo8bWV0YSBuYW1lPSJhcHBsZS1tb2JpbGUtd2ViLWFwcC1zdGF0dXMt YmFyLXN0eWxlIiBjb250ZW50PSJibGFjayI+Cgo8dGl0bGU+cmVjYWxjIHRlc3Q8L3RpdGxlPgo8 c3R5bGU+CiN2aWV3cG9ydCB7CiAgcG9zaXRpb246IGFic29sdXRlOwogIGJvcmRlcjogNHB4IHNv bGlkICMwMDAwMDA7CiAgdG9wOiAwcHg7CiAgbGVmdDogMHB4OwogIGJvdHRvbTogMCU7CiAgcmln aHQ6IDAlOwogIG92ZXJmbG93OiBoaWRkZW47CiAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0 ZTNkKDBweCwgMHB4LCAwcHgpOwp9CiNjb250YWluZXIgewogIHBvc2l0aW9uOiBhYnNvbHV0ZTsK ICB0b3A6IDBweDsKICBsZWZ0OiAwcHg7CiAgd2lkdGg6IDEwMCU7CiAgaGVpZ2h0OiA4MDAwcHg7 CiAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDBweCwgMHB4LCAwcHgpOwp9Ci5ib3hH ZW5lcmFsIHsKICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgdG9wOiAwcHg7CiAgbGVmdDogMHB4Owog IHdpZHRoOiAzMHB4OwogIGhlaWdodDogMzBweDsKfQpib2R5IHsKICBiYWNrZ3JvdW5kLWNvbG9y OiAjZmZmZmZmOwp9CgpALXdlYmtpdC1rZXlmcmFtZXMgY29udGFpbmVyQW5pbSB7CiAgZnJvbSB7 LXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDBweCwgLTIwMHB4LCAwcHgpO30KICB0byB7 LXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDBweCwgLTQwMHB4LCAwcHgpO30KfQo8L3N0 eWxlPgo8c2NyaXB0IGxhbmd1YWdlPSJqYXZhc2NyaXB0Ij4KCnZhciBib3hDb3VudCA9IDA7CnZh ciBzdGFydFRpbWUgPSAwOwp2YXIgTlVNQkVSX09GX0xBWUVSUyA9IDEwMjQ7CgpmdW5jdGlvbiBj cmVhdGVCb3goYm91bmRzWCwgYm91bmRzWSkgewogIHZhciBjc3MgPSBkb2N1bWVudC5zdHlsZVNo ZWV0c1swXTsKICB2YXIgciA9IE1hdGgucm91bmQoMjU1Kihib3hDb3VudCAlIDI1NikgLyA1MTIp OwogIHZhciBnID0gTWF0aC5yb3VuZCgyNTUqKGJveENvdW50ICUgMTYpIC8gMTYpOwogIHZhciBi ID0gTWF0aC5yb3VuZCgyNTUqKGJveENvdW50ICUgMikpOwogIGNzcy5pbnNlcnRSdWxlKCcuYm94 Q29sb3InICsgYm94Q291bnQgKyAnIHsgYmFja2dyb3VuZC1jb2xvcjogcmdiKCcgKyByICsgJywg JyArIGcgKyAnLCAnICsgYiArICcpOyB9Jyk7CiAgdmFyIHggPSBNYXRoLnJvdW5kKDUwICogKGJv eENvdW50ICUgTWF0aC5mbG9vcihib3VuZHNYLzUwKSkgKyAyNSk7CiAgdmFyIHkgPSBNYXRoLnJv dW5kKDUwICogKE1hdGguZmxvb3IoYm94Q291bnQqNTAgLyAoYm91bmRzWCkpKSArIDI1KTsKICB2 YXIgcm90ID0gTWF0aC5yb3VuZChNYXRoLnJhbmRvbSgpICogMzYwKTsKICBjc3MuaW5zZXJ0UnVs ZSgnLmJveEdlbmVyYWw6bnRoLWNoaWxkKCcgKyAoYm94Q291bnQrMSkgKyAnKSB7IC13ZWJraXQt dHJhbnNmb3JtOiB0cmFuc2xhdGUzZCgnICsgeCArICdweCwgJyArIHkgKyAncHgsIDBweCkgcm90 YXRlWignICsgcm90ICsgJ2RlZyk7fScpOwogIHZhciBlbHQgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCdkaXYnKTsKICBlbHQuY2xhc3NMaXN0LmFkZCgnYm94R2VuZXJhbCcpOwogIGVsdC5jbGFz c0xpc3QuYWRkKCdib3hDb2xvcicgKyBib3hDb3VudCk7CiAgYm94Q291bnQrKzsKICByZXR1cm4g ZWx0Owp9CgpmdW5jdGlvbiBpbml0KCkgewogIHZhciBjb250YWluZXIgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgnY29udGFpbmVyJyk7CiAgdmFyIGNzcyA9IGRvY3VtZW50LnN0eWxlU2hlZXRz WzBdOwogIGZvciAodmFyIGkgPSAwOyBpIDwgTlVNQkVSX09GX0xBWUVSUzsgKytpKSB7CiAgICB2 YXIgZWx0ID0gY3JlYXRlQm94KDUwMCwgMjAwMCk7CiAgICBjb250YWluZXIuYXBwZW5kQ2hpbGQo ZWx0KTsKICB9Cn0KCmZ1bmN0aW9uIGRvQW5pbWF0aW9uVGVzdCgpIHsKICBzdGFydFRpbWUgPSBE YXRlLm5vdygpOwogIGNvbnNvbGUubG9nKCdCZWdpbm5pbmcgdGVzdCcpOwogIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdjb250YWluZXInKS5zdHlsZS5iYWNrZ3JvdW5kQ29sb3IgPSAnI2ZmZmZm Zic7CiAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnRhaW5lcicpLnN0eWxlLndlYmtpdEFu aW1hdGlvbiA9ICcnOwogIHNldFRpbWVvdXQoc2xpZGUsIDE2KTsKfQoKZnVuY3Rpb24gc2xpZGUo KSB7CiAgdmFyIGN1cnJUaW1lID0gRGF0ZS5ub3coKTsKICB2YXIgZGVsdGEgPSBjdXJyVGltZSAt IHN0YXJ0VGltZTsKICB2YXIgY29udGFpbmVyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2Nv bnRhaW5lcicpOwogIGlmIChkZWx0YSA8IDIwMDApIHsKICAgIGNvbnRhaW5lci5zdHlsZS53ZWJr aXRUcmFuc2Zvcm0gPSAndHJhbnNsYXRlM2QoMHB4LCAtJyArIE1hdGgucm91bmQoZGVsdGEvMTAp ICsgJ3B4LCAwcHgpJzsKICAgIHNldFRpbWVvdXQoc2xpZGUsIDE2KTsKICB9IGVsc2UgewogICAg Y29udGFpbmVyLnN0eWxlLndlYmtpdEFuaW1hdGlvbiA9ICdjb250YWluZXJBbmltIDJzIGxpbmVh ciAwcyAxIG5vcm1hbCc7CiAgICBjb250YWluZXIuc3R5bGUud2Via2l0VHJhbnNmb3JtID0gJ3Ry YW5zbGF0ZTNkKDBweCwgLTQwMHB4LCAwcHgpJzsKICAgIGNvbnRhaW5lci5hZGRFdmVudExpc3Rl bmVyKCd3ZWJraXRBbmltYXRpb25TdGFydCcsIGZ1bmN0aW9uKCkge2NvbnNvbGUubG9nKCdoZWxv Jyk7IH0sIGZhbHNlKTsKICAgIGNvbnRhaW5lci5hZGRFdmVudExpc3RlbmVyKCd3ZWJraXRBbmlt YXRpb25FbmQnLCBmdW5jdGlvbigpIHtjb25zb2xlLmxvZygnZ2J5ZScpOyB9LCBmYWxzZSk7CiAg fQp9Cgo8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keSBvbmxvYWQ9ImluaXQoKSI+CjxkaXYgaWQ9InZp ZXdwb3J0IiBvbmNsaWNrPSJkb0FuaW1hdGlvblRlc3QoKSI+CiAgPGRpdiBpZD0iY29udGFpbmVy Ij4KCiAgPC9kaXY+CjwvZGl2PgoKPC9ib2R5Pgo= 132412 2012-03-16 16:35:57 -0700 2012-03-26 15:33:04 -0700 Patch bug-79389-20120316163556.patch text/plain 1319 robarnold U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDkwNDAyOTZkZDU4NWU1 MTcyMDNlNzEyNjkzNjhjMTdiZmViZTY0Zi4uZjVmY2IzMDI3OTAzNDMyYzJjMDE0NmQ1YzcxYzhj YTU5OTYwODc1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTE2ICBSb2Ig QXJub2xkICA8cm9iYXJub2xkQGZiLmNvbT4KKworICAgICAgICBTeW50aGV0aWNTdHlsZUNhbGMg b24gYW4gZWxlbWVudCBzaG91bGQgbm90IGZvcmNlIHJlY2FsY3VsYXRpb24gb24gaXRzIGNoaWxk cmVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTM4 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gRXhpc3RpbmcgdGVzdHMgY292ZXIgY29ycmVjdG5lc3MsIG5vdCBzdXJlIGhvdyB0 byB0ZXN0IGZvciBwZXJmb3JtYW5jZS4KKworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnJlY2FsY1N0eWxlKToKKwogMjAxMi0wMy0xNiAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjExMTAyMC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCAyZGY2 ZDRlNDQyNjgzMGExMWEyMzNmZTRkZmQ0M2ViZGY5OWY5ZGIwLi5mYzFmNGMyNDk2ZDdmNzJjZGQy YTkzY2VhYjQ3OWY3MzU3OTBlNmQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0xMTE4LDcg KzExMTgsNyBAQCB2b2lkIEVsZW1lbnQ6OnJlY2FsY1N0eWxlKFN0eWxlQ2hhbmdlIGNoYW5nZSkK ICAgICAgICAgfQogCiAgICAgICAgIGlmIChjaGFuZ2UgIT0gRm9yY2UpIHsKLSAgICAgICAgICAg IGlmIChzdHlsZUNoYW5nZVR5cGUoKSA+PSBGdWxsU3R5bGVDaGFuZ2UpCisgICAgICAgICAgICBp ZiAoc3R5bGVDaGFuZ2VUeXBlKCkgPT0gRnVsbFN0eWxlQ2hhbmdlKQogICAgICAgICAgICAgICAg IGNoYW5nZSA9IEZvcmNlOwogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIGNoYW5n ZSA9IGNoOwo= 137588 2012-04-17 13:18:42 -0700 2012-04-17 13:18:42 -0700 regression : blinking text animation blink.html text/html 423 loic.yhuel PGh0bWw+CiAgICA8aGVhZD4KICAgICAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgogICAgICAg ICAgICBALXdlYmtpdC1rZXlmcmFtZXMgYmxpbmsgewogICAgICAgICAgICAgICAgMCUgICB7IGNv bG9yOiBibGFjazsgfQogICAgICAgICAgICAgICAgNTAlICB7IGNvbG9yOiB3aGl0ZTsgfQogICAg ICAgICAgICAgICAgMTAwJSB7IGNvbG9yOiBibGFjazsgfQogICAgICAgICAgICB9CgogICAgICAg ICAgICAjYmxpbmsgewogICAgICAgICAgICAgICAgLXdlYmtpdC1hbmltYXRpb246IGJsaW5rIDFz IHN0ZXAtZW5kIGluZmluaXRlOwogICAgICAgICAgICB9CiAgICAgICAgPC9zdHlsZT4KICAgIDwv aGVhZD4KICAgIDxib2R5PgogICAgICAgIDxzcGFuIGlkPWJsaW5rPkJsaW5raW5nIHRleHQ8L3Nw YW4+CiAgICA8L2JvZHk+CjwvaHRtbD4K