7938 2006-03-23 11:45:37 -0800 Shave .2% on PLT by removing bogus strcmp. 2006-03-28 14:07:11 -0800 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric eric darin ggaren oldest_to_newest 37429 0 eric 2006-03-23 11:45:37 -0800 For whatever reason we had a completely bogus strcmp in HTMLTokenizer which accounted for .2% of all time spent in the PLT (on my MBP): @@ -901,7 +900,7 @@ ptr[--len] = '\0'; // Now that we've shaved off any invalid / that might have followed the name), make the tag. - if (ptr[0] != '!' && strcmp(ptr, "!doctype") != 0) { + if (ptr[0] != '!') { // make sure it's not a !DOCTYPE currToken.tagName = AtomicString(ptr); currToken.beginTag = beginTag; } 37430 1 7255 eric 2006-03-23 11:46:16 -0800 Created attachment 7255 Remove bogus strcmp to save on plt 37433 2 ggaren 2006-03-23 12:44:55 -0800 Can't "!" also be present for comment elements? 37437 3 7255 darin 2006-03-23 13:18:07 -0800 Comment on attachment 7255 Remove bogus strcmp to save on plt I think the right change is to change the && to a ||. We're supposed to allow tags like <!custom> I believe. 37440 4 eric 2006-03-23 13:28:50 -0800 I had considered the ||, but hyatt and I couldn't think of any valid use case for !tagname. I'll change it to or and add a test case for parsing a <!foo></!foo> tag. 37444 5 darin 2006-03-23 13:56:53 -0800 (In reply to comment #4) > I had considered the ||, but hyatt and I couldn't think of any valid use case > for !tagname. I'll change it to or and add a test case for parsing a > <!foo></!foo> tag. If we're going to disallow anything starting with "!" (and Dave is definitely an authority on making that call), we should both have tests and also change the comment. I think we can do better than a comment that specifically mentions DOCTYPE and code that checks only for "!". 7255 2006-03-23 11:46:16 -0800 2006-03-23 13:18:07 -0800 Remove bogus strcmp to save on plt speed.patch text/plain 1694 eric SW5kZXg6IGh0bWwvSFRNTFRva2VuaXplci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaHRtbC9IVE1MVG9r ZW5pemVyLmNwcAkocmV2aXNpb24gMTM0NTIpCisrKyBodG1sL0hUTUxUb2tlbml6ZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC04ODUsOCArODg1LDcgQEAgSFRNTFRva2VuaXplcjo6U3RhdGUgSFRN TFRva2VuaXplcjo6cGFycwogICAgICAgICAgICAgICAgIGNoYXIqIHB0ciA9IGNCdWZmZXI7CiAg ICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGxlbiA9IGNCdWZmZXJQb3M7CiAgICAgICAgICAg ICAgICAgY0J1ZmZlcltjQnVmZmVyUG9zXSA9ICdcMCc7Ci0gICAgICAgICAgICAgICAgaWYgKChj QnVmZmVyUG9zID4gMCkgJiYgKCpwdHIgPT0gJy8nKSkKLSAgICAgICAgICAgICAgICB7CisgICAg ICAgICAgICAgICAgaWYgKChjQnVmZmVyUG9zID4gMCkgJiYgKCpwdHIgPT0gJy8nKSkgewogICAg ICAgICAgICAgICAgICAgICAvLyBFbmQgVGFnCiAgICAgICAgICAgICAgICAgICAgIGJlZ2luVGFn ID0gZmFsc2U7CiAgICAgICAgICAgICAgICAgICAgIHB0cisrOwpAQCAtOTAxLDcgKzkwMCw3IEBA IEhUTUxUb2tlbml6ZXI6OlN0YXRlIEhUTUxUb2tlbml6ZXI6OnBhcnMKICAgICAgICAgICAgICAg ICAgICAgcHRyWy0tbGVuXSA9ICdcMCc7CiAKICAgICAgICAgICAgICAgICAvLyBOb3cgdGhhdCB3 ZSd2ZSBzaGF2ZWQgb2ZmIGFueSBpbnZhbGlkIC8gdGhhdCBtaWdodCBoYXZlIGZvbGxvd2VkIHRo ZSBuYW1lKSwgbWFrZSB0aGUgdGFnLgotICAgICAgICAgICAgICAgIGlmIChwdHJbMF0gIT0gJyEn ICYmIHN0cmNtcChwdHIsICIhZG9jdHlwZSIpICE9IDApIHsKKyAgICAgICAgICAgICAgICBpZiAo cHRyWzBdICE9ICchJykgeyAvLyBtYWtlIHN1cmUgaXQncyBub3QgYSAhRE9DVFlQRQogICAgICAg ICAgICAgICAgICAgICBjdXJyVG9rZW4udGFnTmFtZSA9IEF0b21pY1N0cmluZyhwdHIpOwogICAg ICAgICAgICAgICAgICAgICBjdXJyVG9rZW4uYmVnaW5UYWcgPSBiZWdpblRhZzsKICAgICAgICAg ICAgICAgICB9CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBkb20vUmFuZ2UuaWRsCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TmFtZTogc3ZuOmVvbC1zdHlsZQogICArIG5hdGl2ZQoKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzNDU1KQorKysgQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDYtMDMtMjMgIEVyaWMgU2VpZGVsICA8ZXNlaWRl bEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBodG1sL0hUTUxUb2tlbml6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRv a2VuaXplcjo6cGFyc2VUYWcpOgorCiAyMDA2LTAzLTIzICBEYXJpbiBBZGxlciAgPGRhcmluQGFw cGxlLmNvbT4KIAogICAgICAgICAqIGdlbmVyYXRlLWRlcml2ZWQtc291cmNlczogVHdlYWtlZCBm b3JtYXR0aW5nIGEgdGlueSBiaXQgYW5kIHJlbW92ZWQgYSBzdHJheQo=