79356 2012-02-23 04:03:11 -0800 Little optimization in CSSParser::parseShorthand. 2012-02-24 06:16:45 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard commit-queue darin haraken kling macpherson morrita tony webkit.review.bot oldest_to_newest 563015 0 menard 2012-02-23 04:03:11 -0800 Little optimization in CSSParser::parseShorthand. 563022 1 128455 menard 2012-02-23 04:10:41 -0800 Created attachment 128455 Patch 563031 2 128455 haraken 2012-02-23 04:28:52 -0800 Comment on attachment 128455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128455&action=review > Source/WebCore/css/CSSParser.cpp:2682 > + bool fnd[6]= { false }; // Trust me ;) "bool fnd[6] = {false, false, false, false, false, false}" might be better (just for clarification). "bool fnd[6] = {false}" is equivalent to "bool fnd[6] = {false, 0, 0, 0, 0, 0}". This is OK because false and 0 have the same meaning in this method, but is a bit confusing. > Source/WebCore/css/CSSParser.cpp:2686 > for (int propIndex = 0; !found && propIndex < numProperties; ++propIndex) { BTW, (I am not sure how much it is important for performance but) maybe we can remove this for loop, by moving the propIndex declaration to outside while (...). Anyway you can try it in another patch. 563039 3 128460 menard 2012-02-23 05:01:17 -0800 Created attachment 128460 Patch 563058 4 128460 haraken 2012-02-23 05:56:55 -0800 Comment on attachment 128460 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128460&action=review > Source/WebCore/css/CSSParser.cpp:-2687 > - for (int propIndex = 0; !found && propIndex < numProperties; ++propIndex) { I am sorry, I was wrong. Let us keep it as-is. ### I was thinking that we might be able to remove the for loop something like this. (The following code is wrong.) int propIndex = 0; while (m_valueList->current()) { if (propIndex >= numProperties) return false; if (parseValue(properties[propIndex], important)) { fnd[propIndex] = true; propIndex++; } } if (propIndex == numProperties) return true; 563071 5 128470 menard 2012-02-23 06:13:11 -0800 Created attachment 128470 Patch 563072 6 128470 haraken 2012-02-23 06:14:03 -0800 Comment on attachment 128470 Patch Thanks for the patch! 563105 7 128470 webkit.review.bot 2012-02-23 07:42:33 -0800 Comment on attachment 128470 Patch Rejecting attachment 128470 from review queue. haraken@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 563203 8 128470 tony 2012-02-23 10:23:30 -0800 Comment on attachment 128470 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128470&action=review > Source/WebCore/css/CSSParser.cpp:2680 > bool found = false; Can we declare found in the while loop? > Source/WebCore/css/CSSParser.cpp:2682 > + bool fnd[6]= { false, false, false, false, false, false }; // Trust me ;) I'm not sure what the comment means. I would probably just remove it. > Source/WebCore/css/CSSParser.cpp:2688 > if (!fnd[propIndex]) { > - if (parseValue(properties[propIndex], important)) > + if (parseValue(properties[propIndex], important)) { Can we merge these if statements with &&? 563457 9 haraken 2012-02-23 14:03:18 -0800 (In reply to comment #8) > > Source/WebCore/css/CSSParser.cpp:2682 > > + bool fnd[6]= { false, false, false, false, false, false }; // Trust me ;) > > I'm not sure what the comment means. I would probably just remove it. The comment means "6 is enough size". We can update the comment to clarify that. 564174 10 128704 menard 2012-02-24 03:53:44 -0800 Created attachment 128704 Patch for landing 564270 11 128704 webkit.review.bot 2012-02-24 06:16:37 -0800 Comment on attachment 128704 Patch for landing Clearing flags on attachment: 128704 Committed r108784: <http://trac.webkit.org/changeset/108784> 564271 12 webkit.review.bot 2012-02-24 06:16:45 -0800 All reviewed patches have been landed. Closing bug. 128455 2012-02-23 04:10:41 -0800 2012-02-23 05:01:06 -0800 Patch bug-79356-20120223091038.patch text/plain 2591 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ5ZGU5Njk1OWNlYjhk NmRiYzFlNmNlM2NmYTI0YzFjOWQ3MjQ3YS4uYjMwYmU1YzAzN2Q0MzA2NTVkZmJiMjlmMWEwM2Uz YmFkMDgyMzEwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTIzICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIExpdHRs ZSBvcHRpbWl6YXRpb24gaW4gQ1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MzU2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIG9uZSBsb29wIGJ5IGlu aXRpYWxpemluZyBhcnJheSB2YWx1ZXMgYXQgZGVjbGFyYXRpb24gdGltZS4KKyAgICAgICAgQWxz byBlYXJseSByZXR1cm4gd2hlbiB0aGUgbnVtYmVyIG9mIHByb3BlcnRpZXMgcGFyc2VkIGFyZSBl cXVhbHMKKyAgICAgICAgd2l0aCBsb25naGFuZHMgY291bnQgb2YgdGhlIHNob3J0aGFuZC4gSXQg aGFwcGVucyB0byBiZSB2ZXJ5IG9mdGVuCisgICAgICAgIHRoZSBjYXNlIChlLmcuIGJvcmRlciku IEluc3RydW1lbnRzIHNob3dzIGFuIGltcHJvdmVtZW50IGZyb20gMTltcworICAgICAgICB0byAx N21zIG9uIHRoZSB0aW1lIHNwZW50IGluIHRoaXMgZnVuY3Rpb24gZm9yIHRoZSBjc3MtcGFyc2Vy LXl1aQorICAgICAgICBiZW5jaG1hcmsuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIDogcmVmYWN0 b3IsIGV4aXNpdGluZyBvbmVzIHNob3VsZCBjb3Zlci4KKworICAgICAgICAqIGNzcy9DU1NQYXJz ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZCk6CisK IDIwMTItMDItMjIgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IHdhcm5pbmcgZXh0ZXJuYWwgZm9udCBtaW1lIChmb250L2ZvbnQv d29mZikuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IDAzZjkxYjNkNzM5NTFmYWYzZjcy ZWFjZmM0MDY5ZjgxYzhkNDE4MjYuLmY2ODU2Zjk3YWNhOTA1ZTcxNDAwNTIyYzY5YWYxNTE1NmMz ZjA2NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC0yNjc4LDE2ICsyNjc4LDE3IEBA IGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZChpbnQgcHJvcElkLCBjb25zdCBpbnQgKnBy b3BlcnRpZXMsIGludCBudW1Qcm9wZXJ0CiAgICAgU2hvcnRoYW5kU2NvcGUgc2NvcGUodGhpcywg cHJvcElkKTsKIAogICAgIGJvb2wgZm91bmQgPSBmYWxzZTsKLSAgICBib29sIGZuZFs2XTsgLy8g VHJ1c3QgbWUgOykKLSAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bVByb3BlcnRpZXM7IGkrKykK LSAgICAgICAgZm5kW2ldID0gZmFsc2U7CisgICAgaW50IHByb3BlcnRpZXNQYXJzZWQgPSAwOwor ICAgIGJvb2wgZm5kWzZdPSB7IGZhbHNlIH07IC8vIFRydXN0IG1lIDspCiAKICAgICB3aGlsZSAo bV92YWx1ZUxpc3QtPmN1cnJlbnQoKSkgewogICAgICAgICBmb3VuZCA9IGZhbHNlOwogICAgICAg ICBmb3IgKGludCBwcm9wSW5kZXggPSAwOyAhZm91bmQgJiYgcHJvcEluZGV4IDwgbnVtUHJvcGVy dGllczsgKytwcm9wSW5kZXgpIHsKICAgICAgICAgICAgIGlmICghZm5kW3Byb3BJbmRleF0pIHsK LSAgICAgICAgICAgICAgICBpZiAocGFyc2VWYWx1ZShwcm9wZXJ0aWVzW3Byb3BJbmRleF0sIGlt cG9ydGFudCkpCisgICAgICAgICAgICAgICAgaWYgKHBhcnNlVmFsdWUocHJvcGVydGllc1twcm9w SW5kZXhdLCBpbXBvcnRhbnQpKSB7CiAgICAgICAgICAgICAgICAgICAgIGZuZFtwcm9wSW5kZXhd ID0gZm91bmQgPSB0cnVlOworICAgICAgICAgICAgICAgICAgICBwcm9wZXJ0aWVzUGFyc2VkKys7 CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogICAgICAgICB9CiAKQEAgLTI2OTcs NiArMjY5OCw5IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZChpbnQgcHJvcElkLCBj b25zdCBpbnQgKnByb3BlcnRpZXMsIGludCBudW1Qcm9wZXJ0CiAgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CiAgICAgfQogCisgICAgaWYgKHByb3BlcnRpZXNQYXJzZWQgPT0gbnVtUHJvcGVydGll cykKKyAgICAgICAgcmV0dXJuIHRydWU7CisKICAgICAvLyBGaWxsIGluIGFueSByZW1haW5pbmcg cHJvcGVydGllcyB3aXRoIHRoZSBpbml0aWFsIHZhbHVlLgogICAgIEltcGxpY2l0U2NvcGUgaW1w bGljaXRTY29wZSh0aGlzLCBQcm9wZXJ0eUltcGxpY2l0KTsKICAgICBmb3IgKGludCBpID0gMDsg aSA8IG51bVByb3BlcnRpZXM7ICsraSkgewo= 128460 2012-02-23 05:01:17 -0800 2012-02-23 06:13:00 -0800 Patch bug-79356-20120223100115.patch text/plain 2727 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ5ZGU5Njk1OWNlYjhk NmRiYzFlNmNlM2NmYTI0YzFjOWQ3MjQ3YS4uYjMwYmU1YzAzN2Q0MzA2NTVkZmJiMjlmMWEwM2Uz YmFkMDgyMzEwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTIzICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIExpdHRs ZSBvcHRpbWl6YXRpb24gaW4gQ1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MzU2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIG9uZSBsb29wIGJ5IGlu aXRpYWxpemluZyBhcnJheSB2YWx1ZXMgYXQgZGVjbGFyYXRpb24gdGltZS4KKyAgICAgICAgQWxz byBlYXJseSByZXR1cm4gd2hlbiB0aGUgbnVtYmVyIG9mIHByb3BlcnRpZXMgcGFyc2VkIGFyZSBl cXVhbHMKKyAgICAgICAgd2l0aCBsb25naGFuZHMgY291bnQgb2YgdGhlIHNob3J0aGFuZC4gSXQg aGFwcGVucyB0byBiZSB2ZXJ5IG9mdGVuCisgICAgICAgIHRoZSBjYXNlIChlLmcuIGJvcmRlciku IEluc3RydW1lbnRzIHNob3dzIGFuIGltcHJvdmVtZW50IGZyb20gMTltcworICAgICAgICB0byAx N21zIG9uIHRoZSB0aW1lIHNwZW50IGluIHRoaXMgZnVuY3Rpb24gZm9yIHRoZSBjc3MtcGFyc2Vy LXl1aQorICAgICAgICBiZW5jaG1hcmsuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIDogcmVmYWN0 b3IsIGV4aXNpdGluZyBvbmVzIHNob3VsZCBjb3Zlci4KKworICAgICAgICAqIGNzcy9DU1NQYXJz ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZCk6CisK IDIwMTItMDItMjIgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IHdhcm5pbmcgZXh0ZXJuYWwgZm9udCBtaW1lIChmb250L2ZvbnQv d29mZikuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IDAzZjkxYjNkNzM5NTFmYWYzZjcy ZWFjZmM0MDY5ZjgxYzhkNDE4MjYuLmY3Mzg5M2FlYmQzNTVmNTEwYTkzOTU3MmRmMWJkZGE3Mzc3 ZDIwNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC0yNjc4LDE2ICsyNjc4LDE4IEBA IGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZChpbnQgcHJvcElkLCBjb25zdCBpbnQgKnBy b3BlcnRpZXMsIGludCBudW1Qcm9wZXJ0CiAgICAgU2hvcnRoYW5kU2NvcGUgc2NvcGUodGhpcywg cHJvcElkKTsKIAogICAgIGJvb2wgZm91bmQgPSBmYWxzZTsKLSAgICBib29sIGZuZFs2XTsgLy8g VHJ1c3QgbWUgOykKLSAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bVByb3BlcnRpZXM7IGkrKykK LSAgICAgICAgZm5kW2ldID0gZmFsc2U7CisgICAgaW50IHByb3BlcnRpZXNQYXJzZWQgPSAwOwor ICAgIGJvb2wgZm5kWzZdPSB7IGZhbHNlLCBmYWxzZSwgZmFsc2UsIGZhbHNlLCBmYWxzZSwgZmFs c2UgfTsgLy8gVHJ1c3QgbWUgOykKIAorICAgIGludCBwcm9wSW5kZXg7CiAgICAgd2hpbGUgKG1f dmFsdWVMaXN0LT5jdXJyZW50KCkpIHsKICAgICAgICAgZm91bmQgPSBmYWxzZTsKLSAgICAgICAg Zm9yIChpbnQgcHJvcEluZGV4ID0gMDsgIWZvdW5kICYmIHByb3BJbmRleCA8IG51bVByb3BlcnRp ZXM7ICsrcHJvcEluZGV4KSB7CisgICAgICAgIGZvciAocHJvcEluZGV4ID0gMDsgIWZvdW5kICYm IHByb3BJbmRleCA8IG51bVByb3BlcnRpZXM7ICsrcHJvcEluZGV4KSB7CiAgICAgICAgICAgICBp ZiAoIWZuZFtwcm9wSW5kZXhdKSB7Ci0gICAgICAgICAgICAgICAgaWYgKHBhcnNlVmFsdWUocHJv cGVydGllc1twcm9wSW5kZXhdLCBpbXBvcnRhbnQpKQorICAgICAgICAgICAgICAgIGlmIChwYXJz ZVZhbHVlKHByb3BlcnRpZXNbcHJvcEluZGV4XSwgaW1wb3J0YW50KSkgewogICAgICAgICAgICAg ICAgICAgICBmbmRbcHJvcEluZGV4XSA9IGZvdW5kID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAg ICAgcHJvcGVydGllc1BhcnNlZCsrOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0K ICAgICAgICAgfQogCkBAIC0yNjk3LDYgKzI2OTksOSBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VT aG9ydGhhbmQoaW50IHByb3BJZCwgY29uc3QgaW50ICpwcm9wZXJ0aWVzLCBpbnQgbnVtUHJvcGVy dAogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAorICAgIGlmIChwcm9wZXJ0aWVz UGFyc2VkID09IG51bVByb3BlcnRpZXMpCisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAgLy8g RmlsbCBpbiBhbnkgcmVtYWluaW5nIHByb3BlcnRpZXMgd2l0aCB0aGUgaW5pdGlhbCB2YWx1ZS4K ICAgICBJbXBsaWNpdFNjb3BlIGltcGxpY2l0U2NvcGUodGhpcywgUHJvcGVydHlJbXBsaWNpdCk7 CiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBudW1Qcm9wZXJ0aWVzOyArK2kpIHsK 128470 2012-02-23 06:13:11 -0800 2012-02-24 03:53:34 -0800 Patch bug-79356-20120223111308.patch text/plain 2626 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ5ZGU5Njk1OWNlYjhk NmRiYzFlNmNlM2NmYTI0YzFjOWQ3MjQ3YS4uYjMwYmU1YzAzN2Q0MzA2NTVkZmJiMjlmMWEwM2Uz YmFkMDgyMzEwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTIzICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIExpdHRs ZSBvcHRpbWl6YXRpb24gaW4gQ1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MzU2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIG9uZSBsb29wIGJ5IGlu aXRpYWxpemluZyBhcnJheSB2YWx1ZXMgYXQgZGVjbGFyYXRpb24gdGltZS4KKyAgICAgICAgQWxz byBlYXJseSByZXR1cm4gd2hlbiB0aGUgbnVtYmVyIG9mIHByb3BlcnRpZXMgcGFyc2VkIGFyZSBl cXVhbHMKKyAgICAgICAgd2l0aCBsb25naGFuZHMgY291bnQgb2YgdGhlIHNob3J0aGFuZC4gSXQg aGFwcGVucyB0byBiZSB2ZXJ5IG9mdGVuCisgICAgICAgIHRoZSBjYXNlIChlLmcuIGJvcmRlciku IEluc3RydW1lbnRzIHNob3dzIGFuIGltcHJvdmVtZW50IGZyb20gMTltcworICAgICAgICB0byAx N21zIG9uIHRoZSB0aW1lIHNwZW50IGluIHRoaXMgZnVuY3Rpb24gZm9yIHRoZSBjc3MtcGFyc2Vy LXl1aQorICAgICAgICBiZW5jaG1hcmsuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIDogcmVmYWN0 b3IsIGV4aXNpdGluZyBvbmVzIHNob3VsZCBjb3Zlci4KKworICAgICAgICAqIGNzcy9DU1NQYXJz ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZCk6CisK IDIwMTItMDItMjIgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IHdhcm5pbmcgZXh0ZXJuYWwgZm9udCBtaW1lIChmb250L2ZvbnQv d29mZikuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IDAzZjkxYjNkNzM5NTFmYWYzZjcy ZWFjZmM0MDY5ZjgxYzhkNDE4MjYuLmYxNTI3YmMxNGE1YzgwMWQ3OTEyMmYzZmRhMTdlZTAxZmEy ZjYyMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC0yNjc4LDE2ICsyNjc4LDE3IEBA IGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZChpbnQgcHJvcElkLCBjb25zdCBpbnQgKnBy b3BlcnRpZXMsIGludCBudW1Qcm9wZXJ0CiAgICAgU2hvcnRoYW5kU2NvcGUgc2NvcGUodGhpcywg cHJvcElkKTsKIAogICAgIGJvb2wgZm91bmQgPSBmYWxzZTsKLSAgICBib29sIGZuZFs2XTsgLy8g VHJ1c3QgbWUgOykKLSAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bVByb3BlcnRpZXM7IGkrKykK LSAgICAgICAgZm5kW2ldID0gZmFsc2U7CisgICAgaW50IHByb3BlcnRpZXNQYXJzZWQgPSAwOwor ICAgIGJvb2wgZm5kWzZdPSB7IGZhbHNlLCBmYWxzZSwgZmFsc2UsIGZhbHNlLCBmYWxzZSwgZmFs c2UgfTsgLy8gVHJ1c3QgbWUgOykKIAogICAgIHdoaWxlIChtX3ZhbHVlTGlzdC0+Y3VycmVudCgp KSB7CiAgICAgICAgIGZvdW5kID0gZmFsc2U7CiAgICAgICAgIGZvciAoaW50IHByb3BJbmRleCA9 IDA7ICFmb3VuZCAmJiBwcm9wSW5kZXggPCBudW1Qcm9wZXJ0aWVzOyArK3Byb3BJbmRleCkgewog ICAgICAgICAgICAgaWYgKCFmbmRbcHJvcEluZGV4XSkgewotICAgICAgICAgICAgICAgIGlmIChw YXJzZVZhbHVlKHByb3BlcnRpZXNbcHJvcEluZGV4XSwgaW1wb3J0YW50KSkKKyAgICAgICAgICAg ICAgICBpZiAocGFyc2VWYWx1ZShwcm9wZXJ0aWVzW3Byb3BJbmRleF0sIGltcG9ydGFudCkpIHsK ICAgICAgICAgICAgICAgICAgICAgZm5kW3Byb3BJbmRleF0gPSBmb3VuZCA9IHRydWU7CisgICAg ICAgICAgICAgICAgICAgIHByb3BlcnRpZXNQYXJzZWQrKzsKKyAgICAgICAgICAgICAgICB9CiAg ICAgICAgICAgICB9CiAgICAgICAgIH0KIApAQCAtMjY5Nyw2ICsyNjk4LDkgQEAgYm9vbCBDU1NQ YXJzZXI6OnBhcnNlU2hvcnRoYW5kKGludCBwcm9wSWQsIGNvbnN0IGludCAqcHJvcGVydGllcywg aW50IG51bVByb3BlcnQKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKKyAgICBp ZiAocHJvcGVydGllc1BhcnNlZCA9PSBudW1Qcm9wZXJ0aWVzKQorICAgICAgICByZXR1cm4gdHJ1 ZTsKKwogICAgIC8vIEZpbGwgaW4gYW55IHJlbWFpbmluZyBwcm9wZXJ0aWVzIHdpdGggdGhlIGlu aXRpYWwgdmFsdWUuCiAgICAgSW1wbGljaXRTY29wZSBpbXBsaWNpdFNjb3BlKHRoaXMsIFByb3Bl cnR5SW1wbGljaXQpOwogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVtUHJvcGVydGllczsgKytp KSB7Cg== 128704 2012-02-24 03:53:44 -0800 2012-02-24 06:16:37 -0800 Patch for landing bug-79356-20120224085342.patch text/plain 2624 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ5ZGU5Njk1OWNlYjhk NmRiYzFlNmNlM2NmYTI0YzFjOWQ3MjQ3YS4uZDYxZTgzMzI3NGJiZWExYmI2YmFhMmVjNjRjZWE4 OGM0M2EwNmU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTIzICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIExpdHRs ZSBvcHRpbWl6YXRpb24gaW4gQ1NTUGFyc2VyOjpwYXJzZVNob3J0aGFuZC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MzU2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgVG9ueSBDaGFuZy4KKworICAgICAgICBSZW1vdmUgb25lIGxvb3AgYnkgaW5pdGlh bGl6aW5nIGFycmF5IHZhbHVlcyBhdCBkZWNsYXJhdGlvbiB0aW1lLgorICAgICAgICBBbHNvIGVh cmx5IHJldHVybiB3aGVuIHRoZSBudW1iZXIgb2YgcHJvcGVydGllcyBwYXJzZWQgYXJlIGVxdWFs cworICAgICAgICB3aXRoIGxvbmdoYW5kcyBjb3VudCBvZiB0aGUgc2hvcnRoYW5kLiBJdCBoYXBw ZW5zIHRvIGJlIHZlcnkgb2Z0ZW4KKyAgICAgICAgdGhlIGNhc2UgKGUuZy4gYm9yZGVyKS4gSW5z dHJ1bWVudHMgc2hvd3MgYW4gaW1wcm92ZW1lbnQgZnJvbSAxOW1zCisgICAgICAgIHRvIDE3bXMg b24gdGhlIHRpbWUgc3BlbnQgaW4gdGhpcyBmdW5jdGlvbiBmb3IgdGhlIGNzcy1wYXJzZXIteXVp CisgICAgICAgIGJlbmNobWFyay4KKworICAgICAgICBObyBuZXcgdGVzdHMgOiByZWZhY3Rvciwg ZXhpc2l0aW5nIG9uZXMgc2hvdWxkIGNvdmVyLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlU2hvcnRoYW5kKToKKwogMjAx Mi0wMi0yMiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2dsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3Rvcjogd2FybmluZyBleHRlcm5hbCBmb250IG1pbWUgKGZvbnQvZm9udC93b2Zm KS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggMDNmOTFiM2Q3Mzk1MWZhZjNmNzJlYWNm YzQwNjlmODFjOGQ0MTgyNi4uNzU2OTA3MzE1N2JiZDcwMjRlYWEwYTc5ZmQyZGYxZmE5OGJkMmQw MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTI2NzgsMTYgKzI2NzgsMTUgQEAgYm9v bCBDU1NQYXJzZXI6OnBhcnNlU2hvcnRoYW5kKGludCBwcm9wSWQsIGNvbnN0IGludCAqcHJvcGVy dGllcywgaW50IG51bVByb3BlcnQKICAgICBTaG9ydGhhbmRTY29wZSBzY29wZSh0aGlzLCBwcm9w SWQpOwogCiAgICAgYm9vbCBmb3VuZCA9IGZhbHNlOwotICAgIGJvb2wgZm5kWzZdOyAvLyBUcnVz dCBtZSA7KQotICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVtUHJvcGVydGllczsgaSsrKQotICAg ICAgICBmbmRbaV0gPSBmYWxzZTsKKyAgICBpbnQgcHJvcGVydGllc1BhcnNlZCA9IDA7CisgICAg Ym9vbCBmbmRbNl09IHsgZmFsc2UsIGZhbHNlLCBmYWxzZSwgZmFsc2UsIGZhbHNlLCBmYWxzZSB9 OyAvLyA2IGlzIGVub3VnaCBzaXplLgogCiAgICAgd2hpbGUgKG1fdmFsdWVMaXN0LT5jdXJyZW50 KCkpIHsKICAgICAgICAgZm91bmQgPSBmYWxzZTsKICAgICAgICAgZm9yIChpbnQgcHJvcEluZGV4 ID0gMDsgIWZvdW5kICYmIHByb3BJbmRleCA8IG51bVByb3BlcnRpZXM7ICsrcHJvcEluZGV4KSB7 Ci0gICAgICAgICAgICBpZiAoIWZuZFtwcm9wSW5kZXhdKSB7Ci0gICAgICAgICAgICAgICAgaWYg KHBhcnNlVmFsdWUocHJvcGVydGllc1twcm9wSW5kZXhdLCBpbXBvcnRhbnQpKQorICAgICAgICAg ICAgaWYgKCFmbmRbcHJvcEluZGV4XSAmJiBwYXJzZVZhbHVlKHByb3BlcnRpZXNbcHJvcEluZGV4 XSwgaW1wb3J0YW50KSkgewogICAgICAgICAgICAgICAgICAgICBmbmRbcHJvcEluZGV4XSA9IGZv dW5kID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAgICAgcHJvcGVydGllc1BhcnNlZCsrOwogICAg ICAgICAgICAgfQogICAgICAgICB9CiAKQEAgLTI2OTcsNiArMjY5Niw5IEBAIGJvb2wgQ1NTUGFy c2VyOjpwYXJzZVNob3J0aGFuZChpbnQgcHJvcElkLCBjb25zdCBpbnQgKnByb3BlcnRpZXMsIGlu dCBudW1Qcm9wZXJ0CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCisgICAgaWYg KHByb3BlcnRpZXNQYXJzZWQgPT0gbnVtUHJvcGVydGllcykKKyAgICAgICAgcmV0dXJuIHRydWU7 CisKICAgICAvLyBGaWxsIGluIGFueSByZW1haW5pbmcgcHJvcGVydGllcyB3aXRoIHRoZSBpbml0 aWFsIHZhbHVlLgogICAgIEltcGxpY2l0U2NvcGUgaW1wbGljaXRTY29wZSh0aGlzLCBQcm9wZXJ0 eUltcGxpY2l0KTsKICAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bVByb3BlcnRpZXM7ICsraSkg ewo=