79352 2012-02-23 02:25:26 -0800 [GTK] Wrong signal name on emission in WebKitWindowProperties.cpp 2012-02-23 16:08:15 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned cgarcia pnormand webkit.review.bot oldest_to_newest 562986 0 mario 2012-02-23 02:25:26 -0800 In WebKitWindowProperties::webkitWindowPropertiesSetResizable, we currently have this: void webkitWindowPropertiesSetResizable(WebKitWindowProperties* windowProperties, bool resizable) { if (windowProperties->priv->resizable == resizable) return; windowProperties->priv->resizable = resizable; g_object_notify(G_OBJECT(windowProperties), "resizable-visible"); } ...which is a mistake since the signal is called 'resizable', not 'resizable-visible' 562988 1 cgarcia 2012-02-23 02:28:25 -0800 Right, it's a copy-paste error. 562989 2 128443 mario 2012-02-23 02:28:42 -0800 Created attachment 128443 Patch 562992 3 128443 cgarcia 2012-02-23 02:31:25 -0800 Comment on attachment 128443 Patch Correct 563625 4 128443 webkit.review.bot 2012-02-23 16:08:06 -0800 Comment on attachment 128443 Patch Clearing flags on attachment: 128443 Committed r108694: <http://trac.webkit.org/changeset/108694> 563626 5 webkit.review.bot 2012-02-23 16:08:15 -0800 All reviewed patches have been landed. Closing bug. 128443 2012-02-23 02:28:42 -0800 2012-02-23 16:08:06 -0800 Patch 0001-2012-02-23-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2276 mario RnJvbSBjMDZhNWJjNzFlODgyNGM5ZjM1NWZjYjQxYWNhNDIyZTk1NWIxZjRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDIzIEZlYiAyMDEyIDExOjI3OjA0ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMi0wMi0yMyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdIFdyb25nIHNpZ25hbCBuYW1lIG9uIGVtaXNzaW9uIGluIFdlYktpdFdp bmRvd1Byb3BlcnRpZXMuY3BwCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc5MzUyCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAg ICAgICBFbWl0IHRoZSBzaWduYWwgJ3Jlc2l6YWJsZScgaW5zdGVhZCBvZiAncmVzaXphYmxlLXZp c2libGUnLgoKICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdpbmRvd1Byb3BlcnRp ZXMuY3BwOgogICAgICAgICh3ZWJraXRXaW5kb3dQcm9wZXJ0aWVzU2V0UmVzaXphYmxlKTogVXNl IHJpZ2h0IHNpZ25hbCBuYW1lLgotLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIC4uLi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXaW5kb3dQcm9wZXJ0aWVzLmNwcCAgIHwgICAgMiArLQogMiBmaWxlcyBjaGFu Z2VkLCAxMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA5NWE3 NjM0Li45OTQ4MzQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDItMjMgIE1h cmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtd IFdyb25nIHNpZ25hbCBuYW1lIG9uIGVtaXNzaW9uIGluIFdlYktpdFdpbmRvd1Byb3BlcnRpZXMu Y3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTM1 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVtaXQg dGhlIHNpZ25hbCAncmVzaXphYmxlJyBpbnN0ZWFkIG9mICdyZXNpemFibGUtdmlzaWJsZScuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXaW5kb3dQcm9wZXJ0aWVzLmNwcDoK KyAgICAgICAgKHdlYmtpdFdpbmRvd1Byb3BlcnRpZXNTZXRSZXNpemFibGUpOiBVc2UgcmlnaHQg c2lnbmFsIG5hbWUuCisKIDIwMTItMDItMjIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmVtb3ZlIHRoZSByZW1haW5pbmcgdXNlcyBvZiBDU1NTdHlsZURlY2xh cmF0aW9uIGluIEVkaXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2luZG93UHJvcGVydGllcy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRXaW5kb3dQcm9wZXJ0aWVzLmNwcAppbmRleCA0MTM4OTAyLi4yNDJi NzUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX aW5kb3dQcm9wZXJ0aWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRXaW5kb3dQcm9wZXJ0aWVzLmNwcApAQCAtMzc3LDcgKzM3Nyw3IEBAIHZvaWQgd2Vi a2l0V2luZG93UHJvcGVydGllc1NldFJlc2l6YWJsZShXZWJLaXRXaW5kb3dQcm9wZXJ0aWVzKiB3 aW5kb3dQcm9wZXJ0aWVzCiAgICAgaWYgKHdpbmRvd1Byb3BlcnRpZXMtPnByaXYtPnJlc2l6YWJs ZSA9PSByZXNpemFibGUpCiAgICAgICAgIHJldHVybjsKICAgICB3aW5kb3dQcm9wZXJ0aWVzLT5w cml2LT5yZXNpemFibGUgPSByZXNpemFibGU7Ci0gICAgZ19vYmplY3Rfbm90aWZ5KEdfT0JKRUNU KHdpbmRvd1Byb3BlcnRpZXMpLCAicmVzaXphYmxlLXZpc2libGUiKTsKKyAgICBnX29iamVjdF9u b3RpZnkoR19PQkpFQ1Qod2luZG93UHJvcGVydGllcyksICJyZXNpemFibGUiKTsKIH0KIAogdm9p ZCB3ZWJraXRXaW5kb3dQcm9wZXJ0aWVzU2V0RnVsbHNjcmVlbihXZWJLaXRXaW5kb3dQcm9wZXJ0 aWVzKiB3aW5kb3dQcm9wZXJ0aWVzLCBib29sIGZ1bGxzY3JlZW4pCi0tIAoxLjcuNy41Cgo=