79345 2012-02-23 01:13:09 -0800 [CMake] Add FindQuickTimeSDK 2012-02-23 11:07:03 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72816 1 paroga paroga aroben dbates rakuco oldest_to_newest 562945 0 paroga 2012-02-23 01:13:09 -0800 [CMake] Add FindQuickTimeSDK 562946 1 128428 paroga 2012-02-23 01:15:48 -0800 Created attachment 128428 Patch 563057 2 128428 rakuco 2012-02-23 05:54:53 -0800 Comment on attachment 128428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128428&action=review > Source/cmake/FindQuickTimeSDK.cmake:10 > + "C:/Program Files (x86)/QuickTime SDK/CIncludes" > + "C:/Program Files/QuickTime SDK/CIncludes" I'd more explicit and prefix this list of hardcoded paths with PATHS. > Source/cmake/FindQuickTimeSDK.cmake:13 > +SET(QuickTimeSDK_LIBRARY_PATH "${QuickTimeSDK_INCLUDE_DIRS}/../Libraries") Isn't GET_FILENAME_COMPONENT(.. .. ABSOLUTE) cleaner? > Source/cmake/FindQuickTimeSDK.cmake:20 > +FIND_PACKAGE_HANDLE_STANDARD_ARGS(QuickTimeSDK DEFAULT_MSG QuickTimeSDK_LIBRARIES QuickTimeSDK_INCLUDE_DIRS) I'd mark_as_advanced the user-visible variables. 563201 3 128493 paroga 2012-02-23 10:18:23 -0800 Created attachment 128493 Patch 563213 4 128493 rakuco 2012-02-23 10:28:40 -0800 Comment on attachment 128493 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128493&action=review > Source/cmake/FindQuickTimeSDK.cmake:13 > +SET(QuickTimeSDK_LIBRARY_PATH "${QuickTimeSDK_INCLUDE_DIRS}/../Libraries") GET_FILENAME_COMPONENT? > Source/cmake/FindQuickTimeSDK.cmake:18 > +# handle the QUIETLY and REQUIRED arguments and set DirectX_FOUND to TRUE if all listed variables are TRUE s/DirectX/QuickTimeSDK/? 563228 5 paroga 2012-02-23 10:34:52 -0800 (In reply to comment #4) > (From update of attachment 128493 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=128493&action=review > > > Source/cmake/FindQuickTimeSDK.cmake:13 > > +SET(QuickTimeSDK_LIBRARY_PATH "${QuickTimeSDK_INCLUDE_DIRS}/../Libraries") > > GET_FILENAME_COMPONENT? IMHO overkill here, since the LIBRARY_PATH is no "public" variable and is resolved in FIND_LIBRARY anyway... > > Source/cmake/FindQuickTimeSDK.cmake:18 > > +# handle the QUIETLY and REQUIRED arguments and set DirectX_FOUND to TRUE if all listed variables are TRUE > > s/DirectX/QuickTimeSDK/? thx 563233 6 128498 paroga 2012-02-23 10:36:31 -0800 Created attachment 128498 Patch 563237 7 128498 rakuco 2012-02-23 10:39:34 -0800 Comment on attachment 128498 Patch Looks OK. 563239 8 128498 aroben 2012-02-23 10:40:08 -0800 Comment on attachment 128498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128498&action=review > Source/cmake/FindQuickTimeSDK.cmake:10 > + "C:/Program Files (x86)/QuickTime SDK/CIncludes" > + "C:/Program Files/QuickTime SDK/CIncludes" Should we use $ENV{PROGRAMFILES} and $ENV{PROGRAMFILES(X86)} here? 563269 9 paroga 2012-02-23 11:07:03 -0800 Committed r108644: <http://trac.webkit.org/changeset/108644> 128428 2012-02-23 01:15:48 -0800 2012-02-23 10:18:06 -0800 Patch bug-79345-20120223101551.patch text/plain 1956 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZFF1aWNrVGltZVNESy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kUXVpY2tUaW1lU0RLLmNtYWtl Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmJmN2ZlOGUyMDAxMzM3OGNkZjljMWFlMjU5ZmNmMTA3ZDRhYWY1YzUKLS0t IC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvY21ha2UvRmluZFF1aWNrVGltZVNESy5jbWFrZQpAQCAt MCwwICsxLDIwIEBACisjIC0gRmluZCBRdWlja1RpbWUgU0RLIGluc3RhbGxhdGlvbg0KKyMgRmlu ZCB0aGUgUXVpY2tUaW1lIGluY2x1ZGVzIGFuZCBsaWJyYXJ5DQorIyBUaGlzIG1vZHVsZSBkZWZp bmVzDQorIyAgUXVpY2tUaW1lX0lOQ0xVREVfRElSUywgd2hlcmUgdG8gZmluZCBRdWlja1RpbWUu aCwgZXRjLg0KKyMgIFF1aWNrVGltZV9MSUJSQVJJRVMsIGxpYnJhcmllcyB0byBsaW5rIGFnYWlu c3QgdG8gdXNlIFF1aWNrVGltZS4NCisjICBRdWlja1RpbWVfRk9VTkQsIElmIGZhbHNlLCBkbyBu b3QgdHJ5IHRvIHVzZSBRdWlja1RpbWUuDQorDQorRklORF9QQVRIKFF1aWNrVGltZVNES19JTkNM VURFX0RJUlMgUXVpY2tUaW1lLmgNCisgICAgIkM6L1Byb2dyYW0gRmlsZXMgKHg4NikvUXVpY2tU aW1lIFNESy9DSW5jbHVkZXMiDQorICAgICJDOi9Qcm9ncmFtIEZpbGVzL1F1aWNrVGltZSBTREsv Q0luY2x1ZGVzIg0KKykNCisNCitTRVQoUXVpY2tUaW1lU0RLX0xJQlJBUllfUEFUSCAiJHtRdWlj a1RpbWVTREtfSU5DTFVERV9ESVJTfS8uLi9MaWJyYXJpZXMiKQ0KK0ZJTkRfTElCUkFSWShRdWlj a1RpbWVTREtfQ1ZDbGllbnRfTElCUkFSWSBDVkNsaWVudCAke1F1aWNrVGltZVNES19MSUJSQVJZ X1BBVEh9IE5PX0RFRkFVTFRfUEFUSCkNCitGSU5EX0xJQlJBUlkoUXVpY2tUaW1lU0RLX1FUTUxD bGllbnRfTElCUkFSWSBRVE1MQ2xpZW50ICR7UXVpY2tUaW1lU0RLX0xJQlJBUllfUEFUSH0gTk9f REVGQVVMVF9QQVRIKQ0KK1NFVChRdWlja1RpbWVTREtfTElCUkFSSUVTICR7UXVpY2tUaW1lU0RL X0NWQ2xpZW50X0xJQlJBUll9ICR7UXVpY2tUaW1lU0RLX1FUTUxDbGllbnRfTElCUkFSWX0pDQor DQorIyBoYW5kbGUgdGhlIFFVSUVUTFkgYW5kIFJFUVVJUkVEIGFyZ3VtZW50cyBhbmQgc2V0IFF1 aWNrVGltZVNES19GT1VORCB0byBUUlVFIGlmIGFsbCBsaXN0ZWQgdmFyaWFibGVzIGFyZSBUUlVF DQorSU5DTFVERShGaW5kUGFja2FnZUhhbmRsZVN0YW5kYXJkQXJncykNCitGSU5EX1BBQ0tBR0Vf SEFORExFX1NUQU5EQVJEX0FSR1MoUXVpY2tUaW1lU0RLIERFRkFVTFRfTVNHIFF1aWNrVGltZVNE S19MSUJSQVJJRVMgUXVpY2tUaW1lU0RLX0lOQ0xVREVfRElSUykNCmRpZmYgLS1naXQgYS9DaGFu Z2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNmZmNjNkNTdkM2U3ZTRkZmM0NWVmY2QwY2EyYjA5NjMx ZjA3ZDdkMS4uODE1ZjNiNzNlODIzZTNkYzY5MjVlYmI4NjM2N2YyY2MzZjhjNTdjYiAxMDA2NDQK LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAy LTIzICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFtD TWFrZV0gQWRkIEZpbmRRdWlja1RpbWVTREsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc5MzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZFF1aWNrVGltZVNESy5jbWFrZTog QWRkZWQuCisKIDIwMTItMDItMjIgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVz aW9uLm1vYmk+CiAKICAgICAgICAgW0NNYWtlXSBSZW1vdmUgRmluZEdESy5jbWFrZSBhbmQgRmlu ZEdESy1QaXhCdWYuY21ha2UK 128493 2012-02-23 10:18:23 -0800 2012-02-23 10:36:21 -0800 Patch bug-79345-20120223191827.patch text/plain 2065 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZFF1aWNrVGltZVNESy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kUXVpY2tUaW1lU0RLLmNtYWtl Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjFjM2EyZTNhMTgxM2FjNDM1MGVhY2Y4ODQzZGVhNzQyM2NhMDEwZWQKLS0t IC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvY21ha2UvRmluZFF1aWNrVGltZVNESy5jbWFrZQpAQCAt MCwwICsxLDIxIEBACisjIC0gRmluZCBRdWlja1RpbWUgU0RLIGluc3RhbGxhdGlvbg0KKyMgRmlu ZCB0aGUgUXVpY2tUaW1lIGluY2x1ZGVzIGFuZCBsaWJyYXJ5DQorIyBUaGlzIG1vZHVsZSBkZWZp bmVzDQorIyAgUXVpY2tUaW1lX0lOQ0xVREVfRElSUywgd2hlcmUgdG8gZmluZCBRdWlja1RpbWUu aCwgZXRjLg0KKyMgIFF1aWNrVGltZV9MSUJSQVJJRVMsIGxpYnJhcmllcyB0byBsaW5rIGFnYWlu c3QgdG8gdXNlIFF1aWNrVGltZS4NCisjICBRdWlja1RpbWVfRk9VTkQsIElmIGZhbHNlLCBkbyBu b3QgdHJ5IHRvIHVzZSBRdWlja1RpbWUuDQorDQorRklORF9QQVRIKFF1aWNrVGltZVNES19JTkNM VURFX0RJUlMgUXVpY2tUaW1lLmggUEFUSFMNCisgICAgIkM6L1Byb2dyYW0gRmlsZXMgKHg4Nikv UXVpY2tUaW1lIFNESy9DSW5jbHVkZXMiDQorICAgICJDOi9Qcm9ncmFtIEZpbGVzL1F1aWNrVGlt ZSBTREsvQ0luY2x1ZGVzIg0KKykNCisNCitTRVQoUXVpY2tUaW1lU0RLX0xJQlJBUllfUEFUSCAi JHtRdWlja1RpbWVTREtfSU5DTFVERV9ESVJTfS8uLi9MaWJyYXJpZXMiKQ0KK0ZJTkRfTElCUkFS WShRdWlja1RpbWVTREtfQ1ZDbGllbnRfTElCUkFSWSBDVkNsaWVudCAke1F1aWNrVGltZVNES19M SUJSQVJZX1BBVEh9IE5PX0RFRkFVTFRfUEFUSCkNCitGSU5EX0xJQlJBUlkoUXVpY2tUaW1lU0RL X1FUTUxDbGllbnRfTElCUkFSWSBRVE1MQ2xpZW50ICR7UXVpY2tUaW1lU0RLX0xJQlJBUllfUEFU SH0gTk9fREVGQVVMVF9QQVRIKQ0KK1NFVChRdWlja1RpbWVTREtfTElCUkFSSUVTICR7UXVpY2tU aW1lU0RLX0NWQ2xpZW50X0xJQlJBUll9ICR7UXVpY2tUaW1lU0RLX1FUTUxDbGllbnRfTElCUkFS WX0pDQorDQorIyBoYW5kbGUgdGhlIFFVSUVUTFkgYW5kIFJFUVVJUkVEIGFyZ3VtZW50cyBhbmQg c2V0IERpcmVjdFhfRk9VTkQgdG8gVFJVRSBpZiBhbGwgbGlzdGVkIHZhcmlhYmxlcyBhcmUgVFJV RQ0KK0lOQ0xVREUoRmluZFBhY2thZ2VIYW5kbGVTdGFuZGFyZEFyZ3MpDQorRklORF9QQUNLQUdF X0hBTkRMRV9TVEFOREFSRF9BUkdTKFF1aWNrVGltZVNESyBERUZBVUxUX01TRyBRdWlja1RpbWVT REtfTElCUkFSSUVTIFF1aWNrVGltZVNES19JTkNMVURFX0RJUlMpDQorTUFSS19BU19BRFZBTkNF RChRdWlja1RpbWVTREtfSU5DTFVERV9ESVJTIFF1aWNrVGltZVNES19DVkNsaWVudF9MSUJSQVJZ IFF1aWNrVGltZVNES19RVE1MQ2xpZW50X0xJQlJBUlkpDQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IDZmZjYzZDU3ZDNlN2U0ZGZjNDVlZmNkMGNhMmIwOTYzMWYwN2Q3 ZDEuLjgxNWYzYjczZTgyM2UzZGM2OTI1ZWJiODYzNjdmMmNjM2Y4YzU3Y2IgMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0wMi0yMyAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBbQ01ha2Vd IEFkZCBGaW5kUXVpY2tUaW1lU0RLCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03OTM0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRRdWlja1RpbWVTREsuY21ha2U6IEFkZGVk LgorCiAyMDEyLTAyLTIyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5t b2JpPgogCiAgICAgICAgIFtDTWFrZV0gUmVtb3ZlIEZpbmRHREsuY21ha2UgYW5kIEZpbmRHREst UGl4QnVmLmNtYWtlCg== 128498 2012-02-23 10:36:31 -0800 2012-02-23 10:40:08 -0800 Patch bug-79345-20120223193635.patch text/plain 2070 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZFF1aWNrVGltZVNESy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kUXVpY2tUaW1lU0RLLmNtYWtl Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjk1ODliMmU2NmRjYzE4Yzg4ZWNjZTZiNGJkM2JiYmVhMzM4MDVjMWEKLS0t IC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvY21ha2UvRmluZFF1aWNrVGltZVNESy5jbWFrZQpAQCAt MCwwICsxLDIxIEBACisjIC0gRmluZCBRdWlja1RpbWUgU0RLIGluc3RhbGxhdGlvbg0KKyMgRmlu ZCB0aGUgUXVpY2tUaW1lIGluY2x1ZGVzIGFuZCBsaWJyYXJ5DQorIyBUaGlzIG1vZHVsZSBkZWZp bmVzDQorIyAgUXVpY2tUaW1lX0lOQ0xVREVfRElSUywgd2hlcmUgdG8gZmluZCBRdWlja1RpbWUu aCwgZXRjLg0KKyMgIFF1aWNrVGltZV9MSUJSQVJJRVMsIGxpYnJhcmllcyB0byBsaW5rIGFnYWlu c3QgdG8gdXNlIFF1aWNrVGltZS4NCisjICBRdWlja1RpbWVfRk9VTkQsIElmIGZhbHNlLCBkbyBu b3QgdHJ5IHRvIHVzZSBRdWlja1RpbWUuDQorDQorRklORF9QQVRIKFF1aWNrVGltZVNES19JTkNM VURFX0RJUlMgUXVpY2tUaW1lLmggUEFUSFMNCisgICAgIkM6L1Byb2dyYW0gRmlsZXMgKHg4Nikv UXVpY2tUaW1lIFNESy9DSW5jbHVkZXMiDQorICAgICJDOi9Qcm9ncmFtIEZpbGVzL1F1aWNrVGlt ZSBTREsvQ0luY2x1ZGVzIg0KKykNCisNCitTRVQoUXVpY2tUaW1lU0RLX0xJQlJBUllfUEFUSCAi JHtRdWlja1RpbWVTREtfSU5DTFVERV9ESVJTfS8uLi9MaWJyYXJpZXMiKQ0KK0ZJTkRfTElCUkFS WShRdWlja1RpbWVTREtfQ1ZDbGllbnRfTElCUkFSWSBDVkNsaWVudCAke1F1aWNrVGltZVNES19M SUJSQVJZX1BBVEh9IE5PX0RFRkFVTFRfUEFUSCkNCitGSU5EX0xJQlJBUlkoUXVpY2tUaW1lU0RL X1FUTUxDbGllbnRfTElCUkFSWSBRVE1MQ2xpZW50ICR7UXVpY2tUaW1lU0RLX0xJQlJBUllfUEFU SH0gTk9fREVGQVVMVF9QQVRIKQ0KK1NFVChRdWlja1RpbWVTREtfTElCUkFSSUVTICR7UXVpY2tU aW1lU0RLX0NWQ2xpZW50X0xJQlJBUll9ICR7UXVpY2tUaW1lU0RLX1FUTUxDbGllbnRfTElCUkFS WX0pDQorDQorIyBoYW5kbGUgdGhlIFFVSUVUTFkgYW5kIFJFUVVJUkVEIGFyZ3VtZW50cyBhbmQg c2V0IFF1aWNrVGltZVNES19GT1VORCB0byBUUlVFIGlmIGFsbCBsaXN0ZWQgdmFyaWFibGVzIGFy ZSBUUlVFDQorSU5DTFVERShGaW5kUGFja2FnZUhhbmRsZVN0YW5kYXJkQXJncykNCitGSU5EX1BB Q0tBR0VfSEFORExFX1NUQU5EQVJEX0FSR1MoUXVpY2tUaW1lU0RLIERFRkFVTFRfTVNHIFF1aWNr VGltZVNES19MSUJSQVJJRVMgUXVpY2tUaW1lU0RLX0lOQ0xVREVfRElSUykNCitNQVJLX0FTX0FE VkFOQ0VEKFF1aWNrVGltZVNES19JTkNMVURFX0RJUlMgUXVpY2tUaW1lU0RLX0NWQ2xpZW50X0xJ QlJBUlkgUXVpY2tUaW1lU0RLX1FUTUxDbGllbnRfTElCUkFSWSkNCmRpZmYgLS1naXQgYS9DaGFu Z2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNmZmNjNkNTdkM2U3ZTRkZmM0NWVmY2QwY2EyYjA5NjMx ZjA3ZDdkMS4uODE1ZjNiNzNlODIzZTNkYzY5MjVlYmI4NjM2N2YyY2MzZjhjNTdjYiAxMDA2NDQK LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAy LTIzICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFtD TWFrZV0gQWRkIEZpbmRRdWlja1RpbWVTREsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc5MzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZFF1aWNrVGltZVNESy5jbWFrZTog QWRkZWQuCisKIDIwMTItMDItMjIgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVz aW9uLm1vYmk+CiAKICAgICAgICAgW0NNYWtlXSBSZW1vdmUgRmluZEdESy5jbWFrZSBhbmQgRmlu ZEdESy1QaXhCdWYuY21ha2UK