79340 2012-02-23 00:34:25 -0800 Web Inspector: add experiment that loads stylesheets as links 2012-06-18 08:14:44 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo me pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 562923 0 pfeldman 2012-02-23 00:34:25 -0800 Otherwise, we can't use persistence extensions with the front-end due to XHR optimization. 562924 1 128423 pfeldman 2012-02-23 00:36:07 -0800 Created attachment 128423 Patch 563074 2 timothy 2012-02-23 06:14:19 -0800 "persistence extensions"? 563079 3 pfeldman 2012-02-23 06:23:45 -0800 (In reply to comment #2) > "persistence extensions"? This minor change is for us to be able to persist changes to inspector styles while developing inspector. Today, inspector loads stylesheets using synchronous XHRs and inject them into the document. As a result, when we debug inspector, navigation to the original resources does not work, Save As does not work, extensions that can save modified resources do not work. This change basically introduces debugging version of the front-end that uses conservative <link> tags for styles, hence making all the machinery above functioning. 563164 4 webkit.review.bot 2012-02-23 09:25:54 -0800 The commit-queue encountered the following flaky tests while processing attachment 128423: perf/object-keys.html bug 63769 (author: ojan@chromium.org) The commit-queue is continuing to process your patch. 563166 5 128423 webkit.review.bot 2012-02-23 09:28:16 -0800 Comment on attachment 128423 Patch Clearing flags on attachment: 128423 Committed r108634: <http://trac.webkit.org/changeset/108634> 563167 6 webkit.review.bot 2012-02-23 09:28:20 -0800 All reviewed patches have been landed. Closing bug. 651374 7 me 2012-06-18 07:24:40 -0700 Why not just load all stylesheets via <link>? Why load them synchronously? 651398 8 pfeldman 2012-06-18 08:14:44 -0700 (In reply to comment #7) > Why not just load all stylesheets via <link>? Why load them synchronously? We load them lazily in View.js. Otherwise it would flicker. 128423 2012-02-23 00:36:07 -0800 2012-02-23 09:28:16 -0800 Patch bug-79340-20120223123605.patch text/plain 2992 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTljNGI5ODMwMmI1MDRk NGFlZDdjMzE5MmQ0MDYyZjVmNjFlOTc0ZC4uNmY4ZTcwOTE3OTRhYWEzMjE2YzYxOWU3ZjU3ZGUz M2JjNDYzOGIyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTIzICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGFkZCBleHBlcmltZW50IHRoYXQgbG9hZHMgc3R5bGVzaGVldHMgYXMgbGlua3MKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MzQwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL1NldHRpbmdzLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkV4cGVyaW1lbnRzU2V0 dGluZ3MpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVmlldy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5WaWV3LnByb3RvdHlwZS5fZG9Mb2FkQ1NTKToKKwogMjAxMi0wMi0yMiAg S2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRW5hYmxlIEdl b2xvY2F0aW9uIGJpbmRpbmdzIGZvciBHT2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwppbmRleCA0NzgxYTEwZGFjN2M3MDk4NTgxYjlmZmY4 OThjMzA3MWI2N2IyY2U2Li5mYmEzYzBmMjU5NGRiZGQ0NGJiYzY4NDNmNDE5YjIzNjg4NDhhY2M3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdz LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanMK QEAgLTE3OCw2ICsxNzgsNyBAQCBXZWJJbnNwZWN0b3IuRXhwZXJpbWVudHNTZXR0aW5ncyA9IGZ1 bmN0aW9uKCkKICAgICB0aGlzLnRpbWVsaW5lU3RhcnRBdFplcm8gPSB0aGlzLl9jcmVhdGVFeHBl cmltZW50KCJ0aW1lbGluZVN0YXJ0QXRaZXJvIiwgIkVuYWJsZSBzdGFydCBhdCB6ZXJvIG1vZGUg aW4gVGltZWxpbmUgcGFuZWwiKTsKICAgICAvLyBGSVhNRTogRW5hYmxlIGh0dHAvdGVzdHMvaW5z cGVjdG9yL2luZGV4ZWRkYi9yZXNvdXJjZXMtcGFuZWwuaHRtbCB3aGVuIHJlbW92ZWQgZnJvbSBl eHBlcmltZW50cy4KICAgICB0aGlzLnNob3dJbmRleGVkREIgPSB0aGlzLl9jcmVhdGVFeHBlcmlt ZW50KCJzaG93SW5kZXhlZERCIiwgIlNob3cgSW5kZXhlZERCIGluIFJlc291cmNlcyBwYW5lbCIp OworICAgIHRoaXMuZGVidWdDU1MgPSB0aGlzLl9jcmVhdGVFeHBlcmltZW50KCJkZWJ1Z0NTUyIs ICJMb2FkIENTUyB2aWEgbGluayB0YWdzIGZvciBkZWJ1Z2dpbmciKTsKIAogICAgIHRoaXMuX2Ns ZWFuVXBTZXR0aW5nKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1ZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Zp ZXcuanMKaW5kZXggYjM5ZGFkNWNkMzgxMGQ4MzhkNTU5ODY3ZWVjYmZkYWVlZTUwMmU0ZS4uZjVh NmRjODQ3ZGUwMTc1YTJlMmJhZTUyZmZmMmM0YWY5YWYwYWQ1NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9WaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvVmlldy5qcwpAQCAtMjc4LDEzICsyNzgsMjAgQEAgV2ViSW5z cGVjdG9yLlZpZXcucHJvdG90eXBlID0gewogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9 CiAKLSAgICAgICAgdmFyIHhociA9IG5ldyBYTUxIdHRwUmVxdWVzdCgpOwotICAgICAgICB4aHIu b3BlbigiR0VUIiwgY3NzRmlsZSwgZmFsc2UpOwotICAgICAgICB4aHIuc2VuZChudWxsKTsKLQot ICAgICAgICBzdHlsZUVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzdHlsZSIpOwot ICAgICAgICBzdHlsZUVsZW1lbnQudHlwZSA9ICJ0ZXh0L2NzcyI7Ci0gICAgICAgIHN0eWxlRWxl bWVudC50ZXh0Q29udGVudCA9IHhoci5yZXNwb25zZVRleHQ7CisgICAgICAgIGlmIChXZWJJbnNw ZWN0b3IuZXhwZXJpbWVudHNTZXR0aW5ncy5kZWJ1Z0NTUy5pc0VuYWJsZWQoKSkgeworICAgICAg ICAgICAgc3R5bGVFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgibGluayIpOworICAg ICAgICAgICAgc3R5bGVFbGVtZW50LnJlbCA9ICJzdHlsZXNoZWV0IjsKKyAgICAgICAgICAgIHN0 eWxlRWxlbWVudC50eXBlID0gInRleHQvY3NzIjsKKyAgICAgICAgICAgIHN0eWxlRWxlbWVudC5o cmVmID0gY3NzRmlsZTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHZhciB4aHIgPSBu ZXcgWE1MSHR0cFJlcXVlc3QoKTsKKyAgICAgICAgICAgIHhoci5vcGVuKCJHRVQiLCBjc3NGaWxl LCBmYWxzZSk7CisgICAgICAgICAgICB4aHIuc2VuZChudWxsKTsKKworICAgICAgICAgICAgc3R5 bGVFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3R5bGUiKTsKKyAgICAgICAgICAg IHN0eWxlRWxlbWVudC50eXBlID0gInRleHQvY3NzIjsKKyAgICAgICAgICAgIHN0eWxlRWxlbWVu dC50ZXh0Q29udGVudCA9IHhoci5yZXNwb25zZVRleHQ7CisgICAgICAgIH0KICAgICAgICAgZG9j dW1lbnQuaGVhZC5pbnNlcnRCZWZvcmUoc3R5bGVFbGVtZW50LCBkb2N1bWVudC5oZWFkLmZpcnN0 Q2hpbGQpOwogCiAgICAgICAgIFdlYkluc3BlY3Rvci5WaWV3Ll9jc3NGaWxlVG9TdHlsZUVsZW1l bnRbY3NzRmlsZV0gPSBzdHlsZUVsZW1lbnQ7Cg==