79335 2012-02-22 23:34:56 -0800 [Qt] Build fix. Qt WebKit2 can not be compiled due to QtWebPageEventHandler. 2012-02-23 10:35:31 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dongseong.hwang hausmann abecsi hausmann jturcotte kenneth ossy oldest_to_newest 562880 0 dongseong.hwang 2012-02-22 23:34:56 -0800 I can not build WebKit2 on qt5 because QtWebPageEventHandler calls m_webView->setInputMethodHints(Qt::InputMethodHints(editor.inputMethodHints));. 562883 1 128407 dongseong.hwang 2012-02-22 23:36:37 -0800 Created attachment 128407 patch 562910 2 128407 hausmann 2012-02-23 00:16:01 -0800 Comment on attachment 128407 patch Well, but this isn't quite correct either, we still _do_ need to propagate the input method hints to the input method. It's just that the mechanism has changed slightly. FWIW, the Qt 5 version that we're developing against currently still has this method (see webkit-qt mailing list of announcements of version changes). That said, QQuickItem::setInputMethodHints has always been a convenience function for not having to re-implement the inputMethodQuery. Since we do that anyway though, we can apply a fix that works with any Qt 5 version, by responding to the Qt::ImHints input method query and returning the hints from the editor state there. 562928 3 dongseong.hwang 2012-02-23 00:44:01 -0800 Ok. I little know about Qt5, so I can not fix it. I want someone to fix it. 562929 4 dongseong.hwang 2012-02-23 00:44:13 -0800 (In reply to comment #0) > I can not build WebKit2 on qt5 because QtWebPageEventHandler calls m_webView->setInputMethodHints(Qt::InputMethodHints(editor.inputMethodHints));. QQuickItem does not have a setInputMethodHints(Qt::InputMethodHints hints) method. 563069 5 hausmann 2012-02-23 06:11:48 -0800 *** Bug 79250 has been marked as a duplicate of this bug. *** 563075 6 128472 hausmann 2012-02-23 06:16:13 -0800 Created attachment 128472 Patch 563077 7 128474 hausmann 2012-02-23 06:18:03 -0800 Created attachment 128474 Patch Patch that actually compiles :) 563229 8 128474 ossy 2012-02-23 10:35:22 -0800 Comment on attachment 128474 Patch Clearing flags on attachment: 128474 Committed r108639: <http://trac.webkit.org/changeset/108639> 563230 9 ossy 2012-02-23 10:35:31 -0800 All reviewed patches have been landed. Closing bug. 128407 2012-02-22 23:36:37 -0800 2012-02-23 03:09:08 -0800 patch 0001-Qt-Build-fix.-QQuickItem-does-not-have-a.patch text/plain 1761 dongseong.hwang RnJvbSBkZDc0MWM1MTA2ZTkwNmM1Y2UzNjllNmI1ODg2OTE0MzhmNjVhNmM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IFRodSwgMjMgRmViIDIwMTIgMTY6MzE6MjQgKzA5MDAKU3ViamVjdDogW1BBVENI XSBbUXRdIEJ1aWxkIGZpeC4gUVF1aWNrSXRlbSBkb2VzIG5vdCBoYXZlIGEKIHNldElucHV0TWV0 aG9kSGludHMoUXQ6OklucHV0TWV0aG9kSGludHMgaGludHMpIG1ldGhvZC4KIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTMzNQoKLS0tCiBTb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIC4u Li9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwIHwgICAgMiAt LQogMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwppbmRleCA1YWEyMDZmLi44ZDJjOWE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTItMDItMjIgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CisK KyAgICAgICAgW1F0XSBCdWlsZCBmaXguIFFRdWlja0l0ZW0gZG9lcyBub3QgaGF2ZSBhCisgICAg ICAgIHNldElucHV0TWV0aG9kSGludHMoUXQ6OklucHV0TWV0aG9kSGludHMgaGludHMpIG1ldGhv ZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MzM1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFF0V2ViUGFnZUV2 ZW50SGFuZGxlcjo6dXBkYXRlVGV4dElucHV0U3RhdGUpOgorCiAyMDEyLTAyLTIyICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IFRpbGVk Q29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhUHJveHk6OmRldmljZVNjYWxlRmFjdG9yRGlkQ2hhbmdl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRI YW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhh bmRsZXIuY3BwCmluZGV4IDcyYjk2YmEuLmZmYjNjMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwCkBAIC00NjIsOCAr NDYyLDYgQEAgdm9pZCBRdFdlYlBhZ2VFdmVudEhhbmRsZXI6OnVwZGF0ZVRleHRJbnB1dFN0YXRl KCkKIAogICAgIGNvbnN0IEVkaXRvclN0YXRlJiBlZGl0b3IgPSBtX3dlYlBhZ2VQcm94eS0+ZWRp dG9yU3RhdGUoKTsKIAotICAgIG1fd2ViVmlldy0+c2V0SW5wdXRNZXRob2RIaW50cyhRdDo6SW5w dXRNZXRob2RIaW50cyhlZGl0b3IuaW5wdXRNZXRob2RIaW50cykpOwotCiAgICAgaWYgKCFtX3dl YlZpZXctPmhhc0ZvY3VzKCkpCiAgICAgICAgIHJldHVybjsKIAotLSAKMS43LjUuNAoK 128472 2012-02-23 06:16:13 -0800 2012-02-23 06:17:55 -0800 Patch bug-79335-20120223151613.patch text/plain 2552 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDc0ZDhmNDQzZjA3NWI0 YTdjMmE4ZDcyMjM2ZTE3MTE5YTcwM2UzZC4uNmVhZWIwZmI3OGViZjg1ZGZhYzA3ZDUxN2EwYjZh YTUzOWNjOWI3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTIzICBTaW1v biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIEJ1 aWxkIGZpeC4gUXQgV2ViS2l0MiBjYW4gbm90IGJlIGNvbXBpbGVkIGR1ZSB0byBRdFdlYlBhZ2VF dmVudEhhbmRsZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTMzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEluIHRoZSB1cGNvbWluZyBRdCA1IGJ1aWxkcyB0aGUgY29udmVuaWVudCBzZXRJbnB1dE1l dGhvZEhpbnRzIG1ldGhvZCBvbiBRUXVpY2tJdGVtCisgICAgICAgIHdpbGwgYmUgcmVtb3ZlZC4g VGhlcmUncyBubyBuZWVkIGZvciB1cyB0byB1c2UgaXQsIHdlIGNhbiBpbXBsZW1lbnQgcGFzc2lu ZyB0aGUgaGludHMKKyAgICAgICAgdG8gdGhlIGlucHV0IG1ldGhvZCByaWdodCBhd2F5IGluIG91 ciByZS1pbXBsZW1lbnRhdGlvbiBvZiBpbnB1dE1ldGhvZFF1ZXJ5LCB3aGljaCB3b3JrcworICAg ICAgICB3aXRoIG9sZCBhbmQgbmV3ZXIgUXQgNSBidWlsZHMuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlldzo6aW5w dXRNZXRob2RRdWVyeSk6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFu ZGxlci5jcHA6CisgICAgICAgIChRdFdlYlBhZ2VFdmVudEhhbmRsZXI6OnVwZGF0ZVRleHRJbnB1 dFN0YXRlKToKKwogMjAxMi0wMi0yMyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBbQ01BS0VdW1dLMl0gQ2xlYW51cCBXZWJLaXQyL0NNYWtlTGlzdHMu dHh0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3 ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmll dy5jcHAKaW5kZXggMzljOTE2ZDE3YTcxYTEyMGNmYTBhMzU5NjE5OTA0ZGMyOGZkOWY1OS4uOGNk NjNmZmMzMmJkZTFkYjI3MzEwNzE0MDc5NzBhOTgzN2VkNTZmYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC0xMjI2LDYgKzEy MjYsOCBAQCBRVmFyaWFudCBRUXVpY2tXZWJWaWV3OjppbnB1dE1ldGhvZFF1ZXJ5KFF0OjpJbnB1 dE1ldGhvZFF1ZXJ5IHByb3BlcnR5KSBjb25zdAogICAgICAgICByZXR1cm4gUVN0cmluZyhzdGF0 ZS5zZWxlY3RlZFRleHQpOwogICAgIGNhc2UgUXQ6OkltTWF4aW11bVRleHRMZW5ndGg6CiAgICAg ICAgIHJldHVybiBRVmFyaWFudCgpOyAvLyBObyBsaW1pdC4KKyAgICBjYXNlIFF0OjpJbUhpbnRz OgorICAgICAgICByZXR1cm4gUXQ6OklucHV0TWV0aG9kSGludHMoc3RhdGUuaW5wdXRNZXRob2RI aW50cyk7CiAgICAgZGVmYXVsdDoKICAgICAgICAgLy8gUmVseSBvbiB0aGUgYmFzZSBpbXBsZW1l bnRhdGlvbiBmb3IgSW1FbmFibGVkLCBJbUhpbnRzIGFuZCBJbVByZWZlcnJlZExhbmd1YWdlLgog ICAgICAgICByZXR1cm4gUVF1aWNrSXRlbTo6aW5wdXRNZXRob2RRdWVyeShwcm9wZXJ0eSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRIYW5k bGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRs ZXIuY3BwCmluZGV4IDcyYjk2YmFlNDM5OWFiMGU3MzFjM2M1MThmZTU5ZTYwMWZlNDc1MDIuLmZm YjNjMzk3OTM0NDEyYmYyNDExOWEzNTQwYWUyZDIzNGYyYjczNjIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwCkBAIC00 NjIsOCArNDYyLDYgQEAgdm9pZCBRdFdlYlBhZ2VFdmVudEhhbmRsZXI6OnVwZGF0ZVRleHRJbnB1 dFN0YXRlKCkKIAogICAgIGNvbnN0IEVkaXRvclN0YXRlJiBlZGl0b3IgPSBtX3dlYlBhZ2VQcm94 eS0+ZWRpdG9yU3RhdGUoKTsKIAotICAgIG1fd2ViVmlldy0+c2V0SW5wdXRNZXRob2RIaW50cyhR dDo6SW5wdXRNZXRob2RIaW50cyhlZGl0b3IuaW5wdXRNZXRob2RIaW50cykpOwotCiAgICAgaWYg KCFtX3dlYlZpZXctPmhhc0ZvY3VzKCkpCiAgICAgICAgIHJldHVybjsKIAo= 128474 2012-02-23 06:18:03 -0800 2012-02-23 10:35:22 -0800 Patch bug-79335-20120223151803.patch text/plain 2557 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDc0ZDhmNDQzZjA3NWI0 YTdjMmE4ZDcyMjM2ZTE3MTE5YTcwM2UzZC4uNmVhZWIwZmI3OGViZjg1ZGZhYzA3ZDUxN2EwYjZh YTUzOWNjOWI3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTIzICBTaW1v biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIEJ1 aWxkIGZpeC4gUXQgV2ViS2l0MiBjYW4gbm90IGJlIGNvbXBpbGVkIGR1ZSB0byBRdFdlYlBhZ2VF dmVudEhhbmRsZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTMzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEluIHRoZSB1cGNvbWluZyBRdCA1IGJ1aWxkcyB0aGUgY29udmVuaWVudCBzZXRJbnB1dE1l dGhvZEhpbnRzIG1ldGhvZCBvbiBRUXVpY2tJdGVtCisgICAgICAgIHdpbGwgYmUgcmVtb3ZlZC4g VGhlcmUncyBubyBuZWVkIGZvciB1cyB0byB1c2UgaXQsIHdlIGNhbiBpbXBsZW1lbnQgcGFzc2lu ZyB0aGUgaGludHMKKyAgICAgICAgdG8gdGhlIGlucHV0IG1ldGhvZCByaWdodCBhd2F5IGluIG91 ciByZS1pbXBsZW1lbnRhdGlvbiBvZiBpbnB1dE1ldGhvZFF1ZXJ5LCB3aGljaCB3b3JrcworICAg ICAgICB3aXRoIG9sZCBhbmQgbmV3ZXIgUXQgNSBidWlsZHMuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlldzo6aW5w dXRNZXRob2RRdWVyeSk6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFu ZGxlci5jcHA6CisgICAgICAgIChRdFdlYlBhZ2VFdmVudEhhbmRsZXI6OnVwZGF0ZVRleHRJbnB1 dFN0YXRlKToKKwogMjAxMi0wMi0yMyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBbQ01BS0VdW1dLMl0gQ2xlYW51cCBXZWJLaXQyL0NNYWtlTGlzdHMu dHh0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3 ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmll dy5jcHAKaW5kZXggMzljOTE2ZDE3YTcxYTEyMGNmYTBhMzU5NjE5OTA0ZGMyOGZkOWY1OS4uMmI4 MjU4NzdkZWE1MDQ0NWE5NWJlZGFjN2E0NmNjOWM4ZjU3ZTE3MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC0xMjI2LDYgKzEy MjYsOCBAQCBRVmFyaWFudCBRUXVpY2tXZWJWaWV3OjppbnB1dE1ldGhvZFF1ZXJ5KFF0OjpJbnB1 dE1ldGhvZFF1ZXJ5IHByb3BlcnR5KSBjb25zdAogICAgICAgICByZXR1cm4gUVN0cmluZyhzdGF0 ZS5zZWxlY3RlZFRleHQpOwogICAgIGNhc2UgUXQ6OkltTWF4aW11bVRleHRMZW5ndGg6CiAgICAg ICAgIHJldHVybiBRVmFyaWFudCgpOyAvLyBObyBsaW1pdC4KKyAgICBjYXNlIFF0OjpJbUhpbnRz OgorICAgICAgICByZXR1cm4gaW50KFF0OjpJbnB1dE1ldGhvZEhpbnRzKHN0YXRlLmlucHV0TWV0 aG9kSGludHMpKTsKICAgICBkZWZhdWx0OgogICAgICAgICAvLyBSZWx5IG9uIHRoZSBiYXNlIGlt cGxlbWVudGF0aW9uIGZvciBJbUVuYWJsZWQsIEltSGludHMgYW5kIEltUHJlZmVycmVkTGFuZ3Vh Z2UuCiAgICAgICAgIHJldHVybiBRUXVpY2tJdGVtOjppbnB1dE1ldGhvZFF1ZXJ5KHByb3BlcnR5 KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVu dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50 SGFuZGxlci5jcHAKaW5kZXggNzJiOTZiYWU0Mzk5YWIwZTczMWMzYzUxOGZlNTllNjAxZmU0NzUw Mi4uZmZiM2MzOTc5MzQ0MTJiZjI0MTE5YTM1NDBhZTJkMjM0ZjJiNzM2MiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxlci5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxlci5jcHAK QEAgLTQ2Miw4ICs0NjIsNiBAQCB2b2lkIFF0V2ViUGFnZUV2ZW50SGFuZGxlcjo6dXBkYXRlVGV4 dElucHV0U3RhdGUoKQogCiAgICAgY29uc3QgRWRpdG9yU3RhdGUmIGVkaXRvciA9IG1fd2ViUGFn ZVByb3h5LT5lZGl0b3JTdGF0ZSgpOwogCi0gICAgbV93ZWJWaWV3LT5zZXRJbnB1dE1ldGhvZEhp bnRzKFF0OjpJbnB1dE1ldGhvZEhpbnRzKGVkaXRvci5pbnB1dE1ldGhvZEhpbnRzKSk7Ci0KICAg ICBpZiAoIW1fd2ViVmlldy0+aGFzRm9jdXMoKSkKICAgICAgICAgcmV0dXJuOwogCg==