79334 2012-02-22 23:03:56 -0800 DFG's logic for emitting a Flush is too convoluted and contains an inaccurate comment 2012-02-23 11:46:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 562857 0 fpizlo 2012-02-22 23:03:56 -0800 It's always safe to emit a Flush even if one has already been emitted, so long as the Flush has something other than a Flush as its child. 562860 1 128401 fpizlo 2012-02-22 23:09:53 -0800 Created attachment 128401 the patch 563314 2 fpizlo 2012-02-23 11:46:15 -0800 Landed in http://trac.webkit.org/changeset/108652 128401 2012-02-22 23:09:53 -0800 2012-02-23 10:39:32 -0800 the patch fixflush_patch_1.diff text/plain 2776 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA4NjEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTAyLTIyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHJ3MgbG9naWMgZm9yIGVtaXR0aW5nIGEgRmx1c2ggaXMgdG9vIGNvbnZvbHV0ZWQgYW5kIGNv bnRhaW5zIGFuIGluYWNjdXJhdGUgY29tbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkzMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHA6CisgICAgICAg IChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6OmdldExvY2FsKToKKyAgICAgICAgKEpTQzo6REZH OjpCeXRlQ29kZVBhcnNlcjo6Z2V0QXJndW1lbnQpOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVD b2RlUGFyc2VyOjpmbHVzaCk6CisKIDIwMTItMDItMjIgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFy cmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBbW0RlZmluZU93blByb3Bl cnR5XV0gZm9yIHRoZSBhcmd1bWVudHMgb2JqZWN0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAkocmV2aXNpb24gMTA4NDUzKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDExIEFwcGxlIElu Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMSwgMjAxMiBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKQEAgLTE3Niw2ICsxNzYsNyBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICBub2RlUHRyID0gJmZsdXNoQ2hpbGQ7CiAgICAgICAgICAgICB9CisgICAgICAg ICAgICBBU1NFUlQobm9kZVB0ci0+b3AgIT0gRmx1c2gpOwogICAgICAgICAgICAgaWYgKG5vZGVQ dHItPm9wID09IEdldExvY2FsKQogICAgICAgICAgICAgICAgIHJldHVybiBub2RlSW5kZXg7CiAg ICAgICAgICAgICBBU1NFUlQobm9kZVB0ci0+b3AgPT0gU2V0TG9jYWwpOwpAQCAtMjI1LDYgKzIy Niw5IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIG5vZGVQ dHIgPSAmZmx1c2hDaGlsZDsKICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIAorICAgICAgICAg ICAgQVNTRVJUKG5vZGVQdHItPm9wICE9IEZsdXNoKTsKKyAgICAgICAgICAgIAogICAgICAgICAg ICAgaWYgKG5vZGVQdHItPm9wID09IFNldEFyZ3VtZW50KSB7CiAgICAgICAgICAgICAgICAgLy8g V2UncmUgZ2V0dGluZyBhbiBhcmd1bWVudCBpbiB0aGUgZmlyc3QgYmFzaWMgYmxvY2s7IGxpbmsK ICAgICAgICAgICAgICAgICAvLyB0aGUgR2V0TG9jYWwgdG8gdGhlIFNldEFyZ3VtZW50LgpAQCAt MjgyLDEzICsyODYsMTAgQEAgcHJpdmF0ZToKICAgICAgICAgCiAgICAgICAgIGlmIChub2RlSW5k ZXggIT0gTm9Ob2RlKSB7CiAgICAgICAgICAgICBOb2RlJiBub2RlID0gbV9ncmFwaFtub2RlSW5k ZXhdOwotICAgICAgICAgICAgaWYgKG5vZGUub3AgPT0gRmx1c2ggfHwgbm9kZS5vcCA9PSBTZXRB cmd1bWVudCkgewotICAgICAgICAgICAgICAgIC8vIElmIGEgbG9jYWwgaGFzIGFscmVhZHkgYmVl biBmbHVzaGVkLCBvciBpZiBpdCdzIGFuIGFyZ3VtZW50IGluIHRoZQotICAgICAgICAgICAgICAg IC8vIGZpcnN0IGJhc2ljIGJsb2NrLCB0aGVuIHRoZXJlIGlzIHJlYWxseSBubyBuZWVkIHRvIGZs dXNoIGl0LiBJbiBmYWN0Ci0gICAgICAgICAgICAgICAgLy8gZW1pdHRpbmcgYSBGbHVzaCBpbnN0 cnVjdGlvbiBjb3VsZCBqdXN0IGNvbmZ1c2UgdGhpbmdzLCBzaW5jZSB0aGUKLSAgICAgICAgICAg ICAgICAvLyBnZXRBcmd1bWVudCgpIGNvZGUgYXNzdW1lcyB0aGF0IHdlIG5ldmVyIHNlZSBhIEZs dXNoIG9mIGEgU2V0QXJndW1lbnQuCi0gICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAg ICAgfQorICAgICAgICAgICAgaWYgKG5vZGUub3AgPT0gRmx1c2gpCisgICAgICAgICAgICAgICAg bm9kZUluZGV4ID0gbm9kZS5jaGlsZDEoKS5pbmRleCgpOworICAgICAgICAgICAgCisgICAgICAg ICAgICBBU1NFUlQobV9ncmFwaFtub2RlSW5kZXhdLm9wICE9IEZsdXNoKTsKICAgICAgICAgCiAg ICAgICAgICAgICBhZGRUb0dyYXBoKEZsdXNoLCBPcEluZm8obm9kZS52YXJpYWJsZUFjY2Vzc0Rh dGEoKSksIG5vZGVJbmRleCk7CiAgICAgICAgICAgICByZXR1cm47Cg==