79318 2012-02-22 19:08:30 -0800 [BlackBerry] Anchor mailto: with target set won't launch Messaging application when clicked 2012-02-24 02:54:20 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Major --- 0 charles.wei leo.yang leo.yang rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 562700 0 charles.wei 2012-02-22 19:08:30 -0800 <a href="mailto:email@host"> click me to launch messaging </a> works , while <a href="mailto:email@host" target="_blank"> click me to launch messaging </a> doesn't work. 562835 1 128397 charles.wei 2012-02-22 22:24:55 -0800 Created attachment 128397 Patch 563036 2 128397 rwlbuis 2012-02-23 04:36:07 -0800 Comment on attachment 128397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128397&action=review Looks good. > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:282 > + BlackBerry::Platform::NetworkRequest platformRequest; Can probably remove the BlackBerry prefix. > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:285 > + platformRequest, BlackBerry::Platform::NavigationType(action.type()))) { Ditto. > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:287 > + || action.type() == NavigationTypeFormResubmitted) Can be just one line. 563051 3 128397 charles.wei 2012-02-23 05:51:04 -0800 Comment on attachment 128397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128397&action=review >> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:282 >> + BlackBerry::Platform::NetworkRequest platformRequest; > > Can probably remove the BlackBerry prefix. No, we can't remove the BlackBerry prefix. We are using BlackBerry:WebKit, but not BlackBerry. Maybe we should use BlackBerry and add the WebKit prefix back in the code. We should do that with another patch. >> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:287 >> + || action.type() == NavigationTypeFormResubmitted) > > Can be just one line. Yes, will fix this and submit. 563052 4 128397 charles.wei 2012-02-23 05:51:52 -0800 Comment on attachment 128397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128397&action=review >>> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:282 >>> + BlackBerry::Platform::NetworkRequest platformRequest; >> >> Can probably remove the BlackBerry prefix. > > No, we can't remove the BlackBerry prefix. We are using BlackBerry:WebKit, but not BlackBerry. Maybe we should use BlackBerry and add the WebKit prefix back in the code. We should do that with another patch. No, we can't remove the BlackBerry prefix. We are using BlackBerry:WebKit, but not BlackBerry. Maybe we should use BlackBerry and add the WebKit prefix back in the code. We should do that with another patch. >>> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:287 >>> + || action.type() == NavigationTypeFormResubmitted) >> >> Can be just one line. > > Yes, will fix this and submit. Yes, will fix this and submit. 563053 5 128397 webkit.review.bot 2012-02-23 05:53:12 -0800 Comment on attachment 128397 Patch Rejecting attachment 128397 from commit-queue. charles.wei@torchmobile.com.cn does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 563056 6 128397 charles.wei 2012-02-23 05:54:16 -0800 Comment on attachment 128397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128397&action=review remove the commit flag, added it by accident. >>>> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:282 >>>> + BlackBerry::Platform::NetworkRequest platformRequest; >>> >>> Can probably remove the BlackBerry prefix. >> >> No, we can't remove the BlackBerry prefix. We are using BlackBerry:WebKit, but not BlackBerry. Maybe we should use BlackBerry and add the WebKit prefix back in the code. We should do that with another patch. > > No, we can't remove the BlackBerry prefix. We are using BlackBerry:WebKit, but not BlackBerry. Maybe we should use BlackBerry and add the WebKit prefix back in the code. We should do that with another patch. No, we can't remove the BlackBerry prefix. We are using BlackBerry:WebKit, but not BlackBerry. Maybe we should use BlackBerry and add the WebKit prefix back in the code. We should do that with another patch. >>>> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:287 >>>> + || action.type() == NavigationTypeFormResubmitted) >>> >>> Can be just one line. >> >> Yes, will fix this and submit. > > Yes, will fix this and submit. Yes, will fix this and submit. 563797 7 128628 leo.yang 2012-02-23 18:23:07 -0800 Created attachment 128628 Patch for landing 564145 8 128628 webkit.review.bot 2012-02-24 02:54:15 -0800 Comment on attachment 128628 Patch for landing Clearing flags on attachment: 128628 Committed r108763: <http://trac.webkit.org/changeset/108763> 564146 9 webkit.review.bot 2012-02-24 02:54:20 -0800 All reviewed patches have been landed. Closing bug. 128397 2012-02-22 22:24:55 -0800 2012-02-23 18:22:55 -0800 Patch bug-79318-20120223142933.patch text/plain 3031 charles.wei SW5kZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkocmV2aXNpb24gMTA4NjA5KQorKysg U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTAyLTIyICBDaGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9i aWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQW5jaG9yIG1haWx0bzogd2l0aCB0 YXJnZXQgc2V0IHdvbid0IGxhdW5jaCBNZXNzYWdpbmcgYXBwbGljYXRpb24gd2hlbiBjbGlja2Vk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTMxOAor CisgICAgICAgIE5lZWQgdG8gZ2l2ZSB0aGUgY2xpZW50IGEgY2hhbmNlIHRvIGRlY2lkZSBob3cg dG8gaGFuZGxlIHRoZSBuZXcgd2luZG93IHJlcXVlc3QuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNs aWVudEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRC bGFja0JlcnJ5OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlvbik6CisKIDIw MTItMDItMjEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVt b3ZlIHRoZSByZW1haW5pbmcgdXNlcyBvZiBDU1NTdHlsZURlY2xhcmF0aW9uIGluIEVkaXRvcgpJ bmRleDogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVy Q2xpZW50QmxhY2tCZXJyeS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAJKHJldmlz aW9uIDEwODYwMikKKysrIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9G cmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNzAsMTMg KzI3MCwzMCBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZG9QZW5kCiAgICAg ZGVsYXlQb2xpY3lDaGVja1VudGlsRnJhZ21lbnRFeGlzdHMoZnJhZ21lbnQsIGZ1bmN0aW9uKTsK IH0KIAotdm9pZCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmRpc3BhdGNoRGVjaWRlUG9s aWN5Rm9yTmV3V2luZG93QWN0aW9uKEZyYW1lUG9saWN5RnVuY3Rpb24gZnVuY3Rpb24sIGNvbnN0 IE5hdmlnYXRpb25BY3Rpb24mLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIFBhc3NS ZWZQdHI8Rm9ybVN0YXRlPiwgY29uc3QgU3RyaW5nJiBmcmFtZU5hbWUpCit2b2lkIEZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOZXdXaW5kb3dBY3Rp b24oRnJhbWVQb2xpY3lGdW5jdGlvbiBmdW5jdGlvbiwgY29uc3QgTmF2aWdhdGlvbkFjdGlvbiYg YWN0aW9uLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIFBhc3NSZWZQdHI8Rm9ybVN0 YXRlPiwgY29uc3QgU3RyaW5nJiBmcmFtZU5hbWUpCiB7CiAgICAgaWYgKHJlcXVlc3QuaXNSZXF1 ZXN0ZWRCeVBsdWdpbigpICYmIFNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzdHVy ZSgpICYmICFtX3dlYlBhZ2VQcml2YXRlLT5tX3BsdWdpbk1heU9wZW5OZXdUYWIpCiAgICAgICAg IChtX2ZyYW1lLT5sb2FkZXIoKS0+cG9saWN5Q2hlY2tlcigpLT4qZnVuY3Rpb24pKFBvbGljeUln bm9yZSk7CiAKICAgICAvLyBBIG5ldyB3aW5kb3cgY2FuIG5ldmVyIGJlIGEgZnJhZ21lbnQgc2Ny b2xsLgogICAgIFBvbGljeUFjdGlvbiBkZWNpc2lvbiA9IGRlY2lkZVBvbGljeUZvckV4dGVybmFs TG9hZChyZXF1ZXN0LCBmYWxzZSk7CisgICAgLy8gTGV0IHRoZSBjbGllbnQgaGF2ZSBhIGNoYW5j ZSB0byBzYXkgd2hldGhlciB0aGlzIG5hdmlnYXRpb24gc2hvdWxkCisgICAgLy8gYmUgaWdub3Jl ZCBvciBub3QuCisgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06Ok5ldHdvcmtSZXF1ZXN0IHBsYXRm b3JtUmVxdWVzdDsKKyAgICByZXF1ZXN0LmluaXRpYWxpemVQbGF0Zm9ybVJlcXVlc3QocGxhdGZv cm1SZXF1ZXN0LCBmYWxzZSAvKmlzSW5pdGlhbCovKTsKKyAgICBpZiAoaXNNYWluRnJhbWUoKSAm JiAhbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQtPmFjY2VwdE5hdmlnYXRpb25SZXF1ZXN0KAor ICAgICAgICBwbGF0Zm9ybVJlcXVlc3QsIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpOYXZpZ2F0aW9u VHlwZShhY3Rpb24udHlwZSgpKSkpIHsKKyAgICAgICAgaWYgKGFjdGlvbi50eXBlKCkgPT0gTmF2 aWdhdGlvblR5cGVGb3JtU3VibWl0dGVkCisgICAgICAgICAgICB8fCBhY3Rpb24udHlwZSgpID09 IE5hdmlnYXRpb25UeXBlRm9ybVJlc3VibWl0dGVkKQorICAgICAgICAgICAgbV9mcmFtZS0+bG9h ZGVyKCktPnJlc2V0TXVsdGlwbGVGb3JtU3VibWlzc2lvblByb3RlY3Rpb24oKTsKKworICAgICAg ICBpZiAoYWN0aW9uLnR5cGUoKSA9PSBOYXZpZ2F0aW9uVHlwZUxpbmtDbGlja2VkICYmIHJlcXVl c3QudXJsKCkuaGFzRnJhZ21lbnRJZGVudGlmaWVyKCkpIHsKKyAgICAgICAgICAgIFJlc291cmNl UmVxdWVzdCBlbXB0eVJlcXVlc3Q7CisgICAgICAgICAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+YWN0 aXZlRG9jdW1lbnRMb2FkZXIoKS0+c2V0TGFzdENoZWNrZWRSZXF1ZXN0KGVtcHR5UmVxdWVzdCk7 CisgICAgICAgIH0KKyAgICAgICAgZGVjaXNpb24gPSBQb2xpY3lJZ25vcmU7CisgICAgfQorCiAg ICAgKG1fZnJhbWUtPmxvYWRlcigpLT5wb2xpY3lDaGVja2VyKCktPipmdW5jdGlvbikoZGVjaXNp b24pOwogfQogCg== 128628 2012-02-23 18:23:07 -0800 2012-02-24 02:54:15 -0800 Patch for landing bug-79318-20120224102306.patch text/plain 3004 leo.yang SW5kZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkocmV2aXNpb24gMTA4NzExKQorKysg U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTAyLTIzICBDaGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9i aWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQW5jaG9yIG1haWx0bzogd2l0aCB0 YXJnZXQgc2V0IHdvbid0IGxhdW5jaCBNZXNzYWdpbmcgYXBwbGljYXRpb24gd2hlbiBjbGlja2Vk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03OTMxOAor CisgICAgICAgIE5lZWQgdG8gZ2l2ZSB0aGUgY2xpZW50IGEgY2hhbmNlIHRvIGRlY2lkZSBob3cg dG8gaGFuZGxlIHRoZSBuZXcgd2luZG93IHJlcXVlc3QuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Um9iIEJ1aXMuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJs YWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRCbGFja0Jl cnJ5OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlvbik6CisKIDIwMTItMDIt MjMgIExlbyBZYW5nICA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtC bGFja0JlcnJ5XSBVcHN0cmVhbSBHTEVTMkNvbnRleHQue2gsIGNwcH0KSW5kZXg6IFNvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVy cnkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3Vw cG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCShyZXZpc2lvbiAxMDg3MTEpCisr KyBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll bnRCbGFja0JlcnJ5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcwLDEzICsyNzAsMjkgQEAgdm9p ZCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmRvUGVuZAogICAgIGRlbGF5UG9saWN5Q2hl Y2tVbnRpbEZyYWdtZW50RXhpc3RzKGZyYWdtZW50LCBmdW5jdGlvbik7CiB9CiAKLXZvaWQgRnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvck5ld1dpbmRv d0FjdGlvbihGcmFtZVBvbGljeUZ1bmN0aW9uIGZ1bmN0aW9uLCBjb25zdCBOYXZpZ2F0aW9uQWN0 aW9uJiwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBQYXNzUmVmUHRyPEZvcm1TdGF0 ZT4sIGNvbnN0IFN0cmluZyYgZnJhbWVOYW1lKQordm9pZCBGcmFtZUxvYWRlckNsaWVudEJsYWNr QmVycnk6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uKEZyYW1lUG9saWN5 RnVuY3Rpb24gZnVuY3Rpb24sIGNvbnN0IE5hdmlnYXRpb25BY3Rpb24mIGFjdGlvbiwgY29uc3Qg UmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBQYXNzUmVmUHRyPEZvcm1TdGF0ZT4sIGNvbnN0IFN0 cmluZyYgZnJhbWVOYW1lKQogewogICAgIGlmIChyZXF1ZXN0LmlzUmVxdWVzdGVkQnlQbHVnaW4o KSAmJiBTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdlc3R1cmUoKSAmJiAhbV93ZWJQ YWdlUHJpdmF0ZS0+bV9wbHVnaW5NYXlPcGVuTmV3VGFiKQogICAgICAgICAobV9mcmFtZS0+bG9h ZGVyKCktPnBvbGljeUNoZWNrZXIoKS0+KmZ1bmN0aW9uKShQb2xpY3lJZ25vcmUpOwogCiAgICAg Ly8gQSBuZXcgd2luZG93IGNhbiBuZXZlciBiZSBhIGZyYWdtZW50IHNjcm9sbC4KICAgICBQb2xp Y3lBY3Rpb24gZGVjaXNpb24gPSBkZWNpZGVQb2xpY3lGb3JFeHRlcm5hbExvYWQocmVxdWVzdCwg ZmFsc2UpOworICAgIC8vIExldCB0aGUgY2xpZW50IGhhdmUgYSBjaGFuY2UgdG8gc2F5IHdoZXRo ZXIgdGhpcyBuYXZpZ2F0aW9uIHNob3VsZAorICAgIC8vIGJlIGlnbm9yZWQgb3Igbm90LgorICAg IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpOZXR3b3JrUmVxdWVzdCBwbGF0Zm9ybVJlcXVlc3Q7Cisg ICAgcmVxdWVzdC5pbml0aWFsaXplUGxhdGZvcm1SZXF1ZXN0KHBsYXRmb3JtUmVxdWVzdCwgZmFs c2UgLyppc0luaXRpYWwqLyk7CisgICAgaWYgKGlzTWFpbkZyYW1lKCkgJiYgIW1fd2ViUGFnZVBy aXZhdGUtPm1fY2xpZW50LT5hY2NlcHROYXZpZ2F0aW9uUmVxdWVzdCgKKyAgICAgICAgcGxhdGZv cm1SZXF1ZXN0LCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6TmF2aWdhdGlvblR5cGUoYWN0aW9uLnR5 cGUoKSkpKSB7CisgICAgICAgIGlmIChhY3Rpb24udHlwZSgpID09IE5hdmlnYXRpb25UeXBlRm9y bVN1Ym1pdHRlZCB8fCBhY3Rpb24udHlwZSgpID09IE5hdmlnYXRpb25UeXBlRm9ybVJlc3VibWl0 dGVkKQorICAgICAgICAgICAgbV9mcmFtZS0+bG9hZGVyKCktPnJlc2V0TXVsdGlwbGVGb3JtU3Vi bWlzc2lvblByb3RlY3Rpb24oKTsKKworICAgICAgICBpZiAoYWN0aW9uLnR5cGUoKSA9PSBOYXZp Z2F0aW9uVHlwZUxpbmtDbGlja2VkICYmIHJlcXVlc3QudXJsKCkuaGFzRnJhZ21lbnRJZGVudGlm aWVyKCkpIHsKKyAgICAgICAgICAgIFJlc291cmNlUmVxdWVzdCBlbXB0eVJlcXVlc3Q7CisgICAg ICAgICAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+YWN0aXZlRG9jdW1lbnRMb2FkZXIoKS0+c2V0TGFz dENoZWNrZWRSZXF1ZXN0KGVtcHR5UmVxdWVzdCk7CisgICAgICAgIH0KKyAgICAgICAgZGVjaXNp b24gPSBQb2xpY3lJZ25vcmU7CisgICAgfQorCiAgICAgKG1fZnJhbWUtPmxvYWRlcigpLT5wb2xp Y3lDaGVja2VyKCktPipmdW5jdGlvbikoZGVjaXNpb24pOwogfQogCg==