79299 2012-02-22 16:30:38 -0800 Type tags in NodeFlags could be compressed 2022-07-26 10:07:46 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED LATER P2 Normal --- 84511 77860 1 morrita morrita ahmad.saleem792 ap bfulgham kling koivisto rniwa webkit.review.bot oldest_to_newest 562533 0 morrita 2012-02-22 16:30:38 -0800 We have type tags like: IsTextFlag = 1, IsCommentFlag = 1 << 1, IsContainerFlag = 1 << 2, IsElementFlag = 1 << 3, IsStyledElementFlag = 1 << 4, IsHTMLFlag = 1 << 5, IsSVGFlag = 1 << 6, InDocumentFlag = 1 << 9, IsShadowRootOrSVGShadowRootFlag = 1 << 16, And these are apparently redundant. We could compress these. 562542 1 koivisto 2012-02-22 16:35:51 -0800 (In reply to comment #0) > InDocumentFlag = 1 << 9, This one is not redundant. 602935 2 137289 morrita 2012-04-16 00:09:25 -0700 Created attachment 137289 Patch 603657 3 morrita 2012-04-16 18:17:31 -0700 As Ryosuke's request at #webkit, I took two bencharks from Dromaeo which hit DOM heavily: dom-modify: before after avg 3,816.93 3,819.05 stdev 44.37 90.98 dom-traverse: before after avg 2,472.91 2,520.09 stdev 62.35 48.05 The lager number is better. This even shows a tiny improvement. But it's unlikely. It will be just a noise. I think we can say that this has no observable performance impact. 603686 4 137289 webkit.review.bot 2012-04-16 19:15:35 -0700 Comment on attachment 137289 Patch Clearing flags on attachment: 137289 Committed r114333: <http://trac.webkit.org/changeset/114333> 603687 5 webkit.review.bot 2012-04-16 19:15:40 -0700 All reviewed patches have been landed. Closing bug. 603701 6 rniwa 2012-04-16 19:32:33 -0700 Thanks for the perf. analysis. 607049 7 morrita 2012-04-20 16:46:46 -0700 Reopening due to the report: https://bugs.webkit.org/show_bug.cgi?id=84511 607056 8 morrita 2012-04-20 16:49:31 -0700 See: https://bugs.webkit.org/show_bug.cgi?id=84497 1886807 9 ahmad.saleem792 2022-07-26 10:06:45 -0700 Code seems to be changed a lot in Node.h - https://github.com/WebKit/WebKit/blob/aff87f6cbcf56b5fe448770a00f51814fa626b7c/Source/WebCore/dom/Node.h I think this patch or patch related changes cannot be applied or already applied in other general concept. Can this be marked as "RESOLVED LATER" and "RESOLVED CONFIGURATION CHANGED"? -> rniwa@webkit.org - any input since Comment 03 mentioned about having any past discussions with yourself? Thanks! 1886809 10 rniwa 2022-07-26 10:07:46 -0700 We can consider doing this refactoring but keeping this 10 year old bug isn't the way to go. -> Later. 137289 2012-04-16 00:09:25 -0700 2012-04-16 19:15:35 -0700 Patch bug-79299-20120416160923.patch text/plain 10508 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY1ZDExYjNkNDgwYmQ1 ZDEwOWNhMTQ4MjM2YWU0YTk3Yzg1MTM2ZS4uMTlmNWMxYmY2NjE1NDQ0MzlmMmIwNTExNjJkZDQ2 MTM5ZGQ4NDM5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTA0LTE1ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFR5cGUgdGFncyBpbiBO b2RlRmxhZ3MgY291bGQgYmUgY29tcHJlc3NlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkyOTkKKworICAgICAgICBCZWNhdXNlIGV4aXN0aW5nIG5v ZGUgZmxhZ3Mgd2hpY2ggaW5kaWNhdGUgdGhlIGNsYXNzIG9mIGVhY2ggbm9kZQorICAgICAgICBh cmUgbXV0dWFsbHkgZXhjbHVzaXZlLCB0aGVzZSBmbGFncyBjYW4gYmUgcmVwcmVzZW50ZWQgYXMg YSBlbnVtLgorICAgICAgICBUaGlzIHBhdGNoIGludHJvZHVjZXMgTm9kZTo6Tm9kZVR5cGVUYWcg dG8gdHVybiB0aGVzZSBmbGFncyBpbnRvIGEKKyAgICAgICAgZW51bSwgYW5kIGVtYmVkcyBpdCBp bnRvIE5vZGU6Om1fbm9kZUZsYWdzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gYmFoYXZpb3IgY2hhbmdlLgorCisgICAg ICAgICogZG9tL05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogZG9tL05v ZGUuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoTm9kZSk6CisgICAgICAgIChXZWJD b3JlOjpOb2RlOjp0eXBlVGFnKToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OnBhcmVudE5vZGUp OgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6cGFyZW50Tm9kZUd1YXJhbnRlZWRIb3N0RnJlZSk6 CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjppc0NvbnRhaW5lck5vZGUpOgorICAgICAgICAoV2Vi Q29yZTo6Tm9kZTo6aXNFbGVtZW50Tm9kZSk6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjppc1N0 eWxlZEVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6aXNUZXh0Tm9kZSk6CisgICAg ICAgIChXZWJDb3JlOjpOb2RlOjppc0hUTUxFbGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6Ok5v ZGU6OmlzU1ZHRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjppc1NoYWRvd1Jvb3Qp OgorCiAyMDEyLTA0LTE0ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBGaXggcGl4ZWxTbmFwcGluZyBmb3IgQ2FsZW5kYXJQaWNrZXIsIE1lZGlhQ29udHJvbCBh bmQgU2Nyb2xsYmFyUGFydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IDRhMTc5Y2M3MjRhZTg3OTlmYmM4 MzE5NmQ3MDEzM2M0YWExNmNmNGIuLmVhZGY2MjNhNDA4NzJlMjNjYmI0NWVlZWFmZTYyYzJmMDNi ZjQ0MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKQEAgLTEyOCw2ICsxMjgsOCBAQCB1c2luZyBuYW1lc3Bh Y2Ugc3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK0NPTVBJTEVfQVNTRVJUKE5vZGU6OlR5 cGVUYWdTaXplIDw9IDgsIE5vZGVfdGFnX3Nob3VsZF9maXRfaW5fYml0cyk7CisKIHVzaW5nIG5h bWVzcGFjZSBIVE1MTmFtZXM7CiAKIGJvb2wgTm9kZTo6aXNTdXBwb3J0ZWQoY29uc3QgU3RyaW5n JiBmZWF0dXJlLCBjb25zdCBTdHJpbmcmIHZlcnNpb24pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaAppbmRleCBjNzA0ZDA4 YjYwYzhlNzQ4YmM0Yzc0ZjQxODlkNmQ5YmJiYTE4NmE3Li4zMDFjMTYxOWZhMjZkYmI5NDZjMTYz YzY1YzQ1ZTJkOGUyYTIzNDIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKQEAgLTkwLDcgKzkwLDcgQEAgY2xhc3Mg SFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uOwogCiB0eXBlZGVmIGludCBFeGNlcHRpb25Db2RlOwog Ci1jb25zdCBpbnQgbm9kZVN0eWxlQ2hhbmdlU2hpZnQgPSAyMTsKK2NvbnN0IGludCBub2RlU3R5 bGVDaGFuZ2VTaGlmdCA9IDE3OwogCiAvLyBTeW50aGV0aWNTdHlsZUNoYW5nZSBtZWFucyB0aGF0 IHdlIG5lZWQgdG8gZ28gdGhyb3VnaCB0aGUgZW50aXJlIHN0eWxlIGNoYW5nZSBsb2dpYyBldmVu IHRob3VnaAogLy8gbm8gc3R5bGUgcHJvcGVydHkgaGFzIGFjdHVhbGx5IGNoYW5nZWQuIEl0IGlz IHVzZWQgdG8gcmVzdHJ1Y3R1cmUgdGhlIHRyZWUgd2hlbiwgZm9yIGluc3RhbmNlLApAQCAtMjAw LDIxICsyMDAsMjAgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBpc0FjdGl2ZU5vZGUoKSBj b25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIAogICAgIC8vIE90aGVyIG1ldGhvZHMgKG5vdCBw YXJ0IG9mIERPTSkKLQotICAgIGJvb2wgaXNFbGVtZW50Tm9kZSgpIGNvbnN0IHsgcmV0dXJuIGdl dEZsYWcoSXNFbGVtZW50RmxhZyk7IH0KLSAgICBib29sIGlzQ29udGFpbmVyTm9kZSgpIGNvbnN0 IHsgcmV0dXJuIGdldEZsYWcoSXNDb250YWluZXJGbGFnKTsgfQotICAgIGJvb2wgaXNUZXh0Tm9k ZSgpIGNvbnN0IHsgcmV0dXJuIGdldEZsYWcoSXNUZXh0RmxhZyk7IH0KLSAgICBib29sIGlzSFRN TEVsZW1lbnQoKSBjb25zdCB7IHJldHVybiBnZXRGbGFnKElzSFRNTEZsYWcpOyB9Ci0gICAgYm9v bCBpc1NWR0VsZW1lbnQoKSBjb25zdCB7IHJldHVybiBnZXRGbGFnKElzU1ZHRmxhZyk7IH0KKyAg ICBib29sIGlzQ29udGFpbmVyTm9kZSgpIGNvbnN0OworICAgIGJvb2wgaXNFbGVtZW50Tm9kZSgp IGNvbnN0OworICAgIGJvb2wgaXNTdHlsZWRFbGVtZW50KCkgY29uc3Q7CisgICAgYm9vbCBpc1Rl eHROb2RlKCkgY29uc3Q7CisgICAgYm9vbCBpc0hUTUxFbGVtZW50KCkgY29uc3Q7CisgICAgYm9v bCBpc1NWR0VsZW1lbnQoKSBjb25zdDsKKyAgICBib29sIGlzU2hhZG93Um9vdCgpIGNvbnN0Owog CiAgICAgdmlydHVhbCBib29sIGlzTWVkaWFDb250cm9sRWxlbWVudCgpIGNvbnN0IHsgcmV0dXJu IGZhbHNlOyB9CiAgICAgdmlydHVhbCBib29sIGlzTWVkaWFDb250cm9scygpIGNvbnN0IHsgcmV0 dXJuIGZhbHNlOyB9Ci0gICAgYm9vbCBpc1N0eWxlZEVsZW1lbnQoKSBjb25zdCB7IHJldHVybiBn ZXRGbGFnKElzU3R5bGVkRWxlbWVudEZsYWcpOyB9CiAgICAgdmlydHVhbCBib29sIGlzRnJhbWVP d25lckVsZW1lbnQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1YWwgYm9vbCBp c0F0dHJpYnV0ZU5vZGUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1YWwgYm9v bCBpc0NoYXJhY3RlckRhdGFOb2RlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICBib29s IGlzRG9jdW1lbnROb2RlKCkgY29uc3Q7Ci0gICAgYm9vbCBpc1NoYWRvd1Jvb3QoKSBjb25zdCB7 IHJldHVybiBnZXRGbGFnKElzU2hhZG93Um9vdEZsYWcpOyB9CiAgICAgYm9vbCBpbk5hbWVkRmxv dygpIGNvbnN0IHsgcmV0dXJuIGdldEZsYWcoSW5OYW1lZEZsb3dGbGFnKTsgfQogCiAgICAgTm9k ZSogc2hhZG93QW5jZXN0b3JOb2RlKCkgY29uc3Q7CkBAIC02MjksNzIgKzYyOCw3OSBAQCBwdWJs aWM6CiAgICAgYm9vbCBoYXNTY29wZWRIVE1MU3R5bGVDaGlsZCgpIGNvbnN0OwogICAgIHNpemVf dCBudW1iZXJPZlNjb3BlZEhUTUxTdHlsZUNoaWxkcmVuKCkgY29uc3Q7CiAKKyAgICBlbnVtIE5v ZGVUeXBlVGFnIHsKKyAgICAgICAgVHlwZVRhZ090aGVyID0gMCwgLy8gTm9kZSBzdWJjbGFzc2Vz IG90aGVyIHRoYW4gbGlzdGVkIGJlbG93LgorICAgICAgICBUeXBlVGFnVGV4dCwgLy8gVGV4dAor ICAgICAgICBUeXBlVGFnQ29udGFpbmVyTm9kZSwgLy8gQ29udGFpbmVyTm9kZSBzdWJjbGFzc2Vz IG90aGVyIHRoYW4gRWxlbWVudCBhbmQgU2hhZG93Um9vdC4KKyAgICAgICAgVHlwZVRhZ0VsZW1l bnQsIC8vIE5vbi1TdHlsZWQgRWxlbWVudAorICAgICAgICBUeXBlVGFnU3R5bGVkRWxlbWVudCwg Ly8gU3R5bGVkRWxlbWVudCBvdGhlciB0aGFuIEhUTUwgYW5kIFNWRyAoRm9yIG5vdyBNYXRoTUxF bGVtZW50IGZhbWlseSBpcyB0aGUgb25seSBvbmUuKQorICAgICAgICBUeXBlVGFnSFRNTEVsZW1l bnQsIC8vIEhUTUxFbGVtZW50CisgICAgICAgIFR5cGVUYWdTVkdFbGVtZW50LCAvLyBTVkdFbGVt ZW50CisgICAgICAgIFR5cGVUYWdTaGFkb3dSb290LCAvLyBTaGFkb3dSb290CisgICAgICAgIFR5 cGVUYWdTaXplCisgICAgfTsKKwogcHJpdmF0ZToKKwogICAgIGVudW0gTm9kZUZsYWdzIHsKLSAg ICAgICAgSXNUZXh0RmxhZyA9IDEsCi0gICAgICAgIElzQ29udGFpbmVyRmxhZyA9IDEgPDwgMSwK LSAgICAgICAgSXNFbGVtZW50RmxhZyA9IDEgPDwgMiwKLSAgICAgICAgSXNTdHlsZWRFbGVtZW50 RmxhZyA9IDEgPDwgMywKLSAgICAgICAgSXNIVE1MRmxhZyA9IDEgPDwgNCwKLSAgICAgICAgSXNT VkdGbGFnID0gMSA8PCA1LAotICAgICAgICBJc0F0dGFjaGVkRmxhZyA9IDEgPDwgNiwKLSAgICAg ICAgQ2hpbGROZWVkc1N0eWxlUmVjYWxjRmxhZyA9IDEgPDwgNywKLSAgICAgICAgSW5Eb2N1bWVu dEZsYWcgPSAxIDw8IDgsCi0gICAgICAgIElzTGlua0ZsYWcgPSAxIDw8IDksCi0gICAgICAgIElz QWN0aXZlRmxhZyA9IDEgPDwgMTAsCi0gICAgICAgIElzSG92ZXJlZEZsYWcgPSAxIDw8IDExLAot ICAgICAgICBJbkFjdGl2ZUNoYWluRmxhZyA9IDEgPDwgMTIsCi0gICAgICAgIEluRGV0YWNoRmxh ZyA9IDEgPDwgMTMsCi0gICAgICAgIEhhc1JhcmVEYXRhRmxhZyA9IDEgPDwgMTQsCi0gICAgICAg IElzU2hhZG93Um9vdEZsYWcgPSAxIDw8IDE1LAorICAgICAgICBOb2RlVHlwZVRhZ01hc2sgPSAx IDw8IDIgfCAxIDw8IDEgfCAxLAorICAgICAgICBJc0F0dGFjaGVkRmxhZyA9IDEgPDwgMywKKyAg ICAgICAgQ2hpbGROZWVkc1N0eWxlUmVjYWxjRmxhZyA9IDEgPDwgNCwKKyAgICAgICAgSW5Eb2N1 bWVudEZsYWcgPSAxIDw8IDUsCisgICAgICAgIElzTGlua0ZsYWcgPSAxIDw8IDYsCisgICAgICAg IElzQWN0aXZlRmxhZyA9IDEgPDwgNywKKyAgICAgICAgSXNIb3ZlcmVkRmxhZyA9IDEgPDwgOCwK KyAgICAgICAgSW5BY3RpdmVDaGFpbkZsYWcgPSAxIDw8IDksCisgICAgICAgIEluRGV0YWNoRmxh ZyA9IDEgPDwgMTAsCisgICAgICAgIEhhc1JhcmVEYXRhRmxhZyA9IDEgPDwgMTEsCiAKICAgICAg ICAgLy8gVGhlc2UgYml0cyBhcmUgdXNlZCBieSBkZXJpdmVkIGNsYXNzZXMsIHB1bGxlZCB1cCBo ZXJlIHNvIHRoZXkgY2FuCiAgICAgICAgIC8vIGJlIHN0b3JlZCBpbiB0aGUgc2FtZSBtZW1vcnkg d29yZCBhcyB0aGUgTm9kZSBiaXRzIGFib3ZlLgotICAgICAgICBJc1BhcnNpbmdDaGlsZHJlbkZp bmlzaGVkRmxhZyA9IDEgPDwgMTYsIC8vIEVsZW1lbnQKLSAgICAgICAgSXNTdHlsZUF0dHJpYnV0 ZVZhbGlkRmxhZyA9IDEgPDwgMTcsIC8vIFN0eWxlZEVsZW1lbnQKKyAgICAgICAgSXNQYXJzaW5n Q2hpbGRyZW5GaW5pc2hlZEZsYWcgPSAxIDw8IDEyLCAvLyBFbGVtZW50CisgICAgICAgIElzU3R5 bGVBdHRyaWJ1dGVWYWxpZEZsYWcgPSAxIDw8IDEzLCAvLyBTdHlsZWRFbGVtZW50CiAjaWYgRU5B QkxFKFNWRykKLSAgICAgICAgQXJlU1ZHQXR0cmlidXRlc1ZhbGlkRmxhZyA9IDEgPDwgMTgsIC8v IEVsZW1lbnQKLSAgICAgICAgSXNTeW5jaHJvbml6aW5nU1ZHQXR0cmlidXRlc0ZsYWcgPSAxIDw8 IDE5LCAvLyBTVkdFbGVtZW50Ci0gICAgICAgIEhhc1NWR1JhcmVEYXRhRmxhZyA9IDEgPDwgMjAs IC8vIFNWR0VsZW1lbnQKKyAgICAgICAgQXJlU1ZHQXR0cmlidXRlc1ZhbGlkRmxhZyA9IDEgPDwg MTQsIC8vIEVsZW1lbnQKKyAgICAgICAgSXNTeW5jaHJvbml6aW5nU1ZHQXR0cmlidXRlc0ZsYWcg PSAxIDw8IDE1LCAvLyBTVkdFbGVtZW50CisgICAgICAgIEhhc1NWR1JhcmVEYXRhRmxhZyA9IDEg PDwgMTYsIC8vIFNWR0VsZW1lbnQKICNlbmRpZgogCiAgICAgICAgIFN0eWxlQ2hhbmdlTWFzayA9 IDEgPDwgbm9kZVN0eWxlQ2hhbmdlU2hpZnQgfCAxIDw8IChub2RlU3R5bGVDaGFuZ2VTaGlmdCAr IDEpLAogCi0gICAgICAgIFNlbGZPckFuY2VzdG9ySGFzRGlyQXV0b0ZsYWcgPSAxIDw8IDIzLAot ICAgICAgICBIYXNDdXN0b21XaWxsT3JEaWRSZWNhbGNTdHlsZUZsYWcgPSAxIDw8IDI0LAotICAg ICAgICBIYXNDdXN0b21TdHlsZUZvclJlbmRlcmVyRmxhZyA9IDEgPDwgMjUsCi0KLSAgICAgICAg SGFzTmFtZUZsYWcgPSAxIDw8IDI2LAotCi0gICAgICAgIEF0dHJpYnV0ZVN0eWxlRGlydHlGbGFn ID0gMSA8PCAyNywKKyAgICAgICAgU2VsZk9yQW5jZXN0b3JIYXNEaXJBdXRvRmxhZyA9IDEgPDwg MTksCisgICAgICAgIEhhc0N1c3RvbVdpbGxPckRpZFJlY2FsY1N0eWxlRmxhZyA9IDEgPDwgMjAs CisgICAgICAgIEhhc0N1c3RvbVN0eWxlRm9yUmVuZGVyZXJGbGFnID0gMSA8PCAyMSwKKyAgICAg ICAgSGFzTmFtZUZsYWcgPSAxIDw8IDIyLAorICAgICAgICBBdHRyaWJ1dGVTdHlsZURpcnR5Rmxh ZyA9IDEgPDwgMjMsCisgICAgICAgIEluTmFtZWRGbG93RmxhZyA9IDEgPDwgMjQsCiAKICNpZiBF TkFCTEUoU1ZHKQotICAgICAgICBEZWZhdWx0Tm9kZUZsYWdzID0gSXNQYXJzaW5nQ2hpbGRyZW5G aW5pc2hlZEZsYWcgfCBJc1N0eWxlQXR0cmlidXRlVmFsaWRGbGFnIHwgQXJlU1ZHQXR0cmlidXRl c1ZhbGlkRmxhZywKKyAgICAgICAgRGVmYXVsdE5vZGVGbGFncyA9IElzUGFyc2luZ0NoaWxkcmVu RmluaXNoZWRGbGFnIHwgSXNTdHlsZUF0dHJpYnV0ZVZhbGlkRmxhZyB8IEFyZVNWR0F0dHJpYnV0 ZXNWYWxpZEZsYWcKICNlbHNlCi0gICAgICAgIERlZmF1bHROb2RlRmxhZ3MgPSBJc1BhcnNpbmdD aGlsZHJlbkZpbmlzaGVkRmxhZyB8IElzU3R5bGVBdHRyaWJ1dGVWYWxpZEZsYWcsCisgICAgICAg IERlZmF1bHROb2RlRmxhZ3MgPSBJc1BhcnNpbmdDaGlsZHJlbkZpbmlzaGVkRmxhZyB8IElzU3R5 bGVBdHRyaWJ1dGVWYWxpZEZsYWcKICNlbmRpZgotICAgICAgICBJbk5hbWVkRmxvd0ZsYWcgPSAx IDw8IDI5CiAgICAgfTsKIAotICAgIC8vIDMgYml0cyByZW1haW5pbmcKKyAgICAvLyA3IGJpdHMg cmVtYWluaW5nCiAKICAgICBib29sIGdldEZsYWcoTm9kZUZsYWdzIG1hc2spIGNvbnN0IHsgcmV0 dXJuIG1fbm9kZUZsYWdzICYgbWFzazsgfQogICAgIHZvaWQgc2V0RmxhZyhib29sIGYsIE5vZGVG bGFncyBtYXNrKSBjb25zdCB7IG1fbm9kZUZsYWdzID0gKG1fbm9kZUZsYWdzICYgfm1hc2spIHwg KC0oaW50MzJfdClmICYgbWFzayk7IH0gCiAgICAgdm9pZCBzZXRGbGFnKE5vZGVGbGFncyBtYXNr KSBjb25zdCB7IG1fbm9kZUZsYWdzIHw9IG1hc2s7IH0gCiAgICAgdm9pZCBjbGVhckZsYWcoTm9k ZUZsYWdzIG1hc2spIGNvbnN0IHsgbV9ub2RlRmxhZ3MgJj0gfm1hc2s7IH0gCi0KKyAgICBOb2Rl VHlwZVRhZyB0eXBlVGFnKCkgY29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8Tm9kZVR5cGVUYWc+ KG1fbm9kZUZsYWdzICYgTm9kZVR5cGVUYWdNYXNrKTsgfQorICAgIAogcHJvdGVjdGVkOgogICAg IGVudW0gQ29uc3RydWN0aW9uVHlwZSB7IAotICAgICAgICBDcmVhdGVPdGhlciA9IERlZmF1bHRO b2RlRmxhZ3MsCi0gICAgICAgIENyZWF0ZVRleHQgPSBEZWZhdWx0Tm9kZUZsYWdzIHwgSXNUZXh0 RmxhZywKLSAgICAgICAgQ3JlYXRlQ29udGFpbmVyID0gRGVmYXVsdE5vZGVGbGFncyB8IElzQ29u dGFpbmVyRmxhZywgCi0gICAgICAgIENyZWF0ZUVsZW1lbnQgPSBDcmVhdGVDb250YWluZXIgfCBJ c0VsZW1lbnRGbGFnLCAKLSAgICAgICAgQ3JlYXRlU2hhZG93Um9vdCA9IENyZWF0ZUNvbnRhaW5l ciB8IElzU2hhZG93Um9vdEZsYWcsCi0gICAgICAgIENyZWF0ZVN0eWxlZEVsZW1lbnQgPSBDcmVh dGVFbGVtZW50IHwgSXNTdHlsZWRFbGVtZW50RmxhZywgCi0gICAgICAgIENyZWF0ZUhUTUxFbGVt ZW50ID0gQ3JlYXRlU3R5bGVkRWxlbWVudCB8IElzSFRNTEZsYWcsIAotICAgICAgICBDcmVhdGVT VkdFbGVtZW50ID0gQ3JlYXRlU3R5bGVkRWxlbWVudCB8IElzU1ZHRmxhZywKLSAgICAgICAgQ3Jl YXRlRG9jdW1lbnQgPSBDcmVhdGVDb250YWluZXIgfCBJbkRvY3VtZW50RmxhZworICAgICAgICBD cmVhdGVPdGhlciA9IERlZmF1bHROb2RlRmxhZ3MgfCBUeXBlVGFnT3RoZXIsCisgICAgICAgIENy ZWF0ZVRleHQgPSBEZWZhdWx0Tm9kZUZsYWdzIHwgVHlwZVRhZ1RleHQsCisgICAgICAgIENyZWF0 ZUNvbnRhaW5lciA9IERlZmF1bHROb2RlRmxhZ3MgfCBUeXBlVGFnQ29udGFpbmVyTm9kZSwKKyAg ICAgICAgQ3JlYXRlRWxlbWVudCA9IERlZmF1bHROb2RlRmxhZ3MgfCBUeXBlVGFnRWxlbWVudCwK KyAgICAgICAgQ3JlYXRlU2hhZG93Um9vdCA9IERlZmF1bHROb2RlRmxhZ3MgfCBUeXBlVGFnU2hh ZG93Um9vdCwKKyAgICAgICAgQ3JlYXRlU3R5bGVkRWxlbWVudCA9IERlZmF1bHROb2RlRmxhZ3Mg fCBUeXBlVGFnU3R5bGVkRWxlbWVudCwKKyAgICAgICAgQ3JlYXRlSFRNTEVsZW1lbnQgPSBEZWZh dWx0Tm9kZUZsYWdzIHwgVHlwZVRhZ0hUTUxFbGVtZW50LAorICAgICAgICBDcmVhdGVTVkdFbGVt ZW50ID0gRGVmYXVsdE5vZGVGbGFncyB8IFR5cGVUYWdTVkdFbGVtZW50LAorICAgICAgICBDcmVh dGVEb2N1bWVudCA9IERlZmF1bHROb2RlRmxhZ3MgfCBUeXBlVGFnQ29udGFpbmVyTm9kZSB8IElu RG9jdW1lbnRGbGFnCiAgICAgfTsKKwogICAgIE5vZGUoRG9jdW1lbnQqLCBDb25zdHJ1Y3Rpb25U eXBlKTsKIAogICAgIHZpcnR1YWwgdm9pZCBkaWRNb3ZlVG9OZXdEb2N1bWVudChEb2N1bWVudCog b2xkRG9jdW1lbnQpOwpAQCAtODAyLDcgKzgwOCw3IEBAIGlubGluZSB2b2lkIGFkZFN1YnJlc291 cmNlVVJMKExpc3RIYXNoU2V0PEtVUkw+JiB1cmxzLCBjb25zdCBLVVJMJiB1cmwpCiAKIGlubGlu ZSBDb250YWluZXJOb2RlKiBOb2RlOjpwYXJlbnROb2RlKCkgY29uc3QKIHsKLSAgICByZXR1cm4g Z2V0RmxhZyhJc1NoYWRvd1Jvb3RGbGFnKSA/IDAgOiBwYXJlbnQoKTsKKyAgICByZXR1cm4gaXNT aGFkb3dSb290KCkgPyAwIDogcGFyZW50KCk7CiB9CiAKIGlubGluZSBDb250YWluZXJOb2RlKiBO b2RlOjpwYXJlbnRPckhvc3ROb2RlKCkgY29uc3QKQEAgLTgxMiw3ICs4MTgsNyBAQCBpbmxpbmUg Q29udGFpbmVyTm9kZSogTm9kZTo6cGFyZW50T3JIb3N0Tm9kZSgpIGNvbnN0CiAKIGlubGluZSBD b250YWluZXJOb2RlKiBOb2RlOjpwYXJlbnROb2RlR3VhcmFudGVlZEhvc3RGcmVlKCkgY29uc3QK IHsKLSAgICBBU1NFUlQoIWdldEZsYWcoSXNTaGFkb3dSb290RmxhZykpOworICAgIEFTU0VSVCgh aXNTaGFkb3dSb290KCkpOwogICAgIHJldHVybiBwYXJlbnRPckhvc3ROb2RlKCk7CiB9CiAKQEAg LTgyOSw2ICs4MzUsNDQgQEAgaW5saW5lIHZvaWQgTm9kZTo6cmVhdHRhY2hJZkF0dGFjaGVkKCkK ICAgICAgICAgcmVhdHRhY2goKTsKIH0KIAoraW5saW5lIGJvb2wgTm9kZTo6aXNDb250YWluZXJO b2RlKCkgY29uc3QKK3sKKyAgICBOb2RlVHlwZVRhZyB0YWcgPSB0eXBlVGFnKCk7CisgICAgcmV0 dXJuIFR5cGVUYWdDb250YWluZXJOb2RlIDw9IHRhZyAmJiB0YWcgPD0gVHlwZVRhZ1NoYWRvd1Jv b3Q7Cit9CisKK2lubGluZSBib29sIE5vZGU6OmlzRWxlbWVudE5vZGUoKSBjb25zdAoreworICAg IE5vZGVUeXBlVGFnIHRhZyA9IHR5cGVUYWcoKTsKKyAgICByZXR1cm4gVHlwZVRhZ0VsZW1lbnQg PD0gdGFnICYmIHRhZyA8PSBUeXBlVGFnU1ZHRWxlbWVudDsKK30KKworaW5saW5lIGJvb2wgTm9k ZTo6aXNTdHlsZWRFbGVtZW50KCkgY29uc3QKK3sKKyAgICBOb2RlVHlwZVRhZyB0YWcgPSB0eXBl VGFnKCk7CisgICAgcmV0dXJuIFR5cGVUYWdTdHlsZWRFbGVtZW50IDw9IHRhZyAmJiB0YWcgPD0g VHlwZVRhZ1NWR0VsZW1lbnQ7Cit9CisKK2lubGluZSBib29sIE5vZGU6OmlzVGV4dE5vZGUoKSBj b25zdAoreworICAgIHJldHVybiBUeXBlVGFnVGV4dCA9PSB0eXBlVGFnKCk7Cit9CisKK2lubGlu ZSBib29sIE5vZGU6OmlzSFRNTEVsZW1lbnQoKSBjb25zdAoreworICAgIHJldHVybiBUeXBlVGFn SFRNTEVsZW1lbnQgPT0gdHlwZVRhZygpOworfQorCitpbmxpbmUgYm9vbCBOb2RlOjppc1NWR0Vs ZW1lbnQoKSBjb25zdAoreworICAgIHJldHVybiBUeXBlVGFnU1ZHRWxlbWVudCA9PSB0eXBlVGFn KCk7Cit9CisKK2lubGluZSBib29sIE5vZGU6OmlzU2hhZG93Um9vdCgpIGNvbnN0Cit7CisgICAg cmV0dXJuIFR5cGVUYWdTaGFkb3dSb290ID09IHR5cGVUYWcoKTsKK30KKwogfSAvL25hbWVzcGFj ZQogCiAjaWZuZGVmIE5ERUJVRwo=