79293 2012-02-22 16:05:26 -0800 Enable Geolocation bindings for GObject 2012-02-23 20:58:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79327 1 abarth abarth gustavo haraken mrobinson pnormand webkit.review.bot xan.lopez oldest_to_newest 562499 0 abarth 2012-02-22 16:05:26 -0800 Enable Geolocation bindings for GObject 562502 1 128316 abarth 2012-02-22 16:06:05 -0800 Created attachment 128316 Patch 562507 2 haraken 2012-02-22 16:09:47 -0800 Try to see if the GTK bot gets happy. 562534 3 128316 pnormand 2012-02-22 16:31:36 -0800 Comment on attachment 128316 Patch Attachment 128316 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11599019 562536 4 haraken 2012-02-22 16:32:18 -0800 :-( 562541 5 128316 abarth 2012-02-22 16:35:37 -0800 Comment on attachment 128316 Patch I'm not sure it's the same problem that mrobinson fixed. It might just be a bug somewhere in the code generator where the include line isn't being generated for some reason. 562625 6 mrobinson 2012-02-22 17:38:41 -0800 This failure seems unrelated to the bug I was looking at. 562629 7 mrobinson 2012-02-22 17:40:18 -0800 Do take care when making changes that break API on GTK+. We just branched for a stable release a few days ago and if Geolocation was disabled there, we may have shipped a pre-release with an API break. 562635 8 abarth 2012-02-22 17:44:00 -0800 Hopefully we will get this fixed shortly. The breaking half of this change when in less than 24 hours ago. With any luck, we'll resolve the issue within another 24 hours. 562638 9 mrobinson 2012-02-22 17:48:04 -0800 (In reply to comment #8) > Hopefully we will get this fixed shortly. The breaking half of this change when in less than 24 hours ago. With any luck, we'll resolve the issue within another 24 hours. If it was only 24-hours ago, everything should be fine then. We branched before that point. :) 562771 10 haraken 2012-02-22 20:48:50 -0800 I tried the GTK build in my local machine and found that "WebCore::" is missing before "NavigatorGeolocation":-) Patch is coming. 562777 11 128381 haraken 2012-02-22 20:56:19 -0800 Created attachment 128381 Patch 562785 12 haraken 2012-02-22 21:05:20 -0800 The GTK bot looks happy:) 562805 13 128381 abarth 2012-02-22 21:41:41 -0800 Comment on attachment 128381 Patch Ah! 562837 14 128381 webkit.review.bot 2012-02-22 22:25:54 -0800 Comment on attachment 128381 Patch Clearing flags on attachment: 128381 Committed r108610: <http://trac.webkit.org/changeset/108610> 562838 15 webkit.review.bot 2012-02-22 22:25:59 -0800 All reviewed patches have been landed. Closing bug. 128316 2012-02-22 16:06:05 -0800 2012-02-22 20:56:14 -0800 Patch bug-79293-20120222160603.patch text/plain 1380 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwODU2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTIyICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRW5hYmxlIEdlb2xvY2F0aW9uIGJp bmRpbmdzIGZvciBHT2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03OTI5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEkgZGlzYWJsZWQgdGhpcyBBUEkgb24gR09iamVjdCB0ZW1wb3JhcmlseSBkdWUg dG8gYSBidWlsZCBpc3N1ZS4gIFRoZQorICAgICAgICBidWlsZCBpc3N1ZSBpcyByZXNvbHZlZCwg c28gd2UgY2FuIHJlLWVuYWJsZSBpdC4KKworICAgICAgICAqIE1vZHVsZXMvZ2VvbG9jYXRpb24v TmF2aWdhdG9yR2VvbG9jYXRpb24uaWRsOgorCiAyMDEyLTAyLTIyICBEYW5pZWwgQmF0ZXMgIDxk YmF0ZXNAd2Via2l0Lm9yZz4KIAogICAgICAgICBVcGRhdGUgY2hhbmdlIGxvZyBlbnRyeSBmb3Ig cjEwODU2MSB0byByZWZsZWN0IHJlbW92YWwgb2YgImlmIChtX2Rpc3BhdGNoU29vbkxpc3QuaXNF bXB0eSgpKSIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL05hdmln YXRvckdlb2xvY2F0aW9uLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2dlb2xvY2F0aW9uL05hdmlnYXRvckdlb2xvY2F0aW9uLmlkbAkocmV2aXNpb24gMTA4NTU1KQor KysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nZW9sb2NhdGlvbi9OYXZpZ2F0b3JHZW9sb2NhdGlv bi5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTIzLDEwICsyMyw3IEBAIG1vZHVsZSB3aW5kb3cgewog ICAgICAgICBDb25kaXRpb25hbD1HRU9MT0NBVElPTiwKICAgICAgICAgU3VwcGxlbWVudGFsPU5h dmlnYXRvcgogICAgIF0gTmF2aWdhdG9yR2VvbG9jYXRpb24gewotI2lmICFkZWZpbmVkKExBTkdV QUdFX0dPQkpFQ1QpIHx8ICFMQU5HVUFHRV9HT0JKRUNUCi0gICAgICAgIC8vIEZJWE1FOiBFbmFi bGUgdGhpcyBpbnRlcmZhY2UgZm9yIEdPQkpFQ1QuCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0 ZSBbVjhFbmFibGVkQXRSdW50aW1lXSBHZW9sb2NhdGlvbiBnZW9sb2NhdGlvbjsKLSNlbmRpZgog ICAgIH07CiAKIH0K 128381 2012-02-22 20:56:19 -0800 2012-02-22 22:25:54 -0800 Patch bug-79293-20120223135618.patch text/plain 5620 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTMwYjUyYmQ3MjUyMzIw OGM2YzY0ZDVkNThkMTg3MGEzYWMxNDdjMS4uMTBhMGRhMzEwYzlkZTVkZjhjMGI0MGU4ZWZjNTU4 MTA4M2U5Mzg1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTIyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBFbmFibGUgR2VvbG9j YXRpb24gYmluZGluZ3MgZm9yIEdPYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc5MjkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzICJXZWJDb3JlOjoiIHRvIHN1cHBsZW1l bnRhbCBtZXRob2QgY2FsbHMuCisgICAgICAgIFRoaXMgd2lsbCBzb2x2ZSB0aGUgR1RLIGJ1aWxk IGZhaWx1cmUgd2UgaGF2ZSBvYnNlcnZlZCBpbiB0aGUgR2VvbG9jYXRpb24gQVBJLAorICAgICAg ICBhbmQgdGh1cyB0aGlzIHBhdGNoIGVuYWJsZXMgdGhlIEdlb2xvY2F0aW9uIEFQSS4KKworICAg ICAgICAqIE1vZHVsZXMvZ2VvbG9jYXRpb24vTmF2aWdhdG9yR2VvbG9jYXRpb24uaWRsOgorICAg ICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG06CisgICAgICAg IChHZW5lcmF0ZVByb3BlcnR5KToKKyAgICAgICAgKEdlbmVyYXRlRnVuY3Rpb24pOgorCiAyMDEy LTAyLTIyICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4KIAogICAgICAgICBVcGRh dGUgY2hhbmdlIGxvZyBlbnRyeSBmb3IgcjEwODU2MSB0byByZWZsZWN0IHJlbW92YWwgb2YgImlm IChtX2Rpc3BhdGNoU29vbkxpc3QuaXNFbXB0eSgpKSIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL05hdmlnYXRvckdlb2xvY2F0aW9uLmlkbCBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vTmF2aWdhdG9yR2VvbG9jYXRpb24uaWRsCmlu ZGV4IGVmNTg0MzgyZjNhN2I1MzNhNjE4NWYyNzQ4OTM0MjVhMTEzNjZhY2EuLmUwYjhmMGVkMWRm YmMzZmI4ZjZiZWQ2ZTBmODY3OGZkODUxOTkwMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvZ2VvbG9jYXRpb24vTmF2aWdhdG9yR2VvbG9jYXRpb24uaWRsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vTmF2aWdhdG9yR2VvbG9jYXRpb24uaWRsCkBA IC0yMywxMCArMjMsNyBAQCBtb2R1bGUgd2luZG93IHsKICAgICAgICAgQ29uZGl0aW9uYWw9R0VP TE9DQVRJT04sCiAgICAgICAgIFN1cHBsZW1lbnRhbD1OYXZpZ2F0b3IKICAgICBdIE5hdmlnYXRv ckdlb2xvY2F0aW9uIHsKLSNpZiAhZGVmaW5lZChMQU5HVUFHRV9HT0JKRUNUKSB8fCAhTEFOR1VB R0VfR09CSkVDVAotICAgICAgICAvLyBGSVhNRTogRW5hYmxlIHRoaXMgaW50ZXJmYWNlIGZvciBH T0JKRUNULgogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW1Y4RW5hYmxlZEF0UnVudGltZV0g R2VvbG9jYXRpb24gZ2VvbG9jYXRpb247Ci0jZW5kaWYKICAgICB9OwogCiB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBt IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5w bQppbmRleCBkOGFiZmZiZWNkZThkOGM5YjI0Mzc2M2U3Y2FhYTVmZGI2YzAyNzcyLi40NzY3N2E4 YzMxNTQ4NzJmM2I1YzZkNzBkZjBiY2VmMjE2ODhjMjEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KQEAgLTM4 OSw4ICszODksOCBAQCBzdWIgR2VuZXJhdGVQcm9wZXJ0eSB7CiAgICAgICAgIHB1c2goQHNldHRl ckFyZ3VtZW50cywgIiR7Y29udmVydEZ1bmN0aW9ufShnX3ZhbHVlX2dldF8kZ3R5cGUodmFsdWUp KSIpOwogICAgICAgICB1bnNoaWZ0KEBnZXR0ZXJBcmd1bWVudHMsICJjb3JlU2VsZiIpOwogICAg ICAgICB1bnNoaWZ0KEBzZXR0ZXJBcmd1bWVudHMsICJjb3JlU2VsZiIpOwotICAgICAgICAkZ2V0 dGVyRnVuY3Rpb25OYW1lID0gIiR7aW1wbGVtZW50ZWRCeX06OiRnZXR0ZXJGdW5jdGlvbk5hbWUi OwotICAgICAgICAkc2V0dGVyRnVuY3Rpb25OYW1lID0gIiR7aW1wbGVtZW50ZWRCeX06OiRzZXR0 ZXJGdW5jdGlvbk5hbWUiOworICAgICAgICAkZ2V0dGVyRnVuY3Rpb25OYW1lID0gIldlYkNvcmU6 OiR7aW1wbGVtZW50ZWRCeX06OiRnZXR0ZXJGdW5jdGlvbk5hbWUiOworICAgICAgICAkc2V0dGVy RnVuY3Rpb25OYW1lID0gIldlYkNvcmU6OiR7aW1wbGVtZW50ZWRCeX06OiRzZXR0ZXJGdW5jdGlv bk5hbWUiOwogICAgIH0gZWxzZSB7CiAgICAgICAgIHB1c2goQHNldHRlckFyZ3VtZW50cywgIiR7 Y29udmVydEZ1bmN0aW9ufShnX3ZhbHVlX2dldF8kZ3R5cGUodmFsdWUpKSIpOwogICAgICAgICAk Z2V0dGVyRnVuY3Rpb25OYW1lID0gImNvcmVTZWxmLT4kZ2V0dGVyRnVuY3Rpb25OYW1lIjsKQEAg LTkyNiw3ICs5MjYsNyBAQCBFT0YKICAgICAgICAgICAgICAgICBteSAkaW1wbGVtZW50ZWRCeSA9 ICRmdW5jdGlvbi0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSW1wbGVtZW50ZWRC eSJ9OwogICAgICAgICAgICAgICAgICRpbXBsSW5jbHVkZXN7IiR7aW1wbGVtZW50ZWRCeX0uaCJ9 ID0gMTsKICAgICAgICAgICAgICAgICB1bnNoaWZ0KEBhcmd1bWVudHMsICJpdGVtIik7Ci0gICAg ICAgICAgICAgICAgJGZ1bmN0aW9uTmFtZSA9ICIke2ltcGxlbWVudGVkQnl9Ojoke2Z1bmN0aW9u TmFtZX0iOworICAgICAgICAgICAgICAgICRmdW5jdGlvbk5hbWUgPSAiV2ViQ29yZTo6JHtpbXBs ZW1lbnRlZEJ5fTo6JHtmdW5jdGlvbk5hbWV9IjsKICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAg ICAgICAgICAgICAgJGZ1bmN0aW9uTmFtZSA9ICJpdGVtLT4ke2Z1bmN0aW9uTmFtZX0iOwogICAg ICAgICAgICAgfQpAQCAtOTM3LDcgKzkzNyw3IEBAIEVPRgogICAgICAgICAgICAgICAgIG15ICRp bXBsZW1lbnRlZEJ5ID0gJGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+ eyJJbXBsZW1lbnRlZEJ5In07CiAgICAgICAgICAgICAgICAgJGltcGxJbmNsdWRlc3siJHtpbXBs ZW1lbnRlZEJ5fS5oIn0gPSAxOwogICAgICAgICAgICAgICAgIHVuc2hpZnQoQGFyZ3VtZW50cywg Iml0ZW0iKTsKLSAgICAgICAgICAgICAgICAkZ2V0dGVyQ29udGVudEhlYWQgPSAiJHthc3NpZ259 Y29udmVydFRvVVRGOFN0cmluZygke2ltcGxlbWVudGVkQnl9Ojoke2Z1bmN0aW9uU2lnTmFtZX0o IiAuIGpvaW4oIiwgIiwgQGFyZ3VtZW50cykgLiAiKSk7XG4iOworICAgICAgICAgICAgICAgICRn ZXR0ZXJDb250ZW50SGVhZCA9ICIke2Fzc2lnbn1jb252ZXJ0VG9VVEY4U3RyaW5nKFdlYkNvcmU6 OiR7aW1wbGVtZW50ZWRCeX06OiR7ZnVuY3Rpb25TaWdOYW1lfSgiIC4gam9pbigiLCAiLCBAYXJn dW1lbnRzKSAuICIpKTtcbiI7CiAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAg ICRnZXR0ZXJDb250ZW50SGVhZCA9ICIke2Fzc2lnbn1jb252ZXJ0VG9VVEY4U3RyaW5nKGl0ZW0t PiR7ZnVuY3Rpb25TaWdOYW1lfSgiIC4gam9pbigiLCAiLCBAYXJndW1lbnRzKSAuICIpKTtcbiI7 CiAgICAgICAgICAgICB9CkBAIC05NTIsNyArOTUyLDcgQEAgRU9GCiAgICAgICAgICAgICAgICAg bXkgJGltcGxlbWVudGVkQnkgPSAkZnVuY3Rpb24tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1 dGVzLT57IkltcGxlbWVudGVkQnkifTsKICAgICAgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyIk e2ltcGxlbWVudGVkQnl9LmgifSA9IDE7CiAgICAgICAgICAgICAgICAgdW5zaGlmdChAYXJndW1l bnRzLCAiaXRlbSIpOwotICAgICAgICAgICAgICAgICRmdW5jdGlvbk5hbWUgPSAiJHtpbXBsZW1l bnRlZEJ5fTo6JHtmdW5jdGlvbk5hbWV9IjsKKyAgICAgICAgICAgICAgICAkZnVuY3Rpb25OYW1l ID0gIldlYkNvcmU6OiR7aW1wbGVtZW50ZWRCeX06OiR7ZnVuY3Rpb25OYW1lfSI7CiAgICAgICAg ICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgICRmdW5jdGlvbk5hbWUgPSAiaXRlbS0+JHtm dW5jdGlvbk5hbWV9IjsKICAgICAgICAgICAgIH0KQEAgLTk2NCw3ICs5NjQsNyBAQCBFT0YKICAg ICAgICAgICAgICAgICBteSAkaW1wbGVtZW50ZWRCeSA9ICRmdW5jdGlvbi0+c2lnbmF0dXJlLT5l eHRlbmRlZEF0dHJpYnV0ZXMtPnsiSW1wbGVtZW50ZWRCeSJ9OwogICAgICAgICAgICAgICAgICRp bXBsSW5jbHVkZXN7IiR7aW1wbGVtZW50ZWRCeX0uaCJ9ID0gMTsKICAgICAgICAgICAgICAgICB1 bnNoaWZ0KEBhcmd1bWVudHMsICJpdGVtIik7Ci0gICAgICAgICAgICAgICAgJGZ1bmN0aW9uTmFt ZSA9ICIke2ltcGxlbWVudGVkQnl9Ojoke2Z1bmN0aW9uTmFtZX0iOworICAgICAgICAgICAgICAg ICRmdW5jdGlvbk5hbWUgPSAiV2ViQ29yZTo6JHtpbXBsZW1lbnRlZEJ5fTo6JHtmdW5jdGlvbk5h bWV9IjsKICAgICAgICAgICAgICAgICAkY29udGVudEhlYWQgPSAiJHthc3NpZ259JHthc3NpZ25Q cmV9JHtmdW5jdGlvbk5hbWV9KCIgLiBqb2luKCIsICIsIEBhcmd1bWVudHMpIC4gIiR7YXNzaWdu UG9zdH0pO1xuIjsKICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgJGZ1bmN0 aW9uTmFtZSA9ICJpdGVtLT4ke2Z1bmN0aW9uTmFtZX0iOwpAQCAtOTc2LDcgKzk3Niw3IEBAIEVP RgogICAgICAgICAgICAgICAgIG15ICRpbXBsZW1lbnRlZEJ5ID0gJGZ1bmN0aW9uLT5zaWduYXR1 cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJJbXBsZW1lbnRlZEJ5In07CiAgICAgICAgICAgICAg ICAgJGltcGxJbmNsdWRlc3siJHtpbXBsZW1lbnRlZEJ5fS5oIn0gPSAxOwogICAgICAgICAgICAg ICAgIHVuc2hpZnQoQGFyZ3VtZW50cywgIml0ZW0iKTsKLSAgICAgICAgICAgICAgICAkY29udGVu dEhlYWQgPSAiJHthc3NpZ259JHthc3NpZ25QcmV9JHtpbXBsZW1lbnRlZEJ5fTo6JHtmdW5jdGlv blNpZ05hbWV9KCIgLiBqb2luKCIsICIsIEBhcmd1bWVudHMpIC4gIiR7YXNzaWduUG9zdH0pO1xu IjsKKyAgICAgICAgICAgICAgICAkY29udGVudEhlYWQgPSAiJHthc3NpZ259JHthc3NpZ25QcmV9 V2ViQ29yZTo6JHtpbXBsZW1lbnRlZEJ5fTo6JHtmdW5jdGlvblNpZ05hbWV9KCIgLiBqb2luKCIs ICIsIEBhcmd1bWVudHMpIC4gIiR7YXNzaWduUG9zdH0pO1xuIjsKICAgICAgICAgICAgIH0gZWxz ZSB7CiAgICAgICAgICAgICAgICAgJGNvbnRlbnRIZWFkID0gIiR7YXNzaWdufSR7YXNzaWduUHJl fWl0ZW0tPiR7ZnVuY3Rpb25TaWdOYW1lfSgiIC4gam9pbigiLCAiLCBAYXJndW1lbnRzKSAuICIk e2Fzc2lnblBvc3R9KTtcbiI7CiAgICAgICAgICAgICB9Cg==