79288 2012-02-22 15:45:50 -0800 [Windows, WinCairo] Handle indeterminate state for checkbox in Windows Theme 2012-02-24 06:46:08 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 lynn.neir bfulgham aroben bfulgham lynn.neir webkit.review.bot oldest_to_newest 562475 0 lynn.neir 2012-02-22 15:45:50 -0800 Windows theme code is not handling indeterminate state for CheckBox. Below is additional code that gives indetermine state capability. Only change is addition of two lines to check for indeterminate state on checkbox and add 8 to the result. This gives correct rendering for Layout test: fast/forms/indeterminate.html unsigned RenderThemeWin::determineState(RenderObject* o) { unsigned result = TS_NORMAL; ControlPart appearance = o->style()->appearance(); if (!isEnabled(o)) result = TS_DISABLED; else if (isReadOnlyControl(o) && (TextFieldPart == appearance || TextAreaPart == appearance || SearchFieldPart == appearance)) result = TFS_READONLY; // Readonly is supported on textfields. else if (isPressed(o)) // Active overrides hover and focused. result = TS_ACTIVE; else if (supportsFocus(appearance) && isFocused(o)) result = TS_FOCUSED; else if (isHovered(o)) result = TS_HOVER; if (isChecked(o)) result += 4; // 4 unchecked states, 4 checked states. else if (isIndeterminate(o) && appearance == CheckboxPart) result += 8; return result; } 563676 1 128600 bfulgham 2012-02-23 16:40:56 -0800 Created attachment 128600 Correct handling of CheckBox when in indeterminate state Thanks for the update, Lynn. I've generated a patch based on your suggested change. 564252 2 128600 aroben 2012-02-24 05:51:12 -0800 Comment on attachment 128600 Correct handling of CheckBox when in indeterminate state View in context: https://bugs.webkit.org/attachment.cgi?id=128600&action=review > Source/WebCore/ChangeLog:8 > + Tested by fast/forms/indeterminate.html I wish we our regression tests actually tested RenderThemeWin! Then we could check in new pixel results for this test. 564291 3 128600 webkit.review.bot 2012-02-24 06:46:04 -0800 Comment on attachment 128600 Correct handling of CheckBox when in indeterminate state Clearing flags on attachment: 128600 Committed r108791: <http://trac.webkit.org/changeset/108791> 564292 4 webkit.review.bot 2012-02-24 06:46:08 -0800 All reviewed patches have been landed. Closing bug. 128600 2012-02-23 16:40:56 -0800 2012-02-24 06:46:03 -0800 Correct handling of CheckBox when in indeterminate state indeterminate_checkbox.patch text/plain 1254 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwODY5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTIzICBMeW5uIE5l aXIgPGx5bm4ubmVpckBza3lwZS5uZXQ+CisKKyAgICAgICAgW1dpbmRvd3MsIFdpbkNhaXJvXSBI YW5kbGUgaW5kZXRlcm1pbmF0ZSBjaGVja2JveCBzdGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkyODgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0ZWQgYnkgZmFzdC9mb3Jtcy9pbmRldGVybWlu YXRlLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHA6IEFkZCBj b2RlIHRvIGNoZWNrIGZvciBpbmRldGVybWluYXRlCisgICAgICAgICAgc3RhdGUgaW4gQ2hlY2tC b3guCisKIDIwMTItMDItMjEgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbY2hyb21pdW1dIE5vdGlmeSBjb21wb3NpdG9yIG9mIHdoZWVsIGV2ZW50IHJl Z2lzdHJhdGlvbiB2aWEgU2Nyb2xsaW5nQ29vcmRpbmF0b3IKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcAkocmV2aXNpb24gMTA4Njg0KQorKysgU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDU3LDYgKzQ1Nyw4IEBAIHVuc2lnbmVkIFJlbmRlclRoZW1lV2luOjpkZXRlcm1pbmVTdGF0 ZSgKICAgICAgICAgcmVzdWx0ID0gVFNfSE9WRVI7CiAgICAgaWYgKGlzQ2hlY2tlZChvKSkKICAg ICAgICAgcmVzdWx0ICs9IDQ7IC8vIDQgdW5jaGVja2VkIHN0YXRlcywgNCBjaGVja2VkIHN0YXRl cy4KKyAgICBlbHNlIGlmIChpc0luZGV0ZXJtaW5hdGUobykgJiYgYXBwZWFyYW5jZSA9PSBDaGVj a2JveFBhcnQpCisgICAgICAgIHJlc3VsdCArPSA4OwogICAgIHJldHVybiByZXN1bHQ7CiB9CiAK