79285 2012-02-22 15:30:36 -0800 Code cleanup in WebNotificationManager 2012-02-22 15:42:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 jonlee jonlee webkit-bug-importer oldest_to_newest 562455 0 jonlee 2012-02-22 15:30:36 -0800 could make part of show() more concise. 562456 1 webkit-bug-importer 2012-02-22 15:31:23 -0800 <rdar://problem/10914522> 562460 2 webkit-bug-importer 2012-02-22 15:32:43 -0800 <rdar://problem/10914539> 562463 3 128305 jonlee 2012-02-22 15:34:55 -0800 Created attachment 128305 Patch 562470 4 jonlee 2012-02-22 15:42:57 -0800 Committed r108563: <http://trac.webkit.org/changeset/108563> 128305 2012-02-22 15:34:55 -0800 2012-02-22 15:36:31 -0800 Patch bug-79285-20120222153547.patch text/plain 2287 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2IzNGNjM2NhYzExM2U3 NjU4YjBmNTdmZTA5ZTMxYzY4MjViNjY2YS4uMDZkYWMzMDc2YWZiNzFlZWQyZGVlZGZlMjAwNzQ4 N2IyNzUzNjhjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTIyICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBDb2RlIGNsZWFudXAgaW4gV2ViTm90 aWZpY2F0aW9uTWFuYWdlciAoNzkyODUpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03OTI4NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTA5MTQ1MjI+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL05vdGlmaWNhdGlvbnMvV2ViTm90aWZpY2F0aW9uTWFuYWdlci5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYk5vdGlmaWNhdGlvbk1hbmFnZXI6OnNob3cpOiBTaW1wbGlmeSBhZGRpbmcg YSBibGFuayB2ZWN0b3IgdG8gdGhlIG1hcCB1c2luZyAuYWRkKCksCisgICAgICAgIHNpbWlsYXIg dG8gd2hhdCBpcyBmb3VuZCBpbiBXZWJOb3RpZmljYXRpb25DbGllbnQubW0gaW4gV2ViS2l0IDEu CisKIDIwMTItMDItMjIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHVEtdIENsZWFuIGJ1aWxkIGlzIGJyb2tlbiB3aGVuIHVzaW5nIG1ha2UgLWoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJO b3RpZmljYXRpb25NYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTm90aWZp Y2F0aW9ucy9XZWJOb3RpZmljYXRpb25NYW5hZ2VyLmNwcAppbmRleCA4NGI1MmMyYWMwM2ZiNjIz MTJkM2RmZDdiMmU2NTU1NmNkYmRlNmE0Li40N2VmOTMwODgyODRiN2NhMTRjY2IxM2IxOWFhZTUz MGZkM2E4MzFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNh dGlvbnMvV2ViTm90aWZpY2F0aW9uTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9Ob3RpZmljYXRpb25zL1dlYk5vdGlmaWNhdGlvbk1hbmFnZXIuY3BwCkBAIC0xMTQs MTEgKzExNCw3IEBAIGJvb2wgV2ViTm90aWZpY2F0aW9uTWFuYWdlcjo6c2hvdyhOb3RpZmljYXRp b24qIG5vdGlmaWNhdGlvbiwgV2ViUGFnZSogcGFnZSkKICAgICBtX25vdGlmaWNhdGlvbk1hcC5z ZXQobm90aWZpY2F0aW9uLCBub3RpZmljYXRpb25JRCk7CiAgICAgbV9ub3RpZmljYXRpb25JRE1h cC5zZXQobm90aWZpY2F0aW9uSUQsIG5vdGlmaWNhdGlvbik7CiAgICAgCi0gICAgTm90aWZpY2F0 aW9uQ29udGV4dE1hcDo6aXRlcmF0b3IgaXQgPSBtX25vdGlmaWNhdGlvbkNvbnRleHRNYXAuZmlu ZChub3RpZmljYXRpb24tPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSk7Ci0gICAgaWYgKGl0ID09 IG1fbm90aWZpY2F0aW9uQ29udGV4dE1hcC5lbmQoKSkgewotICAgICAgICBwYWlyPE5vdGlmaWNh dGlvbkNvbnRleHRNYXA6Oml0ZXJhdG9yLCBib29sPiBhZGRlZFBhaXIgPSBtX25vdGlmaWNhdGlv bkNvbnRleHRNYXAuYWRkKG5vdGlmaWNhdGlvbi0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLCBW ZWN0b3I8dWludDY0X3Q+KCkpOwotICAgICAgICBpdCA9IGFkZGVkUGFpci5maXJzdDsKLSAgICB9 CisgICAgTm90aWZpY2F0aW9uQ29udGV4dE1hcDo6aXRlcmF0b3IgaXQgPSBtX25vdGlmaWNhdGlv bkNvbnRleHRNYXAuYWRkKG5vdGlmaWNhdGlvbi0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLCBW ZWN0b3I8dWludDY0X3Q+KCkpLmZpcnN0OwogICAgIGl0LT5zZWNvbmQuYXBwZW5kKG5vdGlmaWNh dGlvbklEKTsKICAgICAKICAgICBtX3Byb2Nlc3MtPmNvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdl czo6V2ViUGFnZVByb3h5OjpTaG93Tm90aWZpY2F0aW9uKG5vdGlmaWNhdGlvbi0+Y29udGVudHMo KS50aXRsZSwgbm90aWZpY2F0aW9uLT5jb250ZW50cygpLmJvZHksIG5vdGlmaWNhdGlvbi0+aWNv blVSTCgpLnN0cmluZygpLCBub3RpZmljYXRpb24tPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+ c2VjdXJpdHlPcmlnaW4oKS0+dG9TdHJpbmcoKSwgbm90aWZpY2F0aW9uSUQpLCBwYWdlLT5wYWdl SUQoKSk7Cg==