79279 2012-02-22 14:39:36 -0800 Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs 2012-02-22 16:16:56 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 562403 0 beidson 2012-02-22 14:39:36 -0800 Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs This WK2 API was somewhat blindly carried over from WebKit1. Unfortunately it's one of a handful of synchronous messages from the WebProcess to the UI Process that causes hangs and seems unnecessary. It seems rare that a client would want to answer "no" to this call, so making it an asynchronous, notification-only callback would clear those hangs! A patch implementing "WillGoToBackForwardListItem" in the version 1 loader client is coming soon. If clients do decide that it'd be important to implement an actual "should" policy callback, it should be done in the bundle client and we can introduce that when it's needed. In radar as <rdar://problem/10406044> 562491 1 128315 beidson 2012-02-22 16:01:37 -0800 Created attachment 128315 Patch v1 562497 2 128315 andersca 2012-02-22 16:04:23 -0800 Comment on attachment 128315 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=128315&action=review > Source/WebKit2/UIProcess/WebLoaderClient.cpp:245 > + if (m_client.version > 0 || !m_client.shouldGoToBackForwardListItem) > return true; You should add a comment here explaining the version check. > Source/WebKit2/WebProcess/WebPage/WebPage.h:506 > + bool willGoToBackForwardItemCallbackEnabled() { return m_willGoToBackForwardItemCallbackEnabled; } This can be const. 562514 3 beidson 2012-02-22 16:16:56 -0800 http://trac.webkit.org/changeset/108570 128315 2012-02-22 16:01:37 -0800 2012-02-22 16:04:23 -0800 Patch v1 opatch.txt text/plain 14063 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzYjM0Y2MzLi41Y2U2MTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNTYg QEAKKzIwMTItMDItMjIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xMDQwNjA0ND4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03OTI3OQorICAgICAgICBTeW5jaHJvbm91cyBTaG91bGRHb1RvQmFj a0ZvcndhcmRMaXN0SXRlbSBjYXVzZXMgbG90cyBvZiBXZWJQcm9jZXNzIGhhbmdzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQW55dGltZSB0aGUgV2Vi UHJvY2VzcyBzZW5kcyBhIHN5bmMgbWVzc2FnZSB1cCB0byB0aGUgVUkgUHJvY2VzcyBhIGhhbmcg Y2FuIGVuc3VlLgorICAgICAgICAKKyAgICAgICAgSW4gdGhlIGNhc2Ugb2Ygc2hvdWxkR29Ub0Jh Y2tGb3J3YXJkTGlzdEl0ZW0gaXQgc2VlbXMgbWFueSBjbGllbnRzIHdhbnQgYSBiYWNrL2Zvcndh cmQKKyAgICAgICAgbm90aWZpY2F0aW9uIGJ1dCBkb24ndCBhY3R1YWxseSB3YW50IHRvIG1ha2Ug YSBwb2xpY3kgZGVjaXNpb24uCisKKyAgICAgICAgTWFraW5nIGl0IGFuIGFzeW5jaHJvbm91cyBu b3RpZmljYXRpb24gaW5zdGVhZCBvZiBhIHN5bmNocm9ub3VzIHBvbGljeSBjYWxsIHdpbGwgcmVt b3ZlIHRoZQorICAgICAgICBwb3NzaWJpbGl0eSBvZiBhIGhhbmcgaGVyZS4KKworICAgICAgICBJ ZiBjbGllbnRzIGxhdGVyIGRlY2lkZSBpdCBpcyBpbXBvcnRhbnQgdG8gaGF2ZSBhIHBvbGljeSBo ZXJlIHdlIHNob3VsZCBpbXBsZW1lbnQgYSBmb3JtIG9mCisgICAgICAgIHNob3VsZEdvVG9CYWNr Rm9yd2FyZExpc3RJdGVtIGluIHRoZSBidW5kbGUgbG9hZGVyIGNsaWVudC4KKworICAgICAgICBB ZGQgYSBub3RpZmljYXRpb24gIndpbGxHb1RvQmFja0ZvcndhcmRMaXN0SXRlbSIgdG8gdGhlIFdL UGFnZUxvYWRlckNsaWVudDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmg6CisK KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViUGFnZVByb3h5Ojppbml0aWFsaXplTG9hZGVyQ2xpZW50KTogVGVsbCB0aGUgV2ViUHJvY2Vz cyB3aGV0aGVyIGl0IHNob3VsZCBiZQorICAgICAgICAgIHNlbmRpbmcgdGhlIHNob3VsZEdvVG9C YWNrRm9yd2FyZExpc3RJdGVtIG9yIHdpbGxHb1RvQmFja0ZvcndhcmRMaXN0SXRlbSBmb3JtIG9m IHRoaXMgbWVzc2FnZS4KKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzaG91bGRHb1Rv QmFja0ZvcndhcmRMaXN0SXRlbSk6IAorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6Ondp bGxHb1RvQmFja0ZvcndhcmRMaXN0SXRlbSk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW46IEFk ZCBhbiBhc3luY2hyb25vdXMgV2lsbEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtIG1lc3NhZ2UKKwor ICAgICAgICBTdG9yZSBhIGZsYWcgaW4gdGhlIFdlYlByb2Nlc3MgLSBTZW50IGZyb20gdGhlIFVJ UHJvY2VzcyAtIHRvIHRlbGwgdGhlIEZyYW1lTG9hZGVyQ2xpZW50IHdoaWNoIGZvcm0gCisgICAg ICAgIG9mIHRoZSBjYWxsYmFjayBzaG91bGQgYmUgdXNlZDoKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OldlYlBhZ2Up OgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmg6CisgICAgICAgIChXZWJL aXQ6OldlYlBhZ2U6OndpbGxHb1RvQmFja0ZvcndhcmRJdGVtQ2FsbGJhY2tFbmFibGVkKToKKyAg ICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2V0V2lsbEdvVG9CYWNrRm9yd2FyZEl0ZW1DYWxsYmFj a0VuYWJsZWQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2Vz LmluOgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkxvYWRlckNsaWVudC5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYkxvYWRlckNsaWVudDo6c2hvdWxkR29Ub0JhY2tGb3J3YXJkTGlzdEl0ZW0p OiBPbmx5IGNvbnNpZGVyIGNhbGxpbmcgdGhpcyBmb3IKKyAgICAgICAgICB2ZXJzaW9uIDAgY2xp ZW50cy4KKyAgICAgICAgKFdlYktpdDo6V2ViTG9hZGVyQ2xpZW50Ojp3aWxsR29Ub0JhY2tGb3J3 YXJkTGlzdEl0ZW0pOiBMYXRlciBjbGllbnRzIGdldCB0aGlzIGNhbGxiYWNrLgorICAgICAgICAq IFVJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuaDoKKyAgICAgICAgKFdlYkxvYWRlckNsaWVudCk6 CisgICAgICAgIAorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVM b2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUxvYWRlckNsaWVudDo6 c2hvdWxkR29Ub0hpc3RvcnlJdGVtKTogU2VuZCBlaXRoZXIgdGhlIHN5bmNocm9ub3VzICJzaG91 bGQiIG1lc3NhZ2UKKyAgICAgICAgICBvciB0aGUgYXN5bmNocm9ub3VzICJ3aWxsIiBtZXNzYWdl IGRlcGVuZGluZyBvbiB3aGljaCB0aGUgV2ViUHJvY2VzcyB3YXMgbGFzdCB0b2xkIHRoYXQgdGhl CisgICAgICAgICAgVUlQcm9jZXNzIGV4cGVjdHMuIFRoZXJlIGlzIGFuIGVkZ2UgY2FzZSB3aGVy ZSB0aGUgd3Jvbmcgb25lIG1pZ2h0IGJlIHNlbnQgYmVjYXVzZSB0aGUgV2ViUHJvY2VzcworICAg ICAgICAgIGhhc24ndCByZWNlaXZlZCB0aGUgbWVzc2FnZSBhYm91dCBhIGNoYW5nZSBpbiB0aGUg V0tQYWdlTG9hZGVyQ2xpZW50IHlldCBidXQgdGhhdCdzIHByb2JhYmx5IG9rYXk7CisgICAgICAg ICAgSXQgc2VlbXMgdW5saWtlbHkgdGhhdCBhIFVJUHJvY2VzcyBjbGllbnQgd291bGQgZXZlciBy YXBpZGx5IGNoYW5nZSBiZXR3ZWVuIHYwIGFuZCBvdGhlciB2ZXJzaW9ucworICAgICAgICAgIG9m IHRoZSBsb2FkZXIgY2xpZW50IGFuZCB0aGUgVUlQcm9jZXNzIG9mIFdlYktpdDIgaXMgZXF1aXBw ZWQgdG8gaGFuZGxlIHRoYXQgY2FzZSBpZiBpdCBjb21lcyB1cC4KKwogMjAxMi0wMi0yMiAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQ2xl YW4gYnVpbGQgaXMgYnJva2VuIHdoZW4gdXNpbmcgbWFrZSAtagpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9DL1dLUGFnZS5oCmluZGV4IGVhODA0OWQuLjk2ZDA5N2MgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmgKQEAgLTcxLDYgKzcxLDcgQEAgdHlwZWRlZiB2b2lk ICgqV0tQYWdlRGlkQ2hhbmdlQmFja0ZvcndhcmRMaXN0Q2FsbGJhY2spKFdLUGFnZVJlZiBwYWdl LCBXS0JhY2tGb3IKIHR5cGVkZWYgYm9vbCAoKldLUGFnZVNob3VsZEdvVG9CYWNrRm9yd2FyZExp c3RJdGVtQ2FsbGJhY2spKFdLUGFnZVJlZiBwYWdlLCBXS0JhY2tGb3J3YXJkTGlzdEl0ZW1SZWYg aXRlbSwgY29uc3Qgdm9pZCAqY2xpZW50SW5mbyk7CiB0eXBlZGVmIHZvaWQgKCpXS1BhZ2VEaWRG YWlsVG9Jbml0aWFsaXplUGx1Z2luQ2FsbGJhY2spKFdLUGFnZVJlZiBwYWdlLCBXS1N0cmluZ1Jl ZiBtaW1lVHlwZSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbyk7CiB0eXBlZGVmIHZvaWQgKCpXS1Bh Z2VEaWROZXdGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRDYWxsYmFjaykoV0tQYWdlUmVmIHBh Z2UsIFdLVHlwZVJlZiB1c2VyRGF0YSwgY29uc3Qgdm9pZCAqY2xpZW50SW5mbyk7Cit0eXBlZGVm IHZvaWQgKCpXS1BhZ2VXaWxsR29Ub0JhY2tGb3J3YXJkTGlzdEl0ZW1DYWxsYmFjaykoV0tQYWdl UmVmIHBhZ2UsIFdLQmFja0ZvcndhcmRMaXN0SXRlbVJlZiBpdGVtLCBjb25zdCB2b2lkICpjbGll bnRJbmZvKTsKIAogc3RydWN0IFdLUGFnZUxvYWRlckNsaWVudCB7CiAgICAgaW50ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2 ZXJzaW9uOwpAQCAtMTEwLDYgKzExMSw4IEBAIHN0cnVjdCBXS1BhZ2VMb2FkZXJDbGllbnQgewog CiAgICAgLy8gRklYTUU6IGRpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZvckZyYW1lIGFu ZCBkaWROZXdGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQgc2hvdWxkIGJlIG1lcmdlZC4KICAg ICBXS1BhZ2VEaWROZXdGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRDYWxsYmFjayAgICAgICAg ICAgICAgICAgICAgIGRpZE5ld0ZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dDsKKworICAgIFdL UGFnZVdpbGxHb1RvQmFja0ZvcndhcmRMaXN0SXRlbUNhbGxiYWNrICAgICAgICAgICAgICAgICAg ICAgICAgICAgd2lsbEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtOwogfTsKIHR5cGVkZWYgc3RydWN0 IFdLUGFnZUxvYWRlckNsaWVudCBXS1BhZ2VMb2FkZXJDbGllbnQ7CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYkxvYWRlckNsaWVudC5jcHAKaW5kZXggODdmZWVhMC4uYTI5ZDY5ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkxvYWRlckNsaWVudC5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkxvYWRlckNsaWVudC5jcHAKQEAgLTI0 MSwxMiArMjQxLDE4IEBAIHZvaWQgV2ViTG9hZGVyQ2xpZW50OjpkaWRDaGFuZ2VCYWNrRm9yd2Fy ZExpc3QoV2ViUGFnZVByb3h5KiBwYWdlLCBXZWJCYWNrRm9yd2FyCiAKIGJvb2wgV2ViTG9hZGVy Q2xpZW50OjpzaG91bGRHb1RvQmFja0ZvcndhcmRMaXN0SXRlbShXZWJQYWdlUHJveHkqIHBhZ2Us IFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qIGl0ZW0pCiB7Ci0gICAgaWYgKCFtX2NsaWVudC5zaG91 bGRHb1RvQmFja0ZvcndhcmRMaXN0SXRlbSkKKyAgICBpZiAobV9jbGllbnQudmVyc2lvbiA+IDAg fHwgIW1fY2xpZW50LnNob3VsZEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtKQogICAgICAgICByZXR1 cm4gdHJ1ZTsKLSAgICAKKwogICAgIHJldHVybiBtX2NsaWVudC5zaG91bGRHb1RvQmFja0Zvcndh cmRMaXN0SXRlbSh0b0FQSShwYWdlKSwgdG9BUEkoaXRlbSksIG1fY2xpZW50LmNsaWVudEluZm8p OwogfQogCit2b2lkIFdlYkxvYWRlckNsaWVudDo6d2lsbEdvVG9CYWNrRm9yd2FyZExpc3RJdGVt KFdlYlBhZ2VQcm94eSogcGFnZSwgV2ViQmFja0ZvcndhcmRMaXN0SXRlbSogaXRlbSkKK3sKKyAg ICBpZiAobV9jbGllbnQud2lsbEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtKQorICAgICAgICBtX2Ns aWVudC53aWxsR29Ub0JhY2tGb3J3YXJkTGlzdEl0ZW0odG9BUEkocGFnZSksIHRvQVBJKGl0ZW0p LCBtX2NsaWVudC5jbGllbnRJbmZvKTsKK30KKwogdm9pZCBXZWJMb2FkZXJDbGllbnQ6OmRpZEZh aWxUb0luaXRpYWxpemVQbHVnaW4oV2ViUGFnZVByb3h5KiBwYWdlLCBjb25zdCBTdHJpbmcmIG1p bWVUeXBlKQogewogICAgIGlmICghbV9jbGllbnQuZGlkRmFpbFRvSW5pdGlhbGl6ZVBsdWdpbikK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuaCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuaAppbmRleCA5NzA1OTE5 Li41NWNjNmFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViTG9hZGVy Q2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkxvYWRlckNsaWVudC5o CkBAIC04Myw2ICs4Myw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgZGlkQ2hhbmdlQmFja0Zvcndh cmRMaXN0KFdlYlBhZ2VQcm94eSosIFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qIGFkZGVkSXRlbSwg VmVjdG9yPFJlZlB0cjxBUElPYmplY3Q+ID4qIHJlbW92ZWRJdGVtcyk7CiAgICAgYm9vbCBzaG91 bGRHb1RvQmFja0ZvcndhcmRMaXN0SXRlbShXZWJQYWdlUHJveHkqLCBXZWJCYWNrRm9yd2FyZExp c3RJdGVtKik7CisgICAgdm9pZCB3aWxsR29Ub0JhY2tGb3J3YXJkTGlzdEl0ZW0oV2ViUGFnZVBy b3h5KiwgV2ViQmFja0ZvcndhcmRMaXN0SXRlbSopOwogCiAgICAgdm9pZCBkaWRGYWlsVG9Jbml0 aWFsaXplUGx1Z2luKFdlYlBhZ2VQcm94eSosIGNvbnN0IFN0cmluZyYgbWltZVR5cGUpOwogfTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggMmZjZmYwYi4u OGVhM2ZlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAg LTI1NCw2ICsyNTQsMTEgQEAgYm9vbCBXZWJQYWdlUHJveHk6OmlzVmFsaWQoKQogdm9pZCBXZWJQ YWdlUHJveHk6OmluaXRpYWxpemVMb2FkZXJDbGllbnQoY29uc3QgV0tQYWdlTG9hZGVyQ2xpZW50 KiBsb2FkQ2xpZW50KQogewogICAgIG1fbG9hZGVyQ2xpZW50LmluaXRpYWxpemUobG9hZENsaWVu dCk7CisgICAgCisgICAgaWYgKCFsb2FkQ2xpZW50KQorICAgICAgICByZXR1cm47CisKKyAgICBw cm9jZXNzKCktPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OlNldFdpbGxHb1RvQmFja0ZvcndhcmRJ dGVtQ2FsbGJhY2tFbmFibGVkKGxvYWRDbGllbnQtPnZlcnNpb24gPiAwKSwgbV9wYWdlSUQpOwog fQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6aW5pdGlhbGl6ZVBvbGljeUNsaWVudChjb25zdCBXS1Bh Z2VQb2xpY3lDbGllbnQqIHBvbGljeUNsaWVudCkKQEAgLTYwOCw2ICs2MTMsMTIgQEAgdm9pZCBX ZWJQYWdlUHJveHk6OnNob3VsZEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtKHVpbnQ2NF90IGl0ZW1J RCwgYm9vbCYgc2hvdWxkR28KICAgICBzaG91bGRHb1RvQmFja0ZvcndhcmRJdGVtID0gaXRlbSAm JiBtX2xvYWRlckNsaWVudC5zaG91bGRHb1RvQmFja0ZvcndhcmRMaXN0SXRlbSh0aGlzLCBpdGVt KTsKIH0KIAordm9pZCBXZWJQYWdlUHJveHk6OndpbGxHb1RvQmFja0ZvcndhcmRMaXN0SXRlbSh1 aW50NjRfdCBpdGVtSUQpCit7CisgICAgaWYgKFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qIGl0ZW0g PSBwcm9jZXNzKCktPndlYkJhY2tGb3J3YXJkSXRlbShpdGVtSUQpKQorICAgICAgICBtX2xvYWRl ckNsaWVudC53aWxsR29Ub0JhY2tGb3J3YXJkTGlzdEl0ZW0odGhpcywgaXRlbSk7Cit9CisKIFN0 cmluZyBXZWJQYWdlUHJveHk6OmFjdGl2ZVVSTCgpIGNvbnN0CiB7CiAgICAgaWYgKCFtX21haW5G cmFtZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku aCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAppbmRleCBlZjEzYThk Li5hZjhkYTFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCkBAIC0y NjYsNiArMjY2LDcgQEAgcHVibGljOgogICAgIHZvaWQgdHJ5UmVzdG9yZVNjcm9sbFBvc2l0aW9u KCk7CiAgICAgdm9pZCBkaWRDaGFuZ2VCYWNrRm9yd2FyZExpc3QoV2ViQmFja0ZvcndhcmRMaXN0 SXRlbSogYWRkZWRJdGVtLCBWZWN0b3I8UmVmUHRyPEFQSU9iamVjdD4gPiogcmVtb3ZlZEl0ZW1z KTsKICAgICB2b2lkIHNob3VsZEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtKHVpbnQ2NF90IGl0ZW1J RCwgYm9vbCYgc2hvdWxkR29Ub0JhY2tGb3J3YXJkTGlzdEl0ZW0pOworICAgIHZvaWQgd2lsbEdv VG9CYWNrRm9yd2FyZExpc3RJdGVtKHVpbnQ2NF90IGl0ZW1JRCk7CiAKICAgICBTdHJpbmcgYWN0 aXZlVVJMKCkgY29uc3Q7CiAgICAgU3RyaW5nIHByb3Zpc2lvbmFsVVJMKCkgY29uc3Q7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmlu IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbgppbmRl eCAwYTVkYTU4Li5jYjBjNjI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkubWVzc2FnZXMuaW4KQEAgLTE2Myw2ICsxNjMsNyBAQCBtZXNzYWdlcyAtPiBX ZWJQYWdlUHJveHkgewogICAgIEJhY2tGb3J3YXJkRm9yd2FyZExpc3RDb3VudCgpIC0+IChpbnQz Ml90IGNvdW50KQogICAgIEJhY2tGb3J3YXJkQ2xlYXIoKQogICAgIFNob3VsZEdvVG9CYWNrRm9y d2FyZExpc3RJdGVtKHVpbnQ2NF90IGl0ZW1JRCkgLT4gKGJvb2wgc2hvdWxkR29Ub0JhY2tGb3J3 YXJkTGlzdEl0ZW0pCisgICAgV2lsbEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtKHVpbnQ2NF90IGl0 ZW1JRCkKIAogICAgICMgVW5kby9SZWRvIG1lc3NhZ2VzCiAgICAgUmVnaXN0ZXJFZGl0Q29tbWFu ZEZvclVuZG8odWludDY0X3QgY29tbWFuZElELCB1aW50MzJfdCBlZGl0QWN0aW9uKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxv YWRlckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAppbmRleCBiZTI0Njg0Li5mMzVhYjVmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9h ZGVyQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcApAQCAtOTMyLDYgKzkzMiwxMSBAQCBib29sIFdl YkZyYW1lTG9hZGVyQ2xpZW50OjpzaG91bGRHb1RvSGlzdG9yeUl0ZW0oSGlzdG9yeUl0ZW0qIGl0 ZW0pIGNvbnN0CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAgICAgCisgICAgaWYgKHdl YlBhZ2UtPndpbGxHb1RvQmFja0ZvcndhcmRJdGVtQ2FsbGJhY2tFbmFibGVkKCkpIHsKKyAgICAg ICAgd2ViUGFnZS0+c2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpXaWxsR29Ub0JhY2tGb3J3 YXJkTGlzdEl0ZW0oaXRlbUlEKSk7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKyAgICAK ICAgICBib29sIHNob3VsZEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtOwogICAgIGlmICghd2ViUGFn ZS0+c2VuZFN5bmMoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6U2hvdWxkR29Ub0JhY2tGb3J3YXJk TGlzdEl0ZW0oaXRlbUlEKSwgTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6U2hvdWxkR29Ub0JhY2tG b3J3YXJkTGlzdEl0ZW06OlJlcGx5KHNob3VsZEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtKSkpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmNwcAppbmRleCA0MDIyZWM0Li4wNmY3NTU5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0yMTAsNiArMjEwLDcgQEAgV2Vi UGFnZTo6V2ViUGFnZSh1aW50NjRfdCBwYWdlSUQsIGNvbnN0IFdlYlBhZ2VDcmVhdGlvblBhcmFt ZXRlcnMmIHBhcmFtZXRlcnMpCiAgICAgLCBtX251bVdoZWVsRXZlbnRIYW5kbGVycygwKQogICAg ICwgbV9jYWNoZWRQYWdlQ291bnQoMCkKICAgICAsIG1faXNTaG93aW5nQ29udGV4dE1lbnUoZmFs c2UpCisgICAgLCBtX3dpbGxHb1RvQmFja0ZvcndhcmRJdGVtQ2FsbGJhY2tFbmFibGVkKHRydWUp CiAjaWYgUExBVEZPUk0oV0lOKQogICAgICwgbV9nZXN0dXJlUmVhY2hlZFNjcm9sbGluZ0xpbWl0 KGZhbHNlKQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuaAppbmRleCAwMjA0MzE0Li5hZjRjNmJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmgKQEAgLTUwMyw2ICs1MDMsOCBAQCBwdWJsaWM6CiAgICAgdm9p ZCBudW1XaGVlbEV2ZW50SGFuZGxlcnNDaGFuZ2VkKHVuc2lnbmVkKTsKICAgICB2b2lkIHJlY29t cHV0ZVNob3J0Q2lyY3VpdEhvcml6b250YWxXaGVlbEV2ZW50c1N0YXRlKCk7CiAKKyAgICBib29s IHdpbGxHb1RvQmFja0ZvcndhcmRJdGVtQ2FsbGJhY2tFbmFibGVkKCkgeyByZXR1cm4gbV93aWxs R29Ub0JhY2tGb3J3YXJkSXRlbUNhbGxiYWNrRW5hYmxlZDsgfQorICAgIAogcHJpdmF0ZToKICAg ICBXZWJQYWdlKHVpbnQ2NF90IHBhZ2VJRCwgY29uc3QgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVy cyYpOwogCkBAIC01NzEsNiArNTczLDggQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgZGlkUmVtb3Zl QmFja0ZvcndhcmRJdGVtKHVpbnQ2NF90KTsKIAorICAgIHZvaWQgc2V0V2lsbEdvVG9CYWNrRm9y d2FyZEl0ZW1DYWxsYmFja0VuYWJsZWQoYm9vbCBlbmFibGVkKSB7IG1fd2lsbEdvVG9CYWNrRm9y d2FyZEl0ZW1DYWxsYmFja0VuYWJsZWQgPSBlbmFibGVkOyB9CisgICAgCiAgICAgdm9pZCBzZXRE cmF3c0JhY2tncm91bmQoYm9vbCk7CiAgICAgdm9pZCBzZXREcmF3c1RyYW5zcGFyZW50QmFja2dy b3VuZChib29sKTsKIApAQCAtNzY1LDYgKzc2OSw4IEBAIHByaXZhdGU6CiAgICAgdW5zaWduZWQg bV9jYWNoZWRQYWdlQ291bnQ7CiAKICAgICBib29sIG1faXNTaG93aW5nQ29udGV4dE1lbnU7Cisg ICAgCisgICAgYm9vbCBtX3dpbGxHb1RvQmFja0ZvcndhcmRJdGVtQ2FsbGJhY2tFbmFibGVkOwog CiAjaWYgUExBVEZPUk0oV0lOKQogICAgIGJvb2wgbV9nZXN0dXJlUmVhY2hlZFNjcm9sbGluZ0xp bWl0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UubWVzc2FnZXMuaW4gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5tZXNzYWdlcy5pbgppbmRleCA3MjhiNmM0Li43ODEzYWRmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbgorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbgpAQCAtNzQs NiArNzQsNyBAQCBtZXNzYWdlcyAtPiBXZWJQYWdlIHsKICAgICBSZXN0b3JlU2Vzc2lvbkFuZE5h dmlnYXRlVG9DdXJyZW50SXRlbShXZWJLaXQ6OlNlc3Npb25TdGF0ZSBzdGF0ZSkKIAogICAgIERp ZFJlbW92ZUJhY2tGb3J3YXJkSXRlbSh1aW50NjRfdCBiYWNrRm9yd2FyZEl0ZW1JRCkKKyAgICBT ZXRXaWxsR29Ub0JhY2tGb3J3YXJkSXRlbUNhbGxiYWNrRW5hYmxlZChib29sIHdpbGxHb1RvQmFj a0ZvcndhcmRJdGVtRW5hYmxlZCkKIAogICAgIERpZFJlY2VpdmVQb2xpY3lEZWNpc2lvbih1aW50 NjRfdCBmcmFtZUlELCB1aW50NjRfdCBsaXN0ZW5lcklELCB1aW50MzJfdCBwb2xpY3lBY3Rpb24s IHVpbnQ2NF90IGRvd25sb2FkSUQpCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCA1YmU0OGJmLi42YTFiMzMzIDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDIt MjIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8xMDQwNjA0ND4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTI3OQorICAgICAgICBTeW5jaHJvbm91cyBTaG91bGRHb1RvQmFja0ZvcndhcmRMaXN0 SXRlbSBjYXVzZXMgbG90cyBvZiBXZWJQcm9jZXNzIGhhbmdzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIG91ciB0b29scyB0byB0aGUgbmV3 IGZvcm0gb2YgdGhlIFBhZ2VMb2FkQ2xpZW50LgorCisgICAgICAgICogTWluaUJyb3dzZXIvbWFj L0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyLm06CisgICAgICAgICgtW0Jyb3dzZXJXaW5kb3dDb250 cm9sbGVyIGF3YWtlRnJvbU5pYl0pOiAKKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVz dENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6aW5pdGlhbGl6 ZSk6CisKIDIwMTItMDItMjIgIEthbGV2IExlbWJlciAgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K IAogICAgICAgICBFeHBsaWNpdGx5IGluY2x1ZGUgdW5pc3RkLmggaW4gVGVzdE5ldHNjYXBlUGx1 Z0luIGZvciBHQ0MgNC43CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9tYWMvQnJvd3Nl cldpbmRvd0NvbnRyb2xsZXIubSBiL1Rvb2xzL01pbmlCcm93c2VyL21hYy9Ccm93c2VyV2luZG93 Q29udHJvbGxlci5tCmluZGV4IGI2YTMwZjEuLjVkYmQ1YTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01p bmlCcm93c2VyL21hYy9Ccm93c2VyV2luZG93Q29udHJvbGxlci5tCisrKyBiL1Rvb2xzL01pbmlC cm93c2VyL21hYy9Ccm93c2VyV2luZG93Q29udHJvbGxlci5tCkBAIC02MDYsOSArNjA2LDEwIEBA IC0gKHZvaWQpYXdha2VGcm9tTmliCiAgICAgICAgIHByb2Nlc3NEaWRFeGl0LAogICAgICAgICBk aWRDaGFuZ2VCYWNrRm9yd2FyZExpc3QsCiAgICAgICAgIDAsIC8vIHNob3VsZEdvVG9CYWNrRm9y d2FyZEl0ZW0KLSAgICAgICAgMCwgIC8vIGRpZEZhaWxUb0luaXRpYWxpemVQbHVnaW4KKyAgICAg ICAgMCwgLy8gZGlkRmFpbFRvSW5pdGlhbGl6ZVBsdWdpbgogICAgICAgICBkaWREZXRlY3RYU1NG b3JGcmFtZSwKICAgICAgICAgMCwgLy8gZGlkTmV3Rmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0 CisgICAgICAgIDAsIC8vIHdpbGxHb1RvQmFja0ZvcndhcmRMaXN0SXRlbQogICAgIH07CiAgICAg V0tQYWdlU2V0UGFnZUxvYWRlckNsaWVudChfd2ViVmlldy5wYWdlUmVmLCAmbG9hZENsaWVudCk7 CiAgICAgCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVy LmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IGRi NmU5MTQuLmZmZTNkMDggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENv bnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIu Y3BwCkBAIC0zOTcsNyArMzk3LDggQEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZShp bnQgYXJnYywgY29uc3QgY2hhciogYXJndltdKQogICAgICAgICAwLCAvLyBzaG91bGRHb1RvQmFj a0ZvcndhcmRMaXN0SXRlbQogICAgICAgICAwLCAvLyBkaWRSdW5JbnNlY3VyZUNvbnRlbnRGb3JG cmFtZQogICAgICAgICAwLCAvLyBkaWREZXRlY3RYU1NGb3JGcmFtZSAKLSAgICAgICAgMCAgLy8g ZGlkTmV3Rmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0IAorICAgICAgICAwLCAvLyBkaWROZXdG aXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQKKyAgICAgICAgMCwgLy8gd2lsbEdvVG9CYWNrRm9y d2FyZExpc3RJdGVtCiAgICAgfTsKICAgICBXS1BhZ2VTZXRQYWdlTG9hZGVyQ2xpZW50KG1fbWFp bldlYlZpZXctPnBhZ2UoKSwgJnBhZ2VMb2FkZXJDbGllbnQpOwogfQo=