79277 2012-02-22 14:02:12 -0800 new-run-webkit-tests shouldn't restore Safari state on Lion when showing results 2012-02-22 15:23:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED P2 Normal --- 1 dbates dbates abarth eric oldest_to_newest 562364 0 dbates 2012-02-22 14:02:12 -0800 I may have an instance of Safari running (either for reference or debugging) when I run new-run-webkit-tests. Currently new-run-webkit-tests launches Safari, with state restoration on OS 10.7, to show its results. It's annoying when Safari is launched with state restoration because it restores the last saved state of open windows and tabs. Safari also tends to become less responsive while it restores many windows and tabs and hence this restoration can slow down the interpretation of results. I propose that new-run-webkit-tests run the run-safari script passing the no-saved-state command line argument to disable state restoration for the session. 562366 1 128285 dbates 2012-02-22 14:06:25 -0800 Created attachment 128285 Patch 562443 2 128285 abarth 2012-02-22 15:19:00 -0800 Comment on attachment 128285 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128285&action=review Oh thank you! > Tools/ChangeLog:16 > +2012-02-22 Daniel Bates <dbates@webkit.org> Looks like you've got an extra changelog in here. 562449 3 dbates 2012-02-22 15:23:26 -0800 Committed r108560: <http://trac.webkit.org/changeset/108560> 128285 2012-02-22 14:06:25 -0800 2012-02-22 15:19:00 -0800 Patch bug-79277-20120222140624.patch text/plain 2921 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwODU0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI5IEBACisyMDEyLTAyLTIyICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4K KworICAgICAgICBuZXctcnVuLXdlYmtpdC10ZXN0cyBzaG91bGRuJ3QgcmVzdG9yZSBTYWZhcmkg c3RhdGUgb24gTGlvbiB3aGVuIHNob3dpbmcgcmVzdWx0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkyNzcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXNzIGNvbW1hbmQgbGluZSBhcmd1bWVudCBuby1z YXZlZC1zdGF0ZSB0byBydW4tc2FmYXJpIHRvIGRpc2FibGUgU2FmYXJpCisgICAgICAgIHN0YXRl IHJlc3RvcmF0aW9uIGZvciB0aGUgc2Vzc2lvbiBvbiBPUyAxMC43LgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHk6CisgICAgICAgIChNYWNQb3J0 LnNob3dfcmVzdWx0c19odG1sX2ZpbGUpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvbWFjX3VuaXR0ZXN0LnB5OgorICAgICAgICAodGVzdF9zaG93X3Jlc3Vs dHNfaHRtbF9maWxlKToKKworMjAxMi0wMi0yMiAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtp dC5vcmc+CisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChP T1BTISkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5OgorICAgICAgICAoTWFj UG9ydC5zaG93X3Jlc3VsdHNfaHRtbF9maWxlKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L21hY191bml0dGVzdC5weToKKyAgICAgICAgKHRlc3Rfc2hvd19y ZXN1bHRzX2h0bWxfZmlsZSk6CisKIDIwMTItMDItMjIgIEthbGV2IExlbWJlciAgPGthbGV2bGVt YmVyQGdtYWlsLmNvbT4KIAogICAgICAgICBFeHBsaWNpdGx5IGluY2x1ZGUgdW5pc3RkLmggaW4g VGVzdE5ldHNjYXBlUGx1Z0luIGZvciBHQ0MgNC43CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weQkocmV2aXNpb24gMTA4NDMzKQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkJKHdvcmtpbmcg Y29weSkKQEAgLTEyOCw3ICsxMjgsNyBAQCBjbGFzcyBNYWNQb3J0KEFwcGxlUG9ydCk6CiAgICAg ICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRoKCdXZWJDb3JlLmZyYW1ld29yay9WZXJzaW9ucy9B L1dlYkNvcmUnKQogCiAgICAgZGVmIHNob3dfcmVzdWx0c19odG1sX2ZpbGUoc2VsZiwgcmVzdWx0 c19maWxlbmFtZSk6Ci0gICAgICAgIHNlbGYuX3J1bl9zY3JpcHQoJ3J1bi1zYWZhcmknLCBbJy1O U09wZW4nLCByZXN1bHRzX2ZpbGVuYW1lXSkKKyAgICAgICAgc2VsZi5fcnVuX3NjcmlwdCgncnVu LXNhZmFyaScsIFsnLS1uby1zYXZlZC1zdGF0ZScsICctTlNPcGVuJywgcmVzdWx0c19maWxlbmFt ZV0pCiAKICAgICAjIEZJWE1FOiBUaGUgbmV4dCB0d28gcm91dGluZXMgdHVybiBvZmYgdGhlIGh0 dHAgbG9ja2luZyBpbiBvcmRlcgogICAgICMgdG8gd29yayBhcm91bmQgZmFpbHVyZXMgb24gdGhl IGJvdHMgY2F1c2VkIHdoZW4gdGhlIHNsYXZlIHJlc3RhcnRzLgpJbmRleDogVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3Qu cHkJKHJldmlzaW9uIDEwODQzMykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvbWFjX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNjEsNyArMTYxLDcg QEAgamF2YS8KICAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KCkKICAgICAgICAgIyBEZWxh eSBzZXR0aW5nIGEgc2hvdWxkX2xvZyBleGVjdXRpdmUgdG8gYXZvaWQgbG9nZ2luZyBmcm9tIE1h Y1BvcnQuX19pbml0X18uCiAgICAgICAgIHBvcnQuX2V4ZWN1dGl2ZSA9IE1vY2tFeGVjdXRpdmUo c2hvdWxkX2xvZz1UcnVlKQotICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSyBydW5fY29t bWFuZDogWydUb29scy9TY3JpcHRzL3J1bi1zYWZhcmknLCAnLS1yZWxlYXNlJywgJy1OU09wZW4n LCAndGVzdC5odG1sJ10sIGN3ZD0vbW9jay1jaGVja291dFxuIgorICAgICAgICBleHBlY3RlZF9z dGRlcnIgPSAiTU9DSyBydW5fY29tbWFuZDogWydUb29scy9TY3JpcHRzL3J1bi1zYWZhcmknLCAn LS1yZWxlYXNlJywgJy0tbm8tc2F2ZWQtc3RhdGUnLCAnLU5TT3BlbicsICd0ZXN0Lmh0bWwnXSwg Y3dkPS9tb2NrLWNoZWNrb3V0XG4iCiAgICAgICAgIE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0 cHV0cyhzZWxmLCBwb3J0LnNob3dfcmVzdWx0c19odG1sX2ZpbGUsIFsidGVzdC5odG1sIl0sIGV4 cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCiAKICAgICBkZWYgdGVzdF9vcGVyYXRpbmdf c3lzdGVtKHNlbGYpOgo=