79268 2012-02-22 12:33:17 -0800 JSString::outOfMemory() should ASSERT(isRope()) rather than !isRope() 2012-02-23 11:28:59 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P3 Normal --- 1 yong.li.webkit webkit-unassigned barraclough haraken msaboff webkit.review.bot oldest_to_newest 562256 0 yong.li.webkit 2012-02-22 12:33:17 -0800 It seems JSString::outOfMemory() should ASSERT(isRope()) instead of ASSERT(!isRope()) 562292 1 128271 yong.li.webkit 2012-02-22 13:02:30 -0800 Created attachment 128271 the patch 562764 2 128271 haraken 2012-02-22 20:33:50 -0800 Comment on attachment 128271 the patch The change makes sense. 563085 3 yong.li.webkit 2012-02-23 06:48:39 -0800 (In reply to comment #2) > (From update of attachment 128271 [details]) > The change makes sense. Thanks for reviewing! 563088 4 haraken 2012-02-23 06:52:19 -0800 Please note that at present the WebKit svn server is down and something wrong is happening around the commit queue. If the commit fails, let us commit it again after the server recovers. 563106 5 128271 webkit.review.bot 2012-02-23 07:42:47 -0800 Comment on attachment 128271 the patch Rejecting attachment 128271 from review queue. haraken@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 563295 6 128271 webkit.review.bot 2012-02-23 11:28:54 -0800 Comment on attachment 128271 the patch Clearing flags on attachment: 128271 Committed r108649: <http://trac.webkit.org/changeset/108649> 563296 7 webkit.review.bot 2012-02-23 11:28:59 -0800 All reviewed patches have been landed. Closing bug. 128271 2012-02-22 13:02:30 -0800 2012-02-23 11:28:54 -0800 the patch 79268.patch text/plain 1349 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ4MzA2MTMuLjlkZjk0MmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTIyICBZb25nIExpICA8eW9s aUByaW0uY29tPgorCisgICAgICAgIEpTU3RyaW5nOjpvdXRPZk1lbW9yeSgpIHNob3VsZCBBU1NF UlQoaXNSb3BlKCkpIHJhdGhlciB0aGFuICFpc1JvcGUoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkyNjgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICByZXNvbHZlUm9wZSgpIGlzIHRoZSBvbmx5IGNhbGxl ciBvZiBvdXRPZk1lbW9yeSgpLCBhbmQgaXQgY2FsbHMgb3V0T2ZNZW1vcnkoKQorICAgICAgICBh ZnRlciBpdCBmYWlscyB0byBhbGxvY2F0ZSBhIGJ1ZmZlciBmb3IgbV92YWx1ZS4gU28gb3V0T2ZN ZW1vcnkoKSBzaG91bGQgYXNzZXJ0CisgICAgICAgIGlzUm9wZSgpIHJhdGhlciB0aGFuICFpc1Jv cGUoKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNTdHJpbmcuY3BwOgorICAgICAgICAoSlNDOjpK U1N0cmluZzo6b3V0T2ZNZW1vcnkpOgorCiAyMDEyLTAyLTIyICBTaGVyaWZmIEJvdCAgPHdlYmtp dC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMTA4NDU2LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNT dHJpbmcuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuY3BwCmlu ZGV4IDNmYTI5MDEuLmNmYTdkMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTU3RyaW5nLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U1N0cmluZy5jcHAKQEAgLTE4OSw3ICsxODksNyBAQCB2b2lkIEpTU3RyaW5nOjpvdXRPZk1lbW9y eShFeGVjU3RhdGUqIGV4ZWMpIGNvbnN0CiB7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBz X21heEludGVybmFsUm9wZUxlbmd0aCAmJiBtX2ZpYmVyc1tpXTsgKytpKQogICAgICAgICBtX2Zp YmVyc1tpXS5jbGVhcigpOwotICAgIEFTU0VSVCghaXNSb3BlKCkpOworICAgIEFTU0VSVChpc1Jv cGUoKSk7CiAgICAgQVNTRVJUKG1fdmFsdWUgPT0gVVN0cmluZygpKTsKICAgICBpZiAoZXhlYykK ICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMpOwo=