79261 2012-02-22 11:06:53 -0800 [BlackBerry] InputHandler has signed vs unsigned comparison. 2012-02-22 12:15:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mifenton webkit-unassigned webkit.review.bot oldest_to_newest 562162 0 mifenton 2012-02-22 11:06:53 -0800 InputHandler::rectForCaret generates a warning for a comparison between signed and unsigned ints. 562166 1 128250 mifenton 2012-02-22 11:13:15 -0800 Created attachment 128250 Patch 562176 2 128250 rwlbuis 2012-02-22 11:18:45 -0800 Comment on attachment 128250 Patch LGTM. 562232 3 128250 webkit.review.bot 2012-02-22 12:15:22 -0800 Comment on attachment 128250 Patch Clearing flags on attachment: 128250 Committed r108535: <http://trac.webkit.org/changeset/108535> 562233 4 webkit.review.bot 2012-02-22 12:15:26 -0800 All reviewed patches have been landed. Closing bug. 128250 2012-02-22 11:13:15 -0800 2012-02-22 12:15:22 -0800 Patch 0001-2012-02-22-Mike-Fenton-mifenton-rim.com.patch text/plain 1973 mifenton RnJvbSBkZmU4MzIwMzQ4NzNmNTE3OTkwNWM5NTc2MTIyNDk5NDlmM2QwMTlhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog V2VkLCAyMiBGZWIgMjAxMiAxNDoxMDo1NiAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDIt MjIgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgRml4IHdhcm5pbmcg YnkgY2FzdGluZyB0aGUgdW5zaWduZWQgaW50IHRvIGFuIGludC4KCiAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIu Y3BwOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6cmVjdEZvckNh cmV0KToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4vYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lu cHV0SGFuZGxlci5jcHAgICAgICB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRl eCBmNDVjMjAzLi5jMjRkODA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMi0wMi0yMiAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgor CisgICAgICAgIFtCbGFja0JlcnJ5XSBJbnB1dEhhbmRsZXIgaGFzIHNpZ25lZCB2cyB1bnNpZ25l ZCBjb21wYXJpc29uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzkyNjEKKworICAgICAgICBGaXggd2FybmluZyBieSBjYXN0aW5nIHRoZSB1bnNpZ25l ZCBpbnQgdG8gYW4gaW50LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OnJlY3RGb3JDYXJldCk6CisKIDIwMTItMDIt MjIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHRo ZSByZW1haW5pbmcgdXNlcyBvZiBDU1NTdHlsZURlY2xhcmF0aW9uIGluIEVkaXRvcgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVy LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxl ci5jcHAKaW5kZXggN2M5NmFiMC4uOGNhYTQ1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCkBAIC05MDcsNyAr OTA3LDcgQEAgV2ViQ29yZTo6SW50UmVjdCBJbnB1dEhhbmRsZXI6OnJlY3RGb3JDYXJldChpbnQg aW5kZXgpCiAKICAgICBBU1NFUlQobV9jdXJyZW50Rm9jdXNFbGVtZW50LT5kb2N1bWVudCgpICYm IG1fY3VycmVudEZvY3VzRWxlbWVudC0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSk7CiAKLSAgICBpZiAo aW5kZXggPCAwIHx8IGluZGV4ID4gZWxlbWVudFRleHQoKS5sZW5ndGgoKSkgeworICAgIGlmIChp bmRleCA8IDAgfHwgaW5kZXggPiBzdGF0aWNfY2FzdDxpbnQ+KGVsZW1lbnRUZXh0KCkubGVuZ3Ro KCkpKSB7CiAgICAgICAgIC8vIEludmFsaWQgcmVxdWVzdC4KICAgICAgICAgcmV0dXJuIFdlYkNv cmU6OkludFJlY3QoKTsKICAgICB9Ci0tIAoxLjcuNS40Cgo=