79249 2012-02-22 09:19:38 -0800 With tiled drawing enabled, pressing Down arrow after scrolling via mouse gesture causes page to jump back up to top 2012-02-29 11:21:56 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 aroben andersca adamk andersca webkit-bug-importer oldest_to_newest 562033 0 aroben 2012-02-22 09:19:38 -0800 To reproduce: 0. Enable tiled drawing 1. Go to http://www.webkit.org/blog/ 2. Scroll down a bit using a 1-finger swipe on a Magic Mouse (I haven't tested other mice) 3. Press the Down arrow The page jumps back up to the top, then scrolls down one "arrow's worth". It's as if there are two different scroll offsets being tracked: one for gesture scrolls, and one for keyboard scrolls. 562034 1 webkit-bug-importer 2012-02-22 09:19:56 -0800 <rdar://problem/10910908> 562112 2 aroben 2012-02-22 10:25:31 -0800 <rdar://problem/10866273> 567308 3 129371 andersca 2012-02-28 18:29:09 -0800 Created attachment 129371 Patch 567310 4 129371 sam 2012-02-28 18:34:02 -0800 Comment on attachment 129371 Patch I think the ScrollableArea should be the one with a concept of the scroll position and the animator simply queries it. That can be a clean up though. 567312 5 andersca 2012-02-28 18:36:20 -0800 Committed r109183: <http://trac.webkit.org/changeset/109183> 567728 6 adamk 2012-02-29 10:49:24 -0800 This seems to have broken a bunch of Chromium scrolling tests: https://bugs.webkit.org/show_bug.cgi?id=79878. There are links to the failures from there, but the short story is that the Chromium tests aren't seeing any rubberbanding. Does it seem reasonable that this change would cause such regressions? 567768 7 andersca 2012-02-29 11:21:56 -0800 (In reply to comment #6) > This seems to have broken a bunch of Chromium scrolling tests: https://bugs.webkit.org/show_bug.cgi?id=79878. There are links to the failures from there, but the short story is that the Chromium tests aren't seeing any rubberbanding. Does it seem reasonable that this change would cause such regressions? Weird - I'll take a look right away. 129371 2012-02-28 18:29:09 -0800 2012-02-28 18:34:02 -0800 Patch bug-79249-20120228182928.patch text/plain 2834 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGIxMmRkZmEzZmZmZTlk ZjJhYWZlZTA1MjAxYTllMWYyNTFmMWEyNS4uMWIxMDg3NDgxODc2OGYxYjFiMTYyMmVlZTEzMDBk M2U2YjdiZmJhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTI4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgV2l0aCB0aWxlZCBk cmF3aW5nIGVuYWJsZWQsIHByZXNzaW5nIERvd24gYXJyb3cgYWZ0ZXIgc2Nyb2xsaW5nIHZpYSBt b3VzZSBnZXN0dXJlIGNhdXNlcyBwYWdlIHRvIGp1bXAgYmFjayB1cCB0byB0b3AKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MjQ5CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xMDg2NjI3Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTY3JvbGxhYmxlQXJlYTo6bm90aWZ5U2Nyb2xsUG9zaXRpb25DaGFu Z2VkIG11c3QgbWFrZSBzdXJlIHRoYXQgdGhlIHNjcm9sbCBhbmltYXRvciBwb3NpdGlvbiBpcyBr ZXB0IHVwIHRvIGRhdGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmltYXRvci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvcjo6c2V0Q3VycmVudFBvc2l0aW9uKToK KyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbEFuaW1hdG9yLmg6 CisgICAgICAgIChTY3JvbGxBbmltYXRvcik6CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsYWJs ZUFyZWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYWJsZUFyZWE6Om5vdGlmeVNjcm9s bFBvc2l0aW9uQ2hhbmdlZCk6CisKIDIwMTItMDItMjggIE5lZCBIb2xicm9vayAgPG5ob2xicm9v a0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVpbXBsZW1lbnQgcGF0aEZyb21Gb250KCkgaW4gU2lt cGxlRm9udERhdGFNYWMubW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Nj cm9sbEFuaW1hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9y LmNwcAppbmRleCBkNGRlZDM0ODM5N2JhOTIyZGVmYTFlODVlMzQyY2QwZGNmY2E0MGIwLi4yMzAw MGMzZTRmODdlZDYwZWJkNDY1ZjEwY2Y4YzkzMjFkZGM3YmMwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3IuY3BwCkBAIC0xMjIsNiArMTIyLDEyIEBAIGJvb2wgU2Ny b2xsQW5pbWF0b3I6OmhhbmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiBl KQogICAgIHJldHVybiBoYW5kbGVkOwogfQogCit2b2lkIFNjcm9sbEFuaW1hdG9yOjpzZXRDdXJy ZW50UG9zaXRpb24oY29uc3QgRmxvYXRQb2ludCYgcG9zaXRpb24pCit7CisgICAgbV9jdXJyZW50 UG9zWCA9IHBvc2l0aW9uLngoKTsKKyAgICBtX2N1cnJlbnRQb3NZID0gcG9zaXRpb24ueSgpOwor fQorCiBGbG9hdFBvaW50IFNjcm9sbEFuaW1hdG9yOjpjdXJyZW50UG9zaXRpb24oKSBjb25zdAog ewogICAgIHJldHVybiBGbG9hdFBvaW50KG1fY3VycmVudFBvc1gsIG1fY3VycmVudFBvc1kpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3IuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yLmgKaW5kZXggODE0ZDY3NGUzNmFi NmE4ZDZlMGQ4NzViZjg3ZDQ5OTQ1OGI0NmY4OS4uMmIzODk0NDAzZTUxOGVjOGVlYWI0MzJkYzQ0 ZGU5OWYyOGU2NDYwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xs QW5pbWF0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvci5o CkBAIC02NSw2ICs2NSw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgYm9vbCBoYW5kbGVXaGVl bEV2ZW50KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYpOwogCisgICAgdm9pZCBzZXRDdXJyZW50 UG9zaXRpb24oY29uc3QgRmxvYXRQb2ludCYpOwogICAgIEZsb2F0UG9pbnQgY3VycmVudFBvc2l0 aW9uKCkgY29uc3Q7CiAKICAgICB2aXJ0dWFsIHZvaWQgY2FuY2VsQW5pbWF0aW9ucygpIHsgfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuY3BwCmluZGV4IDU4YWQyNDIw NTlmMjczMGJhYTNlZTliMTMzZGQ1ZDUzYzljYTdhYWUuLmJiZDY2ZTgzN2Q4YWY4NjcyYTAxYWQ4 OTE0MjljMjMyZWFiMmYxZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Nj cm9sbGFibGVBcmVhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxl QXJlYS5jcHAKQEAgLTE1MCw2ICsxNTAsNyBAQCB2b2lkIFNjcm9sbGFibGVBcmVhOjpub3RpZnlT Y3JvbGxQb3NpdGlvbkNoYW5nZWQoY29uc3QgSW50UG9pbnQmIHBvc2l0aW9uKQogICAgICAgICAg ICAgdmVydGljYWxTY3JvbGxiYXItPmludmFsaWRhdGUoKTsKICAgICB9CiAKKyAgICBzY3JvbGxB bmltYXRvcigpLT5zZXRDdXJyZW50UG9zaXRpb24ocG9zaXRpb24pOwogICAgIHNjcm9sbEFuaW1h dG9yKCktPm5vdGlmeUNvbnRlbnRBcmVhU2Nyb2xsZWQoKTsKIH0KIAo=