79239 2012-02-22 07:28:28 -0800 [Chromium] video-referer.html fails 2012-02-24 02:40:25 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson webkit-unassigned ap dalecurtis fischman jamesr scherkus vrk webkit.review.bot oldest_to_newest 561972 0 eric.carlson 2012-02-22 07:28:28 -0800 http/tests/media/video-referer.html started to fail after it was updated in r108387. The previous test succeeded if the media engine sent any referrer, now it checks for a specific referrer. 561983 1 eric.carlson 2012-02-22 07:44:44 -0800 Test skipped in r108503. 562639 2 128351 dalecurtis 2012-02-22 17:49:40 -0800 Created attachment 128351 Patch 562641 3 128352 dalecurtis 2012-02-22 17:52:51 -0800 Created attachment 128352 Patch 562657 4 128352 ap 2012-02-22 18:07:53 -0800 Comment on attachment 128352 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128352&action=review > LayoutTests/ChangeLog:6 > + Fix races in video-referer test. Can you comment on what the races are? 562662 5 128352 dalecurtis 2012-02-22 18:16:19 -0800 Comment on attachment 128352 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128352&action=review >> LayoutTests/ChangeLog:6 >> + Fix races in video-referer test. > > Can you comment on what the races are? As far as I can tell, the event listeners are added too soon since they aren't protected by onload(). Which results in something going awry with their setup. I haven't dug too deep on the why, this is just a common problem I've run into with other layout tests. 562712 6 128352 ap 2012-02-22 19:31:22 -0800 Comment on attachment 128352 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128352&action=review I don't think that there should be any events dispatched before src attribute is set. This sounds more like an actual bug in chromium <video> implementation than a problem with the test. > LayoutTests/http/tests/media/video-referer.html:12 > + findMediaElement(); This should not be necessary, because video-test.js calls findMediaElement(), and the element is not inserted dynamically. 563102 7 eric.carlson 2012-02-23 07:31:20 -0800 The failure reported, "CONSOLE MESSAGE: line 30: Uncaught TypeError: Cannot read property 'code' of null", suggests that the 'error' event is not coming from the video element. Have you checked to see what is generating the error and why? 563416 8 128545 dalecurtis 2012-02-23 13:33:12 -0800 Created attachment 128545 Patch 563418 9 128352 dalecurtis 2012-02-23 13:35:12 -0800 Comment on attachment 128352 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128352&action=review >> LayoutTests/http/tests/media/video-referer.html:12 >> + findMediaElement(); > > This should not be necessary, because video-test.js calls findMediaElement(), and the element is not inserted dynamically. Correct, I added it while experimenting and left it in since most other tests call it explicitly. I've removed it in the latest patch set. 563419 10 dalecurtis 2012-02-23 13:37:02 -0800 @Eric, the call is coming from the source element and it's a generic error event without any further details, this lead me to suspect the events weren't attaching to the video tag properly. Which is why I've moved these calls into the onload() handler. 563443 11 ap 2012-02-23 13:57:11 -0800 I still suspect that this is a legitimate chromium bug, not a test issue. 563447 12 jamesr 2012-02-23 13:58:50 -0800 Dale - can you reproduce the failure locally? If so, have you tried logging when the load event fires on failing runs vs passing runs? That should tell you if that's the problem. 563465 13 dalecurtis 2012-02-23 14:10:05 -0800 Yes, I've repro'd the failure locally, w/o my patch the test fails 90% of the time, with my patch I haven't had a failure yet. @Alexey, can you explain why you think this is a Chromium issue and not a simple setup race? Is it not good practice to wait for onload() before starting any JavaScript? 563493 14 eric.carlson 2012-02-23 14:33:37 -0800 (In reply to comment #13) > Yes, I've repro'd the failure locally, w/o my patch the test fails 90% of the time, with my patch I haven't had a failure yet. > This happens because the <source> element has no 'src' attribute, and step 2 of the section on using the source element says (http://dev.w3.org/html5/spec/media-elements.html#loading-the-media-resource): Process candidate: If candidate does not have a src attribute, or if its src attribute's value is the empty string, then end the synchronous section, and jump down to the failed step below. and the "failed" step says: Failed: Queue a task to fire a simple event named error at the candidate element > Is it not good practice to wait for onload() before starting any JavaScript? Sometimes yes, and sometimes no - I am not sure there is a general "good practice" here. 563495 15 128545 eric.carlson 2012-02-23 14:36:17 -0800 Comment on attachment 128545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128545&action=review These changes do fix a problem with the test, but neither your ChangeLog nor your explanations in this bug fully explain why. It is much easier to review a proposed fix when a full explanation is presented. > LayoutTests/ChangeLog:6 > + Fix event setup race by moving setup into body onload() handler. Please say something more specific. 563515 16 128545 fischman 2012-02-23 14:52:22 -0800 Comment on attachment 128545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128545&action=review > LayoutTests/http/tests/media/video-referer.html:18 > frame.addEventListener('load', function () { Shouldn't this listener be added before frame.src is set in the previous line? > LayoutTests/http/tests/media/video-referer.html:25 > + waitForEventAndEnd('error', function () { Shouldn't the listeners be getting added right before the video.load() call above, if no errors are expected? > LayoutTests/http/tests/media/video-referer.html:26 > + consoleWrite('FAIL, got error when loading media.'); IWBN to use waitForEventAndFail() instead of wFEAEnd() for 'error'. (both this suggestion and the next will require you to edit the expected file). > LayoutTests/http/tests/media/video-referer.html:29 > + waitForEvent('canplay', function () { This would benefit from using waitForEventAndEnd. 563527 17 ap 2012-02-23 15:06:38 -0800 > @Alexey, can you explain why you think this is a Chromium issue and not a simple setup race? Is it not good practice to wait for onload() before starting any JavaScript? So Eric explained above why it's correct to have an error event fired early in this specific case, so there is a race indeed. Thanks! 563720 18 128612 dalecurtis 2012-02-23 17:17:58 -0800 Created attachment 128612 Patch 563721 19 128545 dalecurtis 2012-02-23 17:18:11 -0800 Comment on attachment 128545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128545&action=review >> LayoutTests/ChangeLog:6 >> + Fix event setup race by moving setup into body onload() handler. > > Please say something more specific. Done. >> LayoutTests/http/tests/media/video-referer.html:18 >> frame.addEventListener('load', function () { > > Shouldn't this listener be added before frame.src is set in the previous line? Done. >> LayoutTests/http/tests/media/video-referer.html:25 >> + waitForEventAndEnd('error', function () { > > Shouldn't the listeners be getting added right before the video.load() call above, if no errors are expected? Done. >> LayoutTests/http/tests/media/video-referer.html:26 >> + consoleWrite('FAIL, got error when loading media.'); > > IWBN to use waitForEventAndFail() instead of wFEAEnd() for 'error'. > (both this suggestion and the next will require you to edit the expected file). Done. >> LayoutTests/http/tests/media/video-referer.html:29 >> + waitForEvent('canplay', function () { > > This would benefit from using waitForEventAndEnd. Done. 563749 20 128619 dalecurtis 2012-02-23 17:36:29 -0800 Created attachment 128619 Patch 563884 21 128619 eric.carlson 2012-02-23 20:39:54 -0800 Comment on attachment 128619 Patch Thanks! 564139 22 128619 webkit.review.bot 2012-02-24 02:40:19 -0800 Comment on attachment 128619 Patch Clearing flags on attachment: 128619 Committed r108762: <http://trac.webkit.org/changeset/108762> 564140 23 webkit.review.bot 2012-02-24 02:40:25 -0800 All reviewed patches have been landed. Closing bug. 128351 2012-02-22 17:49:40 -0800 2012-02-22 17:52:45 -0800 Patch bug-79239-20120222174939.patch text/plain 3562 dalecurtis U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NTc1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDRjYzBjMTI0NDRjM2MwYzkyMmVi MjI4NmJiYmEyMDI5MDliZTIwZS4uYzYwYmJlMmU3NDhjNDk3N2NjODlkZGUxNTkzNWMzNTdjYTI4 YTkxMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTIyICBEYWxlIEN1cnRpcyAgPGRh bGVjdXJ0aXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gdmlkZW8tcmVmZXJl ci5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTIzOQorCisgICAgICAgIEZpeCByYWNlcyBpbiB2aWRlby1yZWZlcmVyIHRlc3QuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rl c3RzL21lZGlhL3ZpZGVvLXJlZmVyZXIuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1 bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTItMDItMjIgIEFkcmllbm5lIFdhbGtlciAg PGVubmVAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIFVucmV2aWV3ZWQgZ2FyZGVu aW5nLiBHZW5lcmFsaXplIHN2ZyBmYWlsdXJlcyBmcm9tIHIxMDg0OTQuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVyZXIuaHRtbCBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1sCmluZGV4IDY5ZmVkYjI4ZDcx MDQxYjhkMzg3ZDZjZTAxMGU4OTI5N2VhNjhjZjguLmFkNzIwNDBjYzkyY2M1MTVkMmE5NDI1ZTBm NjBiMjBmYTYxMjE1OTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEv dmlkZW8tcmVmZXJlci5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlk ZW8tcmVmZXJlci5odG1sCkBAIC05LDYgKzksNyBAQAogPHNjcmlwdCBzcmM9Li4vLi4vbWVkaWEt cmVzb3VyY2VzL21lZGlhLWZpbGUuanM+PC9zY3JpcHQ+CiA8c2NyaXB0PgogICAgIGZ1bmN0aW9u IGxvYWRDb29raWVBbmRSZWZlcmVyICgpIHsKKyAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOwog ICAgICAgICB2YXIgbW92aWUgPSBmaW5kTWVkaWFGaWxlKCd2aWRlbycsICd0ZXN0Jyk7CiAgICAg ICAgIHZhciB0eXBlID0gbWltZVR5cGVGb3JFeHRlbnNpb24obW92aWUuc3BsaXQoJy4nKS5wb3Ao KSk7CiAgICAgICAgIHZhciBmcmFtZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lmcmFtZScp OwpAQCAtMTYsMjQgKzE3LDI0IEBACiAgICAgICAgIGZyYW1lLmhlaWdodCA9IDA7CiAgICAgICAg IGZyYW1lLnNyYyA9ICJkYXRhOnRleHQvaHRtbCw8Yj50ZXN0PC9iPiI7CiAgICAgICAgIGZyYW1l LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBmdW5jdGlvbiAoKSB7Ci0gICAgICAgICAgICAgICAg dmlkZW8gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndmlkZW8nKTsKICAgICAgICAgICAgICAg ICBzb3VyY2UgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnc291cmNlJyk7CiAgICAgICAgICAg ICAgICAgc291cmNlLnNyYyA9ICdodHRwOi8vMTI3LjAuMC4xOjgwMDAvbWVkaWEvcmVzb3VyY2Vz L3ZpZGVvLXJlZmVyZXItY2hlY2stcmVmZXJlci5waHA/bmFtZT0nICsgbW92aWUgKyAnJnR5cGU9 JyArIHR5cGU7CiAgICAgICAgICAgICAgICAgc291cmNlLnR5cGUgPSB0eXBlOwogICAgICAgICAg ICAgICAgIHZpZGVvLmxvYWQoKTsKICAgICAgICAgfSk7CiAKKyAgICAgICAgd2FpdEZvckV2ZW50 QW5kRW5kKCdlcnJvcicsIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgn RkFJTCwgZ290IGVycm9yIHdoZW4gbG9hZGluZyBtZWRpYSBlcnJvci4nKTsKKyAgICAgICAgfSk7 CisKKyAgICAgICAgd2FpdEZvckV2ZW50KCdjYW5wbGF5JywgZnVuY3Rpb24gKCkgeworICAgICAg ICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICB3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9KTsKKwor ICAgICAgICB3YWl0Rm9yRXZlbnRBbmRFbmQoJ2NhbnBsYXknKTsKICAgICAgICAgZG9jdW1lbnQu Ym9keS5hcHBlbmRDaGlsZChmcmFtZSk7CiAgICAgfQotICAgIAotICAgIHdhaXRGb3JFdmVudEFu ZEVuZCgnZXJyb3InLCBmdW5jdGlvbiAoKSB7Ci0gICAgICAgIGNvbnNvbGVXcml0ZSgnRkFJTCwg Z290IGVycm9yIHdoZW4gbG9hZGluZyBtZWRpYSBlcnJvcjogJyArIHZpZGVvLmVycm9yLmNvZGUp OwotICAgIH0pOyAgICAKLQotICAgIHdhaXRGb3JFdmVudCgnY2FucGxheScsIGZ1bmN0aW9uICgp IHsKLSAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICAgICAgICAg IHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Ci0gICAgfSApOwogPC9z Y3JpcHQ+CiBUZXN0cyB0aGF0IHRoZSBtZWRpYSBwbGF5ZXIgd2lsbCBzZW5kIHRoZSByZWxldmFu dCByZWZlcmVyIHdoZW4gcmVxdWVzdGluZyB0aGUgbWVkaWEgZmlsZS48YnIvPgogPC9ib2R5Pgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlv bnMudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMu dHh0CmluZGV4IDgyNzViY2VjMjE1MGViYWRmZDgxYTM1OGNmNjI4NmZlODlkMzgzMjcuLjI5Mzc2 NDdiOGVjNWViNTc5Y2FiYWQ4ZGIwZTFjY2NhYzhmNmY1ZGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKQEAgLTQyMTksOSAr NDIxOSw2IEBAIEJVR0NSMTE1MDczIFNMT1cgTElOVVggREVCVUcgOiBpbnNwZWN0b3IvZGVidWdn ZXIvc2NyaXB0LWZvcm1hdHRlci1icmVha3BvaW50cy5oCiAKIEJVR1dLNzkyMjQgVklTVEEgV0lO NyA6IGZhc3QvY2FudmFzL3dlYmdsL3RleC1pbWFnZS13aXRoLWZvcm1hdC1hbmQtdHlwZS5odG1s ID0gVEVYVAogCi0vLyBGYWlsaW5nIGFmdGVyIHRlc3Qgd2FzIHVwZGF0ZWQgaW4gcjEwODM4Nywg bWVkaWEgZW5naW5lIHNlbmRpbmcgaW5jb3JyZWN0IHJlZmVycmVyPwotQlVHV0s3OTIzOSA6IGh0 dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1sID0gRkFJTAotCiAvLyBBc3NlcnRpbmcg aW4gZGVidWcgYnVpbGRzIHNpbmNlIHIxMDg1MDYKIEJVR1dLNzkyMjkgREVCVUcgOiBodHRwL3Rl c3RzL2luc3BlY3Rvci9jb25zb2xlLXhoci1sb2dnaW5nLWFzeW5jLmh0bWwgPSBDUkFTSAogQlVH V0s3OTIyOSBERUJVRyA6IGh0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsvbmV0d29yay1kaXNh YmxlLWNhY2hlLXhocnMuaHRtbCA9IENSQVNICg== 128352 2012-02-22 17:52:51 -0800 2012-02-23 13:35:12 -0800 Patch bug-79239-20120222175250.patch text/plain 3520 dalecurtis U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NTc1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDRjYzBjMTI0NDRjM2MwYzkyMmVi MjI4NmJiYmEyMDI5MDliZTIwZS4uYzYwYmJlMmU3NDhjNDk3N2NjODlkZGUxNTkzNWMzNTdjYTI4 YTkxMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTIyICBEYWxlIEN1cnRpcyAgPGRh bGVjdXJ0aXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gdmlkZW8tcmVmZXJl ci5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTIzOQorCisgICAgICAgIEZpeCByYWNlcyBpbiB2aWRlby1yZWZlcmVyIHRlc3QuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rl c3RzL21lZGlhL3ZpZGVvLXJlZmVyZXIuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1 bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTItMDItMjIgIEFkcmllbm5lIFdhbGtlciAg PGVubmVAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIFVucmV2aWV3ZWQgZ2FyZGVu aW5nLiBHZW5lcmFsaXplIHN2ZyBmYWlsdXJlcyBmcm9tIHIxMDg0OTQuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVyZXIuaHRtbCBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1sCmluZGV4IDY5ZmVkYjI4ZDcx MDQxYjhkMzg3ZDZjZTAxMGU4OTI5N2VhNjhjZjguLmRmNGY4MDg4MDE2NDE3NGU3NTdmN2ZiODM0 NjQ3NDEwOTViYWZkY2UgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEv dmlkZW8tcmVmZXJlci5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlk ZW8tcmVmZXJlci5odG1sCkBAIC05LDYgKzksNyBAQAogPHNjcmlwdCBzcmM9Li4vLi4vbWVkaWEt cmVzb3VyY2VzL21lZGlhLWZpbGUuanM+PC9zY3JpcHQ+CiA8c2NyaXB0PgogICAgIGZ1bmN0aW9u IGxvYWRDb29raWVBbmRSZWZlcmVyICgpIHsKKyAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOwog ICAgICAgICB2YXIgbW92aWUgPSBmaW5kTWVkaWFGaWxlKCd2aWRlbycsICd0ZXN0Jyk7CiAgICAg ICAgIHZhciB0eXBlID0gbWltZVR5cGVGb3JFeHRlbnNpb24obW92aWUuc3BsaXQoJy4nKS5wb3Ao KSk7CiAgICAgICAgIHZhciBmcmFtZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lmcmFtZScp OwpAQCAtMTYsMjQgKzE3LDIyIEBACiAgICAgICAgIGZyYW1lLmhlaWdodCA9IDA7CiAgICAgICAg IGZyYW1lLnNyYyA9ICJkYXRhOnRleHQvaHRtbCw8Yj50ZXN0PC9iPiI7CiAgICAgICAgIGZyYW1l LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBmdW5jdGlvbiAoKSB7Ci0gICAgICAgICAgICAgICAg dmlkZW8gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndmlkZW8nKTsKICAgICAgICAgICAgICAg ICBzb3VyY2UgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnc291cmNlJyk7CiAgICAgICAgICAg ICAgICAgc291cmNlLnNyYyA9ICdodHRwOi8vMTI3LjAuMC4xOjgwMDAvbWVkaWEvcmVzb3VyY2Vz L3ZpZGVvLXJlZmVyZXItY2hlY2stcmVmZXJlci5waHA/bmFtZT0nICsgbW92aWUgKyAnJnR5cGU9 JyArIHR5cGU7CiAgICAgICAgICAgICAgICAgc291cmNlLnR5cGUgPSB0eXBlOwogICAgICAgICAg ICAgICAgIHZpZGVvLmxvYWQoKTsKICAgICAgICAgfSk7CiAKKyAgICAgICAgd2FpdEZvckV2ZW50 QW5kRW5kKCdlcnJvcicsIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgn RkFJTCwgZ290IGVycm9yIHdoZW4gbG9hZGluZyBtZWRpYSBlcnJvci4nKTsKKyAgICAgICAgfSk7 CisKKyAgICAgICAgd2FpdEZvckV2ZW50KCdjYW5wbGF5JywgZnVuY3Rpb24gKCkgeworICAgICAg ICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICB3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9KTsKICAg ICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChmcmFtZSk7CiAgICAgfQotICAgIAotICAg IHdhaXRGb3JFdmVudEFuZEVuZCgnZXJyb3InLCBmdW5jdGlvbiAoKSB7Ci0gICAgICAgIGNvbnNv bGVXcml0ZSgnRkFJTCwgZ290IGVycm9yIHdoZW4gbG9hZGluZyBtZWRpYSBlcnJvcjogJyArIHZp ZGVvLmVycm9yLmNvZGUpOwotICAgIH0pOyAgICAKLQotICAgIHdhaXRGb3JFdmVudCgnY2FucGxh eScsIGZ1bmN0aW9uICgpIHsKLSAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKLSAgICAgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7 Ci0gICAgfSApOwogPC9zY3JpcHQ+CiBUZXN0cyB0aGF0IHRoZSBtZWRpYSBwbGF5ZXIgd2lsbCBz ZW5kIHRoZSByZWxldmFudCByZWZlcmVyIHdoZW4gcmVxdWVzdGluZyB0aGUgbWVkaWEgZmlsZS48 YnIvPgogPC9ib2R5PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0v dGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0CmluZGV4IDgyNzViY2VjMjE1MGViYWRmZDgxYTM1OGNmNjI4NmZl ODlkMzgzMjcuLjI5Mzc2NDdiOGVjNWViNTc5Y2FiYWQ4ZGIwZTFjY2NhYzhmNmY1ZGUgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQKQEAgLTQyMTksOSArNDIxOSw2IEBAIEJVR0NSMTE1MDczIFNMT1cgTElOVVggREVCVUcgOiBp bnNwZWN0b3IvZGVidWdnZXIvc2NyaXB0LWZvcm1hdHRlci1icmVha3BvaW50cy5oCiAKIEJVR1dL NzkyMjQgVklTVEEgV0lONyA6IGZhc3QvY2FudmFzL3dlYmdsL3RleC1pbWFnZS13aXRoLWZvcm1h dC1hbmQtdHlwZS5odG1sID0gVEVYVAogCi0vLyBGYWlsaW5nIGFmdGVyIHRlc3Qgd2FzIHVwZGF0 ZWQgaW4gcjEwODM4NywgbWVkaWEgZW5naW5lIHNlbmRpbmcgaW5jb3JyZWN0IHJlZmVycmVyPwot QlVHV0s3OTIzOSA6IGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1sID0gRkFJTAot CiAvLyBBc3NlcnRpbmcgaW4gZGVidWcgYnVpbGRzIHNpbmNlIHIxMDg1MDYKIEJVR1dLNzkyMjkg REVCVUcgOiBodHRwL3Rlc3RzL2luc3BlY3Rvci9jb25zb2xlLXhoci1sb2dnaW5nLWFzeW5jLmh0 bWwgPSBDUkFTSAogQlVHV0s3OTIyOSBERUJVRyA6IGh0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdv cmsvbmV0d29yay1kaXNhYmxlLWNhY2hlLXhocnMuaHRtbCA9IENSQVNICg== 128545 2012-02-23 13:33:12 -0800 2012-02-23 17:18:10 -0800 Patch bug-79239-20120223133311.patch text/plain 3211 dalecurtis U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NjM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjczNTU1MDM4ZjMzMDZlYzkxYWU1 ZjM1NDE5M2E5ZWVmMWY3OGE4Ny4uNDQwM2UzZDhkMTRjMGEzMTE5ZDg0ZGRkYjk5ZDFiNjljZDEx N2ZkYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTIzICBEYWxlIEN1cnRpcyAgPGRh bGVjdXJ0aXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gdmlkZW8tcmVmZXJl ci5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTIzOQorCisgICAgICAgIEZpeCBldmVudCBzZXR1cCByYWNlIGJ5IG1vdmluZyBzZXR1 cCBpbnRvIGJvZHkgb25sb2FkKCkgaGFuZGxlci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5o dG1sOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoK KwogMjAxMi0wMi0yMyAgQ2hhbmdTZW9rIE9oICA8c2hpdmFtaWRvd0BnbWFpbC5jb20+CiAKICAg ICAgICAgW0dUS10gRFJUIGRvZXNuJ3Qgc3VwcG9ydCBzY2hlZHVsZUFzeW5jaHJvbm91c0tleURv d24uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVy ZXIuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1s CmluZGV4IDY5ZmVkYjI4ZDcxMDQxYjhkMzg3ZDZjZTAxMGU4OTI5N2VhNjhjZjguLmE4OTVjMThj MGUyMmMzMmRmMDgzYjIyMjZiZGEzM2YyOWI1MzRmMTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1sCkBAIC0xNiwyNCArMTYsMjIgQEAKICAg ICAgICAgZnJhbWUuaGVpZ2h0ID0gMDsKICAgICAgICAgZnJhbWUuc3JjID0gImRhdGE6dGV4dC9o dG1sLDxiPnRlc3Q8L2I+IjsKICAgICAgICAgZnJhbWUuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcs IGZ1bmN0aW9uICgpIHsKLSAgICAgICAgICAgICAgICB2aWRlbyA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCd2aWRlbycpOwogICAgICAgICAgICAgICAgIHNvdXJjZSA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdzb3VyY2UnKTsKICAgICAgICAgICAgICAgICBzb3VyY2Uuc3JjID0gJ2h0dHA6 Ly8xMjcuMC4wLjE6ODAwMC9tZWRpYS9yZXNvdXJjZXMvdmlkZW8tcmVmZXJlci1jaGVjay1yZWZl cmVyLnBocD9uYW1lPScgKyBtb3ZpZSArICcmdHlwZT0nICsgdHlwZTsKICAgICAgICAgICAgICAg ICBzb3VyY2UudHlwZSA9IHR5cGU7CiAgICAgICAgICAgICAgICAgdmlkZW8ubG9hZCgpOwogICAg ICAgICB9KTsKIAorICAgICAgICB3YWl0Rm9yRXZlbnRBbmRFbmQoJ2Vycm9yJywgZnVuY3Rpb24g KCkgeworICAgICAgICAgICAgY29uc29sZVdyaXRlKCdGQUlMLCBnb3QgZXJyb3Igd2hlbiBsb2Fk aW5nIG1lZGlhLicpOworICAgICAgICB9KTsKKworICAgICAgICB3YWl0Rm9yRXZlbnQoJ2NhbnBs YXknLCBmdW5jdGlvbiAoKSB7CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQorICAgICAgICAgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3Rp ZnlEb25lKCk7CisgICAgICAgIH0pOwogICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxk KGZyYW1lKTsKICAgICB9Ci0gICAgCi0gICAgd2FpdEZvckV2ZW50QW5kRW5kKCdlcnJvcicsIGZ1 bmN0aW9uICgpIHsKLSAgICAgICAgY29uc29sZVdyaXRlKCdGQUlMLCBnb3QgZXJyb3Igd2hlbiBs b2FkaW5nIG1lZGlhIGVycm9yOiAnICsgdmlkZW8uZXJyb3IuY29kZSk7Ci0gICAgfSk7ICAgIAot Ci0gICAgd2FpdEZvckV2ZW50KCdjYW5wbGF5JywgZnVuY3Rpb24gKCkgewotICAgICAgICBpZiAo d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQotICAgICAgICAgICAgd2luZG93LmxheW91dFRl c3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKLSAgICB9ICk7CiA8L3NjcmlwdD4KIFRlc3RzIHRo YXQgdGhlIG1lZGlhIHBsYXllciB3aWxsIHNlbmQgdGhlIHJlbGV2YW50IHJlZmVyZXIgd2hlbiBy ZXF1ZXN0aW5nIHRoZSBtZWRpYSBmaWxlLjxici8+CiA8L2JvZHk+CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggZjg4MjNi OWQwYTBmZjNjYThkMWQyY2Q0NmJjYjE4MGFiZDgwMzY2My4uYmJmNDg2NmI5MTgyNzVjMjVhN2M0 NmM1ZDZlOWNlZThlNWRmYzA3YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtNDIxOCw5ICs0MjE4LDYgQEAgQlVHQ1Ix MTUwNzMgU0xPVyBMSU5VWCBERUJVRyA6IGluc3BlY3Rvci9kZWJ1Z2dlci9zY3JpcHQtZm9ybWF0 dGVyLWJyZWFrcG9pbnRzLmgKIAogQlVHV0s3OTIyNCBWSVNUQSBXSU43IDogZmFzdC9jYW52YXMv d2ViZ2wvdGV4LWltYWdlLXdpdGgtZm9ybWF0LWFuZC10eXBlLmh0bWwgPSBURVhUCiAKLS8vIEZh aWxpbmcgYWZ0ZXIgdGVzdCB3YXMgdXBkYXRlZCBpbiByMTA4Mzg3LCBtZWRpYSBlbmdpbmUgc2Vu ZGluZyBpbmNvcnJlY3QgcmVmZXJyZXI/Ci1CVUdXSzc5MjM5IDogaHR0cC90ZXN0cy9tZWRpYS92 aWRlby1yZWZlcmVyLmh0bWwgPSBGQUlMCi0KIC8vIEFzc2VydGluZyBpbiBkZWJ1ZyBidWlsZHMg c2luY2UgcjEwODUwNgogQlVHV0s3OTIyOSBXSU4gTElOVVggREVCVUcgOiBodHRwL3Rlc3RzL2lu c3BlY3Rvci9jb25zb2xlLXhoci1sb2dnaW5nLWFzeW5jLmh0bWwgPSBDUkFTSAogQlVHV0s3OTIy OSBNQUMgREVCVUcgOiBodHRwL3Rlc3RzL2luc3BlY3Rvci9jb25zb2xlLXhoci1sb2dnaW5nLWFz eW5jLmh0bWwgPSBUSU1FT1VUCg== 128612 2012-02-23 17:17:58 -0800 2012-02-23 17:36:24 -0800 Patch bug-79239-20120223171757.patch text/plain 4019 dalecurtis U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NjM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjczNTU1MDM4ZjMzMDZlYzkxYWU1 ZjM1NDE5M2E5ZWVmMWY3OGE4Ny4uMzc4ZTEwNGI1ZmY1MzVjNTVhZDY0YjU2NmI5NmEyNGIwZjZl YTEzMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTIzICBEYWxlIEN1cnRpcyAgPGRh bGVjdXJ0aXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gdmlkZW8tcmVmZXJl ci5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTIzOQorCisgICAgICAgIEZpeCBlcnJvciBldmVudCByYWNlIGF0IHN0YXJ0dXAgYW5k IGNsZWFudXAgZXZlbnQgY29kZSB0byB0YWtlCisgICAgICAgIGFkdmFudGFnZSBvZiBtb3JlIHN1 Y2NpbmN0IHZpZGVvLXRlc3QuanMgZnVuY3Rpb25hbGl0eTsgc3VjaCBhcworICAgICAgICB3YWl0 Rm9yRXZlbnRBbmRGYWlsLCBldGMuCisKKyAgICAgICAgU2luY2UgdGhpcyB0ZXN0IHVzZXMgYSA8 c291cmNlPiBlbGVtZW50IHdpdGhvdXQgYSAnc3JjJyB0YWcsIGFuIGVycm9yCisgICAgICAgIGV2 ZW50IGdldHMgZmlyZWQgZHVyaW5nIGxvYWQuIElmIHdlIGRvbid0IHdhaXQgdW50aWwgYWZ0ZXIg dGhlIDxib2R5PgorICAgICAgICBvbmxvYWQgZmlyZXMsIHdlJ2xsIHBpY2t1cCB0aGlzIGVycm9y IHdlIGRvbid0IGNhcmUgYWJvdXQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVyZXItZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1sOgorICAg ICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMi0w Mi0yMyAgQ2hhbmdTZW9rIE9oICA8c2hpdmFtaWRvd0BnbWFpbC5jb20+CiAKICAgICAgICAgW0dU S10gRFJUIGRvZXNuJ3Qgc3VwcG9ydCBzY2hlZHVsZUFzeW5jaHJvbm91c0tleURvd24uCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVyZXItZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS92aWRlby1yZWZlcmVyLWV4cGVj dGVkLnR4dAppbmRleCA1NzRhOGY4MzcwYzU3ZGIwZmU2ZjUzYTUzYWEwNmM2OGUwNmUwOTA4Li42 NGQ5YmNiZWU4MjJhNDc1ZTM1MmZiOGQyOTU1MmYxOTI0ZjU4YjkxIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVyZXItZXhwZWN0ZWQudHh0CisrKyBi L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci1leHBlY3RlZC50eHQK QEAgLTEsMyArMSw0IEBACiBFVkVOVChjYW5wbGF5KQorRU5EIE9GIFRFU1QKIFRlc3RzIHRoYXQg dGhlIG1lZGlhIHBsYXllciB3aWxsIHNlbmQgdGhlIHJlbGV2YW50IHJlZmVyZXIgd2hlbiByZXF1 ZXN0aW5nIHRoZSBtZWRpYSBmaWxlLgogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL21lZGlhL3ZpZGVvLXJlZmVyZXIuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVk aWEvdmlkZW8tcmVmZXJlci5odG1sCmluZGV4IDY5ZmVkYjI4ZDcxMDQxYjhkMzg3ZDZjZTAxMGU4 OTI5N2VhNjhjZjguLjA5MDc3Zjg3MzFlZTY2ZWM0ZTc3MDU5NTkxOTdhMjEwNTIxOTRhMDUgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1s CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1sCkBA IC0xNCwyNiArMTQsMTkgQEAKICAgICAgICAgdmFyIGZyYW1lID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgnaWZyYW1lJyk7CiAgICAgICAgIGZyYW1lLndpZHRoID0gMDsKICAgICAgICAgZnJhbWUu aGVpZ2h0ID0gMDsKLSAgICAgICAgZnJhbWUuc3JjID0gImRhdGE6dGV4dC9odG1sLDxiPnRlc3Q8 L2I+IjsKICAgICAgICAgZnJhbWUuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGZ1bmN0aW9uICgp IHsKLSAgICAgICAgICAgICAgICB2aWRlbyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd2aWRl bycpOwogICAgICAgICAgICAgICAgIHNvdXJjZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdz b3VyY2UnKTsKICAgICAgICAgICAgICAgICBzb3VyY2Uuc3JjID0gJ2h0dHA6Ly8xMjcuMC4wLjE6 ODAwMC9tZWRpYS9yZXNvdXJjZXMvdmlkZW8tcmVmZXJlci1jaGVjay1yZWZlcmVyLnBocD9uYW1l PScgKyBtb3ZpZSArICcmdHlwZT0nICsgdHlwZTsKICAgICAgICAgICAgICAgICBzb3VyY2UudHlw ZSA9IHR5cGU7CisKKyAgICAgICAgICAgICAgICB3YWl0Rm9yRXZlbnRBbmRGYWlsKCdlcnJvcicp OworICAgICAgICAgICAgICAgIHdhaXRGb3JFdmVudEFuZEVuZCgnY2FucGxheScpOwogICAgICAg ICAgICAgICAgIHZpZGVvLmxvYWQoKTsKICAgICAgICAgfSk7CiAKKyAgICAgICAgZnJhbWUuc3Jj ID0gImRhdGE6dGV4dC9odG1sLDxiPnRlc3Q8L2I+IjsKICAgICAgICAgZG9jdW1lbnQuYm9keS5h cHBlbmRDaGlsZChmcmFtZSk7CiAgICAgfQotICAgIAotICAgIHdhaXRGb3JFdmVudEFuZEVuZCgn ZXJyb3InLCBmdW5jdGlvbiAoKSB7Ci0gICAgICAgIGNvbnNvbGVXcml0ZSgnRkFJTCwgZ290IGVy cm9yIHdoZW4gbG9hZGluZyBtZWRpYSBlcnJvcjogJyArIHZpZGVvLmVycm9yLmNvZGUpOwotICAg IH0pOyAgICAKLQotICAgIHdhaXRGb3JFdmVudCgnY2FucGxheScsIGZ1bmN0aW9uICgpIHsKLSAg ICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICAgICAgICAgIHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Ci0gICAgfSApOwogPC9zY3JpcHQ+ CiBUZXN0cyB0aGF0IHRoZSBtZWRpYSBwbGF5ZXIgd2lsbCBzZW5kIHRoZSByZWxldmFudCByZWZl cmVyIHdoZW4gcmVxdWVzdGluZyB0aGUgbWVkaWEgZmlsZS48YnIvPgogPC9ib2R5PgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0 IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Cmlu ZGV4IGY4ODIzYjlkMGEwZmYzY2E4ZDFkMmNkNDZiY2IxODBhYmQ4MDM2NjMuLmJiZjQ4NjZiOTE4 Mjc1YzI1YTdjNDZjNWQ2ZTljZWU4ZTVkZmMwN2IgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKQEAgLTQyMTgsOSArNDIxOCw2 IEBAIEJVR0NSMTE1MDczIFNMT1cgTElOVVggREVCVUcgOiBpbnNwZWN0b3IvZGVidWdnZXIvc2Ny aXB0LWZvcm1hdHRlci1icmVha3BvaW50cy5oCiAKIEJVR1dLNzkyMjQgVklTVEEgV0lONyA6IGZh c3QvY2FudmFzL3dlYmdsL3RleC1pbWFnZS13aXRoLWZvcm1hdC1hbmQtdHlwZS5odG1sID0gVEVY VAogCi0vLyBGYWlsaW5nIGFmdGVyIHRlc3Qgd2FzIHVwZGF0ZWQgaW4gcjEwODM4NywgbWVkaWEg ZW5naW5lIHNlbmRpbmcgaW5jb3JyZWN0IHJlZmVycmVyPwotQlVHV0s3OTIzOSA6IGh0dHAvdGVz dHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1sID0gRkFJTAotCiAvLyBBc3NlcnRpbmcgaW4gZGVi dWcgYnVpbGRzIHNpbmNlIHIxMDg1MDYKIEJVR1dLNzkyMjkgV0lOIExJTlVYIERFQlVHIDogaHR0 cC90ZXN0cy9pbnNwZWN0b3IvY29uc29sZS14aHItbG9nZ2luZy1hc3luYy5odG1sID0gQ1JBU0gK IEJVR1dLNzkyMjkgTUFDIERFQlVHIDogaHR0cC90ZXN0cy9pbnNwZWN0b3IvY29uc29sZS14aHIt bG9nZ2luZy1hc3luYy5odG1sID0gVElNRU9VVAo= 128619 2012-02-23 17:36:29 -0800 2012-02-24 02:40:19 -0800 Patch bug-79239-20120223173627.patch text/plain 3948 dalecurtis U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NzAyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODM4Mzg1MTQ2ZmRhNmE4MWI1YTM3 MmU3MTlmNGU2NWQzZjVlZDc4MS4uYTUyOWExOWUxODUyNDE5MGVjZDBkMjRlYzI5Nzg4YmEzZjZh MzA5YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTIzICBEYWxlIEN1cnRpcyAgPGRh bGVjdXJ0aXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gdmlkZW8tcmVmZXJl ci5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03OTIzOQorCisgICAgICAgIEZpeCBlcnJvciBldmVudCByYWNlIGF0IHN0YXJ0dXAgYW5k IGNsZWFudXAgZXZlbnQgY29kZSB0byB0YWtlCisgICAgICAgIGFkdmFudGFnZSBvZiBtb3JlIHN1 Y2NpbmN0IHZpZGVvLXRlc3QuanMgZnVuY3Rpb25hbGl0eTsgc3VjaCBhcworICAgICAgICB3YWl0 Rm9yRXZlbnRBbmRGYWlsLCBldGMuCisKKyAgICAgICAgU2luY2UgdGhpcyB0ZXN0IHVzZXMgYSA8 c291cmNlPiBlbGVtZW50IHdpdGhvdXQgYSAnc3JjJyB0YWcsIGFuIGVycm9yCisgICAgICAgIGV2 ZW50IGdldHMgZmlyZWQgZHVyaW5nIGxvYWQuIElmIHdlIGRvbid0IHdhaXQgdW50aWwgYWZ0ZXIg dGhlIDxib2R5PgorICAgICAgICBvbmxvYWQgZmlyZXMsIHdlJ2xsIHBpY2t1cCB0aGlzIGVycm9y IHdlIGRvbid0IGNhcmUgYWJvdXQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVyZXItZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJlci5odG1sOgorICAg ICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMi0w Mi0yMyAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBUaGlz IHRlc3QgY2hlY2tzIHNlbGVjdCBhdHRyaWJ1dGUgb2YgY29udGVudCBlbGVtZW50IGlzIHZhbGlk LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS92aWRlby1yZWZlcmVy LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcmVmZXJl ci1leHBlY3RlZC50eHQKaW5kZXggNTc0YThmODM3MGM1N2RiMGZlNmY1M2E1M2FhMDZjNjhlMDZl MDkwOC4uNjRkOWJjYmVlODIyYTQ3NWUzNTJmYjhkMjk1NTJmMTkyNGY1OGI5MSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS92aWRlby1yZWZlcmVyLWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVyZXItZXhwZWN0 ZWQudHh0CkBAIC0xLDMgKzEsNCBAQAogRVZFTlQoY2FucGxheSkKK0VORCBPRiBURVNUCiBUZXN0 cyB0aGF0IHRoZSBtZWRpYSBwbGF5ZXIgd2lsbCBzZW5kIHRoZSByZWxldmFudCByZWZlcmVyIHdo ZW4gcmVxdWVzdGluZyB0aGUgbWVkaWEgZmlsZS4KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9tZWRpYS92aWRlby1yZWZlcmVyLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL21lZGlhL3ZpZGVvLXJlZmVyZXIuaHRtbAppbmRleCA2OWZlZGIyOGQ3MTA0MWI4ZDM4N2Q2 Y2UwMTBlODkyOTdlYTY4Y2Y4Li4wOTA3N2Y4NzMxZWU2NmVjNGU3NzA1OTU5MTk3YTIxMDUyMTk0 YTA1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVy ZXIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVyZXIu aHRtbApAQCAtMTQsMjYgKzE0LDE5IEBACiAgICAgICAgIHZhciBmcmFtZSA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoJ2lmcmFtZScpOwogICAgICAgICBmcmFtZS53aWR0aCA9IDA7CiAgICAgICAg IGZyYW1lLmhlaWdodCA9IDA7Ci0gICAgICAgIGZyYW1lLnNyYyA9ICJkYXRhOnRleHQvaHRtbCw8 Yj50ZXN0PC9iPiI7CiAgICAgICAgIGZyYW1lLmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBmdW5j dGlvbiAoKSB7Ci0gICAgICAgICAgICAgICAgdmlkZW8gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgndmlkZW8nKTsKICAgICAgICAgICAgICAgICBzb3VyY2UgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnc291cmNlJyk7CiAgICAgICAgICAgICAgICAgc291cmNlLnNyYyA9ICdodHRwOi8vMTI3 LjAuMC4xOjgwMDAvbWVkaWEvcmVzb3VyY2VzL3ZpZGVvLXJlZmVyZXItY2hlY2stcmVmZXJlci5w aHA/bmFtZT0nICsgbW92aWUgKyAnJnR5cGU9JyArIHR5cGU7CiAgICAgICAgICAgICAgICAgc291 cmNlLnR5cGUgPSB0eXBlOworCisgICAgICAgICAgICAgICAgd2FpdEZvckV2ZW50QW5kRmFpbCgn ZXJyb3InKTsKKyAgICAgICAgICAgICAgICB3YWl0Rm9yRXZlbnRBbmRFbmQoJ2NhbnBsYXknKTsK ICAgICAgICAgICAgICAgICB2aWRlby5sb2FkKCk7CiAgICAgICAgIH0pOwogCisgICAgICAgIGZy YW1lLnNyYyA9ICJkYXRhOnRleHQvaHRtbCw8Yj50ZXN0PC9iPiI7CiAgICAgICAgIGRvY3VtZW50 LmJvZHkuYXBwZW5kQ2hpbGQoZnJhbWUpOwogICAgIH0KLSAgICAKLSAgICB3YWl0Rm9yRXZlbnRB bmRFbmQoJ2Vycm9yJywgZnVuY3Rpb24gKCkgewotICAgICAgICBjb25zb2xlV3JpdGUoJ0ZBSUws IGdvdCBlcnJvciB3aGVuIGxvYWRpbmcgbWVkaWEgZXJyb3I6ICcgKyB2aWRlby5lcnJvci5jb2Rl KTsKLSAgICB9KTsgICAgCi0KLSAgICB3YWl0Rm9yRXZlbnQoJ2NhbnBsYXknLCBmdW5jdGlvbiAo KSB7Ci0gICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCi0gICAgICAgICAg ICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwotICAgIH0gKTsKIDwv c2NyaXB0PgogVGVzdHMgdGhhdCB0aGUgbWVkaWEgcGxheWVyIHdpbGwgc2VuZCB0aGUgcmVsZXZh bnQgcmVmZXJlciB3aGVuIHJlcXVlc3RpbmcgdGhlIG1lZGlhIGZpbGUuPGJyLz4KIDwvYm9keT4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRp b25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25z LnR4dAppbmRleCAyZjYwZjVhZWE5NTJkYzUwMWIxMjE3OTg5NTMxOGI3MzdlNzNmMWQ5Li40OWIw NjE5ZjliYzU0Mzg0MDBmNDkxOWZiNGFmNDA3MjVhMDE3MmI1IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC00MjAzLDkg KzQyMDMsNiBAQCBCVUdDUjExNTA3MyBTTE9XIExJTlVYIERFQlVHIDogaW5zcGVjdG9yL2RlYnVn Z2VyL3NjcmlwdC1mb3JtYXR0ZXItYnJlYWtwb2ludHMuaAogCiBCVUdXSzc5MjI0IFZJU1RBIFdJ TjcgOiBmYXN0L2NhbnZhcy93ZWJnbC90ZXgtaW1hZ2Utd2l0aC1mb3JtYXQtYW5kLXR5cGUuaHRt bCA9IFRFWFQKIAotLy8gRmFpbGluZyBhZnRlciB0ZXN0IHdhcyB1cGRhdGVkIGluIHIxMDgzODcs IG1lZGlhIGVuZ2luZSBzZW5kaW5nIGluY29ycmVjdCByZWZlcnJlcj8KLUJVR1dLNzkyMzkgOiBo dHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXJlZmVyZXIuaHRtbCA9IEZBSUwKLQogLy8gTmVlZCByZWJh c2VsaW5pbmcgYWZ0ZXIgYnVnIDc1MDkxCiBCVUdXSzc1MDkxIFNLSVAgOiBzdmcvY2FydG8ubmV0 L3RhYmdyb3VwLnN2ZyA9IEZBSUwKIEJVR1dLNzUwOTEgU0tJUCA6IHN2Zy9jYXJ0by5uZXQvd2lu ZG93LnN2ZyA9IEZBSUwK