79227 2012-02-22 05:25:49 -0800 build-webkit should use environment variable at number of CPU detection on all platform 2012-02-22 10:10:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 rgabor webkit-unassigned dpranke eric mrobinson ossy webkit.review.bot oldest_to_newest 561876 0 rgabor 2012-02-22 05:25:49 -0800 It would be good (mostly for buildbots) if we could set an environment variable to set the number of cpus which the build script will use. For example if we have a server with 24 cores and we have some low priority bots it would be easy just set an environment variable for them. 561885 1 rgabor 2012-02-22 05:35:54 -0800 On Qt and Gtk platforms the MAKEFLAGS environment variable is enough for this purpose but Chromium just use --makeargs or determineNumberOfCPUs for fallback. The --makeargs option is good when you compile by hand but not for buildbots. 561895 2 128187 rgabor 2012-02-22 05:50:27 -0800 Created attachment 128187 proposed patch 562085 3 128187 webkit.review.bot 2012-02-22 10:10:27 -0800 Comment on attachment 128187 proposed patch Clearing flags on attachment: 128187 Committed r108513: <http://trac.webkit.org/changeset/108513> 562086 4 webkit.review.bot 2012-02-22 10:10:32 -0800 All reviewed patches have been landed. Closing bug. 128187 2012-02-22 05:50:27 -0800 2012-02-22 10:10:27 -0800 proposed patch cpu_env.patch text/plain 1961 rgabor SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwODQ5MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTAyLTIyICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9y Zz4KKworICAgICAgICBidWlsZC13ZWJraXQgc2hvdWxkIHVzZSBlbnZpcm9ubWVudCB2YXJpYWJs ZSBhdCBudW1iZXIgb2YgQ1BVCisgICAgICAgIGRldGVjdGlvbiBvbiBhbGwgcGxhdGZvcm0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MjI3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVOdW1iZXJPZkNQVXMpOgorCiAyMDEyLTAy LTIyICBIYW8gWmhlbmcgIDx6aGVuZ2hhb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9t aXVtXSBCdWlsZCBXZWJLaXQgd2l0aCBNRURJQV9TVFJFQU0gZGlzYWJsZWQuCkluZGV4OiBUb29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCShyZXZpc2lvbiAxMDg0ODMpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMu cG0JKHdvcmtpbmcgY29weSkKQEAgLTMyNiw3ICszMjYsOSBAQCBzdWIgZGV0ZXJtaW5lQXJjaGl0 ZWN0dXJlCiBzdWIgZGV0ZXJtaW5lTnVtYmVyT2ZDUFVzCiB7CiAgICAgcmV0dXJuIGlmIGRlZmlu ZWQgJG51bWJlck9mQ1BVczsKLSAgICBpZiAoaXNMaW51eCgpKSB7CisgICAgaWYgKGRlZmluZWQo JEVOVntOVU1CRVJfT0ZfUFJPQ0VTU09SU30pKSB7CisgICAgICAgICRudW1iZXJPZkNQVXMgPSAk RU5We05VTUJFUl9PRl9QUk9DRVNTT1JTfTsKKyAgICB9IGVsc2lmIChpc0xpbnV4KCkpIHsKICAg ICAgICAgIyBGaXJzdCB0cnkgdGhlIG5wcm9jIHV0aWxpdHksIGlmIGl0IGV4aXN0cy4gSWYgd2Ug Z2V0IG5vCiAgICAgICAgICMgcmVzdWx0cyBmYWxsIGJhY2sgdG8ganVzdCBpbnRlcnByZXR0aW5n IC9wcm9jIGRpcmVjdGx5LgogICAgICAgICBjaG9tcCgkbnVtYmVyT2ZDUFVzID0gYG5wcm9jIDI+ IC9kZXYvbnVsbGApOwpAQCAtMzM0LDEyICszMzYsOCBAQCBzdWIgZGV0ZXJtaW5lTnVtYmVyT2ZD UFVzCiAgICAgICAgICAgICAkbnVtYmVyT2ZDUFVzID0gKGdyZXAgL3Byb2Nlc3Nvci8sIGBjYXQg L3Byb2MvY3B1aW5mb2ApOwogICAgICAgICB9CiAgICAgfSBlbHNpZiAoaXNXaW5kb3dzKCkgfHwg aXNDeWd3aW4oKSkgewotICAgICAgICBpZiAoZGVmaW5lZCgkRU5We05VTUJFUl9PRl9QUk9DRVNT T1JTfSkpIHsKLSAgICAgICAgICAgICRudW1iZXJPZkNQVXMgPSAkRU5We05VTUJFUl9PRl9QUk9D RVNTT1JTfTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICMgQXNzdW1lcyBjeWd3aW4K LSAgICAgICAgICAgICRudW1iZXJPZkNQVXMgPSBgbHMgL3Byb2MvcmVnaXN0cnkvSEtFWV9MT0NB TF9NQUNISU5FL0hBUkRXQVJFL0RFU0NSSVBUSU9OL1N5c3RlbS9DZW50cmFsUHJvY2Vzc29yIHwg d2MgLXdgOwotICAgICAgICB9CisgICAgICAgICMgQXNzdW1lcyBjeWd3aW4KKyAgICAgICAgJG51 bWJlck9mQ1BVcyA9IGBscyAvcHJvYy9yZWdpc3RyeS9IS0VZX0xPQ0FMX01BQ0hJTkUvSEFSRFdB UkUvREVTQ1JJUFRJT04vU3lzdGVtL0NlbnRyYWxQcm9jZXNzb3IgfCB3YyAtd2A7CiAgICAgfSBl bHNpZiAoaXNEYXJ3aW4oKSkgewogICAgICAgICBjaG9tcCgkbnVtYmVyT2ZDUFVzID0gYHN5c2N0 bCAtbiBody5uY3B1YCk7CiAgICAgfQo=