79225 2012-02-22 04:51:27 -0800 Drop clipToImageBuffer from RenderBoxModelObject 2012-02-22 06:19:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 1 zherczeg webkit-unassigned darin hyatt zimmermann oldest_to_newest 561852 0 zherczeg 2012-02-22 04:51:27 -0800 Continue the quest to drop clipToImageBuffer from WebKit. The bgLayer->clip() == TextFillBox is a non-standard rarely used feature. The replacement code has the same speed on Mac. 561857 1 128179 zherczeg 2012-02-22 05:04:52 -0800 Created attachment 128179 patch 561861 2 128180 zherczeg 2012-02-22 05:06:14 -0800 Created attachment 128180 perf test (background image is not attached) 561877 3 128179 zimmermann 2012-02-22 05:27:32 -0800 Comment on attachment 128179 patch Looks great, r=me. As cr-linux is green as well, I assume this doesn't change pixel tests at all. 561882 4 zherczeg 2012-02-22 05:29:59 -0800 Yeah. Now it is green :) 561924 5 zherczeg 2012-02-22 06:19:03 -0800 http://trac.webkit.org/changeset/108492 128179 2012-02-22 05:04:52 -0800 2012-02-22 05:27:32 -0800 patch 0001-clipToImageBuffer.patch text/plain 4559 zherczeg RnJvbSAyMjEwNzdkNzhhODhkNWYxZWUyMzE2YjQyNGQ2MmY0MThjYTU3ZmVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAd2Via2l0Lm9yZz4K RGF0ZTogV2VkLCAyMiBGZWIgMjAxMiAwNTowMjo1MCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGNs aXBUb0ltYWdlQnVmZmVyCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwIHwgICAyNSArKysrKysrKysrKysrKy0tLS0t LQogMiBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCBkMWY4YTE2Li42Nzg3OTY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTItMDItMjIgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAd2Via2l0Lm9yZz4KKworICAg ICAgICBEcm9wIGNsaXBUb0ltYWdlQnVmZmVyIGZyb20gUmVuZGVyQm94TW9kZWxPYmplY3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc5MjI1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLXdlYmtpdC1iYWNr Z3JvdW5kLWNsaXA6IHRleHQgaXMgYSByYXJlbHkgdXNlZCBub24tc3RhbmRhcmQKKyAgICAgICAg ZmVhdHVyZSB1c2VzIGNsaXBUb0ltYWdlQnVmZmVyLiBJdCBpcyByZXBsYWNlZCBieQorICAgICAg ICBDb21wb3NpdGVEZXN0aW5hdGlvbkluIG9uIGEgdHJhbnNwYXJlbnQgbGF5ZXIuIFRoZSBuZXcK KyAgICAgICAgYXBwcm9hY2ggaGFzIHRoZSBzYW1lIHNwZWVkIGFzIHRoZSBvbGQgb25lLgorCisg ICAgICAgIEV4aXN0aW5nIHRlc3RzIGNvdmVyIHRoaXMgaXNzdWUuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy Qm94TW9kZWxPYmplY3Q6OnBhaW50RmlsbExheWVyRXh0ZW5kZWQpOgorCiAyMDEyLTAyLTIxICBB bmRyZWFzIEtsaW5nICA8YXdlc29tZWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBDYWNoZSA8 Zm9udCBmYWNlPiBmYW1pbHkgbGlzdHMgaW4gQ1NTVmFsdWVQb29sLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKaW5kZXggYzY2NzEwZS4u Nzk0MWM4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1v ZGVsT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9k ZWxPYmplY3QuY3BwCkBAIC03MzgsNiArNzM4LDkgQEAgdm9pZCBSZW5kZXJCb3hNb2RlbE9iamVj dDo6cGFpbnRGaWxsTGF5ZXJFeHRlbmRlZChjb25zdCBQYWludEluZm8mIHBhaW50SW5mbywgY28K ICAgICB9CiAgICAgCiAgICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBiYWNrZ3JvdW5kQ2xp cFN0YXRlU2F2ZXIoKmNvbnRleHQsIGZhbHNlKTsKKyAgICBPd25QdHI8SW1hZ2VCdWZmZXI+IG1h c2tJbWFnZTsKKyAgICBJbnRSZWN0IG1hc2tSZWN0OworCiAgICAgaWYgKGJnTGF5ZXItPmNsaXAo KSA9PSBQYWRkaW5nRmlsbEJveCB8fCBiZ0xheWVyLT5jbGlwKCkgPT0gQ29udGVudEZpbGxCb3gp IHsKICAgICAgICAgLy8gQ2xpcCB0byB0aGUgcGFkZGluZyBvciBjb250ZW50IGJveGVzIGFzIG5l Y2Vzc2FyeS4KICAgICAgICAgYm9vbCBpbmNsdWRlUGFkZGluZyA9IGJnTGF5ZXItPmNsaXAoKSA9 PSBDb250ZW50RmlsbEJveDsKQEAgLTc1MSwxNyArNzU0LDE3IEBAIHZvaWQgUmVuZGVyQm94TW9k ZWxPYmplY3Q6OnBhaW50RmlsbExheWVyRXh0ZW5kZWQoY29uc3QgUGFpbnRJbmZvJiBwYWludElu Zm8sIGNvCiAgICAgICAgIC8vIFdlIGhhdmUgdG8gZHJhdyBvdXIgdGV4dCBpbnRvIGEgbWFzayB0 aGF0IGNhbiB0aGVuIGJlIHVzZWQgdG8gY2xpcCBiYWNrZ3JvdW5kIGRyYXdpbmcuCiAgICAgICAg IC8vIEZpcnN0IGZpZ3VyZSBvdXQgaG93IGJpZyB0aGUgbWFzayBoYXMgdG8gYmUuICBJdCBzaG91 bGQgYmUgbm8gYmlnZ2VyIHRoYW4gd2hhdCB3ZSBuZWVkCiAgICAgICAgIC8vIHRvIGFjdHVhbGx5 IHJlbmRlciwgc28gd2Ugc2hvdWxkIGludGVyc2VjdCB0aGUgZGlydHkgcmVjdCB3aXRoIHRoZSBi b3JkZXIgYm94IG9mIHRoZSBiYWNrZ3JvdW5kLgotICAgICAgICBJbnRSZWN0IG1hc2tSZWN0ID0g cGl4ZWxTbmFwcGVkSW50UmVjdChyZWN0KTsKKyAgICAgICAgbWFza1JlY3QgPSBwaXhlbFNuYXBw ZWRJbnRSZWN0KHJlY3QpOwogICAgICAgICBtYXNrUmVjdC5pbnRlcnNlY3QocGFpbnRJbmZvLnJl Y3QpOwotICAgICAgICAKKwogICAgICAgICAvLyBOb3cgY3JlYXRlIHRoZSBtYXNrLgotICAgICAg ICBPd25QdHI8SW1hZ2VCdWZmZXI+IG1hc2tJbWFnZSA9IGNvbnRleHQtPmNyZWF0ZUNvbXBhdGli bGVCdWZmZXIobWFza1JlY3Quc2l6ZSgpKTsKKyAgICAgICAgbWFza0ltYWdlID0gY29udGV4dC0+ Y3JlYXRlQ29tcGF0aWJsZUJ1ZmZlcihtYXNrUmVjdC5zaXplKCkpOwogICAgICAgICBpZiAoIW1h c2tJbWFnZSkKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgCisKICAgICAgICAgR3JhcGhp Y3NDb250ZXh0KiBtYXNrSW1hZ2VDb250ZXh0ID0gbWFza0ltYWdlLT5jb250ZXh0KCk7CiAgICAg ICAgIG1hc2tJbWFnZUNvbnRleHQtPnRyYW5zbGF0ZSgtbWFza1JlY3QueCgpLCAtbWFza1JlY3Qu eSgpKTsKLSAgICAgICAgCisKICAgICAgICAgLy8gTm93IGFkZCB0aGUgdGV4dCB0byB0aGUgY2xp cC4gIFdlIGRvIHRoaXMgYnkgcGFpbnRpbmcgdXNpbmcgYSBzcGVjaWFsIHBhaW50IHBoYXNlIHRo YXQgc2lnbmFscyB0bwogICAgICAgICAvLyBJbmxpbmVUZXh0Qm94ZXMgdGhhdCB0aGV5IHNob3Vs ZCBqdXN0IGFkZCB0aGVpciBjb250ZW50cyB0byB0aGUgY2xpcC4KICAgICAgICAgUGFpbnRJbmZv IGluZm8obWFza0ltYWdlQ29udGV4dCwgbWFza1JlY3QsIFBhaW50UGhhc2VUZXh0Q2xpcCwgdHJ1 ZSwgMCwgcGFpbnRJbmZvLnJlbmRlclJlZ2lvbiwgMCk7CkBAIC03NzIsMTIgKzc3NSwxMyBAQCB2 b2lkIFJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWludEZpbGxMYXllckV4dGVuZGVkKGNvbnN0IFBh aW50SW5mbyYgcGFpbnRJbmZvLCBjbwogICAgICAgICAgICAgTGF5b3V0U2l6ZSBsb2NhbE9mZnNl dCA9IGlzQm94KCkgPyB0b1JlbmRlckJveCh0aGlzKS0+bG9jYXRpb25PZmZzZXQoKSA6IExheW91 dFNpemUoKTsKICAgICAgICAgICAgIHBhaW50KGluZm8sIHNjcm9sbGVkUGFpbnRSZWN0LmxvY2F0 aW9uKCkgLSBsb2NhbE9mZnNldCk7CiAgICAgICAgIH0KLSAgICAgICAgCisKICAgICAgICAgLy8g VGhlIG1hc2sgaGFzIGJlZW4gY3JlYXRlZC4gIE5vdyB3ZSBqdXN0IG5lZWQgdG8gY2xpcCB0byBp dC4KICAgICAgICAgYmFja2dyb3VuZENsaXBTdGF0ZVNhdmVyLnNhdmUoKTsKLSAgICAgICAgY29u dGV4dC0+Y2xpcFRvSW1hZ2VCdWZmZXIobWFza0ltYWdlLmdldCgpLCBtYXNrUmVjdCk7CisgICAg ICAgIGNvbnRleHQtPmNsaXAobWFza1JlY3QpOworICAgICAgICBjb250ZXh0LT5iZWdpblRyYW5z cGFyZW5jeUxheWVyKDEpOwogICAgIH0KLSAgICAKKwogICAgIC8vIE9ubHkgZmlsbCB3aXRoIGEg YmFzZSBjb2xvciAoZS5nLiwgd2hpdGUpIGlmIHdlJ3JlIHRoZSByb290IGRvY3VtZW50LCBzaW5j ZSBpZnJhbWVzL2ZyYW1lcyB3aXRoCiAgICAgLy8gbm8gYmFja2dyb3VuZCBpbiB0aGUgY2hpbGQg ZG9jdW1lbnQgc2hvdWxkIHNob3cgdGhlIHBhcmVudCdzIGJhY2tncm91bmQuCiAgICAgYm9vbCBp c09wYXF1ZVJvb3QgPSBmYWxzZTsKQEAgLTg1NSw2ICs4NTksMTEgQEAgdm9pZCBSZW5kZXJCb3hN b2RlbE9iamVjdDo6cGFpbnRGaWxsTGF5ZXJFeHRlbmRlZChjb25zdCBQYWludEluZm8mIHBhaW50 SW5mbywgY28KICAgICAgICAgICAgICAgICBjb21wb3NpdGVPcCwgdXNlTG93UXVhbGl0eVNjYWxp bmcpOwogICAgICAgICB9CiAgICAgfQorCisgICAgaWYgKGJnTGF5ZXItPmNsaXAoKSA9PSBUZXh0 RmlsbEJveCkgeworICAgICAgICBjb250ZXh0LT5kcmF3SW1hZ2VCdWZmZXIobWFza0ltYWdlLmdl dCgpLCBDb2xvclNwYWNlRGV2aWNlUkdCLCBtYXNrUmVjdCwgQ29tcG9zaXRlRGVzdGluYXRpb25J bik7CisgICAgICAgIGNvbnRleHQtPmVuZFRyYW5zcGFyZW5jeUxheWVyKCk7CisgICAgfQogfQog CiBzdGF0aWMgaW5saW5lIExheW91dFVuaXQgcmVzb2x2ZVdpZHRoRm9yUmF0aW8oTGF5b3V0VW5p dCBoZWlnaHQsIGNvbnN0IEZsb2F0U2l6ZSYgaW50cmluc2ljUmF0aW8pCi0tIAoxLjcuMi41Cgo= 128180 2012-02-22 05:06:14 -0800 2012-02-22 05:06:14 -0800 perf test (background image is not attached) css-clip-text.html text/plain 1147 zherczeg PGh0bWw+CjxzdHlsZT4KI2JnY2xpcCB7CiAgYmFja2dyb3VuZDogdXJsKGJpcmQucG5nKTsKICAt d2Via2l0LXRleHQtZmlsbC1jb2xvcjogdHJhbnNwYXJlbnQ7CiAgLXdlYmtpdC1iYWNrZ3JvdW5k LWNsaXA6IHRleHQ7Cn0KPC9zdHlsZT4KCjxib2R5Pgo8aDEgaWQ9ImJnY2xpcCI+CkFBQUFBQUFB QUE8YnI+CkJCQkJCQkJCQkI8YnI+CkFBQUFBQUFBQUE8YnI+CjwvaDE+Cgo8aDEgaWQ9ImZwcyI+ ZnBzPC9oMT4KCjxzY3JpcHQ+Cgp2YXIgY291bnRlciA9IDA7CnZhciB2YWx1ZSA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdiZ2NsaXAnKTsKCi8vIEZvciBtZWFzdXJpbmcgZGF0YQp2YXIgZnBz ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2ZwcycpOwp2YXIgaGlzdG9yeUxlbmd0aCA9IDA7 CnZhciBoaXN0b3J5RnJhbWVzID0gMDsKdmFyIHN0YXJ0RGF0ZSA9IG5ldyBEYXRlKCk7CnZhciBj dXJyZW50RnJhbWVzID0gMDsKCmZ1bmN0aW9uIGFuaW0oKSB7CiAgICBpZiAoY291bnRlciA9PSAw KSB7CiAgICAgICAgY291bnRlciA9IDE7CiAgICAgICAgdmFsdWUuaW5uZXJIVE1MID0gIkJCQkJC QkJCQkI8YnI+QUFBQUFBQUFBQTxicj5CQkJCQkJCQkJCIjsKICAgIH0gZWxzZSB7CiAgICAgICAg Y291bnRlciA9IDA7CiAgICAgICAgdmFsdWUuaW5uZXJIVE1MID0gIkFBQUFBQUFBQUE8YnI+QkJC QkJCQkJCQjxicj5BQUFBQUFBQUFBIjsKICAgIH0KCiAgICAvLyBEaXNwbGF5IGNvdW50ZXIKICAg IGN1cnJlbnRGcmFtZXMrKzsKICAgIHZhciBub3cgPSBuZXcgRGF0ZSgpOwogICAgdmFyIGxlbmd0 aCA9IChub3cgLSBzdGFydERhdGUpIC8gMTAwMDsKICAgIGlmIChsZW5ndGggPiA1KSB7CiAgICAg ICAgaGlzdG9yeUxlbmd0aCA9IGxlbmd0aDsKICAgICAgICBoaXN0b3J5RnJhbWVzID0gY3VycmVu dEZyYW1lczsKICAgICAgICBjdXJyZW50RnJhbWVzID0gMDsKICAgICAgICBsZW5ndGggPSAwOwog ICAgICAgIHN0YXJ0RGF0ZSA9IG5vdzsKICAgIH0KICAgIGZwcy50ZXh0Q29udGVudCA9ICJhZnBz OiAiICsgKChoaXN0b3J5RnJhbWVzICsgY3VycmVudEZyYW1lcykgLyAoaGlzdG9yeUxlbmd0aCAr IGxlbmd0aCkpOwp9CgpzZXRJbnRlcnZhbChhbmltLDEpOwoKCjwvc2NyaXB0PgoKPC9ib2R5Pgo8 L2h0bWw+Cg==