79205 2012-02-22 00:34:14 -0800 [GTK] fast/frames/frame-dead-region.html crash 2012-02-22 03:16:14 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://webkit-bots.igalia.com/amd64debug/svn_108446.core-when_1329895396-_-who_DumpRenderTree-_-why_11.trace.html P2 Normal --- 1 pnormand abarth abarth webkit.review.bot oldest_to_newest 561702 0 pnormand 2012-02-22 00:34:14 -0800 This is quite recent, I'd track the culprit commit if the waterfall wasn't so slow. #0 0x00007f299304aa18 in WTF::RefPtr<WebCore::Frame>::get (this=0x8) at ../../Source/JavaScriptCore/wtf/RefPtr.h:60 60 T* get() const { return m_ptr; } Thread 1 (Thread 0x7f2988874900 (LWP 6994)): #0 0x00007f299304aa18 in WTF::RefPtr<WebCore::Frame>::get (this=0x8) at ../../Source/JavaScriptCore/wtf/RefPtr.h:60 #1 0x00007f299309f9e4 in WebCore::FocusController::focusedFrame (this=0x0) at ../../Source/WebCore/page/FocusController.h:52 #2 0x00007f29938c719e in WebCore::Frame::willDetachPage (this=0x3d92860) at ../../Source/WebCore/page/Frame.cpp:679 #3 0x00007f299359e4b6 in WebCore::Frame::detachFromPage (this=0x3d92860) at ../../Source/WebCore/page/Frame.h:351 #4 0x00007f299359e17e in WebCore::CachedFrame::destroy (this=0x3f2b4b0) at ../../Source/WebCore/history/CachedFrame.cpp:249 #5 0x00007f299359e1eb in WebCore::CachedFrame::destroy (this=0x3dc9d70) at ../../Source/WebCore/history/CachedFrame.cpp:254 #6 0x00007f299359fa31 in WebCore::CachedPage::destroy (this=0x3950af0) at ../../Source/WebCore/history/CachedPage.cpp:114 #7 0x00007f29935a7839 in WebCore::PageCache::releaseAutoreleasedPagesNow (this=0x1bdea60) at ../../Source/WebCore/history/PageCache.cpp:463 #8 0x00007f29939218e4 in WebCore::Settings::setUsesPageCache (this=0x1b77950, usesPageCache=false) at ../../Source/WebCore/page/Settings.cpp:592 #9 0x00007f2993099ed1 in webkit_web_view_settings_notify (webSettings=0x1baf8e0, pspec=0x1bbda80, webView=0x1abc0b0) at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:3390 #10 0x00007f299769e75f in g_cclosure_marshal_VOID__PARAM () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libgobject-2.0.so.0 #11 0x00007f299769bfff in g_closure_invoke () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libgobject-2.0.so.0 #12 0x00007f29976b595d in signal_emit_unlocked_R () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libgobject-2.0.so.0 #13 0x00007f29976b4ad8 in g_signal_emit_valist () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libgobject-2.0.so.0 #14 0x00007f29976b5056 in g_signal_emit () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libgobject-2.0.so.0 #15 0x00007f29976a0895 in g_object_dispatch_properties_changed () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libgobject-2.0.so.0 #16 0x00007f299769f1e5 in g_object_notify_queue_thaw () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libgobject-2.0.so.0 #17 0x00007f29976a2ba7 in g_object_set_valist () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libgobject-2.0.so.0 #18 0x00007f29976a334c in g_object_set () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libgobject-2.0.so.0 #19 0x0000000000456e7c in resetDefaultsToConsistentValues () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:429 #20 0x00000000004577ef in runTest (testPathOrURL=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:655 #21 0x0000000000457120 in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:491 #22 0x000000000045a121 in main (argc=2, argv=0x7fff483212d8) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1384 561704 1 pnormand 2012-02-22 00:40:03 -0800 http://trac.webkit.org/changeset/108428 seems to be the first commit with this crash. 561711 2 abarth 2012-02-22 00:47:02 -0800 I think we're just missing a null check. I've got a somewhat complicated patch in my working copy right now, but I can fixenate this soon. 561725 3 128151 abarth 2012-02-22 01:09:22 -0800 Created attachment 128151 Patch 561726 4 128152 abarth 2012-02-22 01:10:58 -0800 Created attachment 128152 Patch for landing 561751 5 128152 webkit.review.bot 2012-02-22 01:45:40 -0800 Comment on attachment 128152 Patch for landing Clearing flags on attachment: 128152 Committed r108465: <http://trac.webkit.org/changeset/108465> 561752 6 webkit.review.bot 2012-02-22 01:45:49 -0800 All reviewed patches have been landed. Closing bug. 561805 7 pnormand 2012-02-22 03:16:14 -0800 Thanks Adam :) 128151 2012-02-22 01:09:22 -0800 2012-02-22 01:10:54 -0800 Patch bug-79205-20120222010921.patch text/plain 2879 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjgyYzg3MjZlMmU2MDcw NzVhZGI1ODUwOGJhNjQwZDcyNmMyZGEwOC4uY2ExYTMzOTFkYzQ2Zjc5ZmJmZGIzZDZlMGRkYjNh Y2JmYjQxMDk0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTIyICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0dUS10gZmFzdC9mcmFtZXMv ZnJhbWUtZGVhZC1yZWdpb24uaHRtbCBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkyMDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBcHBhcmVudGx5IHdlJ3JlIG5vdCBzdXBwb3NlZCB0byBjYWxs IHdpbGxEZXRhY2hQYWdlIGZyb20KKyAgICAgICAgQ2FjaGVkRnJhbWU6OmRlc3Ryb3kuICBUaGlz IGNhbGwgZ290IGFkZGVkIGluCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzEwODQyOCwgYnV0IGl0IHNlZW1zIHRvIGNhdXNlIGEgY3Jhc2guCisKKyAgICAgICAgKiBs b2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmNs b3NlQW5kUmVtb3ZlQ2hpbGQpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmRldGFj aEZyb21QYXJlbnQpOgorICAgICAgICAqIHBhZ2UvRnJhbWUuaDoKKyAgICAgICAgKFdlYkNvcmU6 OkZyYW1lOjpkZXRhY2hGcm9tUGFnZSk6CisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlBhZ2U6On5QYWdlKToKKwogMjAxMi0wMi0yMiAgRGFuYSBKYW5zZW5zICA8 ZGFuYWtqQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEN1bGwgcXVhZHMgb3V0 c2lkZSBvZiB0aGUgc2Npc3NvcmluZyBkYW1hZ2UgcmVjdApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFt ZUxvYWRlci5jcHAKaW5kZXggNmJhYmQ2N2IxYzU0YTEwMjJhNzg0NzZlNDFlN2IzMGQ5YTRmMWM4 My4uNTYzNTUzOWQ3N2RlY2VlNDZhYjY0ODg0ZGVlNDM4YzJhMzQ2OWIzZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC0yNDM5LDYgKzI0MzksNyBAQCB2b2lkIEZyYW1l TG9hZGVyOjpjbG9zZUFuZFJlbW92ZUNoaWxkKEZyYW1lKiBjaGlsZCkKICAgICBjaGlsZC0+c2V0 VmlldygwKTsKICAgICBpZiAoY2hpbGQtPm93bmVyRWxlbWVudCgpICYmIGNoaWxkLT5wYWdlKCkp CiAgICAgICAgIGNoaWxkLT5wYWdlKCktPmRlY3JlbWVudEZyYW1lQ291bnQoKTsKKyAgICBjaGls ZC0+d2lsbERldGFjaFBhZ2UoKTsKICAgICBjaGlsZC0+ZGV0YWNoRnJvbVBhZ2UoKTsKIAogICAg IG1fZnJhbWUtPnRyZWUoKS0+cmVtb3ZlQ2hpbGQoY2hpbGQpOwpAQCAtMjUxNyw2ICsyNTE4LDcg QEAgdm9pZCBGcmFtZUxvYWRlcjo6ZGV0YWNoRnJvbVBhcmVudCgpCiAgICAgICAgIHBhcmVudC0+ bG9hZGVyKCktPnNjaGVkdWxlQ2hlY2tDb21wbGV0ZWQoKTsKICAgICB9IGVsc2UgewogICAgICAg ICBtX2ZyYW1lLT5zZXRWaWV3KDApOworICAgICAgICBtX2ZyYW1lLT53aWxsRGV0YWNoUGFnZSgp OwogICAgICAgICBtX2ZyYW1lLT5kZXRhY2hGcm9tUGFnZSgpOwogICAgIH0KIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWUuaAppbmRleCA4MmY0OWQ5ZTFhOTdlMTQxZWM1ZmFiMGEwNDkxYjRlZTI2NzBiMDE3Li4yODMy Y2IwNTM1MWZhM2IzYzE4NzEyYzM3ZjRkOTcyZDhhZDgzN2RjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5oCkBA IC0zNDgsNyArMzQ4LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgaW5saW5lIHZvaWQg RnJhbWU6OmRldGFjaEZyb21QYWdlKCkKICAgICB7Ci0gICAgICAgIHdpbGxEZXRhY2hQYWdlKCk7 CiAgICAgICAgIG1fcGFnZSA9IDA7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1BhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAppbmRleCA1YmRh ODNkNzA5YjhhN2YxZmIxZmY2NjI0NThlODI1MTExNmU0ODY2Li42YjYyYTlmMjNkMjNiM2JjMjY3 MDI1Nzg5YWFkMDljM2U3NDYzMTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Bh Z2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKQEAgLTE4Nyw4ICsxODcs MTAgQEAgUGFnZTo6flBhZ2UoKQogICAgIHNldEdyb3VwTmFtZShTdHJpbmcoKSk7CiAgICAgYWxs UGFnZXMtPnJlbW92ZSh0aGlzKTsKICAgICAKLSAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1haW5G cmFtZSgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+dHJlZSgpLT50cmF2ZXJzZU5leHQoKSkKKyAg ICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1haW5GcmFtZSgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+ dHJlZSgpLT50cmF2ZXJzZU5leHQoKSkgeworICAgICAgICBmcmFtZS0+d2lsbERldGFjaFBhZ2Uo KTsKICAgICAgICAgZnJhbWUtPmRldGFjaEZyb21QYWdlKCk7CisgICAgfQogCiAgICAgbV9lZGl0 b3JDbGllbnQtPnBhZ2VEZXN0cm95ZWQoKTsKIAo= 128152 2012-02-22 01:10:58 -0800 2012-02-22 01:45:40 -0800 Patch for landing bug-79205-20120222011057.patch text/plain 2863 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjgyYzg3MjZlMmU2MDcw NzVhZGI1ODUwOGJhNjQwZDcyNmMyZGEwOC4uNDYwM2VjY2E3ZWU2YTAwZTViODQ4NjM5ZGFlYmRh MDIwZWIzMmFhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTIyICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0dUS10gZmFzdC9mcmFtZXMv ZnJhbWUtZGVhZC1yZWdpb24uaHRtbCBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzkyMDUKKworICAgICAgICBVbnJldmlld2VkLgorCisgICAg ICAgIEFwcGFyZW50bHkgd2UncmUgbm90IHN1cHBvc2VkIHRvIGNhbGwgd2lsbERldGFjaFBhZ2Ug ZnJvbQorICAgICAgICBDYWNoZWRGcmFtZTo6ZGVzdHJveS4gIFRoaXMgY2FsbCBnb3QgYWRkZWQg aW4KKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTA4NDI4LCBidXQg aXQgc2VlbXMgdG8gY2F1c2UgYSBjcmFzaC4KKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y2xvc2VBbmRSZW1vdmVDaGls ZCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6ZGV0YWNoRnJvbVBhcmVudCk6Cisg ICAgICAgICogcGFnZS9GcmFtZS5oOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OmRldGFjaEZy b21QYWdlKToKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFn ZTo6flBhZ2UpOgorCiAyMDEyLTAyLTIyICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQ3VsbCBxdWFkcyBvdXRzaWRlIG9mIHRoZSBzY2lz c29yaW5nIGRhbWFnZSByZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJh bWVMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRl eCA2YmFiZDY3YjFjNTRhMTAyMmE3ODQ3NmU0MWU3YjMwZDlhNGYxYzgzLi41NjM1NTM5ZDc3ZGVj ZWU0NmFiNjQ4ODRkZWU0MzhjMmEzNDY5YjNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlci5jcHAKQEAgLTI0MzksNiArMjQzOSw3IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNsb3NlQW5k UmVtb3ZlQ2hpbGQoRnJhbWUqIGNoaWxkKQogICAgIGNoaWxkLT5zZXRWaWV3KDApOwogICAgIGlm IChjaGlsZC0+b3duZXJFbGVtZW50KCkgJiYgY2hpbGQtPnBhZ2UoKSkKICAgICAgICAgY2hpbGQt PnBhZ2UoKS0+ZGVjcmVtZW50RnJhbWVDb3VudCgpOworICAgIGNoaWxkLT53aWxsRGV0YWNoUGFn ZSgpOwogICAgIGNoaWxkLT5kZXRhY2hGcm9tUGFnZSgpOwogCiAgICAgbV9mcmFtZS0+dHJlZSgp LT5yZW1vdmVDaGlsZChjaGlsZCk7CkBAIC0yNTE3LDYgKzI1MTgsNyBAQCB2b2lkIEZyYW1lTG9h ZGVyOjpkZXRhY2hGcm9tUGFyZW50KCkKICAgICAgICAgcGFyZW50LT5sb2FkZXIoKS0+c2NoZWR1 bGVDaGVja0NvbXBsZXRlZCgpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIG1fZnJhbWUtPnNldFZp ZXcoMCk7CisgICAgICAgIG1fZnJhbWUtPndpbGxEZXRhY2hQYWdlKCk7CiAgICAgICAgIG1fZnJh bWUtPmRldGFjaEZyb21QYWdlKCk7CiAgICAgfQogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5oCmluZGV4IDgyZjQ5 ZDllMWE5N2UxNDFlYzVmYWIwYTA0OTFiNGVlMjY3MGIwMTcuLjI4MzJjYjA1MzUxZmEzYjNjMTg3 MTJjMzdmNGQ5NzJkOGFkODM3ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmgKQEAgLTM0OCw3ICszNDgsNiBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICBpbmxpbmUgdm9pZCBGcmFtZTo6ZGV0YWNoRnJv bVBhZ2UoKQogICAgIHsKLSAgICAgICAgd2lsbERldGFjaFBhZ2UoKTsKICAgICAgICAgbV9wYWdl ID0gMDsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCmluZGV4IDViZGE4M2Q3MDliOGE3ZjFmYjFm ZjY2MjQ1OGU4MjUxMTE2ZTQ4NjYuLjZiNjJhOWYyM2QyM2IzYmMyNjcwMjU3ODlhYWQwOWMzZTc0 NjMxNzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcApAQCAtMTg3LDggKzE4NywxMCBAQCBQYWdlOjp+UGFn ZSgpCiAgICAgc2V0R3JvdXBOYW1lKFN0cmluZygpKTsKICAgICBhbGxQYWdlcy0+cmVtb3ZlKHRo aXMpOwogICAgIAotICAgIGZvciAoRnJhbWUqIGZyYW1lID0gbWFpbkZyYW1lKCk7IGZyYW1lOyBm cmFtZSA9IGZyYW1lLT50cmVlKCktPnRyYXZlcnNlTmV4dCgpKQorICAgIGZvciAoRnJhbWUqIGZy YW1lID0gbWFpbkZyYW1lKCk7IGZyYW1lOyBmcmFtZSA9IGZyYW1lLT50cmVlKCktPnRyYXZlcnNl TmV4dCgpKSB7CisgICAgICAgIGZyYW1lLT53aWxsRGV0YWNoUGFnZSgpOwogICAgICAgICBmcmFt ZS0+ZGV0YWNoRnJvbVBhZ2UoKTsKKyAgICB9CiAKICAgICBtX2VkaXRvckNsaWVudC0+cGFnZURl c3Ryb3llZCgpOwogCg==