<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>79201</bug_id>
          
          <creation_ts>2012-02-21 23:03:25 -0800</creation_ts>
          <short_desc>Node::attach() should be after attaching children in Element::attach</short_desc>
          <delta_ts>2012-02-22 02:12:21 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Shinya Kawanaka">shinyak</reporter>
          <assigned_to name="Shinya Kawanaka">shinyak</assigned_to>
          <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>561647</commentid>
    <comment_count>0</comment_count>
    <who name="Shinya Kawanaka">shinyak</who>
    <bug_when>2012-02-21 23:03:25 -0800</bug_when>
    <thetext>In Element::attach(), Node::attach() is called before attaching children if a shadow root exists.
This may cause O(N^2) problem in NodeRenderingContext.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>561651</commentid>
    <comment_count>1</comment_count>
      <attachid>128138</attachid>
    <who name="Shinya Kawanaka">shinyak</who>
    <bug_when>2012-02-21 23:07:46 -0800</bug_when>
    <thetext>Created attachment 128138
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>561771</commentid>
    <comment_count>2</comment_count>
      <attachid>128138</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-22 02:12:17 -0800</bug_when>
    <thetext>Comment on attachment 128138
Patch

Clearing flags on attachment: 128138

Committed r108470: &lt;http://trac.webkit.org/changeset/108470&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>561772</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-22 02:12:21 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>128138</attachid>
            <date>2012-02-21 23:07:46 -0800</date>
            <delta_ts>2012-02-22 02:12:17 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-79201-20120222160745.patch</filename>
            <type>text/plain</type>
            <size>1709</size>
            <attacher name="Shinya Kawanaka">shinyak</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4NDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2M5YmQyOWMxNmMwNWY1
ZDhhMjQzMzkzOThhMGJiMmE0MDc1Y2ZjZi4uNzc3YmI2NmZlMzI3YjUxOGJjNWYyMzZiY2E1MDBj
OGUwZGUyMzc2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTIxICBTaGlu
eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBOb2RlOjphdHRh
Y2goKSBzaG91bGQgYmUgYWZ0ZXIgYXR0YWNoaW5nIGNoaWxkcmVuIGluIEVsZW1lbnQ6OmF0dGFj
aCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzky
MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBF
bGVtZW50OjphdHRhY2goKSwgTm9kZTo6YXR0YWNoKCkgaXMgY2FsbGVkIGJlZm9yZSBhdHRhY2hp
bmcgY2hpbGRyZW4gaWYgYSBzaGFvZHcgcm9vdCBleGlzdHMuCisgICAgICAgIFRoaXMgbWF5IGNh
dXNlIE8oTl4yKSBwcm9ibGVtIGluIE5vZGVSZW5kZXJpbmdDb250ZXh0LgorCisgICAgICAgIE5v
IG5ldyB0ZXN0cy4gRXhpc3RpbmcgdGVzdHMgc2hvdWxkIGNvdmVyIHRoaXMuCisKKyAgICAgICAg
KiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjphdHRhY2gpOgor
CiAyMDEyLTAyLTIxICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAg
ICAgICBSZW1vdmUgRklYTUUgZnJvbSByZXNvbHZlLXN1cHBsZW1lbnRhbC5wbApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0Vs
ZW1lbnQuY3BwCmluZGV4IDIzMDEwYTA2Y2Q3OTZkMGIwZGU1NTg4YzlkMzU1ZGNmN2IwNGUwOTYu
LjNlYzhjYmQwMTYxZjk0Njc5N2I3OTFkMTQxZmUwN2Y2NTM4MzM5MzMgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl
bWVudC5jcHAKQEAgLTkyOSw3ICs5MjksNiBAQCB2b2lkIEVsZW1lbnQ6OmF0dGFjaCgpCiAgICAg
Ly8gV2hlbiBhIHNoYWRvdyByb290IGV4aXN0cywgaXQgZG9lcyB0aGUgd29yayBvZiBhdHRhY2hp
bmcgdGhlIGNoaWxkcmVuLgogICAgIGlmIChoYXNTaGFkb3dSb290KCkpIHsKICAgICAgICAgcGFy
ZW50UHVzaGVyLnB1c2goKTsKLSAgICAgICAgTm9kZTo6YXR0YWNoKCk7CiAgICAgICAgIHNoYWRv
d1Jvb3RMaXN0KCktPmF0dGFjaCgpOwogCiAgICAgICAgIC8vIEluIGEgc2hhZG93IHRyZWUsIHNv
bWUgb2YgbGlnaHQgY2hpbGRyZW4gbWF5IGJlIGF0dGFjaGVkIGJ5ICdjb250ZW50JyBlbGVtZW50
LgpAQCAtOTM5LDYgKzkzOCw3IEBAIHZvaWQgRWxlbWVudDo6YXR0YWNoKCkKICAgICAgICAgICAg
IGlmICghY2hpbGQtPmF0dGFjaGVkKCkpCiAgICAgICAgICAgICAgICAgY2hpbGQtPmF0dGFjaCgp
OwogICAgICAgICB9CisgICAgICAgIE5vZGU6OmF0dGFjaCgpOwogICAgIH0gZWxzZSB7CiAgICAg
ICAgIGlmIChmaXJzdENoaWxkKCkpCiAgICAgICAgICAgICBwYXJlbnRQdXNoZXIucHVzaCgpOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>